From cc3dd17acf7e3a5bdfe34c21f5c30e646c5fa2e0 Mon Sep 17 00:00:00 2001 From: thakis Date: Tue, 18 Aug 2015 11:43:37 -0700 Subject: [PATCH] clang/win: Enable -Woverloaded-virtual globally. Previously, it was only enabled for chromium_code on Windows. BUG=505301 Review URL: https://codereview.chromium.org/1296773002 Cr-Original-Commit-Position: refs/heads/master@{#343979} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 6e4734b82f3fa0ed8fea5365ac92dde7e4c29a4f --- common.gypi | 3 --- config/compiler/BUILD.gn | 4 ---- 2 files changed, 7 deletions(-) diff --git a/common.gypi b/common.gypi index 88045922d..8c0394bf0 100644 --- a/common.gypi +++ b/common.gypi @@ -3143,9 +3143,6 @@ ['chromium_code==0', { 'variables': { 'clang_warning_flags': [ - # TODO(mgiuca): Move this suppression into individual third-party - # libraries as required. http://crbug.com/505301. - '-Wno-overloaded-virtual', # TODO(thakis): Move this suppression into individual third-party # libraries as required. http://crbug.com/505316. '-Wno-unused-function', diff --git a/config/compiler/BUILD.gn b/config/compiler/BUILD.gn index 7a00b9384..7febde6b4 100644 --- a/config/compiler/BUILD.gn +++ b/config/compiler/BUILD.gn @@ -1049,10 +1049,6 @@ config("no_chromium_code") { if (is_clang) { cflags += [ - # TODO(mgiuca): Move this suppression into individual third-party - # libraries as required. http://crbug.com/505301. - "-Wno-overloaded-virtual", - # TODO(thakis): Move this suppression into individual third-party # libraries as required. http://crbug.com/505316. "-Wno-unused-function",