From d10dcf7daddee5ba1768f7aadd8bb4a18abaf41d Mon Sep 17 00:00:00 2001 From: scottmg Date: Tue, 24 May 2016 18:04:56 -0700 Subject: [PATCH] Revert of Add FrameHost mojo service (patchset #23 id:490001 of https://codereview.chromium.org/1964273002/ ) Reason for revert: Async request for zoom level doesn't work in all cases https://crbug.com/614348 https://crbug.com/613979. I thought https://www.chromium.org/developers/design-documents/mojo/chrome-ipc-to-mojo-ipc-cheet-sheet#TOC-Threading-Model implied the ordering would be correct, but it seems that was too hopeful. Original issue's description: > Add FrameHost mojo service > > Adds new frame-level service with one initial method to handle host zoom > level. > > This moves zoom level supply from async_resource_handler.cc to being a > request made when render_frame_impl handles a willSendRequest. > > The goal of this change is to remove the dependency of > content/browser/loader on the rest of content/browser in particular > here, removing the use of c/b/host_zoom_map_impl.h in > content/browser/loader/async_resource_handler.cc. > > BUG=598073,609607 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/68c6f2ce16d9807b5cb82679099c82c40f39e911 > Cr-Commit-Position: refs/heads/master@{#394547} TBR=dcheng@chromium.org,ben@chromium.org,jam@chromium.org,nasko@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=598073,609607,614348,613979 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2007203002 Cr-Original-Commit-Position: refs/heads/master@{#395761} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b --- android/pylib/gtest/filter/content_browsertests_disabled | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/pylib/gtest/filter/content_browsertests_disabled b/android/pylib/gtest/filter/content_browsertests_disabled index 71b81360b..4b28a2bf8 100644 --- a/android/pylib/gtest/filter/content_browsertests_disabled +++ b/android/pylib/gtest/filter/content_browsertests_disabled @@ -35,7 +35,7 @@ RenderViewImplTest.InsertCharacters RenderViewImplTest.OnHandleKeyboardEvent RenderViewImplTest.OnNavStateChanged # ZoomLevel is not used on Android -RenderFrameImplTest.ZoomLimit +RenderViewImplTest.ZoomLimit RendererAccessibilityTest.SendFullAccessibilityTreeOnReload RendererAccessibilityTest.HideAccessibilityObject RendererAccessibilityTest.ShowAccessibilityObject