mozilla
/
chromium-src-build
зеркало из https://github.com/mozilla/chromium-src-build.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Fix lint issues in tab_ui 

* Suppress a lint warning that is expected.
* For methods whose visibility is relaxed not only for the reason of
  testing, remove the @VisibleForTesting annotation.

Bug: 1108022
Change-Id: I3f8004e3b27cfbbc82a8061c19e57e1662a0691a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315926
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791974}
GitOrigin-RevId: 89f4148d6386ee7d0cf69316492e5ee88f84fd76
This commit is contained in:
Yue Zhang 2020-07-27 20:55:06 +00:00 коммит произвёл Copybara-Service
Родитель c330b60054
Коммит d9dd0f9de7
1 изменённых файлов: 0 добавлений и 121 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

121
android/lint/baseline.xml
Просмотреть файл

@ -199,17 +199,6 @@
column="17"/>
</issue>
<issue
id="CheckResult"
message="The result of `shouldTriggerHelpUI` is not used"
errorLine1=" mTracker.shouldTriggerHelpUI(FeatureConstants.TAB_GROUPS_DRAG_AND_DROP_FEATURE);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/IphMessageService.java"
line="59"
column="9"/>
</issue>
<issue
id="CutPasteId"
message="The id `R.id.bottom_container` has already been looked up in this method; possible cut &amp; paste error?"
@ -3536,17 +3525,6 @@
column="36"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" return TabPersistentStore.getStateFileName(Integer.toString(mTaskId));"
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicy.java"
line="105"
column="35"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
@ -4009,17 +3987,6 @@
column="79"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" NavigationEntry entry = controller.getEntryAtIndex(index);"
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java"
line="401"
column="44"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
@ -5197,17 +5164,6 @@
column="23"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" TabbedModeTabPersistencePolicy.getStateFileName(0));"
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/pseudotab/PseudoTab.java"
line="303"
column="48"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
@ -5747,83 +5703,6 @@
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" tab.getWebContents().getNavigationController().getEntryAtIndex("
errorLine2=" ~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/suggestions/TabContext.java"
line="121"
column="68"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" ConditionalTabStripUtils.setFeatureStatus(FeatureStatus.FORBIDDEN);"
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java"
line="368"
column="42"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" ConditionalTabStripUtils.setFeatureStatus(FeatureStatus.ACTIVATED);"
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java"
line="519"
column="38"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" ConditionalTabStripUtils.setOptOutIndicator(true);"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java"
line="537"
column="46"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" ConditionalTabStripUtils.setContinuousDismissCount("
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java"
line="540"
column="42"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" ConditionalTabStripUtils.setFeatureStatus(FeatureStatus.ACTIVATED);"
errorLine2=" ~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java"
line="561"
column="34"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" &amp;&amp; !ConditionalTabStripUtils.getOptOutIndicator();"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
file="chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabUiFeatureUtilities.java"
line="138"
column="46"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"