From f3596196f96a48ca6279c44ed2a7f2fc2766096b Mon Sep 17 00:00:00 2001 From: "brettw@chromium.org" Date: Mon, 2 Jun 2014 19:16:36 +0000 Subject: [PATCH] Add RLZ build file for GN build, fix Windows build. Some ICU settings were incorrect in the non-component build that caused functions not to get linked properly. We set the wrong exception handling flag in non-component mode. Add rlz to the GN build. Some NSS files were missing. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/307993010 git-svn-id: http://src.chromium.org/svn/trunk/src/build@274298 4ff67af0-8c30-449e-8e8b-ad334ec8d88c --- config/compiler/BUILD.gn | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/config/compiler/BUILD.gn b/config/compiler/BUILD.gn index eb33be96e..4520f3aef 100644 --- a/config/compiler/BUILD.gn +++ b/config/compiler/BUILD.gn @@ -43,10 +43,14 @@ config("compiler") { cflags += [ "/Gy", # Enable function-level linking. "/GS", # Enable buffer security checking. - "/EHsc", # Assume C functions can't throw exceptions and don't catch - # structured exceptions (only C++ ones). "/FS", # Preserve previous PDB behavior. ] + if (is_component_build) { + cflags += [ + "/EHsc", # Assume C functions can't throw exceptions and don't catch + # structured exceptions (only C++ ones). + ] + } } else { # Common GCC compiler flags setup. # --------------------------------