GTTF: Enable glibcxx debug mode for Debug builds by default.

This will help us catch problems earlier.

This CL actually fixes several problems detected by this mode.

BUG=65151, 267870, 267891
TEST=none
R=avi@chromium.org, jar@chromium.org, thakis@chromium.org, thestig@chromium.org, yoz@chromium.org

Review URL: https://codereview.chromium.org/22243002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@239811 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This commit is contained in:
phajdan.jr@chromium.org 2013-12-10 18:52:22 +00:00
Родитель 504a97c71e
Коммит f8451c8fa9
1 изменённых файлов: 6 добавлений и 6 удалений

Просмотреть файл

@ -1099,8 +1099,6 @@
# Profile without optimizing out stack frames when profiling==1.
'profiling_full_stack_frames%': '0',
# Enable strict glibc debug mode.
'glibcxx_debug%': 0,
# And if we want to dump symbols for Breakpad-enabled builds.
'linux_dump_symbols%': 0,
# And if we want to strip the binary after dumping symbols.
@ -2158,10 +2156,6 @@
['profiling==1', {
'defines': ['ENABLE_PROFILING=1'],
}],
['OS=="linux" and glibcxx_debug==1', {
'defines': ['_GLIBCXX_DEBUG=1',],
'cflags_cc+': ['-g'],
}],
['remoting==1', {
'defines': ['ENABLE_REMOTING=1'],
}],
@ -2740,6 +2734,12 @@
}],
],
}],
['OS=="linux" and target_arch!="ia32"', {
# Enable libstdc++ debugging facilities to help catch problems
# early, see http://crbug.com/65151 .
# TODO(phajdan.jr): Should we enable this for all of POSIX?
'defines': ['_GLIBCXX_DEBUG=1',],
}],
# Disabled on iOS because it was causing a crash on startup.
# TODO(michelea): investigate, create a reduced test and possibly
# submit a radar.