Update to newer Android Lint and suppress new Lint errors

This CL updates DEPS to enable updated Android Lint that would work for
Java 8. Also, it adds inline suppression for newly discovered Lint
errors. Additionally, it suppresses Lint deprecation warning for
"android:singleLine". Moreover, it suppresses Lint warnings "AuthLeak",
"VisibleForTests", etc. for tests, and Lint error "ByteOrderMark" in
generated android_chrome_strings.xml (crbug.com/715196).

BUG=635567,669999

Review-Url: https://codereview.chromium.org/2830843004
Cr-Original-Commit-Position: refs/heads/master@{#468545}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5512e732f9513b2e5b3f8c47f146dfa5c3582b6d
This commit is contained in:
zpeng 2017-05-01 20:18:09 -07:00 коммит произвёл Commit bot
Родитель 4a81c967d6
Коммит f9e57da207
2 изменённых файлов: 19 добавлений и 3 удалений

Просмотреть файл

@ -27,6 +27,9 @@ Still reading?
</issue>
<!-- We use asserts in Chromium. See https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Asserts -->
<issue id="Assert" severity="ignore"/>
<issue id="AuthLeak" severity="Error">
<ignore regexp="chrome/android/javatests"/>
</issue>
<issue id="BadHostnameVerifier" severity="Error">
<!-- Safe, used in test only. -->
<ignore regexp="net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java"/>
@ -37,6 +40,10 @@ Still reading?
<issue id="ButtonStyle" severity="Error">
<ignore regexp="remoting/android/host/res/layout/main.xml"/>
</issue>
<!-- Found in generated android_chrome_strings.xml. -->
<issue id="ByteOrderMark" severity="Error">
<ignore regexp="values-pt-rBR/android_chrome_strings.xml"/>
</issue>
<issue id="CommitPrefEdits">
<ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/ticl/android2/channel/AndroidChannelPreferences.java"/>
</issue>
@ -53,7 +60,9 @@ Still reading?
</issue>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="Deprecated" severity="Error">
<ignore regexp="android:singleLine"/>
<ignore regexp="AndroidManifest.xml"/>
<ignore regexp="/test/"/>
</issue>
<issue id="DrawAllocation">
<ignore regexp="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java"/>
@ -122,8 +131,6 @@ Still reading?
<ignore regexp="chromecast/internal"/>
<!-- It is OK for content_shell_apk to have missing assets. -->
<ignore regexp="content/shell/android/java/res/"/>
<!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. -->
<ignore regexp="remoting/android/java/res"/>
<!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/drawable/icon.png -->
<ignore regexp="res/drawable/icon.png"/>
</issue>
@ -209,6 +216,8 @@ Still reading?
<ignore regexp="org/chromium/memconsumer/MemConsumer.*.class"/>
<ignore regexp="org/chromium/memconsumer/ResidentService.class"/>
<ignore regexp="org/chromium/mojo/bindings/ValidationTest.class"/>
<!-- TODO(crbug.com/635567): Fix this properly. -->
<ignore regexp="third_party/android_tools/sdk/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"/>
</issue>
<issue id="OldTargetApi">
<ignore path="AndroidManifest.xml"/>
@ -237,6 +246,9 @@ Still reading?
</issue>
<issue id="Recycle" severity="ignore"/>
<issue id="Registered" severity="ignore"/>
<issue id="ResourceType" severity="Error">
<ignore regexp="/javatests/"/>
</issue>
<issue id="RtlCompat" severity="ignore"/>
<issue id="RtlEnabled" severity="ignore"/>
<issue id="RtlSymmetry" severity="ignore"/>
@ -446,6 +458,10 @@ Still reading?
<ignore regexp="media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java"/>
</issue>
<issue id="ViewConstructor" severity="ignore"/>
<issue id="VisibleForTests" severity="Error">
<ignore regexp="chrome/android/javatests"/>
<ignore regexp="/test/"/>
</issue>
<issue id="WrongCall" severity="ignore"/>
<issue id="WrongConstant">
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java"/>

Просмотреть файл

@ -751,7 +751,7 @@ if (enable_java_templates) {
]
args = [
"--lint-path=$_rebased_lint_android_sdk_root/tools/lint",
"--lint-path=$_rebased_lint_android_sdk_root/tools-lint/bin/lint",
"--cache-dir",
rebase_path(_cache_dir, root_build_dir),
"--platform-xml-path",