When '--' is present on the cmd line, anything to the right of it is
considered args to the test binary and will be pass untouched to it.
This also adds the '--' arg to all isolated-script tests, which is
practically only telemetry tests.
Bug: 1108412
Change-Id: Iec53e68d39c0bbe947ebdc166426d6b4c848e892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318309
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794225}
GitOrigin-RevId: 983340cc7c5746b3619b4d4bddbfa2340c4219af
It currently defaults to the 'release' image, which is internal &
Google-only.
We have some public testers that need to flash to the 'full' images.
Adding the flag should let us do that by passing down the right type
of image based on GN args, which get bound to tests via generated
wrapper scripts.
Bug: 1057152
Change-Id: Ib1a82eb16ca274fe1e04946b588ec2dc2e049c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303981
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#790091}
GitOrigin-RevId: c8ab1d5ab787fe49f033f8fdc328e6d2244ecfe0
It's already set for remote-side tests. After crrev.com/c/2283899, we
can set it for host-side tests too.
Bug: 1057152
Change-Id: I2e37d22fb24e928dff831d8383068fd8d1558edb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285251
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785989}
GitOrigin-RevId: 8b53d4ddd669db5e321e531be1e55922f2266a0b
When running tests that are launched from the host (eg telemetry tests),
the test_runner will take all args passed to it after the last known
arg and treat that as the host-side test command.
Consequently if a known arg is interleaved into the unknown args, the
test runner will not pick it up. By treating unknown args (rather than
trailing args) as the command, we can embed known args into the list.
This will let something like crrev.com/c/2283576 land as-is where we add
'--flash' as the very last arg. Without this CL, that arg is treated
as an arg to telemetry instead of an arg to the test runner.
Bug: 1057152
Change-Id: Id5326dfa3bceab86ae97dc260c9699cf35f56b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283899
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785787}
GitOrigin-RevId: 5b185d12d2f6721d494101188717bedcdd828525
This tests it out on a single test suite. If it looks good, it'll be
rolled out more broadly.
This will let us tear-down all the out-of-band flashing logic for
these devices, and replace it with on-demand pre-test flashing. The
latter being much simpler to maintain, having less moving parts, and
generally being more visible.
Bug: 1057152
Change-Id: Ic2fba3725b01bec2d3dedc4898e8acfe3ad5b22d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261702
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781967}
GitOrigin-RevId: e082e1cf9f9626cdd04a8d5e7356060b62ec27a1
Same thing that crrev.com/c/2219679 did, but for tests invoked via
host-side cmd (eg: telemetry) rather than device-side cmd (eg: gtests).
Bug: 1087407
Change-Id: I514a01583bbfea6a4a600d738587d8663ae0adec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222901
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#773360}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eef14587cc35fea6d3610d65f2c2306dee2d4d0d
Those logs aren't getting cycled out, and I suspect they're not very
useful. So just ignore them.
And move all system logs to a 'system_logs' sub dir.
Bug: 1087407
Change-Id: Ib404945fb10f79da2b0cbe9276b2244500d023ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219679
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#772810}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f3947bcf3f71229cffa2182d157a2796f41b7ab7
Some tests will need special env vars set on device during test
execution. This adds the needed plumbing so we can specify them via
cmd line.
Bug: 1075843
Change-Id: I47203abe4cf4bfe6fa7aa60a4680dd5dacdec25b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175746
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#764787}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 64267a0ff37d992bcf90edc16c8f3dadd94149e3
The results of the disk-usage test reports inflated numbers for Chrome
since we don't strip symbols. By doing so here, we can get results
that more resemble what gets shipped on devices.
Bug: 1071107
Change-Id: I55104f1c02a21d076df971e49edbc306e3cdd3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155050
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#760281}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 925601939cf9975273623b80db7643e17b823b79
This reverts commit a5301433ed9a9610c127691d6c0f6d4c4af82f7d.
Reason for revert: betty-pi-arc-pi-android-pfq is continuously failing
Bug: 1070126
Original change's description:
> Manually roll chromite to pick up localhost vs VM fixes.
>
> Picks up a single change:
> $ git log 97d7f0702..8ef1e6c0 --date=short --first-parent --format='%ad %ae %s'
> 2020-04-06 bpastene@chromium.org device: Don't assume '--device=localhost' means VM.
>
> And updates chromeos/test_runner.py to not specify '--device=localhost'
> when running VM tests.
>
> Bug: 1067800
> Change-Id: Id8af6b2cb1d8a082b71a6ac01cfe9522578a21b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145762
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758264}
TBR=achuith@chromium.org,erikchen@chromium.org,bpastene@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1067800
Change-Id: Ide5832c94b127d0ad360f66954bf2ce101b0933e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146409
Reviewed-by: Hiroki Sato <hirokisato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#758471}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 555860095f79be6bf7038c245fe76eb006ad27f0
Picks up a single change:
$ git log 97d7f0702..8ef1e6c0 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 bpastene@chromium.org device: Don't assume '--device=localhost' means VM.
And updates chromeos/test_runner.py to not specify '--device=localhost'
when running VM tests.
Bug: 1067800
Change-Id: Id8af6b2cb1d8a082b71a6ac01cfe9522578a21b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145762
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#758264}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a5301433ed9a9610c127691d6c0f6d4c4af82f7d
In the beginning python was created. This has made a lot of people
very angry and been widely regarded as a bad move.
Bug: 1050466
Change-Id: Ieac7ca2a42cb21e78d77d628c3fb645d32b7625f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047351
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#740044}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 006cf3e0271407fc467ebbbff2d3c374f3bd4361
- journal contains system-wide logs (in a machine-readable format).
- power_manager contains logs from the daemon that controls system
power, and may provide some insight when a device/VM shuts down
unexpectedly
Bug: 1043953
Change-Id: I14721bdbdc62095d864145bd3d491c2d880b1df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016665
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#734661}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 35eb707c6399d9a8b282b6568392d4d48dd676e2
- Add --trace-dir=PATH to chromeos/test_runner.py
When present, test_runner script passes the switch with
device local path (e.g. /tmp) to gtest to generate trace
file on device and collects the trace files back to PATH
on host afterwards.
- Update run_gtest_benchmark.py to map the trace file path
in the test result json collected by test_runner script
so that processor scripts could find and computer metrics
from the trace file.
Example usage:
For developers:
tools/perf/run_gtest_benchmark.py
out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests
--device=$DUT
--gtest_filter=All/OverviewAnimationsTest.EnterExit/7
--output-dir=/tmp/perf_output
--output-format=histograms
--dbus-stub --stop-ui
For perf bots:
testing/scripts/run_performance_tests.py
--isolated-script-test-output=/tmp/perf_output/output.json
--non-telemetry=true
--use-gtest-benchmark-script
--gtest-benchmark-name=interactive_ui_tests
tools/perf/run_gtest_benchmark.py
out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests
--device=$DUT
--output-format=histograms
--dbus-stub --stop-ui
Bug: 945711
Change-Id: Ia6911921b8354d7763be96c30a8877c9d598f103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974587
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#726402}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 366071126e3a105df3343670e1b3994207b8e1eb
Temporary fix for chrome_all_tast_tests_informational as it takes more than 60 minutes
to complete a run. Tast tests cannot be sharded yet (See crbug.com/968262). Also includes
a bugfix which replaces use of 'str' to 'encode' as some informational tests use '🔥' '❄'
characters.
Timeout example: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel-hw-tests/15876
Bug: 988581
Change-Id: Idd85797811d722289176565e452d163d6e8bb3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839018
Commit-Queue: Anushruth <anushruth@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#704079}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7f095908d28a18cf30ae89c83d5731b615304cb9
This adds LD_LIBRARY_PATH=./ to the test runner script to make it load
dependent shraed objects in test invocation.
Bug: 1002751
Change-Id: I96cb90a245ce83985971e776e14f6d9f5085b802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832848
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Chinglin Yu <chinglinyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#701884}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 22773f51eab5117b01368945d5267bc2446332dd
But do strip them for tast tests on coverage bots. Tast is likely broken
on the coverage bot right now, but the bot's stuck failing on compile,
so I don't think anyone noticed.
Bug: 995776
Change-Id: I3fbfe16133c876c110eddf0747e49f5ee7fdffe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762446
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#689040}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3ca6ffec4ee4dcf6f676a1d13996cdc094e95f5c
I believe we have enough room for this now that we're mounting the
browser outside the default deploy dir.
Change-Id: Ifdb667daadee13603bc3de2833c5ccb3d11961bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758832
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#687880}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 13c30b3c64b522e808c538b407f455d328177b48
vpython uses both HOME and TMPDIR as workspaces. Now that /tmp is
mounted with noexec, we need to point vpython to a tmp dir without that
restriction.
Bug: 990859
Change-Id: I17629676abb898923658a48862a909e99d4fac1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735554
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#684074}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 37fea8c4e744b0e53c3c8503a62533c034962059
The workaround for using private key has been fixed on the chromeos
side and is no longer needed here.
BUG=chromium:972869
TEST=manual
Change-Id: I2bedc47785a0f50cd198017155f294b45fa09e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717996
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Eashan Bhatt <eashanbhatt@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#680983}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 35bc6451f74d62cf8a52e301501ba7bd485ea7d8
We no longer need to load vivid explicitly on Chrome OS VM
because it's already loaded at the start-up time by upstart.
Bug: 904730, 852302
Test: capture_unittests passed at chromeos-amd64-generic-rel on CQ
Change-Id: Id75594458c7ca92c406cf4074845763c0672f944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710286
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
Auto-Submit: Keiichi Watanabe <keiichiw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#679872}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b34a6dc8903ad13a9484ee3d33492b1d14ccfd06
This renames the test "cros_vm_sanity_test" to "cros_browser_sanity_test"
since we also run it on chromebooks.
This also renames the target "cros_vm_launcher" to "cros_test_wrapper"
since we use that wrapper script to launch tests on chromebooks. (Used
mainly for telemetry tests.)
Bug: 866062
Change-Id: I4e6d0b7934ca15f132692121ddac94c56fb3d258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689981
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#675399}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4534c39e40005e35370b4f3b1aed54c4fe4756f8
/tmp will soon no longer be mounted with exec permissions in test images.
We've been using /tmp to install vpython binaries during some browser
tests, so move them to /usr/local/tmp, which should remain mounted with
exec permissions.
R=jbudorick, vapier
Bug: 936818
Change-Id: I0c6ed52f0c1d91d2e905674a74b193a604145f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684632
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#674094}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 215b9c188f1e5aa78c2b25cad7140c726c17d102
And enable it for some UI tests.
Bug: 947531
Change-Id: I1545ce6f718214a65690cc6044e2398d9a0bc218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635350
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665248}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4dad0e4bd5ea5659770c2e5c4e6b8d127a21c6a5
*except for coverage tests, since they need special setup.
This removes support for the '--use-host-tast-bin' arg, since we'll
now default to always using.
Bug: 923426
Change-Id: Ifb57f53153c4d4db73e98e98cce1ef9a49548679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585002
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#655245}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d33514e31c554ba8e861ad03ac6dc66d5a325cf2
This should let us parse some results even if something goes wrong
and the final results.json doesn't get generated for some reason.
Bug: 923426
Change-Id: I028896c9edc7aeb8b3ec6339b8867f0b29ae095f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575105
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#654678}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ba744c00f6bd238921962db91c7545edc34eebe9
These shouldn't be used on the device during tests (only the host).
Bug: 866062
Change-Id: I1d8ecf6cc9b416c34cc90bb55377bb8185556fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572266
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#652277}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9220d4b37fc0bf0c27d386bfbe213f343f96eb36
This makes the "test_type" arg the very first arg. Previously, anything
that came before it couldn't be passed in from the generated test script.
eg: running `./$out/bin/run_gtest --device $DUT_IP` would have no effect
since "--device" came before the "test_type" arg (which itself was
set in the generated script).
Bug: 866062
Change-Id: I7712f11b23f78f28e9831fe506b9467db8c217e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572959
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#652208}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fef7399c060df4ae25879ac8fb05070f1b0ccf95
And enable it on the fyi bot. This'll let me safely iterate on it w/o
breaking things again.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
Bug: 923426
Change-Id: I3f2a8973e7d7c1d35001643fe26e1cf6c08f9477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565154
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#650054}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 86fbe06b11705f92a5a8ca700c7e27becdcd337b
This is a functional revert of https://chromium-review.googlesource.com/c/chromium/src/+/1553805
Turns out `cros_run_test --tast` doesn't exit non-zero if one of the tests
fail. So we've been ignoring failures since that landed. This reverts back
to using local_test_runner, which does reliably exit non-zero on failure.
Hard-coding the conditional instead of reverting the original CL to
avoid merge conflicts and for easier follow-up fixes.
Bug: 923426
Change-Id: Iaa49011061f42f062e79d0d6867f0741314d473b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558494
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#648835}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 41e078e8a655634994f8169a5965990926bba98c
Practically speaking, the logs dir is just the isolated out dir.
This'll collect a number of *.json files for the tests, which I'll convert
into standard chromium json results in a follow-up.
Bug: 923426
Change-Id: I488b740d733a192c97de11bc2ec4dd06f2ffbd1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554797
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#648786}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c4a5c357a442b5e31c07e215ebb31eec77441fe7
This is done by using cros_run_test's "--tast" feature instead of using
its "--remote-cmd" option. The tast bin has a lot more features, one of
which is better result reporting. Leveraging these more accurate results
will come in a follow-up.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
Bug: 923426
Change-Id: I6e30c62c0a1bba0444d3b6d25a0e59a70de50263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553805
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#648032}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5084d89d50df91778c36cf3fd6e09b047b50a24d
I typo'ed the dbus one. And we don't need a to fake a src checkout since
we already essentially have one on disk thanks to the fact that we scp
all of the test's runtime_deps.
R=jbudorick
Bug: 946685
Change-Id: I16ee3cf79f400ad7de883cb3b60da448019f2338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546198
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#646943}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c99736ed42b4138cb54152f17a667507b7842c5d
And remove a couple old suites from the fyi bot.
Bug: 946685
Change-Id: I621e6482c39b9af47173db644a5a1866741fa7eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548054
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#646560}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39af4ef6f76f173ae2d057e08493c85e913024b0
Since chrome-on-cros is launched/managed by initctl, it has its own
method for configuring the environment. This is done by chrome_dev.conf
Bug: 934059
Change-Id: I90c5262b4d27142b308ba2aa2e6d5b0f514d0cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546310
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#645884}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 86bc16b2c84f1882f46274bb909f14e1758fde86
Instead of passing in the single command directly to cros_run_test. (Or
in the case of vm_sanity, letting cros_run_test do that for us.)
This will let us add additional pre-test setup commands for both tests.
(None for now, but coverage tests will use some.)
Bug: 934059
Change-Id: Iba15f4817293c4a1c5db2dabc89f4a97fee49664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542298
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#645790}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca17d127f40b91a53d0b53e59a30c57f2830ef9a
Ben Pastene
Dirk Pranke
Hiroki Sato
Steven Bennetts
Takuto Ikuta
Xiyuan Xia
Anushruth
Chinglin Yu
Eashan Bhatt
Keiichi Watanabe