On Debian, the default /bin/sh is dash. When the chrome_sandbox was built in a
non-component configuration (so no RPATH will be set), the expression:
readelf -d "${CHROME_SANDBOX_BUILD_PATH}" | grep "(RPATH)" &>/dev/null
will have a return code of 0 on dash, but 1 on bash. This is because ">&" is a
bash feature not available in dash. This CL changes the expression to ">
/dev/null 2>&1" to be POSIX sh compliant.
R=dpranke
Change-Id: I8c039f57fc47b78b036cf1a30accf8c5fb030055
Reviewed-on: https://chromium-review.googlesource.com/1188756
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#586582}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1a7dfb76d8e4608fc66601f64a09b95da471ab7c
Also:
* Remove an out-of-date comment.
* Add binutils to install-build-deps.sh for readelf and grep. We already use
binutils in many places, and it's likely already installed everywhere, but
it's good to list out direct dependencies.
BUG=850682
R=thakis
Change-Id: I80830ad42fe37f1b93f393f5a6ca5af68ef92998
Reviewed-on: https://chromium-review.googlesource.com/1157436
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b8a836630dcf0d5c5eba4ecdcc71a5f1ebfb914
The documentation for gn builds specifies using a different
output directory than gyp builds, but the update sandbox script
reports error message assuming only gyp builds.
Update the error message to prod user into specifying BUILDTYPE
to find the sandbox in the right place
BUG=
Review URL: https://codereview.chromium.org/1309433002
Cr-Original-Commit-Position: refs/heads/master@{#344600}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d8807ee10dd5e1e534e46311383c51cc56999f42
Tom Anderson
isheriff
mustaq@chromium.org
jln@chromium.org