Instead of the slightly rube-goldbergian approach of giving mips_arch_variant
the default value mips32r2 in common.gypi and then always overriding this with
mips32r1 in envsetup, just set mips_arch_variant to mips32r1 by default and
don't set it in envsetup.
I checked that the generated ninja file for base is identical before and after
this change, and that the mips flags change as expected when manually setting
mips_arch_variant to mips32r2. No behavior change.
BUG=330631
TBR=torne@chromium.org
Review URL: https://codereview.chromium.org/152233002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248409 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
This is breaking the Chrome OS bots on the waterfall:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28x86%29&number=19593http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28amd64%29&number=13965
From discussion on chromium-dev:
Looking at /var/log/messages for one of the failing tests, Chrome is exiting with SIGABRT over and over, and ui.LATEST has the following over and over:
[0201/085858:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU().
Original issue's description:
> Enable icu_use_data_file_flag on CrOS
>
> 1. Enable icu_use_data_file_flag on CrOS
>
> 2. Doing #1 led to a crash because GetStringUTF8 (that relies on ICU to determine whether the current UI language is RTL) is called before InitializeICU is called. Instead of using GetStringUTF8, get the string directly from the resource bundle because there's no need to adjust the string for the RTL locale in this particular case.
>
> Note to perf-sheriff : The size of chrome binary will be 10M smaller because the ICU data is now in a separate file (icudtl.dat) whose size is about 10M.
>
> BUG=72633
> TEST=ui_base_unittests
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248325TBR=tony@chromium.org,vapier@chromium.org,mark@chromium.org,nkostylev@chromium.org,jshin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633
Review URL: https://codereview.chromium.org/151163003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248374 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1. Enable icu_use_data_file_flag on CrOS
2. Doing #1 led to a crash because GetStringUTF8 (that relies on ICU to determine whether the current UI language is RTL) is called before InitializeICU is called. Instead of using GetStringUTF8, get the string directly from the resource bundle because there's no need to adjust the string for the RTL locale in this particular case.
Note to perf-sheriff : The size of chrome binary will be 10M smaller because the ICU data is now in a separate file (icudtl.dat) whose size is about 10M.
BUG=72633
TEST=ui_base_unittests
Review URL: https://codereview.chromium.org/135963010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248325 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1. Set icu_use_data_file_flag to 1 in common.gypi
2. Add icudatl.dat to the resournce bundle list in
chrome_dll_bundle.gypi and content_shell.gypi
3. Move ICU_UTIL_DATA_IMPL to base.gyp
This CL has to be landed after
https://codereview.chromium.org/111723007/ is landed and rolled in.
(done in https://codereview.chromium.org/118313004/ )
Note to perf-sheriff: This CL adds ~10MB to the resource bundle while cutting down the same amount from the Chrome executable/binary.
BUG=72633
TEST=All the Mac builds (static, shared) go through and tests (e.g.
layout tests, base_unittests --gtest_filter=*String*, net_unittests
--gtest_filter=*IDN*) loading the ICU data pass.
Review URL: https://codereview.chromium.org/109013004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247404 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
mini_installer somehow does not install icudtl.dat in the top product directory (alongside chrome.exe) leading to a failure in InitializeICU().
icudtl.dat is listed in both mini_installer.gypi and FILES.cfg for windows.
Original issue's description:
> Enable icu_use_data_file on Windows
>
>
> Set icu_use_data_file_flag to 1 on Windows in common.gypi and make the dependency on icudata conditional on 'icu_use_data_file_flag != 0' in common.gypi, base.gyp and net.gyp
>
> This also requires a change in third_party/icu/icu.gyp
> ( https://codereview.chromium.org/111723007/ ), which was rolled in by https://codereview.chromium.org/118313004/
>
> BUG=72633
> TEST=All windows builds work fine and there's no perf regression (start-up etc).
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246387TBR=mark@chromium.org,scottmg@chromium.org,laforge@chromium.org,maruel@chromium.org,grt@chromium.org,wtc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633
Review URL: https://codereview.chromium.org/139403006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246632 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This will start covering the policy iOS build on the main waterfall. The code
in chrome/browser/policy is still disabled on that platform by default, but
the policy component and its unittests will be built.
This change also enables one policy on iOS, otherwise some parts of the build
break.
BUG=275292
Review URL: https://codereview.chromium.org/132233031
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246422 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
On Android/ARM we add -fomit-frame-pointer elsewhere in common.gypi.
Simply adding -fno-omit-frame-pointer when building with sanitizers is
not enough, because the former flag wins (it get added closer to the end
of the command line). Therefore, we also remove all -fomit-frame-pointer
flags under sanitizers.
BUG=325685
TEST=wait for the next clang roll, run asan tests on android
R=glider@chromium.org
Review URL: https://codereview.chromium.org/143873009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246256 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We've switched to Aura on Linux (see chromium-dev threads). NPAPI plugins aren't supported on Linux Aura (also see chromium-dev thread). These tests should just be disabled.
> Revert of Reenable linux_aura on the main builders. (Again). (https://codereview.chromium.org/138033023/)
>
> Reason for revert:
> Blink layout tests are failing:
>
> http/tests/plugins/interrupted-get-url.html
> http/tests/plugins/third-party-cookie-accept-policy.html
> plugins/mouse-click-plugin-clears-selection.html
>
> Original issue's description:
> > Reenable linux_aura on the main builders. (Again).
> >
> > We upgraded the eu-strip binary so that it can deal with binaries that
> > are more than two gigabytes large. This should fix the crash on the
> > Google Chrome Linux builder, which was the only bot to break last night.
> >
> > BUG=319075,125106,303342,318961
> > NOTRY=True
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245737
>
> TBR=erg@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=319075,125106,303342,318961
>
> Review URL: https://codereview.chromium.org/143073002TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/137493007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246094 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Blink layout tests are failing:
http/tests/plugins/interrupted-get-url.html
http/tests/plugins/third-party-cookie-accept-policy.html
plugins/mouse-click-plugin-clears-selection.html
Original issue's description:
> Reenable linux_aura on the main builders. (Again).
>
> We upgraded the eu-strip binary so that it can deal with binaries that
> are more than two gigabytes large. This should fix the crash on the
> Google Chrome Linux builder, which was the only bot to break last night.
>
> BUG=319075,125106,303342,318961
> NOTRY=True
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245737TBR=erg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=319075,125106,303342,318961
Review URL: https://codereview.chromium.org/143073002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245865 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
For a short transition period, let envsetup.sh set the right GYP_DEFINES when
GOMA_DIR is set, so that people aren't broken immediately after this lands.
Also stop setting GOMA_COMPILER_PROXY_THREADS – if the value this sets
is truly better, that should be the default in goma, it shouldn't be set in
envsetup.sh (doing it in goma has the advantage that it works on all
platforms, also abstraction barriers, etc.)
BUG=332697
R=brettw@chromium.org, ilevy@chromium.org
Review URL: https://codereview.chromium.org/142393002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245801 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We upgraded the eu-strip binary so that it can deal with binaries that
are more than two gigabytes large. This should fix the crash on the
Google Chrome Linux builder, which was the only bot to break last night.
BUG=319075,125106,303342,318961
NOTRY=True
Review URL: https://codereview.chromium.org/138033023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245737 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Failed due to mysterious failures on the Google Chrome Linux bot.
Example:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
Staging common install files in '/tmp/deb.build.AEvway'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
BUG=335451
Original issue's description:
> Reenable linux_aura on the main builders.
>
> We fixed the browser test slowdown that lead to linux_aura being
> disabled in r235280. (Different test suites are faster or slower, but
> overall, tests run faster.)
>
> We are turning this on primarily to get perf data; if things look
> acceptable, we hope to cut a dev channel this week.
>
> BUG=319075,125106,303342,318961
> NOTRY=True
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245415
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=319075,125106,303342,318961
Review URL: https://codereview.chromium.org/140823008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245429 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Didn't actually help with the build failures on Google Chrome Linux.
Original issue's description:
> linux_aura: Attempt to green the official builder by reverting unwind support.
>
> This effectively reverts in r243919 and r244331 in a desperate attempt
> to fix the tree.
>
> Build fail output:
>
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
> Staging common install files in '/tmp/rpm.build.XtJRbJ'...
> eu-strip: while computing checksum for debug information: Invalid argument
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
> Staging common install files in '/tmp/rpm.build.t4jNp4'...
> eu-strip: while computing checksum for debug information: Invalid argument
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
> Staging common install files in '/tmp/deb.build.CxnH9l'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
> Staging common install files in '/tmp/deb.build.9Zyie1'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
> Staging common install files in '/tmp/deb.build.xUB39X'...
> eu-strip: while computing checksum for debug information: Invalid argument
> Cleaning...
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
> Staging common install files in '/tmp/rpm.build.aN0PGV'...
> eu-strip: while computing checksum for debug information: Invalid argument
> ../out/Release/chrome, section '.eh_frame': the call frame entry at offset 0x18 uses a DWARF expression to describe how to recover register '.cfa', but this translator cannot yet translate DWARF expressions to Breakpad postfix expressions
> ninja: build stopped: subcommand failed.
>
> BUG=180975
> TBR=spang@chromium.org, stip@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245421TBR=spang@chromium.org,stip@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=180975
Review URL: https://codereview.chromium.org/141273005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245428 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This effectively reverts in r243919 and r244331 in a desperate attempt
to fix the tree.
Build fail output:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
Staging common install files in '/tmp/rpm.build.XtJRbJ'...
eu-strip: while computing checksum for debug information: Invalid argument
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
Staging common install files in '/tmp/rpm.build.t4jNp4'...
eu-strip: while computing checksum for debug information: Invalid argument
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c unstable
Staging common install files in '/tmp/deb.build.CxnH9l'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
Staging common install files in '/tmp/deb.build.9Zyie1'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c beta
Staging common install files in '/tmp/deb.build.xUB39X'...
eu-strip: while computing checksum for debug information: Invalid argument
Cleaning...
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable
Staging common install files in '/tmp/rpm.build.aN0PGV'...
eu-strip: while computing checksum for debug information: Invalid argument
../out/Release/chrome, section '.eh_frame': the call frame entry at offset 0x18 uses a DWARF expression to describe how to recover register '.cfa', but this translator cannot yet translate DWARF expressions to Breakpad postfix expressions
ninja: build stopped: subcommand failed.
BUG=180975
TBR=spang@chromium.org, stip@chromium.org
Review URL: https://codereview.chromium.org/141013009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245421 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We fixed the browser test slowdown that lead to linux_aura being
disabled in r235280. (Different test suites are faster or slower, but
overall, tests run faster.)
We are turning this on primarily to get perf data; if things look
acceptable, we hope to cut a dev channel this week.
BUG=319075,125106,303342,318961
NOTRY=True
Review URL: https://codereview.chromium.org/136813004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245415 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
thakis@chromium.org
caitkp@chromium.org
jshin@chromium.org
phajdan.jr@chromium.org
aurimas@chromium.org
fdegans@chromium.org
hans@chromium.org
ronghuawu@chromium.org
eugenis@chromium.org
kochi@google.com
joaodasilva@chromium.org
uekawa@chromium.org
jam@chromium.org
eustas@chromium.org
erg@chromium.org
earthdok@chromium.org
jochen@chromium.org
ycheo@chromium.org
ager@chromium.org
thestig@chromium.org
raymes@google.com
bolian@chromium.org
spang@chromium.org
dalecurtis@google.com
frankf@chromium.org