Since the Blink rename, enum entry names now use the kCamelCase naming
convention instead of SHOUTY_CASE. This doesn't match well with Java
naming conventions and Java constants created by java_cpp_enum.py look
out of place with the rest of the Java codebase.
This CL modifies java_cpp_enum.py so that C++ enum naming conventions
don't leak into the Java side, specifically translating kCamelCase and
CamelCase enum entries to SHOUTY_CASE.
BUG=710335
Review-Url: https://codereview.chromium.org/2815103004
Cr-Original-Commit-Position: refs/heads/master@{#464661}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23b8f65ce75fc2ff04a28cb5a940861c134e0797
Adjust GN configs to only link with Control Flow Guard for executables.
This will still support CFG compiled into Microsoft system DLLs, in all
Chromium processes (e.g. chrome.exe).
This should prevent sporadic official clang build problems in DLLs, related
to CFG. Further investigation/fixes to follow.
TEST=CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite.
BUG=584575,708098
Review-Url: https://codereview.chromium.org/2813823006
Cr-Original-Commit-Position: refs/heads/master@{#464475}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 723503ec2956cc8b66e53a5ee97985ec262a599d
Reason for reland:
Error downstream has been fixed. So it should be able to reland now.
TBR=mikecase@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=605572
Review-Url: https://codereview.chromium.org/2815073003
Cr-Original-Commit-Position: refs/heads/master@{#464107}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e646a34701985a47d695ef0cbafdd8db5c7886e3
46f403377367 posix: Add ScopedDIR for managing open directories
ab9c03f8827b win: Promote WinMultiProcessWithTempDir to test/win for
reuse
9c6d190b9570 linux: Add ScopedPtraceAttach to manage ptrace attachments
fd9f952393ea Fix crashpad_util_test build with GCC after 4b450c813795
e142aa87d663 linux: Fix crashpad_util_test ScopedPtraceAttach.* with the
Yama LSM
a5d81370beda linux: Use pread64() instead of pread() in ProcessMemory
30385d4e4772 handler: Add user extensibility stream call-out
79425e4d9737 win: Free an old buffer before attempting to allocate a
resized one
1f28a123a4c9 designdoc: Add description of user data sources
BUG=crashpad:167,crashpad:30
Review-Url: https://codereview.chromium.org/2814043003
Cr-Original-Commit-Position: refs/heads/master@{#464059}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bcba287825394261983a99443cb1be450de1083c
Previously this was guarded with use_clang on shared_library_config, but
some targets use static_config directly.
BUG=b/37232530
TEST=Build and run device. Check {C/LD}FLAGS
Review-Url: https://codereview.chromium.org/2808253003
Cr-Original-Commit-Position: refs/heads/master@{#463795}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58a97b349697f6764d0d0304a8374da957ef2207
Reason for revert:
Reverting because it broke stuff.
Original issue's description:
> Add back buttons and load new 'pages' by calling javascript.
>
> Previously when we want to see the details inside a specific suite, we
> will go to a url '.../?suite=xxx'. This may not work in google storage.
>
> In this cl, I am changing the logic by calling javascript directly to
> change the content of the page, if the user wants to see a specific
> suite.
>
> Because we are not changing urls anymore, we need to have a "Back"
> button to go back to the main page.
>
> BUG=605572
>
> Review-Url: https://codereview.chromium.org/2799153008
> Cr-Commit-Position: refs/heads/master@{#463781}
> Committed: 9b4e899d21TBR=mikecase@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605572
Review-Url: https://codereview.chromium.org/2814903002
Cr-Original-Commit-Position: refs/heads/master@{#463792}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed038bc007f21c911007959447efa64fdfec4b3f
Previously when we want to see the details inside a specific suite, we
will go to a url '.../?suite=xxx'. This may not work in google storage.
In this cl, I am changing the logic by calling javascript directly to
change the content of the page, if the user wants to see a specific
suite.
Because we are not changing urls anymore, we need to have a "Back"
button to go back to the main page.
BUG=605572
Review-Url: https://codereview.chromium.org/2799153008
Cr-Original-Commit-Position: refs/heads/master@{#463781}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9b4e899d21ec602a49cd050b800085cd22130c69
The new Data Saver settings page moves the savings percent and stats above the
graph, changes formatting, and adds a reset button and site breakdown. The site
breakdown displays the top ten sites with the most data usage and their data
savings. The compression stats in native are quieried and a list of
DataReductionDataUseItem is passed to the view to display.
BUG=615560
Review-Url: https://codereview.chromium.org/2781323004
Cr-Original-Commit-Position: refs/heads/master@{#463732}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1956acf3a49b71307e53b33129dad628b64326e8
Adds the ability to show rows with icons to ItemChooserDialog.
Changes BluetoothChooserDialog to pass in an icon for connected devices.
BUG=543466
Review-Url: https://codereview.chromium.org/2704263004
Cr-Original-Commit-Position: refs/heads/master@{#463554}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9620b50d02828a39914e3764dea3ef4cf2bdc3b
The current install_apk installs all apks one by one. This CL enables
apks installation in parallel when execute the test with
command '--enable-concurrent-adb'. In this way, the total
individial_device_set_up time decreases.
BUG=670302
Review-Url: https://codereview.chromium.org/2791613003
Cr-Original-Commit-Position: refs/heads/master@{#463529}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ff10a8c4f7295430af4d3bac32ffb713fb42761
Increase build parity between chromecast and non-chromecast build. Also
adds more checks. Internal builds all compiled without issue.
BUG=581409, internal b/37211660
Review-Url: https://codereview.chromium.org/2810923002
Cr-Original-Commit-Position: refs/heads/master@{#463515}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: be7bac4630c397e4cb8773fc93e1c559c3bfebdb
Allows to use @EnumType as IntDef annotation instead of
@EnumType.EnumTypeEnum
BUG=707186
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2792583002
Cr-Original-Commit-Position: refs/heads/master@{#463490}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 14f477472e0e8612c98763b68e9a51bcae954c24
This generalizes the fall-back to using base::debug::StackTrace to
capture stack traces in builds which lack frame pointers, allowing
native heap profiling to generate useful data, albeit with a more
significant performance penalty.
Changes made in the earlier patch for native heap profiling stack
capture under Windows are un-done in favour of the following:
1. MemoryDumpManager always allows native heap profiling[1].
2. HeapProfilerAllocationContextTracker chooses whether to use
base::debug::StackTrace or TraceStackFramePointers() based on
the value of BUILDFLAG(CAN_UNWIND_WITH_FRAME_POINTERS).
3. BUILDFLAG(CAN_UNWIND_WITH_FRAME_POINTERS) is no longer defined in
configurations which we cannot use frame pointers for unwinding[2].
[1] Though note that only certain build configs actually support
the necessary allocator shims; this will be addressed later.
[2] Frame pointers are only available in profiling & Debug builds on
some platforms, and are available but unsuitable for us to use for
stack unwinding, on others.
BUG=686208
Review-Url: https://codereview.chromium.org/2757123002
Review-Url: https://codereview.chromium.org/2757123002
Cr-Original-Commit-Position: refs/heads/master@{#463411}
Committed: 22b017b9b2
Cr-Original-Original-Commit-Position: refs/heads/master@{#460311}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 460b12442f72be8185a80cbf1ec0be6d11a27515
This change was motivated by the need to remove the
references to wheezy. I noticed that the target_sysroot_dir
argument could be generalized which avoids the extra
conditional in sysroot.gni.
BUG=697494
Review-Url: https://codereview.chromium.org/2810633004
Cr-Original-Commit-Position: refs/heads/master@{#463368}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75cc3b096e245801afa0607dc4f8adc03566ae16
Note that this only changes the icon for the mini infobar, not for
the entire feature (content settings, desktop UI, etc).
BUG=689992
Review-Url: https://codereview.chromium.org/2791093002
Cr-Original-Commit-Position: refs/heads/master@{#463317}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8088cc1ba912e866ea7c5daef7a7b4beba74525c
In resource_sizes.py, we check for static initializers using readelf
and using dump-static-initializers.py. The latter requires an
unstripped .so file. In some 64 bit APKs (i.e. MonochromePublic.apk), a
32 bit binary is also included but since this binary isn't located in
the normal location ($OUTDIR/lib.unstripped/), we currently just check
the 64 bit binary twice.
This also makes |_VerifyBuildIdsMatch()| fail (which was previously
added incorrectly in https://codereview.chromium.org/2706243013) since
we try to verify the build ids of two different binaries (32 and 64 bit
versions).
To simplify this, we ignore 32 bit .so files when 64 bit .so file are
present since the 32 bit .so files will be checked by other bots.
BUG=708942
Review-Url: https://codereview.chromium.org/2797163006
Cr-Original-Commit-Position: refs/heads/master@{#463284}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ad22b20258b96ac8c6da01059e0eb1b321e56f1
under headless chrome.
This patch includes:
1) adding a new print manager, i.e., HeadlessPrintManager to handle all the
printing related IPCs for headless.
2) plumbing through the pdf data from HeadlessPrintManager to
HeadlessDevToolsManagerDelegate to handle the PrintToPDF command.
3) adding a new option to PrintWebViewHelper on Mac to return all the printed
pages in the first PrintHostMsg_DidPrintPage message as a single file.
This makes it conform to Linux and Windows, which simplify the logic in
HeadlessPrintManager.
This patch guarantees that HeadlessPrintManager is the only IPC entry point.
In the future, if there are requirements to support the same devtools command
in regular chrome, we may consider a framework to ensure multiple print managers
to work properly under a content embedder.
BUG=603559
Review-Url: https://codereview.chromium.org/2780433002
Cr-Original-Commit-Position: refs/heads/master@{#463105}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0cbec8b353f24515cc77a67ee95addc4f7a714ab
This adds some basic TEAM and COMPONENT info for the top-level
//testing and //tools files and a few subdirectories, where either
the right owners are in infra or we don't really have good owners
but might as well pick something. This also adds a TEAM entry
for //build.
R=phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2800973004
Cr-Original-Commit-Position: refs/heads/master@{#463048}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9d705ef39020eddba9be5d940b88d1bfd82b6834
Crushed sprite resources and layers were only used for Contextual
Search. CS no longer has a use for a the animated sprite, so this
removes the crushed sprite resources and layers and replaces
the CS use with a static icon.
BUG=707001
Review-Url: https://codereview.chromium.org/2798123002
Cr-Original-Commit-Position: refs/heads/master@{#462861}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba
All platforms now specify whether to emit frame pointers by default, rather than
relying on default compiler options.
This CL moves the logic from config("default_stack_frames") into compiler.gni.
The former is actually the right place for the logic to live, but there exists
code that relies on whether a frame pointer is emitted by default. Right now,
that logic is being duplicated/guessed by the code in question. This CL at least
unifies the logic in a single location.
There current exists code that uses a preprocessor definition
HAVE_TRACE_STACK_FRAME_POINTERS. Despite the name, the code really wants to know
if most stacks can be unwound using stack pointers. I've renamed it to
CAN_UNWIND_WITH_FRAME_POINTERS. Arguably, any code that uses
CAN_UNWIND_WITH_FRAME_POINTERS is broken and should be removed, since it relies
on the assumption that all stacks will either have or not have frame pointers,
but that can vary TU by TU.
BUG=706116, 706654
Review-Url: https://codereview.chromium.org/2782063005
Cr-Original-Commit-Position: refs/heads/master@{#462622}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f7c8a0df4253be5271276dc7f3c1da5ce9b677c1
This CL filters encoded binary protobuf signaled by "***BINARY RUN
STATS***" and program class information signaled by "ProgramClass:".
This extra output is introduced by updating proguard.
BUG=674152
Review-Url: https://codereview.chromium.org/2801443002
Cr-Original-Commit-Position: refs/heads/master@{#462620}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 749473a927734754dfcb323b16bdf747b7248d5a
No need to build intermediate (possibly quite large) strings. This
might also help with large objects failing to pickle.
BUG=680935
Review-Url: https://codereview.chromium.org/2805533003
Cr-Original-Commit-Position: refs/heads/master@{#462553}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: be6dcf5eec3df0153f9e67b0b1a15cf4416144b7
Building with the wheezy sysroot and is_clang=false results in errors
like this:
../../base/process/process_iterator.h:12:16: fatal error: list: No
such file or directory
#include <list>
[1] added a restriction that use_sysroot must be false when building
with is_clang=false. However, as of [2], the wheezy sysroot has been
removed, and these compilation errors are not present on the Jessie
sysroot. This CL removes the restriction added by [1].
[1] https://codereview.chromium.org/1476923005
[2] https://codereview.chromium.org/2597523003
BUG=575778
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2804633005
Cr-Original-Commit-Position: refs/heads/master@{#462343}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c2c8a4d94797d67f76e061be40cfed0378eccd81
It was disabled in BUILD.gn, because there are known failures,
but recently Clang enabled it by default, so we have to opt out.
Eventually, we need to clean up these failures and reenable the
check as it's useful.
BUG=708216,708707
Review-Url: https://codereview.chromium.org/2797253002
Cr-Original-Commit-Position: refs/heads/master@{#462187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 69faa6a6ffc1ceebf4d499618a5d17c8a1e7af67
When passing --headless to avd.py, it fails to start an emulator
and this message is printed:
qemu-system-i386: -audio: invalid option
Taking out the -no-audio option allows the emulator to launch
successfully.
BUG=NONE
Review-Url: https://codereview.chromium.org/2799453003
Cr-Original-Commit-Position: refs/heads/master@{#462106}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e5a1eaf77cc75b28dc7c40a14fdc412fe9a58242
9104d53d1c60 Fix thread startup in snapshot reader test
542a91e20e39 Fix the race causing flaky CrashpadClient tests
270490ff79df win: Be more careful about child process exit codes
6c8a3f700738 win: Use a semaphore for synchronization in
ProcessSnapshotTest
f14eda221fe7 win: Be more careful about exit codes in end_to_end_test.py
449dfc4b5dc1 Remove BUG_LINE_FORMAT from codereview.settings
d6837b2b869f mac: Fix SystemSnapshotMacTest.TimeZone on macOS 10.12.4
96dc950eaf26 posix: Add ScopedMmap for managing memory-mapped regions
3127026a95c1 Convert generate_doxygen.sh to generate_doxygen.py
1a6ae8ce0ba8 posix: Don’t accumulate zombies in ProcessInfo.Forked
test
aa2bc55777b9 posix: Allow ScopedMmap::ResetAddrLen() to deal with
overlap
385fe6615f11 posix: DCHECK for (addr + len) overflow in
ScopedMmap::ResetAddrLen()
c39e4dc9769e mac: Remove obsolete comment about
mach_msg_header_t::msgh_reserved
46883516231e “Promote” test::Paths::Executable() to
Paths::Executable()
fa8ef92dc7f1 linux: Add ProcessMemory which reads another process'
memory
4b450c813795 test: Use (actual, [un]expected) in gtest
{ASSERT,EXPECT}_{EQ,NE}
76a67a37b1d0 Add the --monitor-self argument to crashpad_handler
45305395ad87 win: Determine length of unloaded module names
8f07f7481ab4 handler: Add --monitor-self-annotations
b4095401639e handler: Reuse existing annotations SimpleStringDictionary
BUG=crashpad:30,crashpad:143
Review-Url: https://codereview.chromium.org/2804713002
Cr-Original-Commit-Position: refs/heads/master@{#462093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4d005995302373474923a31d642c8f49071a0ce
estevenson
drbasic
mikecase
pennymac
perezju
dgn
Pawel Hajdan, Jr
rnk
hzl
siggi
brucedawson
bcf
agrieve
megjablon
ortuno
shenghuazhang
mbjorge
wez
sbc
thakis
scottkirkwood
csharrison
jzfeng
dpranke
jbauman
twellington
jochen
erikchen
zpeng
jbudorick
thomasanderson
krasin
sanfin
mark