f84d755521
python_arch: return "unknown" when file does not exist
...
The `file` program follows POSIX as outlined here:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/file.html
Specifically, this part causes troubles:
If the file named by the file operand does not exist, cannot be read, or
the type of the file named by the file operand cannot be determined, this
shall not be considered an error that affects the exit status.
With older versions of `file` (that does not conform to POSIX), this
script will exit 0 with "unknown" as its output when "$1" does not exist.
But with recent releases (that conform to POSIX), this script will exit 1
and can break the build.
Have the script explicitly check for the existence of $1 and if it does
not exist, then runt he unknown logic like normal.
BUG=chromium:332547
TEST=ran python_arch.sh on bogus files with new & old `file` programs
Review URL: https://codereview.chromium.org/137433002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@244778 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-14 18:52:34 +00:00
b7ba0f1901
Use `file --dereference' instead of `readlink -f' + `file'.
...
`readlink -f' is not standard and may not be present on all systems (such as
some BSDs).
Instead of the readlink+file combo, just ask file(1) to dereference the file
it is given.
R=mark@chromium.org
Review URL: https://codereview.chromium.org/19221002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@211783 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-07-16 11:49:19 +00:00
c33ef873ca
[MIPS] Let python_arch script recognize MIPS arch.
...
The script has to be aware of MIPS arch, so it can figure out that the libary
is for MIPS.
BUG= https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome
Review URL: https://chromiumcodereview.appspot.com/11819009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@175689 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-01-09 03:13:27 +00:00
fa0c695188
OpenBSD: compatibility fixes for the build system.
...
- switch from /bin/bash to /bin/sh (bash is not a part of base system
on OpenBSD)
- switch from /usr/bin/python to /usr/bin/env python (python is not a part
of base system on OpenBSD)
BUG=none
Review URL: http://codereview.chromium.org/6845002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@81550 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-04-14 08:38:55 +00:00
49f4c131f4
Yet another try to hotfix the ARM builbots. Sigh.
...
BUG=none
TEST=ARM buildbots go green?
TBR=zelidrag
Review URL: http://codereview.chromium.org/668069
git-svn-id: http://src.chromium.org/svn/trunk/src/build@40635 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-03-04 17:32:58 +00:00
f6b66cdd4b
Ignore missing python library when detecting python architecture and just return unknown, which should disable building pyauto. The ARM buildbots have an incorrect python_ver set.
...
BUG=none
TEST=ARM buildbots go green.
TBR=zelidrag
Review URL: http://codereview.chromium.org/669071
git-svn-id: http://src.chromium.org/svn/trunk/src/build@40632 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-03-04 17:20:29 +00:00
9944007d9a
Detect python version using /usr/lib/libpython$(ver).so.1.0 instead of /usr/bin/python$(ver). /usr/bin/python may not be installed, i.e. on ARM buildbots.
...
BUG=none
TEST=ARM buildbots go green.
TBR=zelidrag
Review URL: http://codereview.chromium.org/669069
git-svn-id: http://src.chromium.org/svn/trunk/src/build@40631 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-03-04 17:07:54 +00:00
e9c8f168cd
Build pyauto only if the architecture of python binary matches.
...
BUG=none
TEST=Building 32-bit pyauto on 64-bit Linux with a 32-bit sysroot works.
Review URL: http://codereview.chromium.org/660443
git-svn-id: http://src.chromium.org/svn/trunk/src/build@40630 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2010-03-04 16:42:23 +00:00
vapier@chromium.org
raphael.kubo.da.costa@intel.com
petarj@mips.com
phajdan.jr@chromium.org
thestig@chromium.org