Граф коммитов

4 Коммитов

Автор SHA1 Сообщение Дата
ajwong@chromium.org de246f9b4f Disable No-compile tests. They are flaky on the tree.
BUG=105388
TEST=none


Review URL: http://codereview.chromium.org/8664019

git-svn-id: http://src.chromium.org/svn/trunk/src/build@111889 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-11-29 08:19:02 +00:00
ajwong@chromium.org d6ef85ecd3 Callback API Change: Reimplement Bind(); support IgnoreResult, full currying, and use less types.
The main API change IgnoreResult() and fully currying.  See unittest for what the new API looks like.  The rest of the changes are done to support that.

Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object.  Now, IgnoreResult() wraps the function like Unretained().

As an incidental benefit, the new implementation gave us fully currying for free.

Also, the new implementation scales better when supporting higher arities of functions.  The new type growth is:

  (n^2 + 20n) / 2

as opposed to

  (3n^2 + 17n) / 2

where n == arity.

For n = 6 and n=10, the new implementation has 81 and 155 templates respectively.

The old implementation had 105 and 235 templates respectively.

BUG=35233,98919,98542
TEST=existing unittests

Review URL: http://codereview.chromium.org/8483003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@110975 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-11-21 19:23:44 +00:00
ajwong@chromium.org e7d0b3e8d0 Disable no-compile tests for now since bots are timing out randomly.
TBR=ami@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7867025

git-svn-id: http://src.chromium.org/svn/trunk/src/build@100566 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-10 03:59:05 +00:00
ajwong@chromium.org 065181b6b8 Create a "no compile" drivers script in python to unittest compile time asserts.
BUG=87341
TEST=enable some of the existing no-compile tests and run on try bots.

Review URL: http://codereview.chromium.org/7458012

git-svn-id: http://src.chromium.org/svn/trunk/src/build@100564 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2011-09-10 03:03:00 +00:00