This CL moves GoogleURLTracker and associated friends to the Google component.
It additionally moves strings that GoogleURLTrackerInfoBarDelegate into
components_strings.grd (via google_strings.grdp).
Dependencies of this code on google_util are temporarily punched through the
embedder, as google_util will require more time to componentize. Once
google_util is componentized, the indirection through the embedder will be
removed.
BUG=373209,373222
TBR=thakis, cbentzel
Review URL: https://codereview.chromium.org/316203003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@275743 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Bisect bots creates binaries under build/bisect, where as logcat where
searching for binaries and other related file under build/src.
Now we look for files under build/bisect on bisect bots.
BUG=381377
NOTRY=true
Review URL: https://codereview.chromium.org/317993004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@275494 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
This is causing instrumentation-yakju-clankium-tot and clang-clankium-tot-builder (downstream) to fail with the following error message:
FAILED: cd ../../clank/native/framework; python ../../../build/android/gyp/process_resources.py --android-sdk /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//platforms/android-19 --android-sdk-tools /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//build-tools/19.0.0 --android-manifest ../../../clank/java/apps/deviceextras/AndroidManifest.xml --dependencies-res-dirs "" --extra-res-packages "" --extra-r-text-files "" --proguard-file ../../../out/Debug/device_extras_apk/proguard.txt --resource-dir ../../../clank/java/apps/deviceextras/res --res-v14-compatibility-dir ../../../out/Debug/device_extras_apk/res_v14_compatibility --crunch-output-dir ../../../out/Debug/device_extras_apk/res --R-dir ../../../out/Debug/device_extras_apk/gen --stamp ../../../out/Debug/device_extras_apk/codegen.stamp
Traceback (most recent call last):
File "../../../build/android/gyp/process_resources.py", line 217, in <module>
main()
File "../../../build/android/gyp/process_resources.py", line 166, in main
options.v14_verify_only)
File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 335, in GenerateV14Resources
ErrorIfStyleResourceExistsInDir(input_dir)
File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 107, in ErrorIfStyleResourceExistsInDir
'-v17 directory. Please refer to '
Exception: error: style file /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values/styles.xml should be under /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values-v17 directory. Please refer to http://crbug.com/243952 for the details.
I don't know resource loading well enough to tell if that's a legitimate issue or not; so for now reverting this to fix the build bots, and if it is a legitimate issue then ideally it could be fixed before relanding this?
Original issue's description:
> Add creation of v14 compatible resources to process_resources.py
>
> There are a lot of steps in processing resources and preparing them for
> packaging. It will be easier if these are all done by the same script.
>
> BUG=375431,359249
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275401TBR=newt@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375431,359249
Review URL: https://codereview.chromium.org/314363002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@275436 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We ran "python detect_host_arch.py" ~15 times from gyp. Run
detect_host_arch.py directly from from within gyp for faster execution
and since the path is no longer part of the command, the result will
also be cached more often.
The total gain is at best 0.3 seconds. For most people it will be less.
BUG=362075
Review URL: https://codereview.chromium.org/256303003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@275361 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
addr2line processes keep growing as they are used so it's best to
restart them every now and then to avoid making its internal caches
so large that the computer runs out of RAM or the program becomes
incredibly slow.
I experimented with different counts. 10000 uses 50% more memory
than 4000 for a marginal performance increase. 1000 uses a bit
less memory but will be 10% slower. 3-4000 seems to be the sweat
spot.
BUG=379153
Review URL: https://codereview.chromium.org/311443002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@275165 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Chrome shell is still being referred as ChromiumTestShell in
some places, especially in the telemetry scripts. This
cleanup has dependency on changes in the buildbot
scripts as well where we are invoking the telemetry scripts
as ChromiumTestShell. The buildbot changes are uploaded as
part of https://crrev.com/302743002 to correct invocation as
ChromeShell instead ChromiumTestShell.
BUG=355730
Review URL: https://codereview.chromium.org/302653004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274857 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes us get XP/Server 2003 compatible metrics for window
sizes and so indirectly fixes pixels being cut off at the top
of the window.
(Server 2003 compatible metrics make us match x86 behaviour, and
since we need to maintain XP subsystem there indefinitely, I can
sort of rationalize it on that basis.)
R=jschuh@chromium.org, wfh@chromium.org
BUG=361720
Review URL: https://codereview.chromium.org/311953003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274853 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Background: I am currently trying to test NaCl in clank by setting disable_nacl=0 and enable_plugins=1 in gyp. Some of the code required to get this to work is guarded under overly-specific OS==android and similar constructs. This first CL enables a coherent build with the flags set to gyp, but does not yet turn the functionality on completely. A sampling of issues fixed:
1) std:: prefix is more strictly observed on android
2) define NACL_LINUX, etc., is needed for nacl code
3) properly guard flag-setting code
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032R=bradnelson@google.com, darin@chromium.org
Review URL: https://codereview.chromium.org/299703016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This patch makes it possible to run the perf profiler
through adb_profile_chrome. The result is a trace file that
contains samples from perf as well as events from Chrome
trace events or systrace.
For example, to find out in which functions CPU time is
being spent:
$ build/android/adb_profile_chrome --browser build --time 5 --perf
BUG=375754
TEST=build/android/chrome_profiler/run_tests
NOTRY=true
Review URL: https://codereview.chromium.org/293193002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274837 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This splits views_content_client_main_parts_* into versions for
ChromeOS, Mac and Desktop Aura, with a per-platform Create(..) function.
ChromeOS and Desktop Aura sharing a common Aura part.
desktop_test_views_delegate.cc is moved to an _aura version, and a _mac
version added.
views_content_client now loads content_resources.pak to access sandbox
profiles required for mac.
A macviews_builder target is added to expose
views_examples_with_content_exe on Mac, and to give the fyi trybot
something to build.
BUG=366007
Review URL: https://codereview.chromium.org/297143009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274775 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Background: We restart adbd between runs because we noticed that the
likelyhood of an adbd hang goes up with the length of time the process
has been running.
Killing was just a convenient way to do that, but it isn't the most robust.
The chromium.perf bots are very frequently going offline now and they
always are getting stuck at the point of the adbd restart. So I'm trying
this gentler method of restarting to see if it improves reliability.
BUG=
Review URL: https://codereview.chromium.org/304053002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274360 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a new tab to the about:sync page to display the latest per-type
counters. These counters will eventually replace the StatusControllers
that contain much of the same information.
This includes some changes to the C++ SyncInternalsMessageHandler to
register to observe these counters as well as some new WebUI to display
them.
There is a known bug in this code. The StausCounter update logic has
not been implemented yet, so the item counts will always be zero. This
will be fixed in a future CL.
BUG=349301
Review URL: https://codereview.chromium.org/290023003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274348 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
As a first step to getting a separate target for the display unittests, this CL is adding a simple target with one unittest. All display_unittests currently running under ui_unittests will be migrated under this target when display_unittests is enabled on the main waterfall.
BUG=333413
Review URL: https://codereview.chromium.org/304183010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274332 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- This strips conditions inside a variables in addition to the toplevel conditions.
- Removes percent signs from the ends of variable names.
Both of these are required to import some of the Blink .gypis.
Make net forward the crypto config. This appears to be necessary to use net's public API.
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/305013009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274302 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
To solve the dependency on chrome_command_ids, this CL removes the
IDC_OPTIONS_TRANSLATE_* constants and instead defines the command IDs
locally in the file, which is an approach already used at several other places in
the code.
To solve the dependency on themes, the icon ID for the translate infobar is no
longer hardcoded, but fetched from the translate client instead.
BUG=371845
TBR=estade, joaodasilva
Review URL: https://codereview.chromium.org/284313008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274252 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL makes a couple more changes to accomodate for the implementation
of this policy:
- moved the kManagedBookmarks pref into the bookmarks component, so that
it can be referred to from there;
- moved the strings for the managed bookmarks folder name for the same
reasons;
- updated the policy schema to support child bookmarks;
- updated the ManagedBookmarksPolicyHandler to use the schema validation
code, and added a new unit test for that.
TBR=nyquist@chromium.org
BUG=49598
Review URL: https://codereview.chromium.org/307993005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@274124 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
torne@chromium.org
mlamouri@chromium.org
pliard@chromium.org
blundell@chromium.org
sl.ostapenko@samsung.com
cjhopman@chromium.org
tfarina@chromium.org
scottmg@chromium.org
zeeshanq@chromium.org
prasadv@chromium.org
johnme@chromium.org
nbarth@chromium.org
bratell@opera.com
brettw@chromium.org
halton.huo@intel.com
phajdan.jr@chromium.org
rsesek@chromium.org
jsbell@chromium.org
thestig@chromium.org
r.kasibhatla@samsung.com
sehr@chromium.org
skyostil@chromium.org
machenbach@chromium.org
jamesr@chromium.org
tonyg@chromium.org
tapted@chromium.org
jochen@chromium.org
glider@chromium.org
mek@chromium.org
bulach@chromium.org
bradnelson@google.com
rlarocque@chromium.org
erg@chromium.org
dnicoara@chromium.org
grt@chromium.org
droger@chromium.org
joaodasilva@chromium.org
mcgrathr@chromium.org
bengr@chromium.org