This adds a GLib WaylandWatcher implemenatation that allows the
Wayland server to listen for and dispatch messages when using a
GLib message loop.
BUG=549781
TEST=build chrome without use_glib=false and run with --enable-wayland-server
Review URL: https://codereview.chromium.org/1486623003
Cr-Original-Commit-Position: refs/heads/master@{#362719}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75cd05b4694653d9af4fcc8c5c05f7dae433137d
The 64-bit MSVC assembler (ml64.exe) does not accept the /safeseh
switch. Only the 32-bit x86 MSVC assembler (ml.exe) does. The
64-bit assembler prints a warning about an unrecognized option,
which is ulgy though it does not break the build.
BUG= none
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1488853003
Cr-Original-Commit-Position: refs/heads/master@{#362539}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a176b5bc5cca245c32f8963579fd6cdca4e6ea25
This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define.
Review URL: https://codereview.chromium.org/1478623004
Cr-Original-Commit-Position: refs/heads/master@{#362284}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc4bccdacc16ccdf314870049033e03c463e478e
This changes enables chrome for MIPS (Linux and Android)
to be compiled with clang when using gn build.
However, there are still few issues for build to complete successfully:
- "treat_warnings_as_errors=false" must be set for both Android and Linux.
- in case of Linux ldflags retreived by 'exec_script("sysroot_ld_path.py",..'
are ignored by linker, which is causing link failure for 'chrome' target.
BUG=gn gen for MIPS
TEST=gn gen out-gn/mips --args="is_debug=false target_os=\"android\" target_cpu=\"mipsel\" is_clang=true treat_warnings_as_errors=false"
ninja -C out-gn/mips chrome_public_apk
Review URL: https://codereview.chromium.org/1475943003
Cr-Original-Commit-Position: refs/heads/master@{#362002}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: af7fa747c3c2e433028103b45173c0275333abc7
Reason for revert:
Speculative revert to fix:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -d google_chrome -c beta
dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory.
4c4
< libc6 (>= 2.11)
---
> libc6 (>= 2.15)
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/43856/steps/compile/logs/stdio
Original issue's description:
> Only build against prebuilt sysroot when using clang
>
> Its is not currently possible to use gcc with the sysroot
> since the sysroot only contains C++ headers for gcc 4.6
> and gcc 4.8 is required to build chromium. Luckily clang
> is more flexible and able to detect and work with the 4.6
> headers in the sysroot.
>
> BUG=504446
>
> Committed: https://crrev.com/ccc8c1e14c155255a8ef844704d97fa8e7d0dac2
> Cr-Commit-Position: refs/heads/master@{#361905}
TBR=dpranke@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1483433002
Cr-Original-Commit-Position: refs/heads/master@{#361916}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10c8cbc6c725a8aee45a539e0e5acefbd027e011
Its is not currently possible to use gcc with the sysroot
since the sysroot only contains C++ headers for gcc 4.6
and gcc 4.8 is required to build chromium. Luckily clang
is more flexible and able to detect and work with the 4.6
headers in the sysroot.
BUG=504446
Review URL: https://codereview.chromium.org/1476923005
Cr-Original-Commit-Position: refs/heads/master@{#361905}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ccc8c1e14c155255a8ef844704d97fa8e7d0dac2
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1475513006/
Reland of https://codereview.chromium.org/1458653002/TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1469383005
Cr-Original-Commit-Position: refs/heads/master@{#361854}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 06c2ba3165d8b02364bf818d5028a7cb4fe48ac0
Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.
This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.
It also fixes the install step when only a single dex file exists.
BUG=559306
Review URL: https://codereview.chromium.org/1471393002
Cr-Original-Commit-Position: refs/heads/master@{#361762}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f62854810a390c41afcdde391b3aa0f56a9b367a
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Reland of https://codereview.chromium.org/1458653002/TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/1475513006
Cr-Original-Commit-Position: refs/heads/master@{#361741}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cbc1cd295bc85219ad89326457cd7f5cf003d41c
Reason for revert:
This seems to have broken webkit builders: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/94668
Original issue's description:
> New build flag system, convert Google Now flag
>
> This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
>
> Converts Google Now to use this and remove the global google now define and grit define.
>
> Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
>
> Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
>
> Committed: https://crrev.com/3118dde528359280fa0cb3c6fc5b6323e834c514
> Cr-Commit-Position: refs/heads/master@{#361527}
TBR=mark@chromium.org,spang@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1475883002
Cr-Original-Commit-Position: refs/heads/master@{#361541}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4496a9a4563bf34e624261f7dcc5f1180282ff86
This generates headers with build flags rather than forcing them all to be global. It includes an accessor wrapper so that references to the flags will fail if the proper header is not included.
Converts Google Now to use this and remove the global google now define and grit define.
Adds support for grit define values of "true" and "false" for ease of integration with GN (they are mapped to the corresponding Python "True" and "False").
Adds dependencies from the main gyp targets to the new generated feature define target. Since GYP only does hard dependencies one level, this should reduce the chance that somebody adds more of these cases and forces to add a dependency.
Review URL: https://codereview.chromium.org/1458653002
Cr-Original-Commit-Position: refs/heads/master@{#361527}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3118dde528359280fa0cb3c6fc5b6323e834c514
We have permission to remove the build time flag in favor of a runtime
flag for enabling ARC Bridge Service, conditional on committing to a
more stable and appropriate IPC mechanism for the bridge.
BUG=559654
TEST=components_unittests
Review URL: https://codereview.chromium.org/1466143002
Cr-Original-Commit-Position: refs/heads/master@{#361484}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 89b91de77ee7fa5ac5103ff1b9355c8230abcca5
Reason for revert:
Couldn't reproduce the failure.
Original issue's description:
> Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 of https://codereview.chromium.org/1464983003/ )
>
> Reason for revert:
> Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973
>
> Original issue's description:
> > Use sysroot by default for all linux builds
> >
> > Using a sysroot was already the default for official
> > build and when cross compiling (e.g. arm, mips, x86-32).
> > This change makes it the default in all cases.
> >
> > The old behavior of building against local
> > system libraries can still be achieved by
> > setting use_sysroot=0
> >
> > BUG=504446
> >
> > Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d
> > Cr-Commit-Position: refs/heads/master@{#361197}
>
> TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=504446
>
> Committed: https://crrev.com/05373dc078f0d5d3f2fb1398db9a4008a55d9016
> Cr-Commit-Position: refs/heads/master@{#361405}
TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1472873004
Cr-Original-Commit-Position: refs/heads/master@{#361411}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 964155752e49f75260e86ba824fcec81b3fd4c3d
Reason for revert:
Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973
Original issue's description:
> Use sysroot by default for all linux builds
>
> Using a sysroot was already the default for official
> build and when cross compiling (e.g. arm, mips, x86-32).
> This change makes it the default in all cases.
>
> The old behavior of building against local
> system libraries can still be achieved by
> setting use_sysroot=0
>
> BUG=504446
>
> Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d
> Cr-Commit-Position: refs/heads/master@{#361197}
TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446
Review URL: https://codereview.chromium.org/1473363002
Cr-Original-Commit-Position: refs/heads/master@{#361405}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 05373dc078f0d5d3f2fb1398db9a4008a55d9016
Using a sysroot was already the default for official
build and when cross compiling (e.g. arm, mips, x86-32).
This change makes it the default in all cases.
The old behavior of building against local
system libraries can still be achieved by
setting use_sysroot=0
BUG=504446
Review URL: https://codereview.chromium.org/1464983003
Cr-Original-Commit-Position: refs/heads/master@{#361197}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a931efd5dc8d8783ce73a64fc641627866b6869d
This change updates and simplifies vs_toolchain.py so that it supports
VS 2015 in gn builds. The gn and gyp code now shares DLL copying code so
that they should more naturally stay in sync in the future. The
out_release_nacl64 directory now gets a PGO DLL that it didn't used to.
The six warnings globally disabled are globally disabled in gyp builds
as well. The equivalent warnings (narrowing conversions and variable
shadowing) are disabled in gcc/clang so there is no bug for enabling
them at this time.
BUG=440500
Review URL: https://codereview.chromium.org/1468643002
Cr-Original-Commit-Position: refs/heads/master@{#360988}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aaff8dcb6ee993a18ab6e7236711839e72e81cc3
Platform mode uses explicit paths to APKs rather than the current system
of the name + the output directory. This is also a prelude to installing
an additional apk for instrumentation tests that will use the embedded
test server.
BUG=
Review URL: https://codereview.chromium.org/1465523002
Cr-Original-Commit-Position: refs/heads/master@{#360922}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7873c6dcee70af978571d9bdf12cf650ef296d57
The recent formatter alphebetizing change is causing a lot of noise in
code reviews. Figured it'd be worth a clean-up CL.
Exact command I ran:
find . -name "*.gn*" -exec gn format --in-place "{}" \;
TBR=ddorwin@chromium.org
BUG=554928
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1464873002
Cr-Original-Commit-Position: refs/heads/master@{#360891}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d7a71c88990b6788ceaf1ec9ee518099709ff3fd
Exosphere is a set of display server classes for Chromium that
can be used for building a display server on top of Ash, the
Chrome Compositor and the GpuMemoryBuffer framework.
The classes and interfaces are inspired by the Wayland protocol
and reference implementation of a display server that uses
the Wayland protocol and server library is provided in the
wayland/ sub-directory.
BUG=549781
TEST=components_unittests --gtest_filter=ServerTest.*:SurfaceTest.*:BufferTest.*:DisplayTest.*:ShellSurfaceTest.*:SharedMemoryTest.*
Review URL: https://codereview.chromium.org/1412093006
Cr-Original-Commit-Position: refs/heads/master@{#360672}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b195f41daf755c80d31f964538b1159c81d58e70
This CL makes the "process_java_prebuilt" and "compile_java" templates follow the
convention:
"Local variables in a template should be prefixed with an underscore"
BUG=535290
Review URL: https://codereview.chromium.org/1457113002
Cr-Original-Commit-Position: refs/heads/master@{#360608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c79f5d4de76cd15fe59be6c24e8bec7c48a3f11f
This patch
- made shared_resources works
- not compress lpak
- move some code to gni files, so they could be reused in downstream.
BUG=532905
Review URL: https://codereview.chromium.org/1452893002
Cr-Original-Commit-Position: refs/heads/master@{#360183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 372730a1425415ada0fb77e8652357fc9bcb63a0
This adds the ARC bridge functionality and starts an ARC instance when
the user logs in.
BUG=b:24339743
BUG=554214
TEST=chromeos_unittests
TEST=ARC instance running on login
Review URL: https://codereview.chromium.org/1412863004
Cr-Original-Commit-Position: refs/heads/master@{#359982}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c951edfb84c3439da64cc2d97d6e7b495323d349
PNaCl doesn't provide objdump, so use NaCl newlib version when
generating nmf files for PNaCl since the create_nmf.py script requires
objdump to be set.
BUG=462791
Review URL: https://codereview.chromium.org/1449223002
Cr-Original-Commit-Position: refs/heads/master@{#359970}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 102f32212c2e08281d38f59a802377934318680e
The toolchain executables have the ".exe" suffix on Windows. Plumb
through the readelf, nm, and strip tools for NaCl toolchains. These
were accidentally using default host tools, which happen to work on
other host platforms, but don't exist on Windows.
BUG= 512869
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1447533005
Cr-Original-Commit-Position: refs/heads/master@{#359715}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 34fa90d65772e8b432d5c37cd607ed6d6dcc5ca0
reveman
thakis
mcgrathr
agrieve
phosek
vabr
brettw
pkotwicz
Gordana.Cmiljanovic
brucedawson
sbc
Hans Wennborg
moshayedi
raymes
lhchavez
droger
scottmg
jbudorick
pasko
michaelbai
dpranke