shadow-call-stack is enabled by default on Fuchsia now, so we no longer
need to enable it explicitly.
Bug: 821951
Change-Id: I221bc557bf93dfd5bf7c1659f7f8dfc32129c6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898631
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#714312}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3ee16746bdf236c99f485ba4cf3d3d90f265ab03
Changes the OUTDIR/bin/install_foo scripts to run "pm install"
on existing Fuchsia Amber repositories. This better suits the common
workflow of deploying to existing paved devices.
Adds a GN arg "default_fuchsia_build_dir_for_installation" to enable
super EZ zero-arg invocations of the install script.
Bug: 973159
Change-Id: I5d4456fd74f7000a576749d2c427051f24d216b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815838
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Auto-Submit: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#703075}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55fd8528e215a934a7a2ff92cbb29874a7b948b4
All boot image related tasks are now performed at runner script
execution time. This allows build-only bots, which will not execute
tests, to perform a build without needing to checkout boot images.
Make the --boot-images argument optional in update_sdk.py.
Bug: 990513, 997527
Change-Id: Ie2ff4842c824030fb446c6d585c96dca1af9479b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769712
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#690551}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0da94264d98bef9cf647b368d513ca471e3edca0
- Paths intererpreted by GN such as paths in inputs, sources, lib_dirs,
etc should either be relative to BUILD.gn, or GN-absolute (relative to
source root and start with "//").
They should not be rebased as system-absolute paths; those are only
needed for paths that are actually outside the source tree.
If paths are used in multiple contexts, rebasing should be deferred
until they are used in a context where rebased paths are required.
- Paths passed as arguments to scripts should be rebased on
root_build_dir, which is the current working directory of the build.
They should not be rebased on root_out_dir, as that is only the current
working directory for the default toolchain. Using root_out_dir in
place of root_build_dir breaks cross compilation.
They should also not be resolved to system-absolute paths, as that
introduces an undesired dependency on the location of the source tree.
- The 3rd argument to rebase_path has no effect for GN-absolute paths,
which includes all paths built by appending to predefined variables
such as root_out_dir.
Change-Id: I54ff2d9fed0daadacf5bd1bd8fdadc561c3a2882
Reviewed-on: https://chromium-review.googlesource.com/c/1448694
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#629579}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 38a9d29f7a14516cfc4a57559382222f0a41c0ca
V8 compatibility with safe-stack has been fixed, so it should
be safe to enable it on Fuchsia now.
Bug: 821951
Change-Id: Id33070719e2f4e1c5def12b102f9ec5afabcd6b6
Reviewed-on: https://chromium-review.googlesource.com/c/1185730
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#627195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3521df28cf1a85a45331c74b832fc9ae53bf200a
This adds support to build Chromium for Fuchsia on macOS. Currently,
this configuration is to be treated as best-effort.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
Bug: 707030
Test: Locally, builds on mac.
Change-Id: I9e4bde1b7ff658f51586856ae80598c93a2b2e33
Reviewed-on: https://chromium-review.googlesource.com/1185020
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587546}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bbc67a1bd5cc611039aef8c6a2f9fa7151a07735
QEMU will soon be removed from the Fuchsia SDK tarball.
This CL migrates our scripts to source QEMU from CIPD instead.
Change-Id: I2347a5be598a1eecd2d7c9e6c431b55c3eab1189
Reviewed-on: https://chromium-review.googlesource.com/1178975
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584238}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6a59a6bf0c44a45fabe15389cd29373325eb4e8
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org
Change-Id: I99a21f1060e81a5f7930d6ec6b6b269f76a23c41
Reviewed-on: https://chromium-review.googlesource.com/1174011
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/master@{#583327}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8026d1f9ceb969b6575909a459957211b1e6863c
The new SDK format put the kernel images under the target/{x64,arm64}
directories.
Change-Id: I36f944cf1914289ec16d8f9595323b3797652709
Reviewed-on: https://chromium-review.googlesource.com/1087492
Commit-Queue: Alain Vongsouvanh <alainv@google.com>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564564}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e822f462b0ca5c542a5381addd84dbe8b7a1d420
1. Moved fdio to deps instead of public_deps in //base
2. Added direct deps on FDIO in targets that need it, particularly in
mojo.
3. Also replaces some deps with public_deps in
//mojo/edk/test:test_support to reflect set of header deps in the
headers exported by that target.
4. Small cleanups in mojo/edk/BUILD.gn to make it more readable.
5. Updated build/config/fuchsia/BUILD.gn to avoid dependency on
internals of third_party/fuchsia-sdk/BUILD.gn.
Bug: 707030
Change-Id: I402d3cd0d1d709aa381fa10e6fc6dfdb8e7e060c
Reviewed-on: https://chromium-review.googlesource.com/1052608
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557935}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2293c96db6d66f2b49c48eab9335ba665827d283
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org
Bug: 841171
Change-Id: I4c23bacf4f44799b63cebefe51a5f94965408bd8
Reviewed-on: https://chromium-review.googlesource.com/1051263
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/master@{#557142}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8fd4e46f603746981cfca9490ce6ea49ed11928c
The current partition size limits are too small to accomodate very
large packages such as debug builds of "content_unittests" (600MB).
This CL adjusts the limits and deployment workflow to better handle
large files.
* Increase blobstore extend amount from 512MB to 1GB.
* Copy target for install packages changed to /data (was /tmp ,
which is smaller and in-memory).
* Increase /data partition size from 10MB to 1GB, large enough
to hold packages.
* Eagerly delete the /data partition file after qcow2 images are
created, to reduce the space footprint on the test host.
* Add cleanup step for install packages.
* Move qcow2 creation logic to boot_data.py.
* Clarified some logging statements.
Bug: 798851
Change-Id: Ia98dd5f483ccca8802f68a865d3a85ed061dfbd8
Reviewed-on: https://chromium-review.googlesource.com/1030951
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554155}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 43531956535482f54a27900530f0729f195aa98a
SSH multiplexing makes SSH-based forwarding much more performant
and reliable versus using separately negotiated connection.
Connection overhead for runner_v2 SSH operations is also reduced.
* Fix deployment path used to push the test server configuration
to the target device.
* Documentation fixes.
Bug: 798851
Change-Id: I4d97204b0e3420e0ae8ce0ca8bcf6ca137dce46f
Reviewed-on: https://chromium-review.googlesource.com/1018364
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552157}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55e9532b45401cb1b0ee66783b69bed19e79b3c4
This sets is_posix to false for the Fuchsia build as it will rely less
and less on the POSIX implementation. Follow-up CLs will clean up build
files from redundant checks and stop including _posix files by default.
Bug: 812974
Change-Id: I6dc625ba2d4919a775041b1516e051b471c50e97
Reviewed-on: https://chromium-review.googlesource.com/987377
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550292}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9fba3affd0a3246f2ec851c5f83cc3588a379086
This is a reland of 2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a , using
a newer SDK build which addresses the symbol visibility issues
that were causing the "new" operator to break.
TBR=wez@chromium.org
Original change's description:
> Fuchsia: extend the size of the blobstore FVM at build time.
>
> This CL grows Fuchsia blobstore by a specified amount, large enough to
> accommodate packaged executables installed at machine (QEMU) runtime.
>
> Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion
> of fvm.blk.
>
> Bug: 798851, 707030
> Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6
> Reviewed-on: https://chromium-review.googlesource.com/987012
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547568}
Bug: 798851, 707030
Change-Id: I62de331c46b38ed7adb460bf9f5e8335e3f54a02
Reviewed-on: https://chromium-review.googlesource.com/996273
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#548187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: febd80e463c099d074133e649d972bc5d49bc54d
This reverts commit 2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a.
Reason for revert: Unfortunately the SDK this CL rolled us to is subtley but badly broken. The CL fell narrowly short of Breaking All The Things, because some of the Things just don't touch the broken bits. :(
Original change's description:
> Fuchsia: extend the size of the blobstore FVM at build time.
>
> This CL grows Fuchsia blobstore by a specified amount, large enough to
> accommodate packaged executables installed at machine (QEMU) runtime.
>
> Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion
> of fvm.blk.
>
> Bug: 798851, 707030
> Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6
> Reviewed-on: https://chromium-review.googlesource.com/987012
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547568}
TBR=wez@chromium.org,kmarshall@chromium.org
Bug: 828232, 828229, 798851, 707030
Change-Id: I3ac0d1586c1a70700fbbd88d9f5762728bedc868
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/991672
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#547618}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 195beedfda5d3271d053eddfeea929e399229a03
This CL grows Fuchsia blobstore by a specified amount, large enough to
accommodate packaged executables installed at machine (QEMU) runtime.
Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion
of fvm.blk.
Bug: 798851, 707030
Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6
Reviewed-on: https://chromium-review.googlesource.com/987012
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#547568}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a
Clang r326867 turned on SafeStack when targeting Fuchsia by default.
Turn it off in our build config until all the tests pass.
Bug: 817298, 821951
Change-Id: Id2d9f911eb62fe6823365baeba55a4ccc0b484ce
Reviewed-on: https://chromium-review.googlesource.com/959003
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#543745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6705a9b1d17e8f56c9a8229c971a7286ce1fbe42
Includes a Fuchsia SDK update, and a lot of mx_ -> zx_, et al.
Sets CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON=1 as a global define
temporarily to support for 3-sided rolls of third_party DEPS.
Requires https://chromium-review.googlesource.com/c/v8/v8/+/668751 to
have landed and rolled.
Requires boringssl roll with similar change to have landed
https://chromium-review.googlesource.com/c/chromium/src/+/668704.
R=dcheng@chromium.org,nick@chromium.org,tsepez@chromium.org,rockot@chromium.org
TBR=nick@chromium.org
Bug: 765754, 707030
Change-Id: I6c2ad37b3c5b13c2a3a98da6e1ff9160ad2de949
Reviewed-on: https://chromium-review.googlesource.com/669139
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502678}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fe0e9f46ab247ff5a28a823f344c93230953018f
Without this, --as-needed will drop mxio, which means stdio doesn't get
initialized, which means printfs disappear into void.
Before:
sgraham@river:/work/cr/src$ readelf -d out/fuch/d8
Dynamic section at offset 0xe0d2a8 contains 20 entries:
Tag Type Name/Value
0x0000000000000001 (NEEDED) Shared library: [libc.so]
0x000000000000001e (FLAGS) BIND_NOW
0x000000006ffffffb (FLAGS_1) Flags: NOW
0x0000000000000015 (DEBUG) 0x0
...
After:
Dynamic section at offset 0xe0d2a8 contains 21 entries:
Tag Type Name/Value
0x0000000000000001 (NEEDED) Shared library: [libc.so]
0x0000000000000001 (NEEDED) Shared library: [libmxio.so]
0x000000000000001e (FLAGS) BIND_NOW
0x000000006ffffffb (FLAGS_1) Flags: NOW
0x0000000000000015 (DEBUG) 0x0
...
and printf in main() of d8.cc shows up in the output.
Bug: 731217
Change-Id: I66df1a91eb3fa2757c0a05ede37da113ccb80bdb
Reviewed-on: https://chromium-review.googlesource.com/616160
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494585}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8c1ad674f71fdbf8616053868b7a02b4de9c9b05
Reverts some Fuchsia bits of https://chromium-review.googlesource.com/c/582074
Also only default use_custom_libcxx to true on Linux if is_clang
(which on our bots is always the case), so that we can assume that
this flag is available. (If gcc ever adds a -nostdlib++ flag, we
can undo this part.)
Bug: 750434,724204
Change-Id: Ib548b403703f6dc77e5ec09c7ee14e360fb09b72
Reviewed-on: https://chromium-review.googlesource.com/606790
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493055}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff69d3018c42eb994533de337f81d417a0209913
Not the normal simple update-the-hash SDK update. Changes:
- Use our own libunwind (as it's been removed from the Fuchsia SDK);
- Use the toolchain hash as a version #define instead of the .stamp in
sysroot (which has been removed). The Fuchsia team builds with -MD to
cause rebuilds after ABI changes, Chromium builds with -MMD. The
global define ensures we rebuild on SDK updates;
- Update clang version to '6.0.0' to get correct builtins lib;
- Update docs for pulling SDK from prebuilt package, rather than doing
local builds.
- Don't include libc++ and libunwind .so into the runner disk image, as
we link to them statically now.
Bug: 707030, 750392
Change-Id: I6702ce208e23288107db00d80f4bed7f875820ae
Reviewed-on: https://chromium-review.googlesource.com/594270
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491035}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 131568b82901daf84658a300210a9002949b54a2
Ran `tools/clang/scripts/upload_revision.py 308728`.
This changes the clang version from 5.0.0 to 6.0.0, so simplify
some things that dealt with both numbers.
This changes clang to no longer look for libc++ headers in the
Fuchsia SDK. To keep things building, use "our" libc++, like
on linux (use_custom_libcxx). This in turn means we pass
-nodefaultlibs to the linker, which sadly also disables the
automatic linking of clang_rt.builtins, so do that manually now.
(In exchange, we no longer need to pass in -resource-dir.)
This makes -Wformat fire in Google Toolbox for Mac in iOS builds,
so disable -Wformat in that config for now.
Bug: 746303,746505,747638,747643,724204
Change-Id: I6196a2a173a1b4871f22d0ce92436d0197fd7845
Reviewed-on: https://chromium-review.googlesource.com/582074
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488946}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1c688af81fcfa4c072dcca79e698641839e8a42f
80k was the original musl upstream value, but Fuchsia's default stack is
actually 256k. Fix the build file comment that mentioned this.
Bug: 706592
Change-Id: I227640d7f33f8637e388ca931851f50cf925afbc
Reviewed-on: https://chromium-review.googlesource.com/537075
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#479816}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0df88c63b4f36296a7523f80d5bf136154eb92fa
The default stack size is 80k, which is too small for the ample girth of
Chrome. Switch to lld on Fuchsia to gain support for -z stack-size, and
then set the default stack size to 8M.
(lld was also recommended by the Fuchsia team, there's no particular
reason that I used gold originally.)
This fixes JSONReaderTest.Reading. In the stack overflow guard test, 200
deep is allowed, but the default stack size is too small to allow that
to succeed.
Bug: 706592
Change-Id: I83b9675cb795b13c028bcda31dbe81d574723210
Reviewed-on: https://chromium-review.googlesource.com/535875
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#479552}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 79a2810929d1e113f711a933fe4886c84fd34244
Fuchsia support has been upstreamed into Clang, so the existing
Linux-hosted Clang toolchain binaries in third_party with the correct
--target are sufficient. Fuchsia is POSIXy so a lot of things will just
work, but some places will require different implementations, so this CL
adds support for is_fuchsia as well as a basic implementation of the
toolchain config.
The SDK (headers, sysroot, etc.) is currently available at
go/fuchsia-sdk until a standard location for it is decided upon.
The near term goal behind this CL is to bring up base/ and net/ on an
fyi bot running Fuchsia.
BUG=706592
Review-Url: https://codereview.chromium.org/2784063002
Cr-Original-Commit-Position: refs/heads/master@{#471360}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2f97ee120e2d83a87e36e50432b58e790db160ff
Keishi Hattori
Sergey Ulanov
Wez
Kevin Marshall
Michael Spang
Tom Anderson
Scott Graham
Fabrice de Gans-Riberi
Alain Vongsouvanh
Hans Wennborg
Nico Weber