third_party/mesa/src is no longer checked out as of r582655.
BUG=873321
Change-Id: I6ee0dabd58b77a2c1995b7d42df4fb4df909884c
Reviewed-on: https://chromium-review.googlesource.com/1175403
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583326}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 86d8a53eb84f40018c35d064ec1b04908b5dde10
ffmpeg_features is the target used in src/media/ffmpeg and elsewhere.
The target appears to have been accidentally renamed in:
https://chromium-review.googlesource.com/935296
Fixes the following dependency errors when configured with system ffmpeg:
ERROR Unresolved dependencies.
//chrome/services/media_gallery_util:lib
needs //third_party/ffmpeg:ffmpeg_features
//chrome/services/media_gallery_util/public/cpp:browser_tests
needs //third_party/ffmpeg:ffmpeg_features
//chrome/services/media_gallery_util/public/cpp:cpp
needs //third_party/ffmpeg:ffmpeg_features
//media/base:base
needs //third_party/ffmpeg:ffmpeg_features
//media/ffmpeg:ffmpeg
needs //third_party/ffmpeg:ffmpeg_features
//media/filters:filters
needs //third_party/ffmpeg:ffmpeg_features
Change-Id: I2218c1dfb20de87958eeb8c23b18eebbea384c36
Reviewed-on: https://chromium-review.googlesource.com/1131941
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#573952}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 79122c39adda797207909687e09ec1c19e3c3cc7
Use pkg-config to find libs.
Generate shim headers used by third_party/blink/renderer/platform/image-encoders/image_encoder.cc.
Change-Id: I24b259c6905ed2a44b749bbdf00cbad206fa7c89
Reviewed-on: https://chromium-review.googlesource.com/1094330
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565905}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2845858c9aae49ad6d7841a9d095c8af242be14
Ensure ICU symbols have public visibility and are thus excluded from CFI
checks and whole-program optimization. The former caused a startup crash
and the latter has the potential to break virtual calls in weird ways.
BUG=822820
Change-Id: Ia809eefcb9e93b3c612f2381d394db83bbc67120
Reviewed-on: https://chromium-review.googlesource.com/978008
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545638}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f15e8b573ada0fcd643ae393484214b1c7c940f8
third_party/BUILD.gn defines two variables: use_system_libjpeg and
use_libjpeg_turbo. If use_system_libjpeg is true, then use_libjpeg_turbo is
ignored. These variables really have a combined 3 states:
* use_system_libjpeg=true: Use the system libjpeg, which might be the turbo or
regular version of libjpeg, depending on what the user has installed.
* use_system_libjpeg=false,use_libjpeg_turbo=true: Use
third_party/libjpeg_turbo.
* use_system_libjpeg=false,use_libjpeg_turbo=false: Use third_party/libjpeg.
The current unbundle assumes use_system_libjpeg=false and use_libjpeg_turbo=true
(the defaults) and then rewrites the build file of libjpeg_turbo to use the
system library. This CL changes the unbundle to be more direct: simply set
use_system_libjpeg=true. The libjpeg unbundle was broken and
use_system_libjpeg=true was required anyway.
BUG=800977
R=thestig,dpranke
TBR=thakis
Change-Id: I080ab62592007876b3a2e3838cc1a893a383f838
Reviewed-on: https://chromium-review.googlesource.com/974136
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545271}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f3d30e9d19c1a2b3a69217e5e47d1faf019de223
This renames targets in chrome, chromecast and chromeos.
Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.
BUG=814485
TEST=covered by build
TBR=thakis@chromium.org,dcheng@chromium.org
Change-Id: I35f82bb244d2f8bd745d3157f266bae99f21f888
Reviewed-on: https://chromium-review.googlesource.com/935296
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#538905}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6200d332518cd781f87ab86554bc71ff7a01ec4e
This renames targets in chrome, chromecast and chromeos.
Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.
BUG=814485
TEST=covered by build
TBR=dcheng@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
Change-Id: I9e93ff7bfd088b93678ce4a2814a1dbf6e36f091
Reviewed-on: https://chromium-review.googlesource.com/932544
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#538856}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62f6388754e2d36ea003119b0a7f2533c3f62bc1
This reverts commit 5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c
Reason for revert: See comment https://bugs.chromium.org/p/chromium/issues/detail?id=796292#c28
> This reverts commit 4f1a60552748d150783655ee6f7b6f7084e3af95.
>
> Reason for revert: This CL caused time outs in browser tests - see https://crbug.com/796292
>
> Original change's description:
> > Statically link fontconfig on Linux
> >
> > This CL switches Linux to use in-tree fontconfig builds. It exposes some leaks
> > and races detected by LSAN and TSAN. For now, these will be suppressed since
> > these issues were preexisting, but instrumenting fontconfig exposed the issues.
> >
> > R=dnicoara@chromium.org,dpranke@chromium.org
> > BUG=795110,795148
> >
> > Change-Id: Ia75db4ced6ec78a5f0610af9ebc78a87840b86f7
> > Reviewed-on: https://chromium-review.googlesource.com/826403
> > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#524389}
>
> TBR=dpranke@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 795110, 795148
> Change-Id: Id224fdcbfb0ca3373f6219b66252a8970072675b
> Reviewed-on: https://chromium-review.googlesource.com/834869
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525173}
R=dpranke@chromium.orgTBR=dnicoara@chromium.org
BUG=795110,795148,796292
Change-Id: I47a2225cb9cc255721b521cbb790d9eb70e0b3b9
Reviewed-on: https://chromium-review.googlesource.com/841627
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525945}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 65f919d2d86e54c851b0327740a330d152b07ed5
This CL changes the harfbuzz unbundle to set use_system_harfbuzz=true. Since
this build flag exists, it's easier to toggle it than to rewrite
third_party/harfbuzz-ng/BUILD.gn entirely.
R=thestig@chromium.org
BUG=768938
Change-Id: I510994b1d78dc3fe4866ff341018b458ab24e78b
Reviewed-on: https://chromium-review.googlesource.com/840621
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525909}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b5d4c386b9969cff0a8c5c33d51c9ac7112e1b08
This reverts commit 4f1a60552748d150783655ee6f7b6f7084e3af95.
Reason for revert: This CL caused time outs in browser tests - see https://crbug.com/796292
Original change's description:
> Statically link fontconfig on Linux
>
> This CL switches Linux to use in-tree fontconfig builds. It exposes some leaks
> and races detected by LSAN and TSAN. For now, these will be suppressed since
> these issues were preexisting, but instrumenting fontconfig exposed the issues.
>
> R=dnicoara@chromium.org,dpranke@chromium.org
> BUG=795110,795148
>
> Change-Id: Ia75db4ced6ec78a5f0610af9ebc78a87840b86f7
> Reviewed-on: https://chromium-review.googlesource.com/826403
> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524389}
TBR=dpranke@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 795110, 795148
Change-Id: Id224fdcbfb0ca3373f6219b66252a8970072675b
Reviewed-on: https://chromium-review.googlesource.com/834869
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525173}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5a8428d621c9e9c8f5bcfa9ca97ae66002207d8c
The freetype unbundle build file is out-of-date, and trying to use it
will result in errors like this:
ERROR Unresolved dependencies.
//third_party:freetype_harfbuzz(//build/toolchain/linux/unbundle:default)
needs //third_party/freetype:freetype_source(//build/toolchain/linux/unbundle:default)
This CL changes the unbundled build file to simply toggle the
use_system_freetype flag.
R=thestig@chromium.orgCC=phajdan.jr@chromium.org
Change-Id: If38ccc51098857cd479707879562b23f8f32e85f
Reviewed-on: https://chromium-review.googlesource.com/830974
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524535}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a7b961302726f6accc1d70682017b6c36127ae7a
This CL switches Linux to use in-tree fontconfig builds. It exposes some leaks
and races detected by LSAN and TSAN. For now, these will be suppressed since
these issues were preexisting, but instrumenting fontconfig exposed the issues.
R=dnicoara@chromium.org,dpranke@chromium.org
BUG=795110,795148
Change-Id: Ia75db4ced6ec78a5f0610af9ebc78a87840b86f7
Reviewed-on: https://chromium-review.googlesource.com/826403
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524389}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4f1a60552748d150783655ee6f7b6f7084e3af95
This adds webpmux to linked libraries to fix the following compile error:
python "../../build/toolchain/gcc_link_wrapper.py" --output="./font_service.service" -- x86_64-pc-linux-gnu-g++ -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -m64 -pthread -Wl,-O1 -Wl,--gc-sections -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,--export-dynamic -Wl,-O1 -Wl,--as-needed -o "./font_service.service" -Wl,--start-group @"./font_service.service.rsp" -Wl,--end-group -ldl -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -licui18n -licuuc -licudata -latomic -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -lpng16 -lpangocairo-1.0 -lpango-1.0 -lcairo -lfontconfig -lexpat -lz -ljpeg -lwebp -lwebpdemux -lgio-2.0
/usr/lib/gcc/x86_64-pc-linux-gnu/6.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: warning: libfreetype.so.6, needed by /usr/lib/gcc/x86_64-pc-linux-gnu/6.3.0/../../../../lib64/libfontconfig.so, may conflict with libfreetype.so.6
obj/skia/libskia.a(SkWebpEncoder.o): In function `do_encode(SkWStream*, SkPixmap const&, SkWebpEncoder::Options const&)':
SkWebpEncoder.cpp:(.text._ZL9do_encodeP9SkWStreamRK8SkPixmapRKN13SkWebpEncoder7OptionsE+0x46c): undefined reference to `WebPNewInternal'
SkWebpEncoder.cpp:(.text._ZL9do_encodeP9SkWStreamRK8SkPixmapRKN13SkWebpEncoder7OptionsE+0x47e): undefined reference to `WebPMuxSetImage'
SkWebpEncoder.cpp:(.text._ZL9do_encodeP9SkWStreamRK8SkPixmapRKN13SkWebpEncoder7OptionsE+0x494): undefined reference to `WebPMuxDelete'
SkWebpEncoder.cpp:(.text._ZL9do_encodeP9SkWStreamRK8SkPixmapRKN13SkWebpEncoder7OptionsE+0x68e): undefined reference to `WebPMuxSetChunk'
SkWebpEncoder.cpp:(.text._ZL9do_encodeP9SkWStreamRK8SkPixmapRKN13SkWebpEncoder7OptionsE+0x6aa): undefined reference to `WebPMuxAssemble'
SkWebpEncoder.cpp:(.text._ZL9do_encodeP9SkWStreamRK8SkPixmapRKN13SkWebpEncoder7OptionsE+0x6f4): undefined reference to `WebPMuxDelete'
collect2: error: ld returned 1 exit status
This does not affect any build at Google. build/linux/unbundle
is a completely parallel directory tree intended to be used
by Linux distribution packagers. Please see
https://cs.chromium.org/chromium/src/build/linux/unbundle/README
for more context.
BUG=none
R=thestig@chromium.org
Review-Url: https://codereview.chromium.org/2885113003 .
Cr-Original-Commit-Position: refs/heads/master@{#472532}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9c4826790de16b317538db629b44069fa77ddc4
- Better explain what this component does.
- Add a detailed description for replace_gn_files.py.
- Format text to fit in 72 columns.
- Mention GN build files.
Review-Url: https://codereview.chromium.org/2783293002
Cr-Original-Commit-Position: refs/heads/master@{#461186}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5864d312aa006009fb4734c59320f04f2d6dceb2
Investigation of why official chrome_elf.dll builds were 86,016 bytes
larger on gn than gyp showed that encryption functions such as
aesni_cbc_encrypt were being pulled in. Deleting the implementations
of these functions from the .asm file caused no errors which proved that
the functions weren't being referenced, they just weren't being
discarded. Changing the yasm_assemble template to use static_library
fixed that and made the file sizes identical.
Comparison of the dia2dump -p output after that change showed there were
still two extra symbols in the gn builds:
class breakpad::CrashKeysWin * breakpad::CrashKeysWin::keeper_
__aullrem(__aullrem)
keeper_ is a global variable - those are harder to discard, even with
/Gw - but making its source file part of a static_library fixed it.
link /verbose showed that __aullrem is pulled in by an object file that
is then discarded but I decided that following that trail wasn't worth
it. The file sizes are identical and dumpbin /headers shows that the
.text sections virtual size is just 96 bytes larger in the gn case.
Additional changes of source set to static_library may address the
remaining diffs, but they are not large enough to matter.
TL;DR The linker tries to discard unreferenced symbols but it is not
perfect at doing it, even with /Gw and /Gy. Assembly functions may be
difficult also. Use source_set with care.
BUG=624274
Review-Url: https://codereview.chromium.org/2114783002
Cr-Original-Commit-Position: refs/heads/master@{#403480}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ab90cb1edf8f08f1fa5d2551aa21cac225163cf
The TODO about a system yasm is not longer necessary. We don't need to support this for Chrome developers. For Linux distros, Pawel has added an overlay to change the behavior.
The TODO about the output names is out-of-date. The new output location matches the names generated by the C compiler in the Chrome build.
Review-Url: https://codereview.chromium.org/1972173003
Cr-Original-Commit-Position: refs/heads/master@{#393544}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 09869628d781a977987b65906856bd259e40dd9e
The move to libvpx_new happened before M47 (landed in 2524, M47 branch was 2526):
crbug.com/481034
https://codereview.chromium.org/1323333002
Clients which try to transition directly between the tree after this change and before the previous move will end up in a very broken state.
Now it is 6 months later and M48 is stable so is unlikely that a client would check out the old code at all, much less try to transition directly between the two versions.
Leave a compatibility layer for targets which need to be updated out of band (webrtc, libyuv)
Review URL: https://codereview.chromium.org/1734613003
Cr-Original-Commit-Position: refs/heads/master@{#378739}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8cdf034791388299f18fba186f2941313320b706
Leaves the previous version in place but updates BUILD.gn and libvpx.gn to point to the new version. This allows decoupling the WebRTC update which is also in DEPS.
libvpx DEPS changes ac1772e:0d6551
https://codereview.chromium.org/1339033002https://chromium-review.googlesource.com/299759https://codereview.chromium.org/1350853003https://codereview.chromium.org/1353433003
Copy directory to libvpx_new to avoid breaking bisecting. This allows the user to move between and older and newer revision. A followup to rename libvpx_new to libvpx will come in some ~months because there are additional complications if one tries to sync directly from pre-move to post-rename or the other way around.
Remove WATCHLISTS and codereview.settings from _new and use the parent versions.
Add DEPS file to enumerate the #include paths.
Check out third_party/libvpx_new/source/libvpx directly from upstream project
Update all the easy clients of libvpx to depend on the new tree directly.
ac1772e3db
BUG=481034
R=tomfinegan@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/1323333002
Cr-Original-Commit-Position: refs/heads/master@{#349789}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5238138a422157576799266228c0c9ee174936ae
Tom Anderson
Raul Tambre
Lei Zhang
Evangelos Foutras
Mike Gilbert
Scott Violet
Ian Clelland
Lukasz Anforowicz
Paweł Hajdan, Jr
brettw
brucedawson
machenbach
johannkoenig
tfarina