Граф коммитов

10 Коммитов

Автор SHA1 Сообщение Дата
watk ae4fce5cd5 gdb-add-index now removes its temp directory
This fixes a bug in gdb-add-index that meant it never cleaned up its
temp files.

Review-Url: https://codereview.chromium.org/2023363002
Cr-Original-Commit-Position: refs/heads/master@{#397226}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb802c68d1bb7ee6df93a187285f741eec0f5a61
2016-06-01 20:21:54 +00:00
watk b0590cdef3 gdb-add-index: accept a list of files to index
Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's no single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

This CL also cleans up the style a bit for consistency.

BUG=

Review URL: https://codereview.chromium.org/1471523002

Cr-Original-Commit-Position: refs/heads/master@{#361227}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f94079e64790b85d3cdf7264b47c84ad7c9301f2
2015-11-24 00:31:22 +00:00
cleichner 218ce9aadf Made gdb-add-index respect TOOLCHAIN_PREFIX settings.
This allows the script to work for remote debugging cross-compiled
binaries by adding a prefix such as arm-linux-gnueabi- to all of the
binutils commands.

BUG=

Review URL: https://codereview.chromium.org/828373003

Cr-Original-Commit-Position: refs/heads/master@{#310640}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cdc89dff37a8adb59c92f463514fbab48d7abaff
2015-01-09 00:38:14 +00:00
ajwong@chromium.org 06a7c35d40 Add flag to force clobbering of index in gdb-add-index
BUG=374952

Review URL: https://codereview.chromium.org/330333005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@277212 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-14 08:50:22 +00:00
ajwong@chromium.org fbb88fd872 Make gdb-add-index index concurrently.
Most linux machines can likely handle a few concurrent indexing jobs
for the shared objects in one binary. This modification uses SIGUSR1 and
subshells to simulate a semaphore with task queue that significantly
increases the speed of execution over a newly built set of binaries.

By default, this script executes 4 parallel indexing tasks, though the
concurrency be controlled by setting the INDEX_TASKS shell variable.

Here are bencharks from my z620, using a component build browser_test
binary as the target:

6 threads browser_threads:
   real    0m36.307s
   user    0m51.680s
   sys     0m13.150s

4 threads browser_threads:
   real   0m39.243s
   user   0m53.010s
   sys    0m12.230s

1 thread browser_threads:
   real    1m12.099s
   user    0m53.300s
   sys     0m13.580s

This was on an SSD. Benefit hit diminishing return after 4 threads and
may actually taper off sooner.

BUG=none
R=piman@chromium.org

Review URL: https://codereview.chromium.org/23130007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@217815 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-08-15 18:03:03 +00:00
ajwong@chromium.org 0a0e8f599a Make gdb-add-index better respect relative paths and bind mounts.
Without this, gdb-add-index incorrectly skips DSO dependencies if running from a symlink.  $(pwd) returns the path to your directory via the symlink, but ldd returns the "realpath".  Using dirname allows you to match a substring of the path returned by ldd.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10913264

git-svn-id: http://src.chromium.org/svn/trunk/src/build@156968 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-09-15 02:28:20 +00:00
ajwong@chromium.org 39b3730bd4 Replace gdb-add-index with cleanroom rewrite from vrk@
This CL takes add-index.sh and overwrites gdb-add-index.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10827427

git-svn-id: http://src.chromium.org/svn/trunk/src/build@152443 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-08-21 00:09:19 +00:00
ajwong@chromium.org ab0c87e6f5 Add in support for components build.
BUG=none
TEST=tested locally on a chrome binary from a components build.

Review URL: https://chromiumcodereview.appspot.com/10700022

git-svn-id: http://src.chromium.org/svn/trunk/src/build@144835 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-06-28 23:37:31 +00:00
ajwong@chromium.org b0d864e362 Fix checkperms by removing extra space after shebang. Silly checkperms.py
BUG=none
TEST=ran ./tools/checkperms/checkperms.py --root build and it was clean.
TBR=mattm_g

Review URL: https://chromiumcodereview.appspot.com/10703021

git-svn-id: http://src.chromium.org/svn/trunk/src/build@144650 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-06-28 02:23:34 +00:00
ajwong@chromium.org 282c944fbd Adding gdb-add-index script from Redhat's gdb rpm.
For linux users who are going to debug chromium, running gdb-add-index
on the binary first will significantly speed up debugger start time.

The originating RPM is gdb-7.4.50.20120603-1.1.x86_64.rpm. The script is
just a bash script version of the instructions in the gdb man page.

BUG=none
TEST=ran it on a statically linked browser_tests locally. verfied .gdb_index section exists
and that gdb does startup faster (from ~20 secs to ~3 seconds)

Review URL: https://chromiumcodereview.appspot.com/10695024

git-svn-id: http://src.chromium.org/svn/trunk/src/build@144644 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-06-28 01:53:45 +00:00