Creating symlinks in src/ can mess with the build because some
scripts incorrectly re-invoke `gn gen` as part of the build.
Also, it does not make sense to create symlinks in src/ based
on a gn variable that can have different value for different
build directories.
Bug: 1060666, 1061419
Change-Id: I2367aa6436489b77540454da8f7ae17d41c6f9fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102649
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#750187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 909de78b93850db4371465c23d4593fdda93c8c4
A gclient hook would populate the contents of this dir. You could then
re-use these files in any arbitrary normal GN build flow. (No Simple
Chrome shell needed.)
Bug: 937821
Change-Id: I30a78d491088351756017a77fe160de39296b7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052205
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#746499}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49ab01385414279c18480fcb2591fdbe821c0c4d
This adds an entry to .gitignore to ignore .pyc files. This allows
other projects to use this without having the git directory be dirty.
Change-Id: Ifdc6d204efe2c6801f120df14349b88436b16720
Reviewed-on: https://chromium-review.googlesource.com/1191082
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jacob Trimble <modmaker@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#586307}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 51ebed16cb33d08dc4bed3dc0cc1d9fccdcde9b3
This is to generate reproducible binary between commits for Linux by giving use_dummy_lastchange=true in args.gn.
This CL makes binaries independent from commit hash at least for below (time consuming) targets on Linux.
* content_unittests
* interactive_ui_tests
* content_shell (for webkit_layout_tests)
* content_browsertests
* browser_tests
If we can generate deterministic binary, test execution on build bot can be cached. And it will improve CQ cycle time.
But we don't know how often we make changes not introducing functional change in binaries.
So this CL is mainly for getting some stats from test on Linux buildbot and evaluate whether it is better to go forward or not for other platforms.
See more backgrounds here.
https://docs.google.com/document/d/16dalG0ssugZlwc7BBzUoBQUmuqM0S_gwtG2uxL0htdw/edit#
TBR: pfeldman@chromium.org
Bug: 869348
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b351b2135fd5e749ed575484b2182e847a420c9
Reviewed-on: https://chromium-review.googlesource.com/1151169
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579668}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 36541eb81aae62b267dcc88d1fdaef912450299a
https://chromium-review.googlesource.com/c/chromium/tools/build/+/988694/
will turn it on for the simple chrome bots (Right now they invoke all of
gclient inside the chrome-sdk.)
Bug: 732531, 828392
Change-Id: I1f892970cd19fd8f64dcfb6615d3033301ac2fcb
Reviewed-on: https://chromium-review.googlesource.com/989235
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#547812}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9d8ac1b4c1fe49b249575ed7d935fc533b720eb1
Useful for people where the linux installation doesn't provide it by
default, and for bots.
I copied the system ciopfs binary on my ubuntu trusty box to build/ciopfs
and ran:
upload_to_google_storage.py -b chromium-browser-clang/ciopfs build/ciopfs
Bug: 808098
Change-Id: Ia6dd7548a5a5761898506f6bbe50625c33151988
Reviewed-on: https://chromium-review.googlesource.com/897890
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533804}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 762993055a75a8f62232e5454f16b566a2de7e3c
The eu-strip that ships with Ubuntu Trusty segfaults when stripping a
chrome binary that statically links libc++. The issue was fixed
upstream at some point because the crash does not occur on Ubuntu
Xenial.
This CL bundles a patched eu-strip for x86_64 (and removes the x86 one
that used to be in Google Cloud Storage).
The issue was due to a double-free in libelf.so. The patched version
simply removes the offending call to free and statically links libelf
into eu-strip. This probably results in a memory leak, but this is ok
for now since the utility is a very short-lived process.
BUG=593874
R=dpranke@chromium.org,thestig@chromium.org
TBR=thakis@chromium.org
Change-Id: I2085c4f6278cffbaeae972545280ebb437a8bdc0
Reviewed-on: https://chromium-review.googlesource.com/544798
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#481710}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4312d5e0b01af9a3ad5f92a1763142155f01a7c6
This will be used primarily on perf bots to download APKs used for
tracking per-milestone patch size growth.
BUG=695188
Review-Url: https://codereview.chromium.org/2750603003
Cr-Original-Commit-Position: refs/heads/master@{#456502}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2850476323ae769b612011f3d99a2d17759a2952
Having this, a lot of wasted bandwidth is avoided for projects
that use these directories as DEPS entries, since the top-level
Chromium .gitignore doesn't exist in those cases.
The src/ repo already contained 51 other .gitignore files anyway,
so it's hard to claim the top-level file has to be the only one.
BUG=690010
Review-Url: https://codereview.chromium.org/2710593005
Cr-Original-Commit-Position: refs/heads/master@{#452167}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 68d02518d39937443244001624fa500e00aad408
Sylvain Defresne
Ben Pastene
Yoshisato Yanagisawa
Jacob Trimble
Takuto Ikuta
Nico Weber
Dirk Pranke
Paweł Hajdan, Jr
Tom Anderson
estevenson
kjellander