Catch the error raised by 'check_call' rather than the error emitted by
the called process.
BUG=chromium:460693,chromium:459681
TEST=local
- Ran without fix, setting CHROME_HEADLESS=1. Script failed with the exception
in the bug.
- Ran with fix, 'gsutil' failed with AccessDeniedException output
and the calling script successfully emitted a warning message.
R=hinoka@chromium.org, navabi@chromium.org
Review URL: https://codereview.chromium.org/949813002
Cr-Original-Commit-Position: refs/heads/master@{#317608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 63ab4fead51b043cb1f21ae2b31f9e593cbdc3ca
Non-android bots will not have credentials to download SDK packages from Google
Storage buckets. Thus, if a bot does not have credentials, the hook should print
a warning and continue.
BUG=459681
Review URL: https://codereview.chromium.org/940633003
Cr-Original-Commit-Position: refs/heads/master@{#316973}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 30bc93f3361397f8cde5d319923f1609508bb909
This will also change where depot_tools is found. Instead of assuming it is part of the build_bot checkout it will use find_depot_tools.
BUG=454220
Review URL: https://codereview.chromium.org/934753007
Cr-Original-Commit-Position: refs/heads/master@{#316737}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b0c3ed39916e25bed2900b653974672a39fcb254
On the bots the rsync technique to download packages (see bug for more details)
takes too long. It takes almost 30 seconds even when the package is already on
the bot. Instead always download the zip and unzip it.
BUG=350151
Review URL: https://codereview.chromium.org/799673003
Cr-Original-Commit-Position: refs/heads/master@{#310135}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 24606e2106ec9029e042353feaa84555708aefd0
dnj
navabi