The sysroot are generally useful (for example when
cross compiling) and not limited to use in the installer
or official releases.
Another reason to move this is that it would allow other
projects to more easily share chromium's build setup
without depending on chrome/.
Also, rename the install script to simply install-sysroot.
This way the script can keep the same name and support
multiple different debian releases without needing
to duplicate the script (e.g. when we switch to jessie).
BUG=504446
TEST=cross build chromium for arm and ia32
Review URL: https://codereview.chromium.org/1141003002
Cr-Original-Commit-Position: refs/heads/master@{#336843}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8208b4d81396c11e1f8ca8f6ffe52b9fcea87d05
Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
Reland of https://codereview.chromium.org/1179393004/TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1182663007
Cr-Original-Commit-Position: refs/heads/master@{#334690}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 07d847b1c5451748f16f4e7973ce8ef9078d47a2
Reason for revert:
Broke the Linux GN Clobber bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1271/steps/compile/logs/stdio
ninja: error: '../../build/linux/dump_app_syms', needed by 'obj/chrome/linux_symbols.inputdeps.stamp', missing and no known rule to make it
Original issue's description:
> Fix some build symbol configuration.
>
> Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
>
> Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
>
> Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
>
> BUG=
>
> Committed: https://crrev.com/950889c01dd934acf28bce29ea6db75610a8c441
> Cr-Commit-Position: refs/heads/master@{#334510}
TBR=thakis@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1182783006
Cr-Original-Commit-Position: refs/heads/master@{#334522}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 520e8fd6084a0b3f1ec1011273730c4c6e392d09
Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant.
Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission.
Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team.
BUG=
Review URL: https://codereview.chromium.org/1179393004
Cr-Original-Commit-Position: refs/heads/master@{#334510}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 950889c01dd934acf28bce29ea6db75610a8c441
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
This is the third attempt at a landing. First attempt was
reverted: https://codereview.chromium.org/1151753002
This is a re-land of the second attempt which was
reverted speculatively (wrongly as it turned out):
https://codereview.chromium.org/1158283003
TBR=cpu
Review URL: https://codereview.chromium.org/1146303007
Cr-Original-Commit-Position: refs/heads/master@{#332982}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dea1c634b5328b1e171ba22698fb7027f338453f
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
Second attempt at landing this. First attempt was here:
https://codereview.chromium.org/1151753002
TBR=cpu
Review URL: https://codereview.chromium.org/1158283003
Cr-Original-Commit-Position: refs/heads/master@{#332311}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fa36d7041817ddd299c89ca5ecef432c9210fda9
Reason for revert:
Breaks GYP for Chrome OS builds. Repro steps:
cros chrome-sdk --board=amd64-generic
gclient runhooks
Updating projects from gyp files...
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs-only-l nss | sed -e "s/-lssl3//"' returned exit status 0.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --libs libcras' returned exit status 127.
/bin/sh: /build/amd64-generic/build/bin/pkg-config: No such file or directory
gyp: Call to '/build/amd64-generic/build/bin/pkg-config --cflags x11' returned exit status 127.
Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /ssd/src/chromium
TEST=cros chrome-sdk --board=amd64-generic && gclient runhooks
Original issue's description:
> Fix use of 'sysroot' variable in harfbuzz.gyp
>
> The sysroot variable is set conditionally in common.gypi
> but not at the nesting level required for other conditional
> to depend on it like the one in hardbuzz does. This means
> that sysroot always appeared to be empty to harfbuzz.gyp,
> and hence the special handling for ARM linux was required.
>
> This change moves the setting of 'sysroot' up one level of
> nesting and defines 'pkg-config' in common.gypi so it can
> be shared.
>
> Committed: https://crrev.com/6a80b32f309490f44347f2925589a6f0fc23c3ff
> Cr-Commit-Position: refs/heads/master@{#331506}
TBR=mazda@chromium.org,dpranke@chromium.org,cpu@chromium.org,sbc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1154213004
Cr-Original-Commit-Position: refs/heads/master@{#331642}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8505ef356013ec9239f295501a283ec9fd43b08a
The sysroot variable is set conditionally in common.gypi
but not at the nesting level required for other conditional
to depend on it like the one in hardbuzz does. This means
that sysroot always appeared to be empty to harfbuzz.gyp,
and hence the special handling for ARM linux was required.
This change moves the setting of 'sysroot' up one level of
nesting and defines 'pkg-config' in common.gypi so it can
be shared.
Review URL: https://codereview.chromium.org/1151753002
Cr-Original-Commit-Position: refs/heads/master@{#331506}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a80b32f309490f44347f2925589a6f0fc23c3ff
Reason for revert:
All linux perf bots red, failing on various blink_perf tests. Speculatively reverting this CL since several bisects pointed to it.
BUG=485590
Original issue's description:
> Linux Aura accessibility is enabled only on GNOME desktops
>
> Linux Aura accessibility is not enabled on desktops different than GNOME2.
> GNOME3 has deprecated gconf in favor of gsettings and dconf.
> AT-SPI (cross-platform framework that provides communication between AT
> and application) bus launcher has a property called org.a11y.Bus.IsEnabled
> that could be easily read by dbus call.
>
> In generall this patch adds an additional check to enable accessibility.
> When gconf is available use gnome's accessibility key otherwise
> org.a11y.Bus.IsEnabled property.
>
> BUG=472183,468989,468112
> TBR=stevenjb@chromium.org,jochen@chromium.org
>
> Committed: https://crrev.com/16e2d5a386e3ddd5be818a0d27610b1e9ee9c08e
> Cr-Commit-Position: refs/heads/master@{#328651}
TBR=dmazzoni@chromium.org,plundblad@chromium.org,l.gombos@samsung.com,jochen@chromium.org,stevenjb@chromium.org,dpranke@chromium.org,k.czech@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472183,468989,468112
Review URL: https://codereview.chromium.org/1124173005
Cr-Original-Commit-Position: refs/heads/master@{#329404}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c7c15e712cb77a0fe276166996b2bb787490c896
Linux Aura accessibility is not enabled on desktops different than GNOME2.
GNOME3 has deprecated gconf in favor of gsettings and dconf.
AT-SPI (cross-platform framework that provides communication between AT
and application) bus launcher has a property called org.a11y.Bus.IsEnabled
that could be easily read by dbus call.
In generall this patch adds an additional check to enable accessibility.
When gconf is available use gnome's accessibility key otherwise
org.a11y.Bus.IsEnabled property.
BUG=472183,468989,468112
TBR=stevenjb@chromium.org,jochen@chromium.org
Review URL: https://codereview.chromium.org/1028553003
Cr-Original-Commit-Position: refs/heads/master@{#328651}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 16e2d5a386e3ddd5be818a0d27610b1e9ee9c08e
Regarding the latest code on linux,
It was always setting by default language even if value of language was existed.
So we need to add routine for setting language via "spd_set_language".
BUG=289548
Review URL: https://codereview.chromium.org/1043933002
Cr-Original-Commit-Position: refs/heads/master@{#326764}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff4018b80395433657222d6eb0483b2349b1e007
This switches the USE_OPENSSL Linux and CrOS builds to continue
setting USE_NSS_CERTS. This lets it use BoringSSL for the crypto
and SSL stack and NSS for certificate verification. See design
doc for details on the flags:
https://docs.google.com/document/d/1x4DOCKwFkAxl9MGfd6snIzFigO4ku6Shuci0r5BzasQ/edit
On Linux, only client auth and OCSP stapling are missing. On ChromeOS,
there are some problematic USE_NSS_CERTS APIs in RSAPrivateKey to
resolve. We also still need to resolve crbug.com/347404 to maintain
parity.
As a follow-up, USE_OPENSSL_CERTS on non-Android can now be
removed (it was never supported anyway).
BUG=462040
Review URL: https://codereview.chromium.org/881213004
Cr-Original-Commit-Position: refs/heads/master@{#326222}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2bcbc6bceb6017c762ef01553a55a12fe390de16
I think it's safe to re-enable this warning now. The bug was
fixed upstream in 3.15.1 and there have been several NSS upgrades since then.
BUG=255201
Review URL: https://codereview.chromium.org/1028863002
Cr-Original-Commit-Position: refs/heads/master@{#321711}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 86ebf48be903b226d068b08efa16fe3725babb8c
This makes it possible to refer to the platform as DRI and DRM. We need
this intermediate state so we can update the CrOS builds to use DRM
rather than DRI.
BUG=none
TEST=Build ozone with DRI & DRM platform and without to verify build
(GYP and GN)
Review URL: https://codereview.chromium.org/957253005
Cr-Original-Commit-Position: refs/heads/master@{#320788}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d89b572673f0fd352ae9d14e69b79e0430c87fbd
Reason for revert:
Caused compile failure on Linux x64 bot (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/56532)
Output snippet:
FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a x64 -c unstable
dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory.
2a3
> libatk1.0-0 (>= 1.12.4)
ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32
chrome/installer/linux/debian/expected_deps_x64
Original issue's description:
> Resurrect Aura Linux accessibility.
>
> This is based in part on the ATK code we had as part of the Linux GTK port
> that went away, but now rewritten on top of AXPlatformNode. This patch
> successfully exposes an accessibility tree for Views and exposes top-level
> windows and the the role and name of each View. You can test it using
> accerciser. This is just to get the infrastructure in place - we need to
> implement more of the interface for it to be useful for accessibility tools.
>
> BUG=463671
>
> Committed: https://crrev.com/f65bad877350b5f7857d29e4b1b0d4d3f5c7cb6d
> Cr-Commit-Position: refs/heads/master@{#320383}
TBR=plundblad@chromium.org,dpranke@chromium.org,sky@chromium.org,gunsch@chromium.org,dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463671
Review URL: https://codereview.chromium.org/1002993002
Cr-Original-Commit-Position: refs/heads/master@{#320402}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 999e4c26444e68898d4fa642783263b6e408b7e3
This is based in part on the ATK code we had as part of the Linux GTK port
that went away, but now rewritten on top of AXPlatformNode. This patch
successfully exposes an accessibility tree for Views and exposes top-level
windows and the the role and name of each View. You can test it using
accerciser. This is just to get the infrastructure in place - we need to
implement more of the interface for it to be useful for accessibility tools.
BUG=463671
Review URL: https://codereview.chromium.org/975113002
Cr-Original-Commit-Position: refs/heads/master@{#320383}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f65bad877350b5f7857d29e4b1b0d4d3f5c7cb6d
Since the BoringSSL switch, this cannot possibly work. (There isn't an
openssl.gyp to swap out anyway.)
BUG=none
Review URL: https://codereview.chromium.org/859073002
Cr-Original-Commit-Position: refs/heads/master@{#312452}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2b60792760a1291c50594f213a0bc5e71d020e4d
This adds a use_xkbcommon variable that allows usage of libxkbcommon in
the build. Turn this on for linux ozone builds (except embedded builds).
BUG=430194
TEST=build
Review URL: https://codereview.chromium.org/751623003
Cr-Original-Commit-Position: refs/heads/master@{#308204}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 304529e882cd79826c1b8f222a0e855da2ba8a59
Add a new gyp variable: use_libpci (default value is 1).
Add a new define when use_libpci==1: USE_LIBPCI.
Don't call specific PCI code in gpu_info_collector_linux.cc if USE_LIBPCI isn't defined.
BUG=427401
R=piman@chromium.org
Review URL: https://codereview.chromium.org/692893004
Cr-Original-Commit-Position: refs/heads/master@{#302613}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 65ce5accb99908e292b9766c3da6cf54d6cc337f
install-debian.wheezy.sysroot.py is now use for ARM
also, removing duplication. sysroot location is also
now consistent.
Review URL: https://codereview.chromium.org/664383004
Cr-Original-Commit-Position: refs/heads/master@{#300746}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 41d0e08a38f6cc0cb32a2596953a7262c4a9ab02
We are checking gbm system library and cflags using pkg, therefore its
directory ought to be checked in the same way.
I spotted this problem in a Ubuntu 12.04 system where my custom pkg directory
is rather clean, without superfluous libraries. Probably no other developer
noticed this bug before because in the working pkg directory was already being
pulled in by libgestures or any other configuration that uses --libs-only-L
in system.gyp.
BUG=none
TEST=embedded=1 ozone_platform_gbm=1, linking content_shell
Review URL: https://codereview.chromium.org/553793002
Cr-Original-Commit-Position: refs/heads/master@{#293903}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5cdbf79d872e2bbdcf8994da76ef156bc9bacbbc
The GLIB_DISABLE_DEPRECATION_WARNINGS define disables the deprecation
warnings which is caused by the usage of the g_settings_list_schemas
method. Moving the define to the build scripts avoids any future build
errors (-Werror) and warning reports.
BUG=391250
TEST=ninja -C out/Release chrome
Review URL: https://codereview.chromium.org/367113004
Cr-Original-Commit-Position: refs/heads/master@{#292608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3a31d8e495b1d04a01f9e6c57fac608fee0285e3
So we don't break builds that don't use it by running pkg-config, and so
we don't accidently link against it when it is disabled.
The embedded=1 build has OS=="linux" use_udev==0 for small devices such
as the chromecast.
BUG=403162
Review URL: https://codereview.chromium.org/467983002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@290377 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Breaks builds where use_udev==0 since certain targets just assume udev and never check against use_udev.
Udev package should be wrapped in a use_udev confitional altogether and all the locations using Udev should check against use_udev.
Original issue's description:
> Run pkg-config for Udev only if use_udev==1
>
> Some embedded platforms do not have udev support. The change will skip
> running pkg-config if use_udev=0.
>
> BUG=none
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288770TBR=brettw@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/469763002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289280 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
When CL 430573002 landed, it forced the use of libpci on linux, but
many embedded systems lack this library (and probably lack a pci bus
altogether). Let's add a new config variable to make it possible to
disable the use of libpci.
BUG=398416
Review URL: https://codereview.chromium.org/462433002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289262 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of r284079 which was reverted in r284248 for components build
issues. That, in turn, was a reland of r283813 which was reverted in r283845
because it broke WebRTC tests on Android. That, in turn, was a reland of
r283542 which was reverted in r283591 because it broke the WebView build.
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=393317
R=agl@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/401153002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284729 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
(This is a reland of r283813 which was reverted in r283845 because it broke
WebRTC tests on Android. That, in turn, was a reland of of r283542 which was
reverted in r283591 because it broke the WebView build.)
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=none
Review URL: https://codereview.chromium.org/401613008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The //build directory in GN shouldn't refer to anything outside of itself so that non-Chrome projects can copy it and re-use the build configuration. speechd relies on third_party/speech-dispatcher. This patch just moves the loader to the speech-dispatcher target, which makes more sense anyway.
TBR=grunell@chromium.org
Review URL: https://codereview.chromium.org/377403002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@282138 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
sbc
brettw
thestig
spang
simonhatch
k.czech
djmix.kim
davidben
Paweł Hajdan, Jr
sigbjornf
mostynb
Dominic Mazzoni
dnicoara
alexmos
agoode
sfunkenhauser
bedupont
derat
tiago.vignatti
pgal.u-szeged
spang@chromium.org
sbc@chromium.org
dnicoara@chromium.org
mostynb@opera.com
phajdan.jr@chromium.org
davidben@chromium.org
agl@chromium.org
vitalybuka@chromium.org
brettw@chromium.org