Serial kernel logging is a deprecated feature of Zircon and should not
be used anymore. This uses a long-running SSH invocation of "dlog"
to pull the logs over the wire. It works equally well on QEMU and on
devices.
Created a stream multiplexer using "poll" to merge the kernel log and
application log into a single stream, which is passed to the symbolizing
filter.
Modified the symbolizer regex rules to allow kernel log timestamps.
Kernel log timestamps can be omitted from the output, but they seem
to be helpful at visually distinguishing kernel output from app output.
Bug: 838671
Change-Id: Icd45f902a49983b4e4ee262de474d69fbef56860
Reviewed-on: https://chromium-review.googlesource.com/1038423
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556170}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 299b84f8bdf74377b601a650b031e6dd0aa92bf1
Add logic to inspect the ELF headers of the packaged binary and its
libraries, to prune the libraries not marked as NEEDED by their
ELF headers.
Change-Id: Ie74864860f53a28b3dd8cd1f65b8dd24166c4395
Reviewed-on: https://chromium-review.googlesource.com/1041075
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556142}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 43204c00ab62ec37e15c415c677aa136ac84facf
When the SD card is full, we show an error notification as well as an
location dialog. This CL adds the string resources used in error
notification for M68, also adds the new download header string for
disk space info.
TBR=wnwen@chromium.org
Bug: 792775
Change-Id: Ide2ee1a0be020942ad940df05940c98d2231da6e
Reviewed-on: https://chromium-review.googlesource.com/1040245
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556119}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4308e90ba957117b822abed840ed69bb8c35b509
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org
Change-Id: I209953453e1e0e64eb253f1d673c9c6f96c0f493
Reviewed-on: https://chromium-review.googlesource.com/1044268
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/master@{#556064}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fdabad1c1c26520b51fd2eb89acbf87e0812e99a
System logs are included by default, unless they are deliberately
switched off by using the --no-system-logs flag.
-v now turns on DEBUG level logging and enables verbose mode for SSH.
Bug: 839662
Change-Id: I286dd33e3c76864154a98a9e4c07af49b036ec09
Reviewed-on: https://chromium-review.googlesource.com/1043453
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556021}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8a0d7e94f683597b368f34cd3b78d71663e16919
Replaces the WebBlendMode enum with a BlendMode enum in graphics_types.h
under platform/graphics/ which is used throughout blink. This type is
kept because the bindings generator requires an enum with matching
names as the CSS property names (namely kNormal instead of kSrcOver).
Then we convert from BlendMode to SkBlendMode in GraphicsLayer in order
to pass it to the WebLayer.
TBR=fserb
Bug: 838693
Change-Id: If306343f4cd51911b46d6e1ca96529789477d29d
Reviewed-on: https://chromium-review.googlesource.com/1038403
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#555943}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3
Generating a depfile from the manifest building step gives Ninja
the information it needs to trigger incremental rebuilds when static
assets or shared libraries have been modified.
Bug: 839496
Change-Id: I15aee25e8684f9d1fd6a8ad63318cc74639237f0
Reviewed-on: https://chromium-review.googlesource.com/1043047
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555887}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1322db809bcf2ab2305f64f4207fb3a239bd09ef
This reverts commit a6889a090458a2653794c6e63387d6db743dc7f9.
Reason for revert: Seeing multiple failures that might be caused by this change: 839362, 838785, 838858, 839327
Original change's description:
> [CFI] Enable cfi-icall for official Linux x64 builds
>
> The measured size impact is 1.5% and perf impact is ~1%.
>
> Bug: 701919
> Change-Id: I541242711bc85cc124ff3a2680171577e75475bd
> Reviewed-on: https://chromium-review.googlesource.com/1033918
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554828}
TBR=dpranke@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 701919
Change-Id: Ia73c2508483576a16fbc00749f081f013e6fd813
Reviewed-on: https://chromium-review.googlesource.com/1042765
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4a5c48bfcfc6362a8c35cf86d0de977aa6b28c4e
Also removes no longer needed guard flag for GrBackendObject.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel,linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_vr
Change-Id: I228f6bf5bcb554f6dcf31889c210ca2043f5a837
Reviewed-on: https://chromium-review.googlesource.com/1040425
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555816}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e9de9ce989fefb8f048dc1370ad97497e828d36d
I think digit@chromium.org is more preferable these days, so change the
remaining cases of digit@google.com to the preferable way for extra
consistency.
TBR=estevenson@chromium.org
NOTRY=true
Bug: None
Change-Id: Ie545282b334f056c7e72836caabec8539441ec3b
Reviewed-on: https://chromium-review.googlesource.com/1030376
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555744}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8bf4d1ff63ce4b2ebe1315ec093ee214a6ade9e0
This is a reland of 7891d057259d6df8483de1f03a39a6c202cca241
The underlying issue in crbug.com/838703 was fixed and
"lint_test_expectations.py" Works On My Box(TM).
TBR=scottmg@chromium.org
Original change's description:
> Fuchsia: Explicitly check that all file dependencies exist.
>
> Wrap file path references with "EnsureFileExists()" which acts as a
> simple identity function, except for invalid paths for which it
> raises IOErrors.
>
> Bug: 837200
> Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04
> Reviewed-on: https://chromium-review.googlesource.com/1037778
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555137}
Bug: 837200
Change-Id: I21713adc9e8d9fcaab06957a25255de3ee6e596e
Reviewed-on: https://chromium-review.googlesource.com/1038963
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555534}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fe0226186fa4a13732cdbf2aa175cc318b882748
In diagnose_bloat.py and generate_gradle.py the defaults for max
jobs (-j) are too high for machines without a large amount of RAM.
This should help non-Googlers.
Bug: 799954
Change-Id: I0f1480cb3bf93c17e9a182da821876b0d6f5f12c
Reviewed-on: https://chromium-review.googlesource.com/1038440
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555507}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff31875bec10a7fe0513e094483f79157b034347
It seems like the issue with the v8::Locker has been fixed at some
point. I cannot reproduce the issue anymore.
Bug: chromium:189177
Change-Id: Ie2929429735dc0b08dc7241986e7a95cf9d6c845
Reviewed-on: https://chromium-review.googlesource.com/1034685
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555365}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 21c872843e486603e4fe0898fb2ec8db0772e1a3
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org
Change-Id: I4d9f55a3463f97aea1a44d4ca32b5531bd99a956
Reviewed-on: https://chromium-review.googlesource.com/1039148
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/master@{#555301}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e896f838872ca2e440cd43897589d9ae201414d7
Shared libraries are now spread over two directories in the SDK,
causing some libraries to be omitted from packages, rendering the
libraries non-executable.
This CL registers $sysroot/dist as a library data dependency.
Bug: 707030
Change-Id: Ie05e1b5dacf8924475576c3c53bf0d8d460db1f3
Reviewed-on: https://chromium-review.googlesource.com/1039026
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555282}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 096b5311d430cb4af2d065bda656331934d03e36
This will add a positional arg to run_vm_test.py that can take one of two
values:
- "host-cmd": Runs a command on the host. Just launches the vm then
immediately calls the passed in cmd on the host. It's assumed the cmd will
handle data deps, ssh commands, etc.
- "vm-test": Runs a test in the vm. Takes care of spawning the vm, pushing
the test and its deps to the vm, executing the test, and tears down the vm.
(This is the current default behavior.)
Bug: 832374
Change-Id: Ib8bd1b2e7dd393f8a4578979fa164381a8342ef2
Reviewed-on: https://chromium-review.googlesource.com/1038747
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555279}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e5e7dc3762a1b18646810303e106da173ac603b5
This was changed by r554983, which really should have only changed the
android OS check, as Linux builds also need to support NaCl toolchains
where current_os != "linux".
Bug: 822034
Change-Id: I5ca924516158bdd6228b947f32db6b614d1caacd
Reviewed-on: https://chromium-review.googlesource.com/1038430
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555228}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c77b371695be9335ffe86608871d9dc2fd537d8a
It was moved to third_party/blink/tools, and renamed to "blinkpy".
TBR=timvolodine@chromium.org
Bug: 829697
Change-Id: Ie220adc5ce14025112e360657c3954027ae46ebe
Reviewed-on: https://chromium-review.googlesource.com/1032350
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0101944bcb57c6a25847a6930585657e93804f97
Define enable_arcore and add some build rules to use it.
Bug: 833511
Change-Id: I716123c2a282d7d123883df81ebbc00a0a883be8
Reviewed-on: https://chromium-review.googlesource.com/1033580
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555174}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4995409be3818899675acdfdc6d2bf8c18cca910
This is a reland of 10f4dd8996fe4a028ee2aa61cdf84ad4080ef31c
I disabled the gradle build when !use_platform_icu_alternatives so Android bots
continue to build successfully. I also moved cronet_maven/ output directory to
cronet/maven/ so it can be uploaded by the bots.
Original change's description:
> [Cronet] Build maven modules and test by building sample app with gradle
>
> This change builds maven modules for Cronet.
> Each maven module includes:
> 1. POM file defining module and listing dependent modules
> 2. Jars
> 3. Proguard files (optional)
> 4. Native libraries (optional)
> 5. Resources (optional)
> 6. Javadocs (optional)
> We build four maven modules:
> 1. cronet-api: the Cronet API
> 2. cronet-embedded: the Cronet native implementation
> 3. cronet-fallback: the Cronet fallback implementation
> 4. cronet-common: Cronet implementation in common with #3 and #4
>
> To test the maven modules, this change builds the Cronet sample app using gradle.
> You can install and run the resulting app by:
> ninja -C out/Debug cronet_maven_test_build
> adb install -r out/Debug/cronet_maven/test/build/outputs/apk/debug/test-debug.apk
> adb install -r out/Debug/cronet_maven/test/build/outputs/apk/androidTest/debug/test-debug-androidTest.apk
> adb shell am instrument -w org.chromium.cronet_sample_apk.test/android.support.test.runner.AndroidJUnitRunner
>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I5ed27e86f3e01dc3a6441ab449bbe942553343af
> Reviewed-on: https://chromium-review.googlesource.com/998019
> Commit-Queue: Paul Jensen <pauljensen@chromium.org>
> Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554608}
Change-Id: Ieba6842b48d0b8e97ca1dc6686080cb31a87ed95
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
TBR=estevenson@chromium.org
Eric already approved the build/ change in https://chromium-review.googlesource.com/998019
Change-Id: Ieba6842b48d0b8e97ca1dc6686080cb31a87ed95
Reviewed-on: https://chromium-review.googlesource.com/1037723
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555157}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5ff415959d5ef4d105cda4cd4fe36f06107f54b9
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org
Change-Id: Iaad06800c9481fb681d957ef11aa927829d71d3f
Reviewed-on: https://chromium-review.googlesource.com/1037190
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555139}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 412a73d305768b542032518d63938b9acb40e93d
Wrap file path references with "EnsureFileExists()" which acts as a
simple identity function, except for invalid paths for which it
raises IOErrors.
Bug: 837200
Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04
Reviewed-on: https://chromium-review.googlesource.com/1037778
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555137}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7891d057259d6df8483de1f03a39a6c202cca241
The revised comments more accurately reflect the current runner
behavior.
Bug: 808057
Change-Id: I4b193241a26034d608f3e1281eea7f4ce21dd510
Reviewed-on: https://chromium-review.googlesource.com/1037780
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555130}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c2b7c8c0e1a859c32591954aaebd869cbeb47e2b
This is an unmodified reland of r554617 after fixing cases where
target_os=["chromeos"] was not set in some Chrome OS builders'
gclient configs.
Causes Chrome builds for Chrome OS to emit additional 32-bit and
64-bit copies of the mojo_core shared library built against the
Android toolchain, for use from within the ARC++ container.
In order to support building these library targets, this also
modifies DEPS to include a minimal set of required Android support
tools and libraries in chromeos checkouts.
Bug: 822034
Change-Id: I0e6ae87a1b9da80b82c40fd637a5be07dd7b8272
Reviewed-on: https://chromium-review.googlesource.com/1035619
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554983}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 027d7fa1c191f60f754985b9c235597f8c9a2081
There's no longer a dependency on any system fonts when running Linux tests, so
font packages may be removed. The CrOs fonts are kept because, presumably,
folks might still want them when testing Linux CrOs builds, though the CrOs
tests also no longer depend on any system fonts.
BUG=787020
R=dpranke
Change-Id: I6074842eb67eba6194fa90e549e0485b529aa814
Reviewed-on: https://chromium-review.googlesource.com/1036585
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554930}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a4c92980d887f00be05ed676a246e81030b0356
This will let the chrome-sdk explicitly set them as args (ie CL:1035427)
Once that lands, then we can remove the default env-var logic.
Bug: 732531
Change-Id: Id8283e6018f8f7e652a29cb367b0a3c10adc6fa8
Reviewed-on: https://chromium-review.googlesource.com/1035602
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554917}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c35c578d6b5fc3c7f6e4d36e7014a4306e19960
The 'API' to the scripts remains the same, only the delivery mechanism changes.
This is a reland of https://crrev.com/c/887819.
BUG=797051
R=erikchen@chromium.org, justincohen@chromium.org
Change-Id: I6628170430265e54e6ed0d42509114825b85a6b8
Reviewed-on: https://chromium-review.googlesource.com/1030816
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554882}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5654182dd049bb8fbddf48cf23cff461472aad19
After Clang r329300 we need to request this explicitly. Make sure to do
so also on Windows.
Bug: 835506, 829795
Change-Id: I4b47e897ac202eb796d8c5b31808dfae2aeb5b22
Reviewed-on: https://chromium-review.googlesource.com/1035265
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554881}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3e568aae1d572c4b373f40e0826de7ea0a39d3c0
* Switch Android Studio's generate_gradle.py script to no longer build
all the generated files by default. This reduces runtime for a clean
build from 10 minutes to 20 seconds. Add a `--full` flag to explicitly
build these generated files, which should not be necessary on a
regular basis.
* Most of the benefit from generated files being present is fewer red
underlines in Android Studio. Many red underlines are from lacking a
R.java file, which takes a long time to generate.
* Fix bug so generate_gradle.py works even right after `gn clean`.
* Allow users to specify `-j` so generate_gradle.py works without goma.
* Speed up generating the `all` module (which is the default) by not
creating each sub-project's build.gradle file when generating the
information that it needs.
Bug: 799954,620034
Change-Id: Ie3c6ea0cdba198aede001332d64bec2eccffbe13
Reviewed-on: https://chromium-review.googlesource.com/1031052
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554838}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ccbb2419379c8eb34bfc2bf262c5d29b995116c0
Trivial fix for next LTS Ubuntu (similar to the
https://chromium-review.googlesource.com/c/chromium/src/+/736729)
+ adding LTS info to older versions mentioned in changed sh file
+ removing 17.04 info
Change-Id: Ib3889ac68bc41ff90cc6e36d9c60f56e2af76527
Reviewed-on: https://chromium-review.googlesource.com/1034055
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554836}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d7577c3d87fc74d4eb76b88f2fe2bd75163f3d4f
This change uses a special sandbox feature to gain access to the
system's root certificate store.
The previous code referenced the cert store under "/system", but that
directory is not attached to the namespaces of non-"shell" processes.
Bug: 837536
Change-Id: I4a406525558e10dd0cac8e9b28345560899e07dc
Reviewed-on: https://chromium-review.googlesource.com/1032050
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554820}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d18578f3e006e7a6384211e74aaebc7bb59f8b0e
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org
Change-Id: Idfa47ca98804e2f2f9ac6c7a3f4e6a76bffd328d
Reviewed-on: https://chromium-review.googlesource.com/1034782
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/master@{#554742}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9df38cd4b3ad2f1dde08484b114b52e8c1ab3950
The original patchset has a minor flaw in building for UWP unrelated to the changes made in the original CL itself. $target_cpu is used in "host" toolset instead of $host_cpu and when building an arm target it causes issues as it can't build host tools.
Fixes an error introduced in crrev.com/c/923161
R=brucedawson@chromium.org, dpranke@chromium.org, phoglund@chromium.org
Bug: 812814
Change-Id: Ia6e7f1dc2b5494e212d67b99a119e023a1308c25
Reviewed-on: https://chromium-review.googlesource.com/1022493
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554707}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 86ac3fe7e3327a67ba131764738ed5cdb3685fff
This reverts commit 58eabf0b4f69f136629286538c31c10e9375c51c.
Reason for revert: Broke ChromeOS ASan builder
Original change's description:
> Build 32- and 64-bit Android mojo_core for Chrome OS distribution
>
> Causes Chrome builds for Chrome OS to emit additional 32-bit and
> 64-bit copies of the mojo_core shared library built against the
> Android toolchain, for use from within the ARC++ container.
>
> In order to support building these library targets, this also
> modifies DEPS to include a minimal set of required Android support
> tools and libraries in chromeos checkouts.
>
> Bug: 822034
> Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0
> Reviewed-on: https://chromium-review.googlesource.com/1026203
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554617}
TBR=rockot@chromium.org,dpranke@chromium.org
Change-Id: I2e2b0d3500aa948f15ec7cf0ff024f7a82fd719d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 822034
Reviewed-on: https://chromium-review.googlesource.com/1033369
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554632}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9591f2badbd80682049c16a00df7df1625fce19e
Causes Chrome builds for Chrome OS to emit additional 32-bit and
64-bit copies of the mojo_core shared library built against the
Android toolchain, for use from within the ARC++ container.
In order to support building these library targets, this also
modifies DEPS to include a minimal set of required Android support
tools and libraries in chromeos checkouts.
Bug: 822034
Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0
Reviewed-on: https://chromium-review.googlesource.com/1026203
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554617}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 58eabf0b4f69f136629286538c31c10e9375c51c
This change builds maven modules for Cronet.
Each maven module includes:
1. POM file defining module and listing dependent modules
2. Jars
3. Proguard files (optional)
4. Native libraries (optional)
5. Resources (optional)
6. Javadocs (optional)
We build four maven modules:
1. cronet-api: the Cronet API
2. cronet-embedded: the Cronet native implementation
3. cronet-fallback: the Cronet fallback implementation
4. cronet-common: Cronet implementation in common with #3 and #4
To test the maven modules, this change builds the Cronet sample app using gradle.
You can install and run the resulting app by:
ninja -C out/Debug cronet_maven_test_build
adb install -r out/Debug/cronet_maven/test/build/outputs/apk/debug/test-debug.apk
adb install -r out/Debug/cronet_maven/test/build/outputs/apk/androidTest/debug/test-debug-androidTest.apk
adb shell am instrument -w org.chromium.cronet_sample_apk.test/android.support.test.runner.AndroidJUnitRunner
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5ed27e86f3e01dc3a6441ab449bbe942553343af
Reviewed-on: https://chromium-review.googlesource.com/998019
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10f4dd8996fe4a028ee2aa61cdf84ad4080ef31c
This was previously split out to support defining different profiles
for Chrome and Chromium. Since we no longer need to do this, it's
simplest to have this all inline. (In particular, this refactor makes
using this profile on Linux like, 2 lines of diff.)
No functionality change is intended.
Bug: 805098
Test: `rgrep fprofile-sample-use out | wc -l` gives a high number
Change-Id: Ice635b71942f10ef1aed9e2fd9872ac06f598803
Reviewed-on: https://chromium-review.googlesource.com/1024637
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554571}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 31d221685cba6b84e9c7ddcdf81c8c3722653a56
This change adds a global toggle for the WebUSB "guard" permission to
the site settings preferences on Android. Toggling this setting to
"block" will disregard existing USB device permissions and prevent any
site from requesting access to a USB device by displaying the device
chooser dialog.
To simplify the addition of this global toggle UsbChooserPreferences
has been merged into SingleCategoryPreferences and the entire USB
device permission framework has been refactored to manage the same kind
of opaque "objects" as is done in the desktop UI and underlying
storage infrastructure.
Screenshots of this new UI are included in the design doc:
https://goo.gl/uMPMZZ
Bug: 771703
Change-Id: I6ab766ddd1e00e8663d3b6658d872ef8ad8e95ea
Reviewed-on: https://chromium-review.googlesource.com/1006157
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554468}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b17421e33624954f62e89ae337d239ddddde379d
Andrii Shyshkalov
Kevin Marshall
Xing Liu
fuchsia-sdk-chromium-autoroll
danakj
Vlad Tsyrklevich
Greg Daniel
Egor Pasko
Eric Stevenson
Ian Vollick
Andreas Haas
Ben Pastene
Ken Rockot
Kent Tamura
Dirk Pranke
Paul Jensen
Wez
Tom Anderson
Sergey Berezin
Hans Wennborg
Peter Wen
Marcin Wiacek
Juan Antonio Navarro Perez
Anita Woodruff
Robin Raymond
Abhishek Arya
George Burgess IV
Oksana Zhuravlova
Reilly Grant
Conley Owens