This matches the gn name and is less confusing with use_openssl and
use_openssl_certs both existing. The preprocessor flag will follow
in another CL. For now, the old name is still defined, but not used
within Chromium.
A follow-up CL will remove deprecated use_nss and USE_NSS #defines
together which will then cause downstream churn. Though from a grep
of known downstreams, the churn seems to be fairly minimal. The
removal is split from this CL so that, if we need to revert, the
CL to revert is small.
BUG=462040
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/1085923002
Cr-Original-Commit-Position: refs/heads/master@{#325541}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ee13e37acf707e703a380a9c1a03f0b494dd6a6
Now that android_webview_build is no longer supported, the extra level
of indirection of including cpufeatures.gypi instead of directly
depending on the cpufeatures target is not necessary. Remove the cases
in the Chromium tree. Other references appear in projects pulled in via
DEPS that will have to be fixed separately before cpufeatures.gypi can
be entirely deleted.
BUG=440793
Review URL: https://codereview.chromium.org/1045123005
Cr-Original-Commit-Position: refs/heads/master@{#324117}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9845b890dd38f0b88b0304f3bd6c437a7c6f8f8d
Grit's execution depends on the resource ID file, but this was not listed as a dependency in grit targets. This means that changing the resource ID file wouldn't re-run grit.
Review URL: https://codereview.chromium.org/1038213002
Cr-Original-Commit-Position: refs/heads/master@{#322531}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fd9bbb762401141baa603ef5bececbc9426da169
The MacViews browser were missing infobar and background tab assets.
mac_views_browser grit define is added so that we can include infobar assets.
Don't remap theme image ids so that Mac's background tab assets can be
found.
Map IDR_THEME_TAB_BACKGROUND_INCOGNITO to the same asset as
IDR_THEME_TAB_BACKGROUND.
BUG=425229
Review URL: https://codereview.chromium.org/983823004
Cr-Original-Commit-Position: refs/heads/master@{#321602}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c306fb9a8d5179f34589d6ab330a71ebd40eb073
This patch adds a whole bunch of small targets that
had either already been done but weren't mentioned
in the 'gn_all' group, or needed to be done.
In theory this should produce no change on any platform
other than Linux, except for one small windows target.
R=brettw@chromium.orgTBR=dtu@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/975123003
Cr-Original-Commit-Position: refs/heads/master@{#319580}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: db5527d777f1e0cdbaec2bca579bec33aaf7497e
In order to be able to make sure we are building the same list of targets
in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
targets.
Eventually, we should make sure that if one builds 'gn_all', then building
'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
is a start.
The 'gn_all' target replaces the //:root target in the GN builds.
TBR=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/953463003
Cr-Original-Commit-Position: refs/heads/master@{#317893}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e2ef382dd208417056acbd579620a428fa1b7af4
Reason for revert:
Suspecting this breaks Mac builds.
http://build.chromium.org/p/chromium/builders/Mac/builds/33993
Original issue's description:
> add gn_all, gyp_all targets to the build files, remove GN's //:root
>
> In order to be able to make sure we are building the same list of targets
> in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
> targets.
>
> Eventually, we should make sure that if one builds 'gn_all', then building
> 'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
> is a start.
>
> The 'gn_all' target replaces the //:root target in the GN builds.
>
> R=brettw@chromium.org
> BUG=461019
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
>
> Committed: https://crrev.com/ff30e3de333305ccdaa103aa7f9e46765da83e99
> Cr-Commit-Position: refs/heads/master@{#317760}
TBR=brettw@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461019
Review URL: https://codereview.chromium.org/944573003
Cr-Original-Commit-Position: refs/heads/master@{#317763}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6d374cf7ead69b3ff110f9d7dfba0dee921e6b7
In order to be able to make sure we are building the same list of targets
in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
targets.
Eventually, we should make sure that if one builds 'gn_all', then building
'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
is a start.
The 'gn_all' target replaces the //:root target in the GN builds.
R=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/936193004
Cr-Original-Commit-Position: refs/heads/master@{#317760}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff30e3de333305ccdaa103aa7f9e46765da83e99
The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu
as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate.
R=brettw@chromium.orgTBR=ddorwin@chromium.org
EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
BUG=344767
Review URL: https://codereview.chromium.org/913373002
Cr-Original-Commit-Position: refs/heads/master@{#317223}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4327621a322c964a8bc6d1ef5a4534f0f877d63e
ICU 54.1 comes with CLDR 26 locale data along with Lao and Khmer dictionaries
for line/word breaking, new interval/duration formatting support, display
context support for date-time and lang/region display name and many more.
To better support regional variants such as en-{CA,AU}, fr-CA, es-*, and de-CH,
the locale data for those variants are included.
The ICU data file (icudtl.dat) for non-Android platform is
256,960 bytes smaller than before.
On Android, it's 232,240 bytes larger because the currency display
name data was added for EcmaScript I18N API.
On Linux/Mac/Android/iOS, base::TestSuites initializer now sets the
ICU locale explicitly to en_US if the default locale is a POSIX locale
that is not supported because I got rid of word_POSIX to save about
100kB. Moreover, virtually none of our users uses a POSIX locale so that
testing on POSIX locale is not realistic.
en_GB time formatting changed in ICU 54.1/CLDR 26 and the expected results
are updated.
Noto to Sheriff: The above data size changes (reduction or increase) may
require the expected size adjustment.
See https://codereview.chromium.org/403723003 for a similar change.
BUG=428145
TEST=All tests on all platforms including but not limited to
1. Blink: layout tests and webkit_unittests
1. base_unittests: Break*, *onvers*, *Format*, *CU*, RTL*, *Search*
2. browser_tests: *ncoding*, *UILanguage* (CrOS)
3. sql_unittests
4. gfx_unittests: RenderText*
5. components_unittests: Query*, *ookmark*
6. net_unittests: Net**IDN*, URL*
7. url_unittests
8. ui_base_unittests
Review URL: https://codereview.chromium.org/878723002
Cr-Original-Commit-Position: refs/heads/master@{#317210}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8fe2fe9afd2d94f6cd814cd55900460ad11da26a
This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.
Minor updates to Win64 build, including some fixes for size_t to int conversions.
Review URL: https://codereview.chromium.org/929793006
Cr-Original-Commit-Position: refs/heads/master@{#317162}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1c719acf7db459016f425eb8018ec4208511578
Various bits of Chrome for Android that are being upstreamed
(in particular Cast support) require Google Play Services.
This adds Google Play Services to the Android chrome_java
target.
Note that this uses a variable so that one can use an
alternative version of Google Play Services. This is
required for Chrome for Android development.
TBR=sky@chromium.org
BUG=450675
Review URL: https://codereview.chromium.org/865733002
Cr-Original-Commit-Position: refs/heads/master@{#315538}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c8db3ccbde213d09fac41060c0bf81d4a0020cda
linux and android should share same yasm defines and include_dirs,
just as src/third_party/libjpeg_turbo/libjpeg.gyp does.
BUG=455151
Review URL: https://codereview.chromium.org/893413002
Cr-Original-Commit-Position: refs/heads/master@{#314719}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c3bb5e1ef6c5e741eb23eec23834527ddb140525
Using deps caused pulling a bit of mojo code to chrome.exe. That
caused weird unresolved externatls problems during Windows GN build.
Review URL: https://codereview.chromium.org/876783003
Cr-Original-Commit-Position: refs/heads/master@{#313126}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f7b4f01989be22df44d9b5475143ef98b653b1ac
This picks up:
-Fix Android ARM Neon build.
-Fix Android GN build.
This also fixes an issue with the GN ARM NEON build.
BUG=451035
Review URL: https://codereview.chromium.org/871433002
Cr-Original-Commit-Position: refs/heads/master@{#312629}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d2a76a150091e5c5f1d9e4a42a27d6f1f7538137
For the file I'm testing with (c/b/resources/about_stats.html),
a rebuild runs 101 edges and compiles a bunch of cc files and takes 40s.
This reduces build times from 40s to 9.6s and reduces the number
of edges to 37.
BUG=439182
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/740463005
Cr-Original-Commit-Position: refs/heads/master@{#306945}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9261dde33f1939f432cafe6f9654efedba4dc252
A starting point for doing all of src, and adding a PRESUBMIT.
Includes https://codereview.chromium.org/772663002/ and https://codereview.chromium.org/770053002/.
I haven't pushed new binaries yet.
Generated via:
> cd build
> git ls-files *.gn *.gni | sed -e "s/^/@..\\\\out\\\\Debug\\\\gn format --in-place /" >x.bat && x.bat
The only things that I don't love in the current output are:
1. Turning
args = [
"--depfile", rebase_path(depfile, root_build_dir),
"--android-sdk-tools", rebased_android_sdk_build_tools,
"--dex-path", rebased_output,
]
into:
args = [
"--depfile",
rebase_path(depfile, root_build_dir),
"--android-sdk-tools",
rebased_android_sdk_build_tools,
"--dex-path",
rebased_output,
]
The heuristic for this isn't trivial though, and it also affects e.g. '-Xclang' in cflags, as well
as assignments to temporaries that are later assigned to args.
2. Turning single line
if (defined(invoker.inputs)) { inputs = invoker.inputs }
into
if (defined(invoker.inputs)) {
inputs = invoker.inputs
}
This could be argued to be an improvement, but as it's very boilerplate-y perhaps an exception to
allow single line in this case is worthwhile. I think there was discussion of new syntax for this
case too, something like "inputs ?= invoker.inputs" maybe.
In both cases, I think it's worthwhile to get formatting turned on, and then go back and special
case these if we decide it's worthwhile.
R=brettw@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/766573003
Cr-Original-Commit-Position: refs/heads/master@{#306305}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b199254f481c5db36d56e83fce40594b06d2b81f
Eliminated platform specific (stdio & Windows) File I/O calls and replaced with
the use of base::File. This makes Chrome's Env (nearly) platform agnostic while
simplifying the implementation.
BUG=431914
Review URL: https://codereview.chromium.org/710373002
Cr-Original-Commit-Position: refs/heads/master@{#305020}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bf82318b8929b07d7bb0abce2729c5a83b9dbfcb
This actually hooks up (i.e. passes from invoker) several variables
controlling apk creation (version name, version code,
use_relocation_packer, use_chromium_linker, unzip_libraries_from_apk).
Adds support for overriding some configuration in the private repo.
Adds support for public_configs in grit_rule.gni.
Adds some junit targets (these are built as android libraries currently
instead of host libraries, but that just means we do a bit extra work
that we don't really need).
BUG=359249
Review URL: https://codereview.chromium.org/659703002
Cr-Original-Commit-Position: refs/heads/master@{#301039}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca675d3ec565477b2e3bae8b0709a412d029fa21
This adds a pretty straightforward gn template corresponding to
protoc_java.gypi.
protoc_java.py is updated to actually parse options instead of just
using positional arguments.
Adds cacheinvalidation targets.
TBR=brettw, zea
BUG=359249
Review URL: https://codereview.chromium.org/580343002
Cr-Original-Commit-Position: refs/heads/master@{#297739}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a3f2d3f6819d1a6709a5a4d8fc62321e478bcc9f
This fixes configuration of various targets (mostly adding some missing
files for is_android builds).
Adds a target setting up the content_shell_apk assets directory.
Uncomments the previously non-working dependencies from
libcontent_shell_content_view.
Adds forwarding of testonly in all of the android templates.
TBR=mark@
BUG=359249
Review URL: https://codereview.chromium.org/569923003
Cr-Original-Commit-Position: refs/heads/master@{#296319}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2fd48fd14b188a0b854f9c5910b9f40b5576291f
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Original-Commit-Position: refs/heads/master@{#296302}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e5389527466d390b5653724a069008b9f1edcd5c
Also remove a few redundant consts that result in warnings like:
../../content/common/cursors/webcursor_aurax11.cc:20:1: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
const ui::PlatformCursor WebCursor::GetPlatformCursor() {
^~~~~~
TBR=davemoore@chromium.org,sadrul@chromium.org
R=brettw@chromium.org, thakis@chromium.org,rch@chromium.org
BUG=393046, 335824
Review URL: https://codereview.chromium.org/538333002
Cr-Original-Commit-Position: refs/heads/master@{#293930}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c2d33ac8c061cf27a594473d6f9a450ee6c3c89
Currently this is either a list or a string. However, this is causing some problems because templates can't add to the invoker's visibility list without knowing if the original is a string or a list.
In an effort to make this consistent, I'm converting all visibiltiy to be lists, and will remove support for strings in a future build.
This exempts cld from header checking since it was confusing GN's header checker. It adds a ppapi header target as well that will be used by libyuv (that requires a roll).
TBR=scottmg
Review URL: https://codereview.chromium.org/544423002
Cr-Original-Commit-Position: refs/heads/master@{#293638}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9af4262ad8020658ee04c07d13a2617af64147b1
Mostly just a refactoring of build rules to support prebuilt jars.
Adds support for proguard preprocessing of both prebuilt and
non-prebuilt java libraries.
Adds definitions of all (but for android.jar) of the prebuilt jars that
we need from the sdk.
BUG=359249
Review URL: https://codereview.chromium.org/484813002
Cr-Original-Commit-Position: refs/heads/master@{#291464}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 684b22957e09c08e917a63390b04980a67da4fa1
Previously, if you specified an empty resource ID file in the grit template in the GN build, it would send "-f" with no argument to grit, and this would cause the command line parsing to get messed up and it wouldn't generate any files.
This patch just omits the "-f" argument in this case.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/495183002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@291173 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This directory contains a GN build file that defines a dummy "ui"
component target that does not really do anything that matters.
ui/ targets are almost finished at this time, so there is no point in
keeping this ui/ BUILD file in build/secondary.
BUG=None
TEST=None
R=brettw@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/451553002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@290188 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This matches the gyp build and is important for parts of the code that
guard their API with UNIT_TEST. For instance,
chrome/browser/ui/views/omnibox/omnibox_view_views.h has a GetRenderText
function guarded by #if UNIT_TEST that shadows a protected function
GetRenderText from its parent class views::Textfield, but with different
const-ness. If c/b/u/v/o/omnibox_view_views.cc is compiled with UNIT_TEST
set, it attempts to use the guarded member function instead of the base
class which fails to compile.
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/464503003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@288988 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.
This CL was originally landed as 288164 and reverted as 288239 because it allows
more aggressive LTO in MSVS. This resulted in the compiler noticing an
intentional arithmetic overflow and warning about it.
BUG=401761
Review URL: https://codereview.chromium.org/425333002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@288505 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Suspected to have broken the Chrome Win build:
c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : warning C4756: overflow in constant arithmetic
> Roll gtest and gmock DEPS.
>
> These DEPS have not been updated for ~2 years, so there is a good chance
> something will blow up. Due to interdependancy between the repos,
> rolling gtest required gmock also be rolled.
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/425333002TBR=ncbray@chromium.org
Review URL: https://codereview.chromium.org/454823002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@288239 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It doesn't run yet. This disables WebRTC since that's not done yet.
Libvpx isn't done either. This patch exports the disable flag for this from media to dependent targets like the GYP build does. It adds one extra check for this flag in Pepper. I assume everybody that compiles without libvpx also disables plugins so this has never come up before.
Disable some warnings in Mesa.
The resulting binary does not yet run.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/419913003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@285962 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Pull grit 171 to get the new deps fixes required to implement this.
This removes the call to grit for querying inputs completely, and enables depfile writing to enable automatic rebuilds when things are out-of-date.
Adds a new outputs variable that bypasses querying grit for outputs. This will assert that the given files exist in grit. This version allows outputs to be empty in which case it will revert to the old dynamic behavior. I'm going to land this with just the worst cases fixed to make landing easier. Then followup with converting the rest of the grit targets and removing the dynamic option.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/407653003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284705 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.
Renames the enable_printing flag to printing_mode since this is an integer
tri-state.
Minor improvements to chrome/renderer
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/400243003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284508 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The ICU update does the following among other things:
- Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
encoding spec.
- Add CP866
- Add far better/more extensive support for plural, format, etc
- Numerous locale data update
- Khmer/Lao line/word-breaking support
- More compact Chinese/Japanese dictionary (now a part of the upstream
instead of our local patch)
- Better plural support that we plan to use right away.
- Update icu/BUILD.gn : file list update, new defines, etc.
- Update tests
a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
remove JIS X 212 code points from the round-trip test
b. l10n_util_unittests: Display names for zh-*.
c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
d. Update Expected results in file_manager_browsertest/test_util.js
(see http://crbug.com/383930)
- Update SpellcheckerWordIterator
a. Add U+0027 back to MidNumLet
b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
word-breaking.
- l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
- Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
has 'at' before time, which is not handled by Date.parse()
- update license.py because we don't have a separate Chinese/Japanese
dictionary any more. It's now a part of ICU
Note to Sheriff :
1. 140 ~ 200 kB size increase is expected for all platforms.
This size increase was singed off by laforge@.
The expected size has to be updated with both reva/revb pointing to the
revision corresponding to this CL.
2. http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json
after this CL is landed.
BUG=132145,277023,136148,360433,364072
TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
browser_tests (encoding related, Iden*verifyGet*),
unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
layout tests (encoding, date/calendar, line breaking, and others),
build 'base_i18n_nacl', GN build bots.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org
Review URL: https://codereview.chromium.org/265613002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@284167 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds support for android resources to gn.
Two new templates are introduced:
java_string_grd: This is like gyp's build/java_strings_grd.gypi. It runs
grit and generates Android strings.xml files and then zips them
together.
android_resources: This is the target for android resources. It is
mostly a wrapper around process_resources.py. This is *not part* of
android_library (like it is in gyp). Making these two things separate is
more like facebook's BUCK and google's internal build rules (and gyp's
java.gypi and java_apk.gypi have gotten way too big and complicated).
Changes to the actual build scripts are very minor except for the added
support for andoid_resources to write_build_config.py. Building
resources requires getting all the transitive resource dependencies, and
so this reuses the simple sorted transitive dependency thing from
write_ordered_libraries.py.
TBR=rch@chromium.org
BUG=359249
Review URL: https://codereview.chromium.org/361633002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@283293 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This uses the proto file directory for the generated files rather than the directory of the BUILD file. This makes it more natural when you have a BUILD file in a different directory than the proto files.
Fixes a search-and-replace error that accidentally changed the fallback source_prereqs code to use "inputs".
Fix ozone build.
BUG=
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/386943006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@282998 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This fills out a number of ui targets and does some changes to the resources to match the GYP build. In particular, we had a number of different ui/resources targets that were depended on independently. The GYP build has only one, so I combined them into a meta "ui/resources" target.
Adds a grit repack template.
TBR=ajwong
Review URL: https://codereview.chromium.org/369603004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@281087 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
components/autofill
components/metrics
components/policy
components/variations
third_party/libphonenumber
third_party/mt19937ar
ui/gfx/ipc
These are all requried to compile chrome/browser in some form or another.
Fills out all grit_defines (also required for chrome/browser) and adds associated flags for them.
Add the ability for generated_extensions_api to not generate a bundle.
Remove mt19937ar from .gitignore (it's just checked into the tree)
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/365793002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@281057 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
These deps are some of those required to compile chrome/browser (so mostly those containing resources and protobufs that have generated headers). chrome/browser still has some dependencies left.
Add third_party libs libaddressinput and dom_distiller_js.
Add components dom_distiller and policy.
Separate the generate_library_loader into a separate .gni file.
Rename components_strings to just strings.
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/362583002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@280916 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds a lot of global enable flags for various features used by the browser.
It is not turned on because it does not compile yet. It needs some include directories and generated sources from dependencies that aren't done yet.
It is basically a line-by-line translation of the current chrome_browser.gypi. As such, it looks pretty ugly but I think keeping these in sync will be easiest.
I put in the obvious names of the GN deps. There are surely a bunch that exist in the GN build that aren't here yet but I'm going to save this for later passes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/356303002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@280693 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It's a goodness to sequester build configuration in the build/
directory. The gn secondary_source stuff was under tools/gn for
historical reasons, so move it to a more appropriate place.
BUG=None
TEST=do a gn build of base_unittests, run said unittests.
Review URL: https://codereview.chromium.org/340153004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@278355 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
davidben
tfarina
torne
knn
brettw
dfalcantara
andresantoso
jochen
dpranke
scottmg
hiroshige
jshin
aberent
halton.huo
vchigrin
dconnelly
fdegans
qsr
wangxianzhu
Nico Weber
vrk
cmumford
vitalybuka
John Abd-El-Malek
cjhopman
ajm
ckocagil
rsesek
isherman
cjhopman@chromium.org
brettw@chromium.org
tfarina@chromium.org
jamesr@chromium.org
ncbray@chromium.org
tommi@chromium.org
thakis@chromium.org
scottmg@chromium.org
jshin@chromium.org
cjhopman@chromium.org
ajwong@chromium.org
rvargas@chromium.org
bashi@chromium.org
jmadill@chromium.org
cmasone@chromium.org