This changes includes all the locale .pak files into the
WebView apk when building it from the chromium tree,
similarly to what we're doing when building it from the
Android tree, see android_webview/Android.mk.
BUG=405035
TESTED=Manual. Verified that the set of locales in the
downstream and upstream SystemWebViewGoogle.apk is the same.
Review URL: https://codereview.chromium.org/868673003
Cr-Original-Commit-Position: refs/heads/master@{#315001}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0826b636a11190f231e2ca167f7ec1304234be6a
Handle -G output_dir=foo as well as -Goutput_dir=foo.
I'm not sure how common this case is but we have
NaCl SDK bot that do this.
Getting this wrong results in windows toolchain being
installed in 'out/' (which doesn't necessarily exist)
rather than the output_dir tree and gyp uses.
Add unittests for the affected parts of gyp_chromium.
BUG=454594
Review URL: https://codereview.chromium.org/896663002
Cr-Original-Commit-Position: refs/heads/master@{#314381}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10ef1e2aa8ebb806ccfe7c52235f0fb76564ee2c
This allows us to override the settings in common.gypi, as
well as other include files. Only accepts one string, not an
array. Limitation of gyp_helper.
BUG=
Review URL: https://codereview.chromium.org/705663002
Cr-Original-Commit-Position: refs/heads/master@{#302841}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cec083d3e7038a5b26e5fdc2e514d404890805cb
Python always does reference counting and that handles most of the
objects used by GYP. The GC is used to detect and drop circular
references. If GC is turned off then the heap scanning can be skipped
to save some CPU cycles, and the memory leaked due to circular
references isn't noticeable.
This saves about 1 second out of 16 on Linux in a Z620 workstation.
BUG=None
Review URL: https://codereview.chromium.org/495993002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@291287 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert:
Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build):
Traceback (most recent call last):
File "src/build/landmines.py", line 132, in <module>
sys.exit(main())
File "src/build/landmines.py", line 119, in main
gyp_environment.SetEnvironment()
File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment
vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs
with open(json_data_file, 'r') as tempf:
IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json'
Original issue's description:
> Make landmines work on local builds too
>
> Moves (some of) gyp environment setup out of gyp_chromium into separate
> module, and shares that between gyp_chromium and landmines.py.
>
> landmines.py is added as the first entry in DEPS hooks so that it can
> clobber the entire build directory before running other hooks that
> extract/generate into the build dir.
>
> R=iannucci@chromium.org
> BUG=400011
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400011
Review URL: https://codereview.chromium.org/469623002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289158 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.
landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.
R=iannucci@chromium.org
BUG=400011
Review URL: https://codereview.chromium.org/457003004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@289099 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Since it's no longer necessary to source envsetup, having a bitness check in
here isn't very useful.
Let build/gyp_chromium always pass --check for android so that it behaves the
same as android_gyp and let android_gyp print a note that it'll disappear
eventually.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/222203005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@261195 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
In order to keep from needing to system-install VS runtime DLLs
for debug builds, we put them in the output directory. This
mostly works, except in the case of nacl64 it requires the x64
CRT, but builds into the x86 output directory. The OS loader will
ignore the x86 ones, and continue searching the PATH, so before
launching nacl64.exe, append to PATH to the location of the x64
CRT DLLs.
See linked bug for more details and investigation.
R=cpu@chromium.org, mseaborn@chromium.org
BUG=346034
Review URL: https://codereview.chromium.org/180223004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@253504 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This makes the -D defines for the default desktop Linux build of re2 in GN match that of GYP.
This moves the SSL configuration stuff into the root build directory. It's better to match the GYP build exactly for ease of landing even though this is a stupid dependency.
Fixes the help text that still references the implicit "gen" command (I removed this).
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/170533003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@252981 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This accomplishes three things:
- simple switch back to 2010 temporarily, if necessary
- making sure that all bots don't switch at exactly the same time (almost all have GYP_MSVS_VERSION=2010 in their settings)
- in particular, not having Official builders switch
Unfortunately, this will need to be merged on to the 34 branch, as it has the current "auto-use" code, so otherwise it'd switch to 2013 as soon as depot_tools starts updating the toolchain (previously, the only check was whether the toolchain exists on the local hard drive).
R=maruel@chromium.org
BUG=323300
Review URL: https://codereview.chromium.org/174143003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@252604 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
igsolla
sbc
scottmg
justsomeguy
mkosiba
joaodasilva@chromium.org
gunsch@chromium.org
scottmg@chromium.org
iannucci@chromium.org
sky@chromium.org
jochen@chromium.org
dmikurube@chromium.org
bungeman@chromium.org
thakis@chromium.org
brettw@chromium.org
r.c.ladan@gmail.com
viettrungluu@chromium.org
kjellander@chromium.org
pkasting@chromium.org
mattm@chromium.org
saiarcot895@gmail.com