Code using testing::CreateFunctor and testing::CallbackToFunctor
is usually more easily read if they used C++ lamdas instead. This
also avoids the situation where some closures needed to use BindOnce
where others BindRepeating. Finally this eliminates a GN dependency
issue identified in issue 806952.
Bug: 1007833, 806952
Change-Id: I43d103b038465501019b68a3350d1a528d5686cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908708
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#714122}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a05801034d8babb7c437f8ca5792ba5528c56275
- Remove unused cc/layers/scrollbar_theme_painter.h
- Add comments in cc::Scrollbar
- Remove rect parameter from cc::Scrollbar::PaintPart() because the
rect can be easily calculated by blink, given that the coordinate
space of the canvas is clearly defined
- Improve performance of blink::ScrollbarLayerDelegate::HasTickMarks
(implementation of cc::Scrollbar::HasTickMarks()). The old
implementation queried all tick marks and see if it was empty, which
may be slow when there are a lot of tick marks (e.g. when searching
in a huge document).
- Add blink::ScrollbarTheme::PaintTrackAndButtonsForCompositor() to
avoid exposing too much details of ScrollbarTheme to outside.
This is a preparation for CompositeAfterPaint composited scrollbar
implementation.
Change-Id: Ibf8c7a90d80ddf972f215495d0fd89470fa2deb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834286
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#702201}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7920cf550d305894d142e31c1c3b40a44e5c72fd
This is a refactoring CL only. Before this CL, we created a
ServiceWorkerNavigationLoader always, and then called methods on it
about whether to forward to a service worker or fall back to network.
But there is no need to create the loader just to fall back to network.
This CL changes things to only create the loader once we decided to
forward to a service worker.
As for the linked bugs, much of the complexity was probably due to the
old non-S13nSW code path, and I encountered this while trying to move
things to the UI thread.
Bug: 926114, 824858
Change-Id: I320ebcd9401c283653bc58ce0c2049c62c1e5139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690572
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#675890}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 46a16ef848252e7869f40c6e98bdf3f76320ee5b
Before this CL DisplayProvider would take a BeginFrameSource and create
an OutputSurface, DisplayScheduler, and Display.
For GPU surface based begin frames we want to check if output surface
supports it and create an appropriate BFS based on that. This CL
changes the order in which BFS and OutputSurface are created:
1) DisplayProvider (renamed to OutputSurfaceProvider) returns an output
surface instead of Display.
2) RootCompositorFrameSinkImpl doesn't need two phase initialization. It
creates the BFS after getting the output surface and then creates the
Display.
3) FrameSinkManager supports creating RootCompositorFrameSink with an
external begin frame source for compositor frame fuzzer.
Bug: 953970
Change-Id: I78d1700b24dc87a35096bde3993410a5da98a9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580859
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#655478}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec6f13bd817e1604b4d759e6f66b961a0ab8494c
chromeos_export.h is being included outside of src/chromeos which
should not be the case. This is probably from files moved out of
src/chromeos. This CL fixes those and makes chromeos_export a non
public deps of //chromeos.
Bug: 918682
Change-Id: I6bf394f0c933b8259f7567cfbb514c936b2d457c
Reviewed-on: https://chromium-review.googlesource.com/c/1405979
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: A Olsen <olsen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#622093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cc799d40f9b62fb97ca873695c44987b4f69f519
This gets rid of the old C-linkage entry point for standalone service
binaries, in favor of a cleaner and typesafe C++ entry point which takes
a proper ServiceRequest.
TBR=msw@chromium.orgTBR=jamescook@chromium.org
Bug: 911217
Change-Id: Ide390764db97eaa45806fdb3ca0f3e39a408baa7
Reviewed-on: https://chromium-review.googlesource.com/c/1359475
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#613691}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5079280b8b709811bb939fd3030f7c521fd0a31d
This change makes it so GpuChannelEstablishFactory is publically accessible,
and non-content code can use it to get access to GpuMemoryBufferManager and
to create context providers.
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: Iba90a603a6326c61447acd21037b5e9b6573356c
Reviewed-on: https://chromium-review.googlesource.com/c/1262621
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#596923}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 25d3737f3c9f4f2e221714e70b14babe08af4c58
Now that Skia is running GL directly as a part of OOP-R, it means that
the keep alive mechanisms for the command buffer are no longer being
applied. If any part of Skia runs long, then the watch dog hang
detector will kill the gpu process.
In particular, the gpu command buffer does this via:
* ContextGroup::ReportProgress
* GLES2DecoderImpl::ReportProgress
* GLES2DecoderImpl::ExitCommandProcessingEarly
...which all wind up eventually in GpuWatchdogThread::ReportProgress.
This fixes this by hooking up CreateGrGLInterface to ReportProgress on several "slow" calls.
Bug: 884804, 887939
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I84f2dc92670de3f1dd1ca7e0e8aa85c2d08a4858
Reviewed-on: https://chromium-review.googlesource.com/c/1242033
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#596091}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a237d180c9ca68a68fae1e83c1d06ebcf46ce6a2
Delete the unused constant AppShimMsgStart, since no messages
remain in app_shim_messages.h. Rename to indicate that only
param traits remain in the file.
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: Id36e797109a835dba51ebf121edf4c3ba537494b
Reviewed-on: https://chromium-review.googlesource.com/1211967
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590831}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c18f448aea14bcf0ca8d7cdde2049863b740c9f5
Now that SwiftShader has been integrated into every platform on every test,
we can remove OSMesa from the chromium codebase.
BUG=chromium:873321
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie75c73c172aaffd17a3e041aa7f4cf37a96c3d4d
Reviewed-on: https://chromium-review.googlesource.com/1128207
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582655}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0f21886190d0c27515faec2ada23541b936fb0f3
It looks like this file has * listed as its owner, so it doesn't need
any specific owner review.
Bug: 859514
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: I9afd700a6a36f00b5fb46847fbc5d01d08646db8
Reviewed-on: https://chromium-review.googlesource.com/1169437
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#582236}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b170ec58e8db44797571af99d40f1868a31698db
chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly.
This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc
will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work.
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1161610 with official Google ChromeOS build fix.
TBR=avi
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: If1cbab605ee0f14ec4c942d0c4b03b318e7d3c41
Reviewed-on: https://chromium-review.googlesource.com/1162922
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580732}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4970b15bfc133364ed94ba543b36bee321f3c133
This reverts commit 22333d92d225b2abdf0a628cb811e438b3e94c88.
Reason for revert: suspected of breakage in 'generate_build_files': https://bugs.chromium.org/p/chromium/issues/detail?id=870827#c3
Original change's description:
> Fix missing dependencies with RLZ target.
>
> chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly.
>
> This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc
> will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work.
>
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
> Change-Id: I85d78d25b1905c68524e0636cec3006102d17749
> Reviewed-on: https://chromium-review.googlesource.com/1161610
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580579}
TBR=avi@chromium.org,jam@chromium.org
Change-Id: I5bca5200d639f01dbba1ed582d9dccb3290cf0c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Reviewed-on: https://chromium-review.googlesource.com/1162211
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580660}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7bde422c7e0f2ea07c5093dda2d2c94d5a88510c
chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly.
This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc
will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work.
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: I85d78d25b1905c68524e0636cec3006102d17749
Reviewed-on: https://chromium-review.googlesource.com/1161610
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580579}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 22333d92d225b2abdf0a628cb811e438b3e94c88
This reverts commit 494108abe23d689c0a311025d464edc7453d368b.
Reason for revert: Reland it in M70.
Original change's description:
> Revert "Convert Extensions TCP & TLS Socket APIs to mojo sockets"
>
> This reverts commit 41066e83216ea19036dcf33cfbf35e18f77da9fe.
>
> Reason for revert: This CL broke an internal app. See crbug.com/865958
>
> Original change's description:
> > Convert Extensions TCP & TLS Socket APIs to mojo sockets
> >
> > This CL converts extensions TCP and TLS socket apis to network service's mojo
> > socket.
> >
> > - Remove combined_socket_unittest.cc because the test cases no longer apply. I
> > tried to write equivalent ones in tcp_socket_unittest.cc and
> > tls_socket_unittest.cc
> > - Add a ContentUtilityClient implementation for extensions_browsertests, so we
> > can inject a NetworkServiceTestHelper to the utility process in which network
> > service runs.
> >
> > Bug: 721401
> > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
> > Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
> > Reviewed-on: https://chromium-review.googlesource.com/1070434
> > Commit-Queue: Helen Li <xunjieli@chromium.org>
> > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#563390}
>
> TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 721401, 865958
> Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1145340
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576982}
TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 721401, 865958
Change-Id: I9748ea1d6c04f26429508da9358ca16ff01ff90d
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1148480
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577565}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bff8e3ea6d0d7c1f1fe045f595ffaeaf64ff41f9
This reverts commit 41066e83216ea19036dcf33cfbf35e18f77da9fe.
Reason for revert: This CL broke an internal app. See crbug.com/865958
Original change's description:
> Convert Extensions TCP & TLS Socket APIs to mojo sockets
>
> This CL converts extensions TCP and TLS socket apis to network service's mojo
> socket.
>
> - Remove combined_socket_unittest.cc because the test cases no longer apply. I
> tried to write equivalent ones in tcp_socket_unittest.cc and
> tls_socket_unittest.cc
> - Add a ContentUtilityClient implementation for extensions_browsertests, so we
> can inject a NetworkServiceTestHelper to the utility process in which network
> service runs.
>
> Bug: 721401
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
> Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
> Reviewed-on: https://chromium-review.googlesource.com/1070434
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563390}
TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 721401, 865958
Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1145340
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576982}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 494108abe23d689c0a311025d464edc7453d368b
The name "EDK" has been pretty widely regarded as meaningless and
therefore confusing to other developers. Given this and the fact
that Mojo is less embedder-centric than it once was and can now be
used without embedding at all, this CL renames the core
implementation to, well, "core".
- mojo/edk/embedder becomes mojo/core/embedder, and the include path
now matches the GN target path (finally)
- mojo/edk/system is moved to mojo/core - all parts of mojo/core
which are not mojo/core/embedder are private to the core
implementation
- mojo::edk -> mojo::core, for both public and private symbols
- The "EDK" is known as the "Mojo Core Embedder" library
- Documentation is updated to reflect these changes
A few stub headers have been put in place to allow for incremental
transition from the old things to the new things.
Where absolutely necessary, some forward declarations of
ScopedIPCSupport outside //mojo have been upated too.
Follow-up CLs will migrate everything over to //mojo/core/embedder
etc.
TBR=dcheng@chromium.orgTBR=tsepez@chromium.orgTBR=vitalybuka@chromium.orgTBR=jam@chromium.org
NOPRESUBMIT=true
Bug: None
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
Change-Id: I4f426fa1da67e87184be9eb8e2267160ddb6c2c7
Reviewed-on: https://chromium-review.googlesource.com/1126323
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#572627}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dba46db9f177fdbdd5e0d11486f81c68d07dbe25
This CL converts extensions TCP and TLS socket apis to network service's mojo
socket.
- Remove combined_socket_unittest.cc because the test cases no longer apply. I
tried to write equivalent ones in tcp_socket_unittest.cc and
tls_socket_unittest.cc
- Add a ContentUtilityClient implementation for extensions_browsertests, so we
can inject a NetworkServiceTestHelper to the utility process in which network
service runs.
Bug: 721401
Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo
Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba
Reviewed-on: https://chromium-review.googlesource.com/1070434
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563390}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 41066e83216ea19036dcf33cfbf35e18f77da9fe
Replaces the WebBlendMode enum with a BlendMode enum in graphics_types.h
under platform/graphics/ which is used throughout blink. This type is
kept because the bindings generator requires an enum with matching
names as the CSS property names (namely kNormal instead of kSrcOver).
Then we convert from BlendMode to SkBlendMode in GraphicsLayer in order
to pass it to the WebLayer.
TBR=fserb
Bug: 838693
Change-Id: If306343f4cd51911b46d6e1ca96529789477d29d
Reviewed-on: https://chromium-review.googlesource.com/1038403
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#555943}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3
Also removes no longer needed guard flag for GrBackendObject.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel,linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_vr
Change-Id: I228f6bf5bcb554f6dcf31889c210ca2043f5a837
Reviewed-on: https://chromium-review.googlesource.com/1040425
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555816}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e9de9ce989fefb8f048dc1370ad97497e828d36d
Now that CDMs use mojo exclusively, remove the Pepper APIs that are
now unused.
BUG=772160
TEST=compiles
Change-Id: Ifa77be717e7b11ab20ae8053901dcb663b1726cc
Reviewed-on: https://chromium-review.googlesource.com/981125
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#547187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e16205da434f46379bd8080b1e513c6ce3b32c4f
After the refactoring, //components/wallpaper only contains utility
functions used by //ash/wallpaper, so it makes sense to move them under
//ash for code health.
In addition:
1) Create wallpaper_types.h under //ash/public. This file will be the
only allowed wallpaper dependency in //chrome.
2) WallpaperFilesId class is exactly the same with a std::string, so
it's deprecated.
Bug: 776464
Change-Id: I8beb0cc94948d655a8eb5fe5a895647719aaaefc
Reviewed-on: https://chromium-review.googlesource.com/967867
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545201}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b96897b4ce5a14d4a46ad0defe5068fcefae0df8
Previously FeaturePolicyFeature was defined in
third_party/WebKit/common/feature_policy/feature_policy_feature.h
Then redefined in feature_policy.mojom when moving Feature Policy IPC to mojo
https://chromium-review.googlesource.com/c/chromium/src/+/784372
This CL removes the duplicated definition in feature_policy_feature.h and use
mojom::FeaturePolicyFeature everywhere instead.
Bug: 789818
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: Ia50428b30264becb54d3a4180118bc2fa4d98d94
Reviewed-on: https://chromium-review.googlesource.com/902642
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535401}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 730f283fbc668bcca07612aeb4c24c1b4a11409a
Removed FontDescriptor class which was used in IPC and replaced by using
embedded string16 font_name and float font_point_size fields directly.
Replaced usage of NSFont with CTFontRef in order to be able to access
font_name and font_point_size fields outside of objective-C.
Updated FontLoader API to use mojo::ScopedSharedBufferHandle to avoid
unnecessary conversions.
Bug: 775809
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I5b891aa2ebb386fb460d64a8f0a79c6bba95f82c
Reviewed-on: https://chromium-review.googlesource.com/768332
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#518858}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 27bcca76fb5c9e73b5270c8a407eb42ec445f2bd
This CL renames the HeaderPainter because it does much more than
painting which has become confusing. This is a precursor CL to
https://chromium-review.googlesource.com/c/chromium/src/+/768601.
Bug: 762401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: Ie41fa68c8b4559e258eac6eee957cc059794bd96
Reviewed-on: https://chromium-review.googlesource.com/774058
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#517265}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 662865528550cee1ef5e178adec5a558d0705056
It's not needed anymore now that libaddressinput doesn't need a
basictypes file.
Link to the github commit: https://github.com/googlei18n/libaddressinput/pull/143/
Bug: 775946
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I95b20063d05311d352c7055dae7dd58d0682fc8b
Reviewed-on: https://chromium-review.googlesource.com/726099
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511872}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 17ebe806789b5cf788debbc783eabb6ed208edfc
We no longer need the metric since the experiment of not compositing
small scrollers is done. See crbug.com/684631.
Bug: 775643
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I689f26f1355f01238f3ac8f0121bca59e9be3956
Reviewed-on: https://chromium-review.googlesource.com/728702
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510861}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c3c92b5963257e19dbc255ed9426d42160b051f2
This removes the manually-updated software_rendering_list and
gpu_driver_bug_list versions, replacing them with Chromium
git commit hashes. These hashes are used to generate
permalinks, like this one:
57c9d07b41/gpu/config/software_rendering_list.json
Bug: 772177
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id23a5e05506492999a43cd173e4659095f75fe4c
Reviewed-on: https://chromium-review.googlesource.com/728950
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510568}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96bd9ef90d95efa332485195e03c63477b90bb07
SDCH code has been disabled in Chrome since M59. SDCH code is being removed from
Chrome in M63.
This CL is to remove it from .gn, .gitignore, licenses.py and
check_gn_headers_whitelist.txt.
Bug: 762686
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I0986a75b548fd6c1ec2e6806a8f6cd38ad2058f6
Reviewed-on: https://chromium-review.googlesource.com/674666
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503153}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1
Removing iTunes support from media_gallery API on Windows and Mac, as it is
not maintained and has been broken on Windows since iTunes changed its
configuration file locations more than a year ago.
Bug: 762991,758355
Tbr: tsepez, bbudge
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I258659e5241f27f5ad2b0cc86ba8f902f77a32e7
Reviewed-on: https://chromium-review.googlesource.com/646801
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500748}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf99550c9df48abf9c6b32a062320a26bf1624cd
Not sure about this choice of home for this method.
This CL also deletes CSSPropertyMetadata class.
Bug: 751373
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I812df195574ee38f2e798dd7fdb7986b15efad22
Reviewed-on: https://chromium-review.googlesource.com/652207
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500540}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6d76d1aeb62ce848e5d74fc6a21011e4a04d304a
Removing Picasa support from the MediaGalleries API and removing any
Picasa related file.
Bug: 762985, 758355, 567212
Tbr: sky, bbudge
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I9612d2ad2407d167ac8462b51d1eddee5d70cf9e
Reviewed-on: https://chromium-review.googlesource.com/650948
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500420}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67522843fc18901d1c95fc35671b085677680f68
This also removes some usage of the FILE thread as well, but not all.
Bug: 675631
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I97dc1b3bbe52f865ccbaf639bd33fc5dd65b474b
Reviewed-on: https://chromium-review.googlesource.com/566744
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498359}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e4a2323376aaac1259084ff92cddcbabb32da442
This enables sending UseCounter WebFeature through IPC:
https://chromium-review.googlesource.com/c/550520/
This CL also includes some optimization work in EventTarget.
Bug: 716565
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I156ffb951d6a2868e9757063a91fee97fdf8008b
TBR=rockot@chromium.org
Change-Id: I156ffb951d6a2868e9757063a91fee97fdf8008b
Reviewed-on: https://chromium-review.googlesource.com/555950
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#484164}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f41b44927adbcbd4ad3f79cc50b385f95c3d6ce4
Chris Mumford
Henrique Ferreiro
Xianzhu Wang
Matt Falkenhagen
Sunny Sachanandani
Steven Bennetts
Ken Rockot
Nico Weber
Bill Orr
Adrienne Walker
Tom Sepez
Scott Violet
Alexis Hetu
Charlie Andrews
John Abd-El-Malek
Roberto Carrillo
Helen Li
Ken Rockot
danakj
Greg Daniel
Oksana Zhuravlova
Blink Reformat
John Rummell
Wenzhao Zang
James Hawkins
Luna Lu
Michael Warres
Joel Hockey
Christopher Lam
sebsg
Shanmuga Pandi M
Yi Gu
Kai Ninomiya
Evan Stade
Jay Civelli
Renee Wright
Ben Wells
Thiago Farina
James Zern