According to the comments in
https://chromium-review.googlesource.com/c/chromium/src/+/1882109
Also reorder the options so they have the same order in all
platforms, making it easier to see what's different across platforms.
Bug: none
Change-Id: Ibea9ef89a4fd78e31677f0e43036739ec6ad372c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881636
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#709994}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0a97ab1d8475193bbc09ec422b6f72eb4ddf7988
GOOGLE_CHROME_BUILD is more a branding thing. Since
Google Chrome builds set both GOOGLE_CHROME_BUILD and
OFFICIAL_BUILD, this doesn't have an effect in practice.
People who do non-Google Chrome-branded OFFICIAL_BUILD
asan builds will now get the different flags, which seems
like a good change.
While here, also deduplicate the common flags and add
a comment saying that the OFFICIAL_BUILD asan flags
are basically never used.
Bug: 961769
Change-Id: I42491c1d4d3ab876b0de92d0746266580dafe1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882109
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#709905}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3f4c7ae8d4a56f57b286b46ade4f5ca330bcdb12
In https://chromium-review.googlesource.com/c/chromium/src/+/1539153, I
cleaned up some dead symbols but, in doing so, I left a stray
"race:base::trace_event::" in the file with no trailing newline. That
line and the suppression following it don't actually do anything useful
as a result and apparently TSan bots have been fine, so remove them.
Bug: 257396
Change-Id: Ic995eff58651c011edee0dd0586d9e598f155fe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681449
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#706083}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 60dc9c939405578e75f97d92ea12a0a552b5e271
This was uncovered when we removed the bulk ffmpeg suppressions. If
ClusterFuzz comes back and reports tons of different threading issues,
we probably need to go back to blanket suppressing everything. For now,
see if we can target something more fine-grained this time.
Bug: 977085
Change-Id: If19c254e0b98c5d450b74cc7d02fd7a2f1a0e189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669760
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#671095}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec90982c89c85ca5ac8f53a17d35557027276a98
EmbeddedTestServer callbacks run on a background thread, so shared state
should be synchronized.
Bug: 965724, 965726
Change-Id: I10503dd76f1def680e0c0d944149632a8dbaedea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662530
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#670698}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff93edd82ccedc7e376b6dd7c7968002ed5606de
TracingControllerImpl::SetEnabledOnFileThread has not existed since
https://chromium-review.googlesource.com/611188.
Bug: 490856
Change-Id: I3c2bcad754242d187693bdc451af372be0cae646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666944
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#670590}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6f269f912574c0b6e51fcc6e7065433bccd82c07
Rather than sleeping for half a second, wait for two data points,
notify the other thread, and then stop counting.
Bug: 239359
Change-Id: If439ca20df6a7ceb5c2c308baf0e7c508c1cb2ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617629
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#670537}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 56d69033f64172c2d9311f4f217c985c0e300570
Chrome currently builds SQLite with SQLITE_TEMP_STORE=3, which disables
temporary storage, so unixTempFileDir should never be called.
Bug: 244385
Change-Id: Idfa8bf86d997654c619db5d2abf3198afae41983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661499
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669829}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0dd19e3384863aef22aca199a97dd6d11901b6ca
ClusterFuzz claims this is since fixed, but in that case the
suppression should have been removed.
Bug: 84094
Change-Id: I316f6c97f99fa49224297050d9c3385b29bac0ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661473
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669742}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10441c0c39a10cdd0570c456a793327c0e84657c
I believe this was fixed upstream in
ec03a56a31
Confirmed race no longer reproduces locally, and if I comment out the locks
added above, it does.
Bug: 347538
Change-Id: I313f5ed4aafbf012ffa4543580f3b3a5541c2c2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657299
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4c22d7cb98a446c1e72a9b5c1ea5c32845a5ea9
Several testcase leaks are coming from this method -- suppress leak
detection for this method until the leak is fixed.
Bug: 961062
Change-Id: Ibc61de53bd8d4357d30b024e3c3e96928295e19d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647121
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667819}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5c9ef6ccba1e06c8647a6ef17f8227b6b9cf2080
Per the bug, there were two issues, one of which was fixed and the other
sounds like it was fixed in newer ALSA in 2014 (comment #17). Remove the
suppression.
Bug: 374135
Change-Id: I37c8ca04dd9c7cf8d33b12940cd5457b0cbe6e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641202
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665590}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bbe1d856c1592f8bd223e60603d5261198f57246
webrtc::acm1::AudioCodingModuleImpl::PlayoutData10Ms can no longer be found in
code search, so remove the style suppression.
Bug: 348511
Change-Id: Id723f1ca2bb0927be198f1b4166f8fd786fc2893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620590
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#663080}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a6f222e9350ebf3fc006b0dda3dbf3c78009bf8f
The last comment on the bug suggests this is no longer applicable. If
so, we should remove the suppression.
Bug: 347534
Change-Id: I9da64043c95c167a5cab72f09645f6db9a3a50f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625099
Commit-Queue: Adam Klein <adamk@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#662558}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 098dcffb1581aa3c26ecb599389aafd83a65238c
This is probably a false positive. The test currently assumes that, in
the period when it's calling SetClearSiteDataHeader, there are no
requests in flight. This appears to be true, however, it depends on
signals across processes, which I suspect TSan is not taking into
account. The race doesn't trigger with --single-process, which supports
this theory.
Still, adding a lock is easy and seems prudent when state is accessed in
this way across threads.
Bug: 965719
Change-Id: I7c5c34a06df4684845f76c0e8730c4bfea7170c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626297
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#662539}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 19351c0a721e1c2c7e9f63481963bbc6f057d7f5
Bug discussion suggests the issue was fixed, and
NoTrackDoubleFieldsForSerializerScope no longer exists. Remove the
suppression.
Bug: v8:3143
Change-Id: Ic8bcea8d111ad8334914a817ca46a5f4a83558fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618147
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#662189}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4d93139e8e9f1554c944f011ad8c81c251673e73
The original event_sigcb and event_gotsig race conditions were resolved by
https://crbug.com/605894. However, the suppression was so broad that it covered
every event loop iteration using libevent. Several other bugs have crept in
in the meantime.
Add finer-grained suppressions for those bugs.
Bug: 23244, 965714, 965717, 965719, 965722, 965724, 965726
Change-Id: I646da30f7df1d0a19a4c1eb6ad7aebcd93ba099b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620705
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#662176}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0895d55ac0b76308c3c837133816eddb8b0bf62e
Bug: 699562
Change-Id: I9c818a0c0c490b2d32929a9867d5d3bebf6e8ca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618016
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#661014}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1e7bfdb26cc8551539d9bf9b94dcc9fd326c55b7
These races have been around 8+ years so new CLs triggering these TSAN failures
should be ignored. I've prototyped a fix to avoid the races.
This global variable is set very early in Chrome startup and cleared very late
in Chrome shutdown so reads shouldn't race writes.
Bug: 927330
Change-Id: Ic3ed2446e4cee92dbeda83a0b10ad99a1fbf5d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566824
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#650846}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 433cfc173e369a5f51afcd6ef14cab8dbdf9c481
The accessibility dump tests (both tree-dump and event-dump) execute
multiple passes for each test. Most OSes run two passes (Blink +
Native), but on Windows we recently introduced a third pass for UIA.
The addition of the UIA pass required that we toggle an experimental
command-line flag to ensure that UIA is properly enabled/disabled.
Unfortunately, modifying the command-line multiple times during the
test ran afoul of the ThreadSanitizer, which reported a data-race
condition. This required that the dump tests be parameterized, so that
each "pass" now runs independently, and can update their command line
only once.
Note: "gtest_filter" now requires a "/xxx" suffix, e.g.:
--gtest_filter=DumpAccessibilityEventsTest.ValueValueChanged/*
Bug: 946481, 928949
Change-Id: I6490f33681b5567b6584442c9cf241611b3b5baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542692
Commit-Queue: Ian Prest <iapres@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#646672}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3fb61ca45c6511a79977f32a047613e981d0f2fc
The base::CommandLine was overly broad. The flakiness analysis of
https://chromium-review.googlesource.com/c/chromium/src/+/1539787
reported that DumpAccessibilityTreeTest.AccessibilityObject and
QuicAllowedPolicyIsNotSet.NoQuicRegulations were flaky.
The latter has a 1.8% confidence and is on a non-TSan builder, so it's
probably a false positive. DumpAccessibilityTreeTest.AccessibilityObject
is real and is tracked in crbug/946481. Refine the suppression to just
cover that.
(If other command-line races come up, I think it's preferable to add new
suppressions and file new bugs rather than revive the overbroad
base::CommandLine suppression. The overbroad one has let new bugs
through, like the accessibility test.)
Bug: 946481, 334140
Change-Id: If09cb2fa2629751367e3fd822e3ba5159d529492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548138
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#646493}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f38b1c44c8ffe65ef028986507bfe614eafd885f
The CreateObject implementation should release the ppp_class_data when
it goes out of scope.
Bug: 258113
Change-Id: I563c6b5234f5ac94fed4fd43ce69c448e54866de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539692
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644512}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ad71d5814950c7107f7a2c9adf43dcdc363cafc
The bug is marked closed. Remove the suppressions so we'll catch future
base::CommandLine races.
Bug: 334140
Change-Id: Ia5492467222cfcfb4508d62aef9136b932347171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539787
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644463}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a719973ce617b1a7b0d3e87b4e26dd9f42264406
Per the bug, "The patch mentioned in #49 was already rolled out in
Chrome to reduce the data race warnings. We will close this issue.
Please file a new one if you see more issues."
The bug should not be closed without first removing the suppression. Do
so now, so we'll actually notice if there are more issues.
Bug: 158922
Change-Id: I3c924a73296396d2dd7a8efcdc4705cd8a5fc7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539286
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644300}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 680ccb60d62240cd31615d79f9a14f300af7c086
See if this still happens.
Bug: 355641
Change-Id: Idfb2ed96049e7806e54867d253e9f6d43284304d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512492
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644298}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9aded53d324ed7189488a10ca87f69060b999c08
Per code search, these symbols don't exist anymore.
Bug: 244368, 333871, 388730, 430533, 569682
Change-Id: Ibb00d618e92d006c1c6e982973f6a946a9162dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539153
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644293}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7aa7341a44fcbb42448cb65e507e093a665a40b4
The bug was fixed, but it looks like we forgot to remove the
suppression. The symbols in question no longer even exist.
Bug: 338675
Change-Id: I9962be3a4a52d1f5a877744eb43e03894c818437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538571
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644278}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d094f94963faf012217b7ffe5632c383b633ceec
This was fixed per the bug, but we forgot to remove the suppression.
Hopefully it hasn't masked new instances over the past five years!
Bug: 347553
Change-Id: I61164fcc93fb622dfde593c22a7ba06c7d3e92d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538451
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644275}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ad45717b55b853121bfc2c206d77483b522b2402
Per the bug, this was believed to be due to std::string copy-on-write
logic. We've since switched to C++11, which forbids that optimization,
and libc++, which uses the short string optimization instead.
Bug: 310851
Change-Id: Ia40cde0ff3b6e6262addbb51837db08dd6c9a7d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538450
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644274}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 781a2ea7cf8c5dd6e3d1e29c46e0ab6ab7f5ad02
The original race condition from 2017 is now fixed. Remove the
supression now, so we'll notice if anything new shows up since then.
Bug: 719633
Change-Id: I5250dee8c7362e0337cbd1652f0eae030fb5d43b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531017
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#642461}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b63c38de58c48f315738ecfee083877d170e563e
Nico Weber
David Benjamin
Michael Starzinger
Takuto Ikuta
Victor Costan
Oksana Zhuravlova
Gabriel Charette
Caleb Raitto
Abhishek Arya
Paul Jensen
Ian Prest
Matt Menke
Matt Mueller