version_codes.txt, generated by official_buildbot script, is using the wrong
label for webview version codes. Label is currently WebviewStable, etc, but
these need to match the APK names, ie AndroidWebviewStable etc.
This is the final of a multi-part patch.
Previous CLs: crrev/i/1221430, crrev/c/1586394, crrev/i/1220601
Bug: 957163
Test: Run official_buildbot.sh locally and check that version_codes.txt
Test: has appropriate version code values for AndroidWebview apks
Change-Id: Ifb5f0b979cdbfb3f702055c896eccb057cffeb2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585656
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#655023}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8fc9ec734ca7b96b6b44e10f19e445e3b4000a2e
version_codes.txt, generated by official_buildbot script, is using the wrong
label for webview version codes. Label is currently WebviewStable, etc, but
these need to match the APK names, ie AndroidWebviewStable etc.
This was intended to be the second of a 3-way patch, but some of the
changes needed downstream were missed, and so two more patches remain:
one downstream to implement this new change and another upstream to
remove old unneeded values.
Previous cl: crrev/i/1220601
Bug: 957163
Test: Run official_buildbot.sh locally and check that version_codes.txt
Test: has appropriate version code values for AndroidWebview apks
Change-Id: Iffcf36aff98fd870a9f7ee54ebc7a033e728b46c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586394
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#654942}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ab57366f5cbcaba7d8b7d76297559a06a53e14f
Change the characters that get written to the chrome_versions.txt output
file so that it can be read by the parser Omaha uses.
Bug: 953059
Change-Id: I219dd2360cacf6d9bed2316478d86e733c4dcb06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570699
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#651786}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 683a70218f4b3a33ddb2eb8560488a4343a293db
Change the characters that get written to the chrome_versions.txt output
file so that it can be read by the parser Omaha uses.
Bug: 953059
Change-Id: Id36ac48cdce1686cf0509e7b5fb175b3b2baebb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568009
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#651365}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c4c3c4933642d234a7dfccd9df28c783439b285e
This is one of multiple follow-ups to crrev.com/c/1554184.
That CL accidentally left mb looking for a runtime_deps file that
the generate_wrapper template wasn't generating. This CL simplifies
it to just use the default runtime_deps file for actions.
Bug: 816629,861983
Change-Id: Idfd208d32a4e8b3a66af30e8d9a307f1a8bd3b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562214
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#650106}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39f14962238cb6e30faa8fd76ba731a3192e6cd7
This reverts commit b4a06a456edebd47cdc421e752adb6b6e333f422.
Reason for revert: Clank Official Build Failure - 75.0.3761.0 crbug.com/951364
Original change's description:
> [Bundles] Add Upstream 64-bit Trichrome Chrome Bundles.
>
> This CL adds the following targets for 64-bit biulds:
> trichrome_64_32_chrome_bundle
> trichrome_64_chrome_bundle
>
> These complemnent existing Monochrome targets.
>
> Also rename template monochrome_public_bundle_tmpl to
> monochrome_or_trichrome_public_bundle_tmpl.
>
> Change-Id: I1773085c82e2dbf068c9bfbd1ca03a7175fee1c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553913
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#648671}
TBR=huangs@chromium.org,cjgrant@chromium.org,agrieve@chromium.org,tiborg@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Ifce48fc21989590f7bdcdc5c1337653cf1d9a7cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561272
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#649513}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4352cd27f4b62b0668d07e84ac74093a80f45a2
This CL adds the following targets for 64-bit biulds:
trichrome_64_32_chrome_bundle
trichrome_64_chrome_bundle
These complemnent existing Monochrome targets.
Also rename template monochrome_public_bundle_tmpl to
monochrome_or_trichrome_public_bundle_tmpl.
Change-Id: I1773085c82e2dbf068c9bfbd1ca03a7175fee1c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553913
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#648671}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b4a06a456edebd47cdc421e752adb6b6e333f422
Channel-specific versionCodes for standalone webview need to be in a
specific order so the correct channels have precedence over others.
Follow-up CL to http://crrev/c/1547757
Bug: 919216
Change-Id: I085ee25dc4029cf3edb3b3f5b0d2257267adc800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550011
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#647130}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3cc32db7d1e493d305f7fedd331819b3cd1be251
To enable downstream official build scripts to build channels for
standalone webview, upstream version code logic needs to generate
unique version codes for each channel.
Change-Id: Ic53d4c529416ded7bf32498c527d623f17b2f478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547757
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#646941}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 909e9085881a7e9a8b6cfc9fb157a6a863beb064
Android arm64 builds of monochrome need to build multiple apks with
various combinations of 32-vs-64-bit chrome & webview. Each apk will
need a unique version code, distinguished by the second-to-last digit
(the architecture digit).
This CL modifies the version code logic to support this.
Bug: 946281
Test: Check chrome_versions.txt, add automated tests.
Change-Id: I78b8d6fedb4c18db2442f50a027f988616e180c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540683
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#646640}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de15424b71aedb6209ca127952c2d87d20a0da74
Write android chrome versionCode values to a file in version.gni,
making the values accessible elsewhere, such as in downstream build
scripts.
Also add support for notouch build versionCodes, to enable removing
downstream versionCode logic entirely.
Depends on: http://crrev/c/1501459
Bug: 919636
Test: Run android chrome official build script successfully
Change-Id: I4a85f01c302346a46b184b9d15a5d7a89c273d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524096
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#645144}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e9f8b8674e5c76e91c65d1be3eb6cb2a3b245510
Refactor existing chrome for android and webview version code
logic from build/config/android/chrome_version.gni to a python
script and add unit tests (in PRESUBMIT).
Bug: 938138, 945039
Test: Add unit tests in PRESUBMIT; manually verify versionCode
Test: values in manifest.xml using Android Studio apk analyzer
Change-Id: I6537c8f2d4d1f6ee9a18c43f253b69de0afe674a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501459
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#645096}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c14bba7555f72753930dcbd93bc3f59acb291728
Reland commit f4f6c5fff0620889d1ba8f0f319d15cb21510dfb
Revert 1 was 172ccc05351f0786dab62149f35ac75241d66878
Revert 2 was cd0e1d01615241e4e01a8510ab3f342666cdff6f
The previous attempt at a reland failed during gclient sync
when lastchange.py attempted to perform
"git log -1 --format=%H %ct --grep=^Change-Id: HEAD"
The new logic shows the git failure but falls back to
the original logic of defaulting to a version of 0.0.0
when the git command fails.
Bug: 917159
Change-Id: I22a03fe773a3507e566abb9d29eac08d7e56a647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533261
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#644680}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75221bfc31b61c340bd6663d82fd9dabe973c394
The changes are to allow build files to be generated using Python 3 on Windows.
The scripts still work with Python 2.
There are no intended behaviour changes.
Bug: 941669
Change-Id: I52c912c624660c7a46c05f8f36871744abd7b8d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521487
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Original-Commit-Position: refs/heads/master@{#641870}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4197d3af6e42aa72076d6051153a644f3df62dd5
This reverts commit 5f2e9a96b47669cd210488d728cbd81032e969a5.
Reason for revert: gclient sync fails with the following error:
________ running '/usr/bin/python src/build/util/lastchange.py -o src/build/util/LASTCHANGE' in '/mnt/sdd/chrome'
ERROR:root:Failed to get version info: %s
Original change's description:
> Reland: "Add --merge-base-ref option to lastchange.py"
>
> Reland commit f4f6c5fff0620889d1ba8f0f319d15cb21510dfb
> Revert was 172ccc05351f0786dab62149f35ac75241d66878
>
> The previous attempt at a reland changed FetchGitRevision
> which caused breakage when
> chrome/test/chromedriver/embed_version_in_cpp.py attempted to call this
> function. https://crrev.com/c/1459921 was recently merged which
> completely removed embed_version_in_cpp.py which should allow
> this change to re-land without modification from the previous
> attempt at a reland.
>
> Change-Id: I0dbd7436938ae27167a9381415277d95d0d8312f
> Bug: 917159
> Reviewed-on: https://chromium-review.googlesource.com/c/1460454
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Eli Ribble <eliribble@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#633730}
TBR=dpranke@chromium.org,tandrii@chromium.org,eliribble@chromium.org
Change-Id: Ia644ba3b8fe50b38fec26959a298f0d269fa54c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 917159
Reviewed-on: https://chromium-review.googlesource.com/c/1479950
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#633886}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cd0e1d01615241e4e01a8510ab3f342666cdff6f
Reland commit f4f6c5fff0620889d1ba8f0f319d15cb21510dfb
Revert was 172ccc05351f0786dab62149f35ac75241d66878
The previous attempt at a reland changed FetchGitRevision
which caused breakage when
chrome/test/chromedriver/embed_version_in_cpp.py attempted to call this
function. https://crrev.com/c/1459921 was recently merged which
completely removed embed_version_in_cpp.py which should allow
this change to re-land without modification from the previous
attempt at a reland.
Change-Id: I0dbd7436938ae27167a9381415277d95d0d8312f
Bug: 917159
Reviewed-on: https://chromium-review.googlesource.com/c/1460454
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#633730}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5f2e9a96b47669cd210488d728cbd81032e969a5
This reverts commit f4f6c5fff0620889d1ba8f0f319d15cb21510dfb.
Reason for revert:
Still fails on chromeos build-bot. See 919777 #4 for more details.
Example failure:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8922379830326735328
Bug: 919777
Original change's description:
> Reland: "Add --merge-base-ref option to lastchange.py""
>
> Reland commit fb941d6f96a1815eb737c5a91cbd6d119b59e387.
> Revert was bff8ece152ca22576538a6d1e117a27eb689ccb0.
>
> The original commit changed RunGitCommand as a standard refactor
> to simplify the code in a single module. Turns out that module is
> called by python code in other repositories. Therefore this version
> retains the old behavior of RunGitCommand until the other repositories
> can be changed.
>
> Change-Id: Ifcbb74c6928ad27169a9381415277d95d0c9265e
> Bug: 917159
> Reviewed-on: https://chromium-review.googlesource.com/c/1401511
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Eli Ribble <eliribble@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#628936}
TBR=alemate@chromium.org,dpranke@chromium.org,tandrii@chromium.org,jbudorick@chromium.org,eliribble@chromium.org
Change-Id: Ia65dba384bf477660c33f89c1cd3c0e76d5e6d61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 917159
Reviewed-on: https://chromium-review.googlesource.com/c/1454803
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#629165}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 172ccc05351f0786dab62149f35ac75241d66878
Reland commit fb941d6f96a1815eb737c5a91cbd6d119b59e387.
Revert was bff8ece152ca22576538a6d1e117a27eb689ccb0.
The original commit changed RunGitCommand as a standard refactor
to simplify the code in a single module. Turns out that module is
called by python code in other repositories. Therefore this version
retains the old behavior of RunGitCommand until the other repositories
can be changed.
Change-Id: Ifcbb74c6928ad27169a9381415277d95d0c9265e
Bug: 917159
Reviewed-on: https://chromium-review.googlesource.com/c/1401511
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#628936}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f4f6c5fff0620889d1ba8f0f319d15cb21510dfb
This reverts commit fb941d6f96a1815eb737c5a91cbd6d119b59e387.
Reason for revert: Compile failure on internal builders.
Bug: 919777
Original change's description:
> Add --merge-base-ref option to lastchange.py
>
> This option allows the chromecast platform team to remove some custom
> logic in favor of a general flag that anyone can use. The
> --merge-base-ref flag takes a ref, such as
> "origin/chromium/src" and limits lastchange's calculations to the merge
> base between HEAD and that ref
>
> As part of this commit I simplified the VersionInfo class because it
> didn't need the aditional complexity of not being named-tuple. After a
> review of the various uses of RunGitCommand it seemed prudent to fold
> in the returncode and error checking into the RunGitCommand function
> to simplify the rest of the code.
>
> This commit also moves towards a model of failing early and providing
> messaging to the user about why the command failed. This led to
> factoring out the FetchVersionInfo function which no longer does useful
> work and to calculating the git top directory early in the process and
> using it throughout.
>
> Bug: 917159
> Test: None
> Change-Id: If58a956f51ccc019c7be860227a0039cdc0709b8
> Reviewed-on: https://chromium-review.googlesource.com/c/1387690
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Eli Ribble <eliribble@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620447}
TBR=dpranke@chromium.org,tandrii@chromium.org,eliribble@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 917159
Change-Id: Id6134dad46603cb056f8351279b5522c3c6f151d
Reviewed-on: https://chromium-review.googlesource.com/c/1400836
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620881}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bff8ece152ca22576538a6d1e117a27eb689ccb0
This option allows the chromecast platform team to remove some custom
logic in favor of a general flag that anyone can use. The
--merge-base-ref flag takes a ref, such as
"origin/chromium/src" and limits lastchange's calculations to the merge
base between HEAD and that ref
As part of this commit I simplified the VersionInfo class because it
didn't need the aditional complexity of not being named-tuple. After a
review of the various uses of RunGitCommand it seemed prudent to fold
in the returncode and error checking into the RunGitCommand function
to simplify the rest of the code.
This commit also moves towards a model of failing early and providing
messaging to the user about why the command failed. This led to
factoring out the FetchVersionInfo function which no longer does useful
work and to calculating the git top directory early in the process and
using it throughout.
Bug: 917159
Test: None
Change-Id: If58a956f51ccc019c7be860227a0039cdc0709b8
Reviewed-on: https://chromium-review.googlesource.com/c/1387690
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620447}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb941d6f96a1815eb737c5a91cbd6d119b59e387
This is to better support Python 3 since optparse is deprecated as of
Python 3.2
Bug: 121231108
Test: Run locally
Change-Id: I08861b82f2f2f563e576dd50c9e8af0c4252cb9f
Reviewed-on: https://chromium-review.googlesource.com/c/1382929
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#618007}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a04cefb3124eee8ca06a47b8e1a9c6dfa8a4f823
When we added LASTCHANGE.committime in r583420, we missed a
case where we might not write it in the hook, and in that
situation the build would fail due to the file being missing.
TBR=thakis@chromium.org
BUG=875039
Change-Id: I5c596f55fe90bc5f5175c74ba27e218f108f843b
Reviewed-on: https://chromium-review.googlesource.com/1178892
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583852}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ea3f82d03831c13bd1bc7277334fd313af7f86b3
BUILD_DATE used to take the current time and then set BUILD_DATE to
the first Sunday of the month (unofficial builds) or to that date at 5am
(official builds), so that the date stays constant for a while, to
keep binary hashes changing less frequently. (BUILD_DATE makes it into
base/, so most binaries contain it.)
This behavior is kept, but it's now based off the timestamp of the most
recent commit.
This has the advantage of being deterministic, so for example if some
Android bot builds the same revision twice, it's now guaranteed that
both builds will end up with the same timestamp. The motivation is that
I want to reland https://chromium-review.googlesource.com/1161104 which
broke Android bots which assume fully deterministic BUILD_DATEs and
currently only work by accident due to write_build_date_header.py not
rerunning in incremental builds.
Since querying git is slow and the timestamp will be queried at
gn gen time in a follow-up change, let lastchange.py write the last
commit's timestamp in a file next to build/util/LASTCHANGE and then read
that in write_build_date_header.py.
For official chrome builds we ship, this shouldn't make much of a difference,
since there's always recent commits when we ship those (if only to
update chrome/VERSION).
When syncing to an old revision (past the revision this change lands in, of
course -- say this lands and then 2 years pass, and then you sync back
1.5 years), that will now have an old date while it had a current date
before. This could happen while bisecting. You'd get more security
interstitials while bisecting.
Embedders might ship old Chromiums without having a recent commit
in src. These would have BUILD_DATEs in the past. I announced this change on
https://groups.google.com/a/chromium.org/forum/#!topic/embedder-dev/Ymk3bHPQ45M
We can add an explicit opt-out if requested.
Build date currently affects:
- HSTS lists (considered valid for 70 days past build date)
-- but only enabled for official chrome builds (GOOGLE_CHROME_BUILD
check in TransportSecurityState())
- certificate transparency (considered valid for 70 days past build date)
- invalid cert date interstitial (warns if system clock is
more than 2 days behind build date, or more than 365 days
in the future)
- browser upgrade detector indicator UI (stops checking after
build is 12 weeks old)
- field trials (kNoExpirationYear is 2 years past build date)
//base:build_date already depends on lastchange_file and only reruns
when that file is touched (and on full builds).
Lots of prior discussion in https://codereview.chromium.org/1641413002/
(this approach but without widening was suggested in comment 26,
comment 46 mentions security concerns from agl, comment 67 onwards are about
security too. Eventually http://crbug.com/584880 got filed with a plan similar
to this CL here, but there was no time to evaluate the proposal at the time
due to internship schedule reasons. I talked to security -- namely,
felt agl ncarter carlosil -- and everyone thinks this has no obvious issues.)
Obsoletes https://chromium-review.googlesource.com/c/564598/, a prior attempt
at getting deterministic builds (opt-in, by setting an env var with the desired
date).
Bug: 314403,584880,871173
Change-Id: I6ccd78bff005572a9fa391e9820f4f5f83583c50
Reviewed-on: https://chromium-review.googlesource.com/1167913
Reviewed-by: Alex Mineer <amineer@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583420}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c984bc7664755d701c75b49b795678e164551e3
This is to take stats of cache hit rate on swarming test execution.
I will record stats to the issue few days later.
I changed dummy value due to some test failure.
Bug: 869348
Change-Id: Ied830d0e783065e3aad48f066ad6b471b735fe00
Reviewed-on: https://chromium-review.googlesource.com/1157737
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579787}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23f7bc518a817b8c102fe144e87b932a273ce053
This is to generate reproducible binary between commits for Linux by giving use_dummy_lastchange=true in args.gn.
This CL makes binaries independent from commit hash at least for below (time consuming) targets on Linux.
* content_unittests
* interactive_ui_tests
* content_shell (for webkit_layout_tests)
* content_browsertests
* browser_tests
If we can generate deterministic binary, test execution on build bot can be cached. And it will improve CQ cycle time.
But we don't know how often we make changes not introducing functional change in binaries.
So this CL is mainly for getting some stats from test on Linux buildbot and evaluate whether it is better to go forward or not for other platforms.
See more backgrounds here.
https://docs.google.com/document/d/16dalG0ssugZlwc7BBzUoBQUmuqM0S_gwtG2uxL0htdw/edit#
TBR: pfeldman@chromium.org
Bug: 869348
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b351b2135fd5e749ed575484b2182e847a420c9
Reviewed-on: https://chromium-review.googlesource.com/1151169
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579668}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 36541eb81aae62b267dcc88d1fdaef912450299a
This reverts commit 0895c7977a5c312aca132b23a3a9d46f78f77ee4.
Reason for revert: Missed a hardcoded gn location: https://crbug.com/857107.
Original change's description:
> Pull GN via CIPD package
>
> The gn binary will be downloaded into third_party/gn. This CL rolls
> buildtools forward to a revision where gn is no longer in buildtools.
>
> Because buildtools has no way to cleanup after itself, add
> build/util/gn_cleanup.py to delete the old binaries so that we don't
> accidentally depend on them.
>
> Update mb.py to use the new location.
>
> Update explicit location in ios/web_view/BUILD.gn for the new location.
>
> Update explicit location in
> tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new
> location.
>
> Update explicit location in tools/licenses.py with for the new location.
>
> Bug: 855791
> Bug: 794764
> Bug: 856883
> Bug: 856884
> Bug: 856878
> Bug: 856899
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116
> Reviewed-on: https://chromium-review.googlesource.com/1112840
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570792}
TBR=dpranke@chromium.org,scottmg@chromium.org
Change-Id: I89e180710b5ce483106fa3b4ff6e8dec06780c07
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855791, 794764, 856883, 856884, 856878, 856899
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1117219
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#570799}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 35383539aa83f27185a661215773ece946535676
The gn binary will be downloaded into third_party/gn. This CL rolls
buildtools forward to a revision where gn is no longer in buildtools.
Because buildtools has no way to cleanup after itself, add
build/util/gn_cleanup.py to delete the old binaries so that we don't
accidentally depend on them.
Update mb.py to use the new location.
Update explicit location in ios/web_view/BUILD.gn for the new location.
Update explicit location in
tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new
location.
Update explicit location in tools/licenses.py with for the new location.
Bug: 855791
Bug: 794764
Bug: 856883
Bug: 856884
Bug: 856878
Bug: 856899
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I92c908faf4f868850eafa1b4adf6e7c33c365116
Reviewed-on: https://chromium-review.googlesource.com/1112840
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#570792}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0895c7977a5c312aca132b23a3a9d46f78f77ee4
This reverts commit e25c04d02eb0d12a48e506dc82df9c421f8203a7 and relands
commits a221822f30fb4ae70dcfac45b581bf95f312b8c0 and
b69d8c48da838196d9655402dd739e62227762a7
Adds the following changes:
(1) In chrome/installer/mac/sign_app.sh.in l62, embed the provisioning
profile as "embedded.provisionprofile", rather than
"embedded.mobileprovision" (suspected root cause for
crbug.com/850890).
(2) Update DEPS to roll the corresponding reland from
chrome/installer/mac/internal.
Bug: 850890, 848052
Change-Id: I3f2134a5d587ec6c3c6e223ec7ef5283a9bece30
Reviewed-on: https://chromium-review.googlesource.com/1095597
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566257}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4d80b33e7c64069cb69041c4957ea77ecf6e14e8
This changes sign_app.sh to take a provisioning profile path as an
argument, which it will copy into the app bundle Content/ directory. It
then signs the app with --entitlements pointing at a newly created
entitlements.plist file, in order to grant the keychain-access-group
entitlement.
The entitlement is needed to create and access cryptographic key
material in the Secure Enclave Processor (SEP) on compatible macOS
devices.
Bug: 848052
Change-Id: Ib002fc73d250409e555f4caee8848a2c3e95e591
Reviewed-on: https://chromium-review.googlesource.com/1079833
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565027}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b69d8c48da838196d9655402dd739e62227762a7
Some web sites (like apple.com or llbean.com) build forms after the page
loading. This prevent using the server side type resolution.
Add a tracker to update the autofill forms regularly.
Bug: 798675
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ieaaf502a7bff38756d90bd96e94c058977dcab7b
Reviewed-on: https://chromium-review.googlesource.com/943321
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#544331}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: faebdb6d4f0f5e6458c9092e223e53d40de12e28
For unclear reasons, the build/util/LASTCHANGE file frequently contained
the hash of a local-only commit from a working branch, and the result
was a 404 error when trying to inspect a page in devtools.
To avoid this, add a --filter regex that is passed to "git log --grep",
defaulting to '^Change-Id:'. This header is present for the main
source tree and third_party/skia/ official commits.
BUG=760304
Change-Id: I9464ba37a1197872a7ffd31b8c2f1a2a85856276
Reviewed-on: https://chromium-review.googlesource.com/949312
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541137}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b0f0d1a7402a84cda225408e7396f6454148d4d4
This CL uses SSH reverse port forwarding to dynamically connect the test
suites running on Fuchsia to the Python-based test servers running on
the controlling machine.
Also adds a logging context to the spawning server library, so that the
verbosity of its logging output can be independently adjusted.
Change-Id: I6099ccc21efdd5e2e6b994e863f8d4b3dadaaae1
Reviewed-on: https://chromium-review.googlesource.com/907633
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535911}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49c9ff7f3b4c6ae5b17d764ee0ac83a37cb118d2
On android, adb is used to forward connections from the device to the
host, but there isn't a way to reserve the source port before deciding
which destination port on the host to forward it to. Change
RemoteTestServer reserve a port for AIA & OCSP, and forward it to another
port, like it already does on Fuchsia. Unlike Fuchsia, the second adb
forwarding step is still required to forward the connection from device to
host.
Change-Id: I739543fd0036f189928b5c7ce31c4d9a520e1cf0
Reviewed-on: https://chromium-review.googlesource.com/887171
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532946}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb27199b5bbf8706ca90fc0c6a6d42c21092f686
Previous implementation was slow when you put too many items in
the negative part of gtest filter (with positive part = *).
For net_unittests we have 2 mln fnmatch.fnmatch() calls.
Using one re match() instead of repetitive fnmatch() is much faster.
This change makes it more than 1000 times faster in heavy scenarios
(0.1 sec instead of 8 min for net_unittests with 100 negative items).
R=alexandermont@chromium.org, jbudorick@chromium.org
Bug: 783187
Change-Id: I70b0487e451cfc0457a683d4e1ef5de2a8bee732
Reviewed-on: https://chromium-review.googlesource.com/758853
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525737}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: da0240761319bc610c7c4121d76659c7364b79bb
Previously OCSP was broken with RemoteTestServer because OCSP server
port wasn't proxied.
1. Updated testserver.py to accept --ocsp-proxy-port-number argument
which makes it possible to generate correct cerificate for the
proxied connection.
2. Updated chrome_test_server_spawner.py to forward oscp server port.
3. Updated RemtoeTestServer to proxy OCSP connection.
4. Enabled OCSP tests on Fuchsia where they were previously failing.
Bug: 776575, 792300
Change-Id: Iedb1f5b26fc29ad0c73e78f450cd49335a424c18
Reviewed-on: https://chromium-review.googlesource.com/810096
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522634}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ee7c8db6b554120fb28385f8759695048f1d8612
This removes the manually-updated software_rendering_list and
gpu_driver_bug_list versions, replacing them with Chromium
git commit hashes. These hashes are used to generate
permalinks, like this one:
57c9d07b41/gpu/config/software_rendering_list.json
Bug: 772177
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id23a5e05506492999a43cd173e4659095f75fe4c
Reviewed-on: https://chromium-review.googlesource.com/728950
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510568}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96bd9ef90d95efa332485195e03c63477b90bb07
Adds a script that runs resource_sizes.py on two given APKs, diffing
the results. This is being added with the intention of using it to
measure the size impact of including VR, but should be usable to
measure the impact of any build flags, etc.
Bug: 759087
Change-Id: I1db06594d3c02cc6a0d90c44343e5c25281d6f4e
Reviewed-on: https://chromium-review.googlesource.com/657460
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501739}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 20e696b8cf4c1e0c941a8bcb113e99109a2f7379
1. Added ws server type in test server spawner.
2. Fixed a bug in testserver.py which prevented it from loading certs
with relative paths (because it has to chdir to the working dir)
3. Enabled some tests on Android and Fuchsia. The two tests that are
still disabled depend on basic-auth-proxy mode in testserver, which
doesn't work with RemoteTestServer.
Bug: 441711, 731302
Change-Id: Id8346111f260ead648a98b0854669d1211fe3393
Reviewed-on: https://chromium-review.googlesource.com/656758
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500722}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c786d33ad7886c8d656ded42b68b4d0746b6881
This is a reland of d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5
Original change's description:
> Update test server spawner to run multiple test servers in parallel
>
> Previously test server spawner didn't allow running more than one test
> server. With this change it's now possible to run multiple tests that
> depend on test_server in parallel.
> 1. Updated chrome_test_launch_spawner.py to support more than one
> test server. /kill now requires a get parameter to specify which
> server should be killed. Number of concurrent test servers is
> specified by test runner which instantiates the spawner.
> 2. Updated test runners for Android and Fuchsia to pass the new
> max_servers parameter for the spawner to match test parallelism
> on these platforms (1 on Android, 4 on Fuchsia).
>
> Bug: 731302
> Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
> Reviewed-on: https://chromium-review.googlesource.com/627339
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497967}
TBR=mmenke@chromium.org
Bug: 731302
Change-Id: I153632cf1fc946f0543a55108555644993a942a5
Reviewed-on: https://chromium-review.googlesource.com/642151
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498596}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62cf685519caeaffb848879e549b0e2dac11d25c
This reverts commit d15b34fd6a7c4775c6488fef1a4b7abd7f1c46e5.
Reason for revert: Broke net_unittests on Cronet bots
Original change's description:
> Update test server spawner to run multiple test servers in parallel
>
> Previously test server spawner didn't allow running more than one test
> server. With this change it's now possible to run multiple tests that
> depend on test_server in parallel.
> 1. Updated chrome_test_launch_spawner.py to support more than one
> test server. /kill now requires a get parameter to specify which
> server should be killed. Number of concurrent test servers is
> specified by test runner which instantiates the spawner.
> 2. Updated test runners for Android and Fuchsia to pass the new
> max_servers parameter for the spawner to match test parallelism
> on these platforms (1 on Android, 4 on Fuchsia).
>
> Bug: 731302
> Change-Id: I2e0e0c79dddb0b9f3745a444aae28e9235c3f126
> Reviewed-on: https://chromium-review.googlesource.com/627339
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497967}
TBR=phajdan.jr@chromium.org,mmenke@chromium.org,sergeyu@chromium.org,jbudorick@chromium.org
Change-Id: Ia8fbe198eddd3900665b18192f9ebfd0a2f08c75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731302
Reviewed-on: https://chromium-review.googlesource.com/642150
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498212}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 690dbd0f33566dfbeba1a9b88e6911adcfb4aa34
Drew Stonebraker
John Budorick
Samuel Huang
Xi Han
Eli Ribble
Raul Tambre
Maksim Ivanov
Yoshisato Yanagisawa
Xiyuan Xia
Alexander Alekseev
Andrew Luo
Dirk Pranke
Nico Weber
Takuto Ikuta
Scott Graham
Martin Kreichgauer
Olivier Robin
Klaus Weidner
Kevin Marshall
Matt Mueller
Dmitry Trofimovich
Sergey Ulanov
Kai Ninomiya
bsheedy
Sergey Ulanov