Eliminates NetworkListDetailedView and dependencies.
This mostly removes dead code, but also fixes the following
issues related to the old code:
* TrayNetwork::OnWillToggleWifi() ->
TrayNetwork::RequestToggleWifi() to toggle wifi directly
from Ash.
* Implement TrayNetwork::NetworkManagerChanged() so that
detailed views are notified when technology state changes.
* Eliminates unnecessary ash::SystemTrayDelegate
dependencies on network_menu_ when using new connection
handler code.
BUG=240859
For about_network.cc:
TBR=jamescook@chromium.org, jennyz@chromium.org
Review URL: https://codereview.chromium.org/15350002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@201322 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The close button in download pane should be the tab close button asset : tab_close_*.png (this was originally reported as part of BUG=173251).
By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).
The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed (this is handled by two separate committs to work around restriction on binary committs by newbies).
See https://codereview.chromium.org/12703022/ for added resources.
BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
Review URL: https://chromiumcodereview.appspot.com/12703039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190844 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Inconsistent use of [x] close panel icon
> The close button in download pane should be the tab close button asset : tab_close_*.png
> (this was originally reported as part of BUG=173251).
>
> By the same logic the same smaller bitmap with red hover background should be used for all infobars
> such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
> platforms (Mac was missed with the previous implementation).
>
> The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
>
> Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
> IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
> IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
> png files were also renamed.
>
> BUG=217094
> TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
>
> TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
>
> TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
>
> TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
>
> Review URL: https://codereview.chromium.org/12634025TBR=flackr@chromium.org
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190432 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The close button in download pane should be the tab close button asset : tab_close_*.png
(this was originally reported as part of BUG=173251).
By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).
The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed.
BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
Review URL: https://codereview.chromium.org/12634025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190431 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Mobile (Android and iOS).
Added a new page chrome://net-export to start/stop/send the net_log
for mobile platforms. net_log entries are saved in
"chrome-net-export-log.json" file created in temporary directory.
Button "Start Saving (after deleting old data)" will start saving to a
temporary file in "NetLog" directory in Temp directory. It deletes all
the old temporary files that were in that directory before creating a
new temporty file. It is a no-op if we are already saving data into a
file.
Button "Stop Saving Data" closes the temporary file so that it could
be mailed. It is a no-op if we haven't started saving data into a
file.
Button "Send Data" emails the data file if a temporary file exists in
"NetLog" directory. It is a no-op if there is no file.
There is only a single temporary file into which we log the
data. NetLog data is saved in the browser process. Logging of net_log
data behaves similar to the command line option --log-net-log.
If chrome://net-export is accessed in multiple tabs, action in first
tab wins. If Stop is clicked in any tab, logging stops. If start is
clicked in any tab, net logging starts.
about:about lists chrome://net-export as one of the links.
unit tests create a temporary file for each test run and they delete the
file at the end of the test run.
mmenke@ and/or eroman@ for chrome\browser\resources and webui changes.
jar@ for net_log_temp_file changes.
jhawkins@chromium.org for chrome\browser\ui\webui and chrome\browser\resources
OWNERS stamp.
R=jar@chromium.org, mmenke@chromium.org
BUG=151212
TEST=chrome://net-export
Review URL: https://chromiumcodereview.appspot.com/11828036
git-svn-id: http://src.chromium.org/svn/trunk/src/build@180026 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
of net_internal's HTML and JS to ios's grit_whitelist.
Disabled Firefox settings for iOS ala Android.
Set FTP transaction factory if DISABLE_FTP_SUPPORT is not set.
Used ProxyService::CreateUsingSystemProxyResolver instead of
net::CreateProxyServiceUsingV8ProxyResolver because V8 is
used on IPHone.
Temporarily ifdef'ed out webkit_glue::ResourceLoadTimingInfo
for IOS in load_timing_observer. load_timing_observer is going
away per mmenke. Thus change to load_timing_observer.h and
load_timing_observer.cc will be deleted.
R=droger@chromium.org, mmenke@chromium.org
BUG=151212
Review URL: https://chromiumcodereview.appspot.com/11450023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@172789 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Several auxiliary tools used when building Chrome for iOS are generated via the
following two-step pattern: (1) compiling the executable with ninja, and (2)
copying the executable into a location that is shared with other projects.
Previously, these two steps were specified as actions in the same target.
However, as the ordering of multiple actions in one target is defined only by
inputs and outputs and the compilation action had no inputs/outputs set, the
copying action wasn't properly depending on the compilation action.
As it's challenging to set correct inputs for the ninja build, this CL
separates these actions into two targets in order to be able to specify that
the second action should not run until the first action finishes.
Review URL: https://chromiumcodereview.appspot.com/11301003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@164743 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The mac_build.gypi is used to build Mac targets via ninja. The template runs gyp_chromium to generate a ninja project file, then gyp target that includes the template should include an action to run ninja for the desired targets.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10826169
git-svn-id: http://src.chromium.org/svn/trunk/src/build@150357 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
stevenjb@chromium.org
palmer@chromium.org
justincohen@google.com
stuartmorgan@chromium.org
varkha@chromium.org
flackr@chromium.org
fischman@chromium.org
rohitrao@chromium.org
rtenneti@chromium.org
jam@chromium.org
lliabraa@chromium.org
qsr@chromium.org
chenyu@chromium.org
msarda@chromium.org
blundell@chromium.org