The NMR1 SDK has been published upstream, so BuildInfo#isGreaterThanN is
no longer needed. This patch also removes reflection for
UserManager#isDemoUser() and ShortcutManager#reportShortcutUsed(),
and updates AndroidManifest.xml to remove the conditional include
of launchershortcut.xml and network_security_config.xml.
BUG=707302
Review-Url: https://codereview.chromium.org/2785373004
Cr-Original-Commit-Position: refs/heads/master@{#461787}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df46c2242e4635dc77fce945bfc0ea0089efee31
Previously, we only logged gtest stdout as part of parsing the
stdout to determine the test results. When using XML parsing
(i.e., when a user passed --enable-xml-result-parsing), stdout
was not logged.
This CL ensures we log the stdout in both cases.
BUG=707373
Review-Url: https://codereview.chromium.org/2793133003
Cr-Original-Commit-Position: refs/heads/master@{#461705}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00314619b481948fcaeed5cf5e607232a7e55d2d
Adding frameworks jar build from the android-7.1.1_r28 tag
in AOSP.
Bug:707823
Change-Id: Ifbe2c91aa1b495b0959b5de026bc9fd690474b12
Reviewed-on: https://chromium-review.googlesource.com/466631
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Michael Case <mikecase@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#461605}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2b501b65e0987b4f2a23561a4906eb02f955a40
- Better explain what this component does.
- Add a detailed description for replace_gn_files.py.
- Format text to fit in 72 columns.
- Mention GN build files.
Review-Url: https://codereview.chromium.org/2783293002
Cr-Original-Commit-Position: refs/heads/master@{#461186}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5864d312aa006009fb4734c59320f04f2d6dceb2
Adding support to use Robolectric's play-services shadow
classes. Removing a custom shadow class we had in Chromium
now that the same shadow is available in Robolectric.
BUG=693660
Review-Url: https://codereview.chromium.org/2760743002
Cr-Original-Commit-Position: refs/heads/master@{#460906}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 476fddc51fb5cf133f2ce351c6805e65f4cbc4dd
When doing x64 builds of Chrome with VC++ we compile some modules
(currently just libyuv) with clang, in order to get inline assembly
support. This causes problems on /analyze builds because clang-cl
doesn't understand the /analyze compiler switches. This change
disables /analyze for those files that are compiled with clang.
With this change I can do a /analyze build of libyuv without
hitting any errors, but warnings are emitted as appropriate.
R=brettw@chromium.org
BUG=427616
Review-Url: https://codereview.chromium.org/2786733005
Cr-Original-Commit-Position: refs/heads/master@{#460874}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb4bb0ebf2bfc2881100122e1513ee3f694744a0
It appears the "*" path in the case statement is never
matched due to the double-quotes (tested with bash 4.3.11 on
Trusty 14.04). Removing the quoting aligns with other case
statements in the script, and solves the problem. This bug
made https://codereview.chromium.org/2650823010 not have any
effect, which was discovered when deploying ARM 64 bots for
WebRTC.
BUG=684356,webrtc:7024
Review-Url: https://codereview.chromium.org/2790453002
Cr-Original-Commit-Position: refs/heads/master@{#460733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95504aea9818ec4e593358d0373f9c41531a3b67
Create an OWNERS file for this directory and add myself as well. This is
preparation for using a shared FreeType between Blink and PDFium, but
not actually used as a depedency to any Windows targets yet.
BUG=700926
Review-Url: https://codereview.chromium.org/2781773003
Cr-Original-Commit-Position: refs/heads/master@{#460211}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e15f5107bfba9080481fd78ed35c69c81fc41ac3
Currently, logcats are very difficult to find in bot logs. Adding
logging to log the logdog links.
In the future, these links will get moved out of the python logs
and into the result detail HTML page.
Review-Url: https://codereview.chromium.org/2777103004
Cr-Original-Commit-Position: refs/heads/master@{#460151}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2753f4dd3d49fddb16c538feddb125c92cc0fe23
llvm-ar is faster and is capable of handling
LLVM bitcode files without a need for a Gold plugin.
BUG=660216,607968
Review-Url: https://codereview.chromium.org/2766333002
Cr-Original-Commit-Position: refs/heads/master@{#460129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8968cd5170f4a22b1c508ffa3bc240b346c44b1b
When building a custom framework, the framework and the framework_dir
flags need to be added to the command-line of every linkable target
the depends directly or indirectly on it. GN propagates properly the
framework as it knows about "libs", but the -F flag added to ldflags
need to be propagated using all_dependent_configs.
BUG=704946
Review-Url: https://codereview.chromium.org/2778813002
Cr-Original-Commit-Position: refs/heads/master@{#460071}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5376139411f2b362d24abc27425f3827697a46d4
Chrome has not built with VS 2013 for a while now, so no need to carry
that baggage around as we add VS 2017 support.
Review-Url: https://codereview.chromium.org/2771333002
Cr-Original-Commit-Position: refs/heads/master@{#459876}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e7c0d998d5416b380ffefe1f6acd6126e35d11ed
This change contains two parts, for full-symbol (symbol_level=2, default)
and reduced-symbol (symbol_level=1) debug builds. It has no effect on release
builds.
1.) For symbol_level=2, pass -Wl,--gdb-index to the linker. This lets the linker
write an index that lets it load binaries much faster.
gdb startup time for target chrome from goes from 60s to 10s and time from
`run` in gdb to the program actually starting from 270s to 45s.
In return, this slows down linking a bit, but for target chrome in a
debug build, it increases link time from 37s to 42s, which is better than
making people who want to use gdb wait several minutes every time they start
gdb.
There's some history here: We used to pass -Wl,--gdb-index long ago, and
then removed it in https://codereview.chromium.org/335903002/, with the
recommendation that people who want to use gdb could run build/gdb-add-index.
But running `gdb-add-index chrome` takes 73s nowadays, a lot more than the 5s
that gold needs. (Back then, gdb-add-index was faster, and gold, due to us
not yet defaulting to component builds in debug builds, was slower. Also,
people were on an older default Ubuntu and used an older gdb version.)
People who don't use gdb should use symbol_level=1 for their builds anyhow
(and bots do too), so this small regression in link time shouldn't affect
them.
Remove the explicit gdb_index gn arg now that this has a good default.
2) For symbol_level=1, make this mode actually work again after the gn swtich.
In symbol_level=1 builds, gn would pass `-g1 -gsplit-dwarf` to clang (*).
Surprisingly, -gsplit-dwarf implies -g2 with clang, so the -g1 gets
overriden by -g2 immediately.
Before this, symbol_level=1 in debug builds would produce full debug info.
Since all bots set symbol_level=1, this might help with build speed
on debug bots. For people who set this locally, it'll also speed up
gdb startup time for target chrome from 39s to 13s and time from
`run` in gdb to the program actually starting from 255s to 35s.
*: clang always writes stack debug info to both .o and .dwo files, and lets
the linker link them into the executable, so -g1 -gsplit-dwarf would make
no sense. This was used as justification to make -gsplit-dwarf imply -g2,
as it otherwise wouldn't have an effect.
BUG=374952
R=piman@chromium.org, tansell@chromium.org
Review-Url: https://codereview.chromium.org/2770933009
Review-Url: https://codereview.chromium.org/2770933009 .
Cr-Original-Commit-Position: refs/heads/master@{#459824}
Committed: 7b26c51270
Cr-Original-Original-Commit-Position: refs/heads/master@{#459790}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b9f7581b93ae8096afed29d415791803caf2e2e3
Reason for revert:
Suspicion that it cause a compile failure on https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/65207
Original issue's description:
> linux: Improve gdb startup time for debug builds from over 4 minutes to 35s.
>
> This change contains two parts, for full-symbol (symbol_level=2, default)
> and reduced-symbol (symbol_level=1) debug builds. It has no effect on release
> builds.
>
> 1.) For symbol_level=2, pass -Wl,--gdb-index to the linker. This lets the linker
> write an index that lets it load binaries much faster.
> gdb startup time for target chrome from goes from 60s to 10s and time from
> `run` in gdb to the program actually starting from 270s to 45s.
> In return, this slows down linking a bit, but for target chrome in a
> debug build, it increases link time from 37s to 42s, which is better than
> making people who want to use gdb wait several minutes every time they start
> gdb.
>
> There's some history here: We used to pass -Wl,--gdb-index long ago, and
> then removed it in https://codereview.chromium.org/335903002/, with the
> recommendation that people who want to use gdb could run build/gdb-add-index.
> But running `gdb-add-index chrome` takes 73s nowadays, a lot more than the 5s
> that gold needs. (Back then, gdb-add-index was faster, and gold, due to us
> not yet defaulting to component builds in debug builds, was slower. Also,
> people were on an older default Ubuntu and used an older gdb version.)
>
> People who don't use gdb should use symbol_level=1 for their builds anyhow
> (and bots do too), so this small regression in link time shouldn't affect
> them.
>
> Remove the explicit gdb_index gn arg now that this has a good default.
>
> 2) For symbol_level=1, make this mode actually work again after the gn swtich.
> In symbol_level=1 builds, gn would pass `-g1 -gsplit-dwarf` to clang (*).
> Surprisingly, -gsplit-dwarf implies -g2 with clang, so the -g1 gets
> overriden by -g2 immediately.
>
> Before this, symbol_level=1 in debug builds would produce full debug info.
> Since all bots set symbol_level=1, this might help with build speed
> on debug bots. For people who set this locally, it'll also speed up
> gdb startup time for target chrome from 39s to 13s and time from
> `run` in gdb to the program actually starting from 255s to 35s.
>
> *: clang always writes stack debug info to both .o and .dwo files, and lets
> the linker link them into the executable, so -g1 -gsplit-dwarf would make
> no sense. This was used as justification to make -gsplit-dwarf imply -g2,
> as it otherwise wouldn't have an effect.
>
> BUG=374952
>
> Review-Url: https://codereview.chromium.org/2770933009
> Cr-Commit-Position: refs/heads/master@{#459790}
> Committed: 7b26c51270TBR=dpranke@chromium.org,piman@chromium.org,tansell@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=374952
Review-Url: https://codereview.chromium.org/2776193002
Cr-Original-Commit-Position: refs/heads/master@{#459800}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 745ab003bddd9043058e1f19db831a9b4f0f6dbf
baxley
sandv
twellington
kjellander
jbudorick
Mike Case
michaeldo
perezju
wychen
hzl
brucedawson
Nico Weber
thestig
jochen
rsesek
mikecase
findit-for-me
agrieve
jshin
Pawel Hajdan, Jr
krasin
drott
thomasanderson
sdefresne
machenbach
satorux
jwd