With this change linux_arm bot now gets past the isolate_tests
phase and fails when trying to run the tests on swarming.
BUG=564059
Review-Url: https://codereview.chromium.org/2550663003
Cr-Original-Commit-Position: refs/heads/master@{#436375}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e1e756db7c44f44ce809170d12865341cb6c1ad5
The documentation for forward_variables_from specifies that it will give an error if the variable already exists in the target scope. But this was not implemented. Instead, the value would be silently overwritten.
This change implements the error, and fixes the times this happens in the Linux and Android builds.
Review-Url: https://codereview.chromium.org/1943583002
Cr-Original-Commit-Position: refs/heads/master@{#391136}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0785c950dce7221b10c21e911795e181076b90db
PPAPI extensions tests use the same structure as NaCl browser tests and
as such can use the same template which was refactored and moved to
a .gni file which is now used by both types of tests.
BUG=462791, 512900
Review URL: https://codereview.chromium.org/1521843002
Cr-Original-Commit-Position: refs/heads/master@{#365369}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b460625d15a1ea80272d125a63233d823d095a1d
Non-SFI uses PNaCl toolchain, but pexes need to be pre-translated
for the target platform, and the nmf format is different hence
requiring a different action.
BUG=462791
Review URL: https://codereview.chromium.org/1494423002
Cr-Original-Commit-Position: refs/heads/master@{#364442}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92e64362e9e2f615b1aef34c069ce78a3713dfe0
This changes enables chrome for MIPS (Linux and Android)
to be compiled with clang when using gn build.
However, there are still few issues for build to complete successfully:
- "treat_warnings_as_errors=false" must be set for both Android and Linux.
- in case of Linux ldflags retreived by 'exec_script("sysroot_ld_path.py",..'
are ignored by linker, which is causing link failure for 'chrome' target.
BUG=gn gen for MIPS
TEST=gn gen out-gn/mips --args="is_debug=false target_os=\"android\" target_cpu=\"mipsel\" is_clang=true treat_warnings_as_errors=false"
ninja -C out-gn/mips chrome_public_apk
Review URL: https://codereview.chromium.org/1475943003
Cr-Original-Commit-Position: refs/heads/master@{#362002}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: af7fa747c3c2e433028103b45173c0275333abc7
PNaCl doesn't provide objdump, so use NaCl newlib version when
generating nmf files for PNaCl since the create_nmf.py script requires
objdump to be set.
BUG=462791
Review URL: https://codereview.chromium.org/1449223002
Cr-Original-Commit-Position: refs/heads/master@{#359970}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 102f32212c2e08281d38f59a802377934318680e
The toolchain executables have the ".exe" suffix on Windows. Plumb
through the readelf, nm, and strip tools for NaCl toolchains. These
were accidentally using default host tools, which happen to work on
other host platforms, but don't exist on Windows.
BUG= 512869
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1447533005
Cr-Original-Commit-Position: refs/heads/master@{#359715}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 34fa90d65772e8b432d5c37cd607ed6d6dcc5ca0
With a simple tweak, the toolchain already knows how to strip the
nexe and leave the unstripped nexe where it can be found. After
that, the unstripped nexe can just be copied as the .debug file and
a single objcopy command suffices to annotate the stripped file with
a pointer to the .debug file.
Also factor out computations about toolchain directory names into
//build/config/nacl/config.gni where they can be reused.
BUG= 546352
R=bbudge@chromium.org, dpranke@chromium.org
Review URL: https://codereview.chromium.org/1415293005
Cr-Original-Commit-Position: refs/heads/master@{#356340}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7a379aa7f9ff6fe49bd441869887c7b517a1a0a0
Drop _BSD_SOURCE and _DEFAULT_SOURCE defines, which are redundant with
_GNU_SOURCE on Linux. This brings the set affecting Linux in line with
the standalone NaCl build.
Conditionalize these defines to affect only Linux, Android, and NaCl
toolchains. That is, none of these are used on Mac (or Windows). This
makes the GN build consistent with the GYP and Scons builds. On Mac,
defining _POSIX_C_SOURCE (without also defining _DARWIN_C_SOURCE) makes
the system headers disable some symbols that NaCl sources need.
BUG=545236
R=dpranke@chromium.org, mseaborn@chromium.org
Review URL: https://codereview.chromium.org/1408273003
Cr-Original-Commit-Position: refs/heads/master@{#355327}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2640ff9632d74c85964e100b34811f90569fe510
The NaCl IRT is a special case and needs to be built with specific
code-generation and optimization options (we also always want debug
symbols). This plumbs through an is_nacl_irt variable that configs
can test, and uses that to make the standard configs do the right
thing. The resulting compiler and linker flags are a close
approximation of what GYP uses.
BUG= 531702
R=dpranke@chromium.org, dschuff@chromium.org
Review URL: https://codereview.chromium.org/1397953002
Cr-Original-Commit-Position: refs/heads/master@{#353385}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0b9de3622acdbc1fba625094b369090f65145b78
With this change, in the Chromium repo NaCl will now be built solely using Chromium's versions of the GN build files, rather than a mixture of chromium and NaCl files.
This will allow us to delete the NaCl versions in a subsequent NaCl-side CL and switch to pulling the chromium versions in via a DEPS entry, and thus "unfork" the build.
R=brettw@chromium.org, ncbray@chromium.org, mcgrathr@chromium.org
BUG=433528
Review URL: https://codereview.chromium.org/1312813003
Cr-Original-Commit-Position: refs/heads/master@{#346452}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fa6ffe2fb9f488ddb859555f5abc29de72407a62
sbc
mcgrathr
brettw
agrieve
phosek
Gordana.Cmiljanovic
mseaborn
dpranke