Граф коммитов

4 Коммитов

Автор SHA1 Сообщение Дата
brettw e93212eebd Enable header checking for chrome/browser/ui
This disables header checking for split static libraries. In addition to the internal issues discussed in the added comment to split_static_library.gni, there is a circular include cycle between //chrome/browser and //chrome/browser/ui. Both of these are split static libraries, so enabling check for this configuration would additionally require listing all of the split ui targets in the allow_circular_includes_from annotation in the browser target.

Since this is only for official builds, we still get header checking on the normal builds so there should be no missing coverage for header checking.

R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2363083003
Cr-Original-Commit-Position: refs/heads/master@{#420705}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b3e6014f6994d0eb4abe1a60ca4ceb580f73ad9b
2016-09-23 19:57:38 +00:00
brettw 9a19321fbd Make webkit_modules a split static library in non-component builds.
Previously this was forced to a source set because it was too large for official Windows builds to handle as a static library.

This uses the split_static_library template for non-component official Windows builds so it can be a static library now.

Updates the split_static_library template to handle the case where an output name is specified.

BUG=627637
Previously landed version of http://crrev.com/2145253003 with addition of split_static_library change.

Review-Url: https://codereview.chromium.org/2145753007
Cr-Original-Commit-Position: refs/heads/master@{#405797}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 251c55188818138cba319ca20d843b30c71d3137
2016-07-15 18:23:16 +00:00
brettw f66fa5e68f Separate out target defaults in the GN build config.
This separates out the default values of configs for the various target types into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the places where those templates are defined rather than putting them all in BUILDCONFIG. An example of this is the test() target defaults, where the actual template is declared in a .gni file but the defaults have to be global.

Review-Url: https://codereview.chromium.org/2150753002
Cr-Original-Commit-Position: refs/heads/master@{#405627}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: edb6ecc9667278999e8b885a4e79849887580d2d
2016-07-14 23:38:48 +00:00
brettw a261670439 Use split_static_library in GN build.
This is a new function of GN that allows us to automatically split large
static libraries on Windows where the size becomes too large.

BUG=

Review-Url: https://codereview.chromium.org/2105513002
Cr-Original-Commit-Position: refs/heads/master@{#402883}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f760b440babafea496f1a13aef7b984ba85a0df6
2016-06-29 19:00:55 +00:00