Reason for revert:
The actual crash was in OmahaClient, which is fixed in: http://crrev.com/1856823002
Original issue's description:
> Revert of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1838173005/ )
>
> Reason for revert:
> Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830
>
> Original issue's description:
> > Propagate is_official_build to version script.
> >
> > OFFICIAL_BUILD is a special variable in the version script which
> > takes its value from the environment variable. This means that local
> > builds with is_official_build will not actually result in
> > ChromeVersionConstants.isOfficialBuild() returning true.
> >
> > This CL propagates the is_official_build truthiness to the script so
> > official builds no longer depend solely on the environment variable.
> >
> > BUG=599268
> >
> > Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
> > Cr-Commit-Position: refs/heads/master@{#384340}
>
> TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=599268
>
> Committed: https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b
> Cr-Commit-Position: refs/heads/master@{#384610}
TBR=agrieve@chromium.org,thestig@chromium.org,skyostil@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=599268
Review URL: https://codereview.chromium.org/1856843002
Cr-Original-Commit-Position: refs/heads/master@{#385007}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 87d01a7e475b0785364328af5b22b15b28a40e66
Reason for revert:
Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830
Original issue's description:
> Propagate is_official_build to version script.
>
> OFFICIAL_BUILD is a special variable in the version script which
> takes its value from the environment variable. This means that local
> builds with is_official_build will not actually result in
> ChromeVersionConstants.isOfficialBuild() returning true.
>
> This CL propagates the is_official_build truthiness to the script so
> official builds no longer depend solely on the environment variable.
>
> BUG=599268
>
> Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
> Cr-Commit-Position: refs/heads/master@{#384340}
TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=599268
Review URL: https://codereview.chromium.org/1851843002
Cr-Original-Commit-Position: refs/heads/master@{#384610}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 756e9b934bf1d706dd59ab39bed2af842b67063b
OFFICIAL_BUILD is a special variable in the version script which
takes its value from the environment variable. This means that local
builds with is_official_build will not actually result in
ChromeVersionConstants.isOfficialBuild() returning true.
This CL propagates the is_official_build truthiness to the script so
official builds no longer depend solely on the environment variable.
BUG=599268
Review URL: https://codereview.chromium.org/1838173005
Cr-Original-Commit-Position: refs/heads/master@{#384340}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eab85df0275b825e428954c4030e358ce968ecd9
Rewrite the argument handling code using argparse. It allows us to get
rid of a lot of manual parsing as well as the whole help message.
In addition, it fixes a few other bugs present in the previous
implementation:
- Passing 3 or more arguments that are not values for parameters would
cause an infinite loop.
- The "--template" option was not allowed (only its short form "-t"
was).
R=mark@chromium.org, brettw@chromium.org
Review URL: https://codereview.chromium.org/336513002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@277450 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
wnwen
skyostil
raphael.kubo.da.costa@intel.com
mad@chromium.org