This reverts commit 8700df8a8aef14e8d88dec7668be4b4e16c7c204.
Reason for revert:
Android builders started failing since this commit:
https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/217957
Traceback (most recent call last):
File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 105, in Main
ret = self.args.func()
File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 378, in CmdGen
return self.RunGNGen(vals)
File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 961, in RunGNGen
ret = self.GenerateIsolates(vals, isolate_targets, isolate_map, build_dir)
File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1075, in GenerateIsolates
command, extra_files = self.GetIsolateCommand(target, vals)
File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1392, in GetIsolateCommand
'generated_scripts can no longer customize the script path')
AssertionError: generated_scripts can no longer customize the script path
Original change's description:
> Rename wrapper_scripts for generated_script tests in MB.
>
> A few tests (some Android resource_sizes tests, and one Perfetto
> test), were using generated_script tests that were generating
> wrappers that weren't named 'bin/run_$target_name'.
>
> We want all generated_script tests to be using consistent names, so
> this CL changes those targets.
>
> Bug: 816629
> Change-Id: If447fbee6b33637de4c9711e87379128272285af
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802694}
TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 816629
Change-Id: I11ec06405105860f01f3b7752df2024615f7badc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384069
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802984}
GitOrigin-RevId: 56428611ac02c50b40bdb2d951f9d94e5a4bb617
The "generic_wrapper" scripts now being generated during the build
need to know whether or not to use Xvfb when running a test; this
CL adds that logic.
Bug: 816629
Change-Id: Ic2cae1295d7edf583236d6d2640c220c883324ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370507
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802875}
GitOrigin-RevId: 79d065d7fabdb164567f71d063f6a09e6a4f1422
This reverts commit 8ce938a2f69dcd0ad814f5045d30ba13d99b910e.
Reason for revert: <Suspect this CL breaks Linux FYI Ozone bot and Linux FYI SkiaRenderer Vulkan (NVIDIA)/(Intel HD 630) >
Original change's description:
> Reland "Reland "X11 and Ozone: enable use_x11 and use_ozone""
>
> This is a reland of 75363679c701c78fac57dea6b816f4c21c80bf5e
>
> Original change's description:
> > Reland "X11 and Ozone: enable use_x11 and use_ozone"
> >
> > This is a reland of f985905ebdd488c63b7819a65c817aa98fb8da49.
> >
> > This change broke our headless build:
> > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed.
> > assert(ozone_platform_x11)
> > ^-----
> > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included.
> > "//ui/events/platform/x11",.
> >
> > Fix:
> > Don't include x11 build for headless case.
> >
> > Original change's description:
> > > X11 and Ozone: enable use_x11 and use_ozone
> > >
> > > This is the final change that enables use_x11
> > > and use_ozone for Linux builds and (as it was
> > > before) excludes X11 for chromeos, chromecast,
> > > lacros.
> > >
> > > in order to run ozone/X11/wayland, one must pass
> > > —enable-features=UseOzonePlatform
> > > —ozone-platform=x11 or wayland. otherwise,
> > > non-ozone/X11 is used.
> > >
> > > it’s also possible to completely disable X11
> > > so that clients, who need that kind of build can
> > > continue to have that.
> > >
> > > Bug: 1085700
> > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> > > Cr-Commit-Position: refs/heads/master@{#801523}
> >
> > Bug: 1085700
> > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#801692}
>
> Bug: 1085700
> Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802773}
TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com
Change-Id: I093bf5be51d6858d895c59d6bb31f3aa61c162b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1085700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383110
Reviewed-by: Maggie Chen <magchen@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802855}
GitOrigin-RevId: fdfbaf2ed4f136be6601c3b546264590c7f48749
This reverts commit 4f9f15981caeba46dae541d3fe1b30661f8b8389.
The CL being reverted causes cronet_test_instrumentation_apk to crash
on builder "android-cronet-marshmallow-arm64-rel".
Bug: 1115229
Change-Id: I2b177353b00a57befe488e0bbef242a2b585162c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376316
Auto-Submit: Nick Harper <nharper@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802814}
GitOrigin-RevId: 4727f47b25685107217c4c285a0f7c050db451c5
local runs would be ran with:
rdb stream -new -realm chromium:public ./out/Debug/bin/run_net_unittests
--result-sink-upload
Need to add --result-sink-upload to recipes. The rdb stream will be
active on the bots, as a gn.arg
Bug: 1104245,1104238
Change-Id: I8cbc9246110c28579e11c26ed92aad133a187a18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365216
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802776}
GitOrigin-RevId: 711a12e4beef80e144dfc2c23feb4efa3ae50a3c
This is a reland of 75363679c701c78fac57dea6b816f4c21c80bf5e
Original change's description:
> Reland "X11 and Ozone: enable use_x11 and use_ozone"
>
> This is a reland of f985905ebdd488c63b7819a65c817aa98fb8da49.
>
> This change broke our headless build:
> ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed.
> assert(ozone_platform_x11)
> ^-----
> See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included.
> "//ui/events/platform/x11",.
>
> Fix:
> Don't include x11 build for headless case.
>
> Original change's description:
> > X11 and Ozone: enable use_x11 and use_ozone
> >
> > This is the final change that enables use_x11
> > and use_ozone for Linux builds and (as it was
> > before) excludes X11 for chromeos, chromecast,
> > lacros.
> >
> > in order to run ozone/X11/wayland, one must pass
> > —enable-features=UseOzonePlatform
> > —ozone-platform=x11 or wayland. otherwise,
> > non-ozone/X11 is used.
> >
> > it’s also possible to completely disable X11
> > so that clients, who need that kind of build can
> > continue to have that.
> >
> > Bug: 1085700
> > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#801523}
>
> Bug: 1085700
> Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#801692}
Bug: 1085700
Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802773}
GitOrigin-RevId: 8ce938a2f69dcd0ad814f5045d30ba13d99b910e
A few tests (some Android resource_sizes tests, and one Perfetto
test), were using generated_script tests that were generating
wrappers that weren't named 'bin/run_$target_name'.
We want all generated_script tests to be using consistent names, so
this CL changes those targets.
Bug: 816629
Change-Id: If447fbee6b33637de4c9711e87379128272285af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802694}
GitOrigin-RevId: 8700df8a8aef14e8d88dec7668be4b4e16c7c204
This reverts commit dbecad0d008bd8ef3169b241c20e688dce0c0223.
Change-Id: I032d41a62c0a0072bab3383404604d1ea572b7cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375690
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802642}
GitOrigin-RevId: 3c1ba31cf20fd902cc8482710e67c6b5bede30c8
These were temporarily disabled to allow a multi-sided merge.
Tbr: bialpio@chromium.org
Bug: 1113301
Change-Id: I1d9ef778868e89547ef42117cfb804304558890f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376028
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802501}
GitOrigin-RevId: 615444a51cb6fc9cc23305da43f5b93bde733a4c
This is a reland of c332bdd051fed917e4aaff2fe211e8b24b936e69
Original change's description:
> Roll sysroots
>
> This is needed after [1] changed the libwayland-client symbols file.
>
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/2379674
>
> R=msisov
>
> Change-Id: Iffada22847663b5a9ca3973d45f7a0a2c93fedd5
> Bug: 1116384
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380370
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#802266}
Bug: 1116384
Change-Id: I7794af648f513aaadad8b414c90e6fc8fea02c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380932
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802468}
GitOrigin-RevId: 6592af7941d479a9b05568c541e075ba4fc7f126
This is unused, and now that we have an expectations file this should still
be easy enough to audit.
Change-Id: Ic48e76ed4e1b90e351c27a350cf82d3f6b0fea6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380576
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802443}
GitOrigin-RevId: 911c0aaf96e5ee85bcd921f6170b1ac71998c483
This is a reland of f1d35ca278d3e96e16ee9ca91503eadfd5e1426e
Original change's description:
> linux sysroot: fix libwayland-client-symbols file.
>
> I initially generated it by myself and made a huge mistake by
> setting base version to a single version. However, some symbols
> only appeared after certain version. Thus, fix that problem by
> copying and using the symbols file from wayland packages
> in https://git.launchpad.net/ubuntu/+source/wayland.
>
> Bug: 1116384
> Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674
> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802226}
Bug: 1116384
Change-Id: I0bbdcc98f0c88d414edef74db8b38e30249cbc08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380318
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802405}
GitOrigin-RevId: f970623b8d007431b4c6d5117686beb81dde4d22
Allow git to ignore build/fuchsia/internal directory.
Make DeviceTarget generic class for non-emulator targets that don't need provisioning.
Replace original DeviceTarget with GenericX64Target, for provisioning devices with generic x64 build.
Bug: 1080854
Change-Id: I2e70a85689ce9527b86bcb5eeb24895119454da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343228
Commit-Queue: Chong Gu <chonggu@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#802392}
GitOrigin-RevId: 2a8d57b91300475fb998241d48e4478a3f4fb8ee
There is no longer a need to use E1000 under x64, and Fuchsia defaults
to virtio-net-pic for both architectures.
Bug: fuchsia:59041
Change-Id: I817bc69e84e4b024db6b9e3d8ee8fabe2502a552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379718
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802343}
GitOrigin-RevId: f6b2688c65634640bd347cdb534b53109766636f
This reverts commit f1d35ca278d3e96e16ee9ca91503eadfd5e1426e.
Reason for revert: Looks like this broke the linux-lacros-rel bot: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel?limit=200
Original change's description:
> linux sysroot: fix libwayland-client-symbols file.
>
> I initially generated it by myself and made a huge mistake by
> setting base version to a single version. However, some symbols
> only appeared after certain version. Thus, fix that problem by
> copying and using the symbols file from wayland packages
> in https://git.launchpad.net/ubuntu/+source/wayland.
>
> Bug: 1116384
> Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674
> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802226}
TBR=thomasanderson@chromium.org,msisov@igalia.com
Change-Id: Ia285ce4239ba8e9841476fd5dc890252a713f8fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380105
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802319}
GitOrigin-RevId: bfd1675cc013556c2a2768d08753c34dae8b9c81
This is needed after [1] changed the libwayland-client symbols file.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2379674
R=msisov
Change-Id: Iffada22847663b5a9ca3973d45f7a0a2c93fedd5
Bug: 1116384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380370
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#802266}
GitOrigin-RevId: c332bdd051fed917e4aaff2fe211e8b24b936e69
I initially generated it by myself and made a huge mistake by
setting base version to a single version. However, some symbols
only appeared after certain version. Thus, fix that problem by
copying and using the symbols file from wayland packages
in https://git.launchpad.net/ubuntu/+source/wayland.
Bug: 1116384
Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674
Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802226}
GitOrigin-RevId: f1d35ca278d3e96e16ee9ca91503eadfd5e1426e
This reverts commit 75363679c701c78fac57dea6b816f4c21c80bf5e.
Reason for revert: Looks like it broke linux trusty bot
Original change's description:
> Reland "X11 and Ozone: enable use_x11 and use_ozone"
>
> This is a reland of f985905ebdd488c63b7819a65c817aa98fb8da49.
>
> This change broke our headless build:
> ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed.
> assert(ozone_platform_x11)
> ^-----
> See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included.
> "//ui/events/platform/x11",.
>
> Fix:
> Don't include x11 build for headless case.
>
> Original change's description:
> > X11 and Ozone: enable use_x11 and use_ozone
> >
> > This is the final change that enables use_x11
> > and use_ozone for Linux builds and (as it was
> > before) excludes X11 for chromeos, chromecast,
> > lacros.
> >
> > in order to run ozone/X11/wayland, one must pass
> > —enable-features=UseOzonePlatform
> > —ozone-platform=x11 or wayland. otherwise,
> > non-ozone/X11 is used.
> >
> > it’s also possible to completely disable X11
> > so that clients, who need that kind of build can
> > continue to have that.
> >
> > Bug: 1085700
> > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#801523}
>
> Bug: 1085700
> Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#801692}
TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com
Change-Id: I6c4e523808341b75c0f734492ac71cb2b9767617
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1085700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377814
Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#802108}
GitOrigin-RevId: cd648bbc0ec0302175821dc72fbf9e9855fa4229
https://crrev.com/c/2300380 is failing to build on android_cronet
bot due to a conflict in GN settings between
use_allocator=="partition" and use_partition_alloc=false.
Ideally, we shouldn't have two flags and we'd better to remove
use_partition_alloc in future. This patch mitigates the issue
by prioritizing use_allocator over use_partition_alloc.
Bug: 998048
Change-Id: I293a884186dfa9804930b835ba236efb818a761d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368797
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801737}
GitOrigin-RevId: 24622fa5673f6a05341cb5b6841dac331f3bfcb0
This is a reland of f985905ebdd488c63b7819a65c817aa98fb8da49.
This change broke our headless build:
ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed.
assert(ozone_platform_x11)
^-----
See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included.
"//ui/events/platform/x11",.
Fix:
Don't include x11 build for headless case.
Original change's description:
> X11 and Ozone: enable use_x11 and use_ozone
>
> This is the final change that enables use_x11
> and use_ozone for Linux builds and (as it was
> before) excludes X11 for chromeos, chromecast,
> lacros.
>
> in order to run ozone/X11/wayland, one must pass
> —enable-features=UseOzonePlatform
> —ozone-platform=x11 or wayland. otherwise,
> non-ozone/X11 is used.
>
> it’s also possible to completely disable X11
> so that clients, who need that kind of build can
> continue to have that.
>
> Bug: 1085700
> Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#801523}
Bug: 1085700
Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#801692}
GitOrigin-RevId: 75363679c701c78fac57dea6b816f4c21c80bf5e
Some linux version might not like the '#' in the file name, replace it with well supported characters.
Run this on arm64-rel CQ bot and it works.
Bug: 1096656
Change-Id: Id589214dd473315b85698fcc60677f3d94772cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373042
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#801673}
GitOrigin-RevId: 504fed75640a81c0c79e04f4261db0a61de3cd62
This reverts commit f985905ebdd488c63b7819a65c817aa98fb8da49.
Reason for revert: break headless build.
Repro: mkdir ./out/headless && echo 'import("//build/args/headless.gn")' > out/headless/args.gn && gn gen ./out/headless
Waiting for editor on "/usr/local/google/home/caseq/cr/src/out/headless/args.gn"...
Generating files...
ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed.
assert(ozone_platform_x11)
^-----
See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included.
"//ui/events/platform/x11",
^-------------------------
Original change's description:
> X11 and Ozone: enable use_x11 and use_ozone
>
> This is the final change that enables use_x11
> and use_ozone for Linux builds and (as it was
> before) excludes X11 for chromeos, chromecast,
> lacros.
>
> in order to run ozone/X11/wayland, one must pass
> —enable-features=UseOzonePlatform
> —ozone-platform=x11 or wayland. otherwise,
> non-ozone/X11 is used.
>
> it’s also possible to completely disable X11
> so that clients, who need that kind of build can
> continue to have that.
>
> Bug: 1085700
> Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#801523}
TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com
Change-Id: Id1f451c6b8a9aeeaa48a8d12da2776b8676aca09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1085700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376482
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801565}
GitOrigin-RevId: 26a1704c2160c1beded97376ab4b9098b2cefa7a
ParseFromString will fail if given a raw resource since it expects a
compiled xml file.
Change-Id: I2a92b3cd48e8cfc1eb402106689f3596fe960e73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375901
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801547}
GitOrigin-RevId: a4c59f9360c30a953a9b86731c117da8052133f2
This is the final change that enables use_x11
and use_ozone for Linux builds and (as it was
before) excludes X11 for chromeos, chromecast,
lacros.
in order to run ozone/X11/wayland, one must pass
—enable-features=UseOzonePlatform
—ozone-platform=x11 or wayland. otherwise,
non-ozone/X11 is used.
it’s also possible to completely disable X11
so that clients, who need that kind of build can
continue to have that.
Bug: 1085700
Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#801523}
GitOrigin-RevId: f985905ebdd488c63b7819a65c817aa98fb8da49
In https://crrev.com/651373, the package_exists() implementation changed
but the comment did not reflect this change.
Change-Id: Ic13e7a3cef28a980ebd167af1bab31006bbf5b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375928
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801469}
GitOrigin-RevId: cd966ec4a7f9da83491252b533815192387eb29d
Newer distros have lib32gcc-s1, but older, supported distros have
lib32gcc1. Support both, rather than only one of the two.
Bug: 1119692
Change-Id: I2ba4ee25507976683c987ea89623e7e0d80957af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372588
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801445}
GitOrigin-RevId: 3ec3c17303d45c1373bbafe445ea57465974afc9
Lint does not correctly determine whether chromium targets depend on
appcompat since it uses string matching that does not match our library
name. Since this is the same for all chromium targets, ignore this lint
warning globally.
Bug: 1116130
Change-Id: I106f4dbbabd50e2e781b6152816c02ae8036f999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373206
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801437}
GitOrigin-RevId: e2801f5ca0785815b299074ee1cde739bc5cfa12
chromium-autoroll
Wenbin Zhang
Dirk Pranke
Maggie Chen
Nick Harper
Ben Joyce
Maksim Sisov
Ben Mason
Justin DeWitt
Tom Anderson
Sam Maier
Chong Gu
Wayne Piekarski
Wez
Andrew Grieve
Scott Little
Yuki Shiino
Arthur Wang
Mark Mentovai
kouhei
Andrey Kosyakov
Lei Zhang
Peter Wen