Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL and WM_GESTURE (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.
One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported).
BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/7648011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@96661 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL and WM_GESTURE (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary.
One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported).
BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@96592 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Add crash_service64.exe in places where crash_service.exe is depended
upon, otherwise it doesn't get built on Buildbot.
Declaring run-time dependencies via Gyp dependencies is a hack:
creating test_support_ui.a doesn't depend on crash_service.exe being
present. But it seems to be the usual practice to sprinkle run-time
dependencies in Gyp dependencies until the desired effect is achieved.
BUG=89730
TEST=trybots
Review URL: http://codereview.chromium.org/7619012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@96479 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.
Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7623015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@96391 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Now that r96121 has landed, this should not cause compile failures when compiling base/ on the host.
Original comments follow.
Numerous changes, including:
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.
Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7529035TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/7587003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@96211 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.
Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7529035
git-svn-id: http://src.chromium.org/svn/trunk/src/build@95910 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.
Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@95907 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
And fixes the code of task manager and following tests which didn't work correctly on WebUI TaskManager.
- TaskManagerBrowserTest.ShutdownWhileOpen
- ExtensionApiTest.ProcessesVsTaskManager
- PrerenderBrowserTest.PrerenderTaskManager
BUG=chromium-os:13885
TEST=trybots
Review URL: http://codereview.chromium.org/7550004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@95567 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
And fixes the code of task manager and following tests which didn't work correctly on WebUI TaskManager.
- TaskManagerBrowserTest.ShutdownWhileOpen
- ExtensionApiTest.ProcessesVsTaskManager
- PrerenderBrowserTest.PrerenderTaskManager
BUG=chromium-os:13885
TEST=trybots
Review URL: http://codereview.chromium.org/7520011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@95015 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
* Added --enable-web-intents switch.
* Added enable_web_intents build variable, for use in WebKit mostly.
* Added registration InfoBar and piping to the WebKit side, which is not hooked
up on that side yet.
BUG=none
TEST=RegisterIntentHandlerInfoBarDelegateTest.*
Review URL: http://codereview.chromium.org/7461093
git-svn-id: http://src.chromium.org/svn/trunk/src/build@94867 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Message/MethodCall/Response classes wrap around DBusMessage.
MessageReader and Message Writer provide API to read and write
D-Bus messages in a type safe fashion.
BUG=90036
TEST=The code is not yet used in Chrome. Run unit tests.
Review URL: http://codereview.chromium.org/7492029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@94845 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Fetch Subversion URL and the revision from 'git log' even if git-svn is not available.
- Remove VersionInfo.root, since nobody is using it.
- Allow a user to specify the directory name just prior to the svn src URL.
FYI: We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the fifth step of them:
(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan)
(5) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark)
(6) Update tweak_info_plist to use lastchange.py. (reviewer: mark)
BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Windows" on Windows and Linux.
Review URL: http://codereview.chromium.org/7493073
git-svn-id: http://src.chromium.org/svn/trunk/src/build@94828 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
thakis@chromium.org
rsleevi@chromium.org
jschuh@chromium.org
georgey@chromium.org
pkasting@chromium.org
mseaborn@chromium.org
dnicoara@chromium.org
mnissler@chromium.org
jochen@chromium.org
mark@chromium.org
maruel@chromium.org
cmp@chromium.org
nsylvain@chromium.org
apatrick@chromium.org
bradnelson@google.com
fta@sofaraway.org
fischman@chromium.org
siggi@chromium.org
phajdan.jr@chromium.org
dhollowa@chromium.org
lambroslambrou@chromium.org
yoshiki@chromium.org
darin@chromium.org
tony@chromium.org
timurrrr@chromium.org
jhawkins@chromium.org
satorux@chromium.org
haraken@google.com
sky@chromium.org
sergeyu@chromium.org