37cbff8c96
Don't launch sub-process through shell.
...
Setting shell=True causes CygWin to open a Python
interactive prompt rather than download/copy file.
Since there are no actual shell meta-characters in
the command, there shouldn't be any problems in
forking the command directly.
BUG=
Review URL: https://codereview.chromium.org/1231863014
Cr-Original-Commit-Position: refs/heads/master@{#339086}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2fc996195ef56017d369313af60a8946e52e1fb9
2015-07-16 18:45:37 +00:00
46f1b725a3
Make get_syzygy_binaries.py resistant to cloud failures.
...
This now uses gsutil to perform downloads which ensures that the downloaded data is not corrupt and matches its stored checksum. It also tries repeatedly with an exponential backoff.
BUG=
Review URL: https://codereview.chromium.org/1236623002
Cr-Original-Commit-Position: refs/heads/master@{#338718}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3641d5ffaee287ab74c7a2c0270e28d5e9864a7d
2015-07-14 18:35:59 +00:00
d1a9e981d2
Fetch Kasko crash reporter for use with SyzyASAN.
...
BUG=
Review URL: https://codereview.chromium.org/866023003
Cr-Original-Commit-Position: refs/heads/master@{#312666}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9bdc2bf7cb9d0b3e20bece03498da081f2f6723b
2015-01-22 20:20:52 +00:00
f08b37c789
Get the Syzygy binaries from an https server.
...
BUG=
Review URL: https://codereview.chromium.org/778643012
Cr-Original-Commit-Position: refs/heads/master@{#306886}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4e8e135c7016b2bf676da596234de478e0f6a89a
2014-12-04 21:00:23 +00:00
35b6d589f8
Remove the include and lib archive from the get_syzygy_binaries script.
...
We don't produce them anymore.
TBR=chrisha@chromium.org
BUG=
Review URL: https://codereview.chromium.org/662543009
Cr-Original-Commit-Position: refs/heads/master@{#300971}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f07597fa403c6be9c7bdcf79a69a2af739dd1cff
2014-10-23 23:05:21 +00:00
d23f8ccd02
Remove orphaned Syzygy binaries on non-Windows platforms.
...
This modifies the gclient hook to remove files that were inadvertently downloaded by a previous version of the script.
BUG=414826
Review URL: https://codereview.chromium.org/586063002
Cr-Original-Commit-Position: refs/heads/master@{#295763}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f3b3b3bbeb8ed28ffa0c7580650a1d2ef29dade2
2014-09-19 19:30:04 +00:00
1c77dc1dcb
Fixed build on Windows with Cygwin (get_syzygy_binaries script).
...
1. Allow get_syzygy_binaries to run in cygwin.
2. On cygwin, get_syzygy_binaries makes all of the binaries it unpacks
executable (to avoid "permission denied" errors during compilation).
BUG=386911
Review URL: https://codereview.chromium.org/341183002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@278748 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-20 17:30:31 +00:00
c7183b332a
Move Syzygy symbol files to 'exe' subdirectory as they were before.
...
The current script places the symbols in their own subdirectory, which breaks the expectations of the SyzyASAN build integration.
BUG=
TBR=sebmarchand@chromium.org
Review URL: https://codereview.chromium.org/334093002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@277330 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-15 18:28:48 +00:00
cf994b44d7
Bring Syzygy binaries in using a script rather than as a dependency.
...
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273353
Review URL: https://codereview.chromium.org/306543006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@277048 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-06-13 18:07:26 +00:00
683e2d9a63
Revert 273353 "Bring Syzygy binaries in using a script rather th..."
...
broke webview_licenses.py:
Got LicenseError "missing README.chromium or licenses.py SPECIAL_CASES entry" while scanning third_party/syzygy
> Bring Syzygy binaries in using a script rather than as a dependency.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/306543006
TBR=chrisha@chromium.org
Review URL: https://codereview.chromium.org/300223013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@273362 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-28 21:49:29 +00:00
3b176c9818
Bring Syzygy binaries in using a script rather than as a dependency.
...
BUG=
Review URL: https://codereview.chromium.org/306543006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@273353 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-28 21:07:43 +00:00
4c93a77fbe
Add get_syzygy_binaries.py script.
...
This adds a script for retrieving and installing Syzygy binaries. Currently binaries are checked in to an SVN repository and installed via a DEPS dependency. The Syzygy team is moving to git, and archiving their binaries on Google Common Data Storage. A later CL will move to using this script, installing the binaries via a DEPS hook.
BUG=
R=siggi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270401
Review URL: https://codereview.chromium.org/288703002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270531 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-15 00:13:51 +00:00
21ab050464
Revert of Add get_syzygy_binaries.py script. ( https://codereview.chromium.org/288703002/ )
...
Reason for revert:
Causing check_perms failure on Linux bots.
http://chromegw.corp.google.com/i/chromium/builders/Linux/builds/49795
Original issue's description:
> Add get_syzygy_binaries.py script.
>
> This adds a script for retrieving and installing Syzygy binaries. Currently binaries are checked in to an SVN repository and installed via a DEPS dependency. The Syzygy team is moving to git, and archiving their binaries on Google Common Data Storage. A later CL will move to using this script, installing the binaries via a DEPS hook.
>
> BUG=
> R=siggi@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270401
TBR=siggi@chromium.org ,chrisha@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/279053004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270433 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-14 17:44:14 +00:00
fcdac4d330
Add get_syzygy_binaries.py script.
...
This adds a script for retrieving and installing Syzygy binaries. Currently binaries are checked in to an SVN repository and installed via a DEPS dependency. The Syzygy team is moving to git, and archiving their binaries on Google Common Data Storage. A later CL will move to using this script, installing the binaries via a DEPS hook.
BUG=
R=siggi@chromium.org
Review URL: https://codereview.chromium.org/288703002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@270401 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-05-14 14:26:14 +00:00
bcwhite
chrisha
erikwright
sebmarchand
mgiuca@chromium.org
chrisha@chromium.org
mattm@chromium.org
jiayl@chromium.org
chrisha@google.com