Previous CL moved these scripts into bin/helper/ because lots of
these scripts are not meant to be directly run by developers (they
are run by other scripts such as
build/android/pylib/junit/test_runner.py). Moving these scripts
back directly into bin/ because this move caused an issue with
incremental builds.
BUG=
TBR=pauljensen@chromium.org
Review URL: https://codereview.chromium.org/1708383002
Cr-Original-Commit-Position: refs/heads/master@{#376527}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4868bb07bb1f357ac5636a80b351bb62840dd91e
Adding scripts to make it easy to run junit test. These are named
out/bin/run_<junit_suite_name>.
Moving the helper scripts that our test runner uses to run the
junit test suites. These scripts are not meant to be run except
by the test runner. Moving them into out/bin/helper/<script_names>
so people don't accidently try to run them.
BUG=511999
Review URL: https://codereview.chromium.org/1674353004
Cr-Original-Commit-Position: refs/heads/master@{#375603}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 713185d2283e9a97e2a95b6c7c2f7eb531ae591c
If errorprone finds an error in non-Chromium code the build will
fail. This shouldn't happen, so I am disabling errorprone on
non-Chromium code.
BUG=
Review URL: https://codereview.chromium.org/1314493010
Cr-Original-Commit-Position: refs/heads/master@{#345941}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb9e4863c7dd58c17fd53cd025f7f0dad17a52a5
This updates errorprone from 1.1.2 to 2.0.1. Version 2.0.1 includes
some fixes that lets errorprone work if you have java 8. I also
deleted the ChromiumErrorProneCompiler to just use the default
ErrorProneCompiler instead. Currently, the ChromiumErrorProneCompiler
doesn't override any default behavior and would need to be
changed a good bit to be compatible with 2.0.1.
BUG=517259
Review URL: https://codereview.chromium.org/1286613002
Cr-Original-Commit-Position: refs/heads/master@{#345688}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 29d8817ee93db9e2ba9177a456a4992e3ad54d99
These changes let the errorprone compiler find problems when building Android.
A global flag disabled Errorprone by default.
When enabled, code problems will be shown with suggestions on how to fix them.
BUG=485599
Review URL: https://codereview.chromium.org/1136573002
Cr-Original-Commit-Position: refs/heads/master@{#335509}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6ffb1179d6adf08edd64848b45b7415b6b6de43d
Adds a new junit_binary template for gyp which makes it easy to
make new Junit test suites by setting a lot of the options and
necessary dependencies for you.
Also, adds a new java_binary.gypi file which uses the
create_java_binary_script.py similiar to how the java_binary
GN template works when main_class is specified. This lets
GYP and GN work similiar when building a junit binary, so
our test runner can run them the same way.
Finally, because of the slightly different way were now running
the junit binary, the java classpath contains all of the jars
instead of just the test jar (before we were running
java -jar test_jar.jar which set the classpath to just be
test_jar.jar). Therefore, we can simplify things and just look
in the classpath for the paths to the Robolectric dependencies
when running Robolectric junit tests.
BUG=
Review URL: https://codereview.chromium.org/1057783002
Cr-Original-Commit-Position: refs/heads/master@{#324093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ad64324d470c43b29854282d5ad5b1ff75dfc6c
Reason for revert:
Didn't help. We probably got scheduled on other, flakier Android devices which caused tests to start flaking, or something else is the root cause.
Original issue's description:
> Revert of [Android] JUnit runner + gyp changes. (patchset #15 id:280001 of https://codereview.chromium.org/574433003/)
>
> Reason for revert:
> Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.
>
> Original issue's description:
> > [Android] JUnit runner + gyp changes.
> >
> > This adds Java code for running junit tests, as well as gyp targets for
> > both runnable and non-runnable host-side JARs.
> >
> > BUG=316383
> >
> > Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> > Cr-Commit-Position: refs/heads/master@{#296340}
>
> TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=316383
>
> Committed: https://crrev.com/54b9408f8b18e3bf3a33343e375186e1949e8e86
> Cr-Commit-Position: refs/heads/master@{#296384}
TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383
Review URL: https://codereview.chromium.org/596303002
Cr-Original-Commit-Position: refs/heads/master@{#296406}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6e9dc50aecf078d7826fe8e4611b2c238aab3f23
Reason for revert:
Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.
Original issue's description:
> [Android] JUnit runner + gyp changes.
>
> This adds Java code for running junit tests, as well as gyp targets for
> both runnable and non-runnable host-side JARs.
>
> BUG=316383
>
> Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> Cr-Commit-Position: refs/heads/master@{#296340}
TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383
Review URL: https://codereview.chromium.org/597123002
Cr-Original-Commit-Position: refs/heads/master@{#296384}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 54b9408f8b18e3bf3a33343e375186e1949e8e86
This adds Java code for running junit tests, as well as gyp targets for
both runnable and non-runnable host-side JARs.
BUG=316383
Review URL: https://codereview.chromium.org/574433003
Cr-Original-Commit-Position: refs/heads/master@{#296340}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2e56d4508e33de5fc60bbbb41c5a5d5534e88174
agrieve
mikecase
raywilliams
phoglund
jbudorick