Some fixes included:
- Changes to resource management to account for new R.java packaging
from library projects
(https://android-review.googlesource.com/#/c/43134/).
- Fixed the package for some inludes in ModalDialogTest.java. This only
worked because of how we previously used to aggregate all resoures
from the prior layer. With the new packaging, we must use the resource
from the appropriate layer.
BUG=163001,166434
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11819047
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176176 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> [Android] Generate localized strings.xml files at build time.
>
> This generates localized strings.xml files (e.g.
> values-fr/strings.xml) from grd and xtb files at build time. This
> means we no longer need to check in localized strings.xml files. Note:
> the xtb files are empty until translations are available.
>
> Benefits:
> - 41 fewer extraneous results when grepping Java string IDs
> - Switching from maintaining strings in strings.xml over to using a
> grd file is One Trivial CL* away: just include English in the list
> of languages for which we generate strings.xml files.
>
> *Restrictions may apply
>
> BUG=167248
>
> Review URL: https://codereview.chromium.org/11659006TBR=newt@chromium.org
Review URL: https://codereview.chromium.org/11820058
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176151 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This generates localized strings.xml files (e.g.
values-fr/strings.xml) from grd and xtb files at build time. This
means we no longer need to check in localized strings.xml files. Note:
the xtb files are empty until translations are available.
Benefits:
- 41 fewer extraneous results when grepping Java string IDs
- Switching from maintaining strings in strings.xml over to using a
grd file is One Trivial CL* away: just include English in the list
of languages for which we generate strings.xml files.
*Restrictions may apply
BUG=167248
Review URL: https://codereview.chromium.org/11659006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Moves ui/app_list code specific to toolkit-views to ui/app_list/views.
Update gyp[i], include guards, #includes for moved files.
Seed chrome/browser/ui/cocoa/app_list and ui/app_list/cocoa with a
skeleton Cocoa UI.
BUG=138633
TEST=Mostly build changes. Functionality of AppLauncher on ChromeOS
and Windows should be unchanged.
On OSX, without chrome running, `Chromium.app/Contents/MacOS/Chromium --show-app-list`
should show a borderless gray window for 1 second (note: this is for
testing only -- OSX needs a different approach for IPC).
Review URL: https://chromiumcodereview.appspot.com/11784034
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Move the step creation lines to the parent script. The biggest
advantage of this is the full step is properly printed, starting
with the exact shell line used to run the test suite.
- Rename some steps into c++ style.
BUG=168894
NOTRY=true
Review URL: https://codereview.chromium.org/11817033
git-svn-id: http://src.chromium.org/svn/trunk/src/build@176010 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Changes in preparation to moving buildbot config to point directly
to this file.
- Improved substring bot-id matching. Because we're using an
unordered dict, look for all possible bot-id substring matches
and pick the longest one, instead of picking the first substring
match.
Added generic 'builder' bot-id that several bots will use.
- Changed factory_property key to 'android_bot_id' to make it more
clear where this value is used and easier to search for.
R=cmp
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11823032
git-svn-id: http://src.chromium.org/svn/trunk/src/build@175924 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change adds an accessibility audit which runs just before tearDown() on any WebUI browser test that uses the chrome/test/data/webui/test_api.js framework.
As of this change, the test will run by default for each test case, but not cause any errors in the case of accessibility issues. As we fix accessibility issues, we can set the a11yIssuesAreErrors flag on a per-test and per-fixture basis, to catch regressions. Once the majority of WebUI pages are passing the accessibility audit, and we have a mechanism in place for ignoring false positives, we will transition to treating accessibility issues as errors by default.
http://www.chromium.org/developers/accessibility/webui-accessibility-audit has more information.
BUG=162740
Review URL: https://chromiumcodereview.appspot.com/11363170
git-svn-id: http://src.chromium.org/svn/trunk/src/build@175866 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Our bash scripts were getting complicated an unwieldy. In this
commit I port the test logic into python, as a precursor to
moving the rest of the file.
I also move the step selection logic into python which offers the following advantages:
- Less files to maintain, easier to change something globally.
- Paves way to moving most factory_properties into 'slave_properties' argument I added. This will let us change parameters like buildtype (make vs. ninja) without a waterfall restart. This also moves configuration into a single place.
Also:
- Refactor test runners to not require envsetup.
- Adding test report step
BUG=153707,163476, 168518
Review URL: https://codereview.chromium.org/11666023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@175698 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The Android NetworkChangeNotifier is initialized with connection_type =
CONNECTION_UNKNOWN.
This means that the result returned by NetworkChangeNotifier::IsOffline() is
inaccurate until the first network change happens.
This can happen for the whole initialization path if the user starts Chrome
after he explicitly disabled WiFi and 3G.
This CL updates NetworkChangeNotifier.java to support multiple native
observers. This can happen in case NetworkChangeNotifierDelegateAndroid is
instantiated multiple times (e.g. when multiple factories are instantiated).
Still on the Java side, NetworkChangeNotifier.java was also changed to fetch
the actual connection type as soon as the auto-detector (interacting with the
Android platform) is enabled.
On the native side, NetworkChangeNotifierDelegateAndroid now fetches at
construction time the current connection type from the Java side singleton
through a direct JNI function call (possible since the delegate is constructed
on the JNI thread).
NetworkChangeNotifierAndroid::GetCurrentConnectionType() is now a simple
wrapper around the delegate's GetCurrentConnectionType() method (which is
thread-safe).
BUG=166883
Review URL: https://codereview.chromium.org/11628008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@175138 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ilevy@chromium.org
yfriedman@chromium.org
smckay@chromium.org
oshima@chromium.org
newt@chromium.org
ricow@chromium.org
tapted@chromium.org
kalman@chromium.org
jschuh@chromium.org
nileshagrawal@chromium.org
tonyg@chromium.org
craigdh@chromium.org
kristianm@chromium.org
dewittj@chromium.org
aboxhall@chromium.org
jln@chromium.org
petarj@mips.com
cmp@chromium.org
frankf@google.com
phajdan.jr@chromium.org
marja@chromium.org
pph34r@gmail.com
dbeam@chromium.org
avi@chromium.org
tedchoc@chromium.org
pliard@chromium.org
sbc@chromium.org