This appears to break Chrome for Android perf tests, in addition to
the kraken benchmark upstream.
-------------------
Log output:
Traceback (most recent call last):
File "clank/build/run_crossbrowser_perftests.py", line 1429, in <module>
sys.exit(main(sys.argv))
File "clank/build/run_crossbrowser_perftests.py", line 1416, in main
passed &= chrome_benchmarks.Run()
File "/usr/local/google/b/build/slave/soju-official-perf-noflash-clankium/build/src/clank/build/../../build/android/pylib/base_test_runner.py", line 79, in Run
return self.RunTests()
File "clank/build/run_crossbrowser_perftests.py", line 329, in RunTests
return self.RunCrossBrowserPerfTests(options.filter, options.force_disabled)
File "clank/build/run_crossbrowser_perftests.py", line 379, in RunCrossBrowserPerfTests
passed &= bool(RunTheTest())
File "clank/build/run_crossbrowser_perftests.py", line 368, in RunTheTest
return test_fn()
File "clank/build/run_crossbrowser_perftests.py", line 1222, in PaintBlankBenchmark
timeout)
File "clank/build/run_crossbrowser_perftests.py", line 426, in RunPaintBenchmarkHelper
timeout=timeout))
File "/usr/local/google/b/build/slave/soju-official-perf-noflash-clankium/build/src/clank/build/perf_test_runner.py", line 629, in RunPerfTest
result, units, result_type=result_type)
File "/usr/local/google/b/build/slave/soju-official-perf-noflash-clankium/build/src/clank/build/../../build/android/pylib/perf_tests_helper.py", line 127, in PrintPerfResult
output += '\nAvg %s: %f%s' % (measurement, avg, units)
TypeError: float argument required, not str
-------------------
Original commit:
The previous version was printing out only the first histogram.
BUG=
Review URL: https://codereview.chromium.org/11413144TBR=marja@chromium.org
Review URL: https://codereview.chromium.org/11418165
git-svn-id: http://src.chromium.org/svn/trunk/src/build@169510 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This lets device_forwarder be controlled (started and killed) like
host_forwarder (see r167167).
This has the main benefit of moving the setup/tear down complexity from the
Python Forwarder wrapper code to the forwarder itself so that various clients
(including WebKit) can use forwarder2 more easily (e.g. no need to use pexpect
anymore (which is not available in WebKit)).
This implied a refactoring in the Daemon class so that its clients don't have
to duplicate the socket-related code.
Review URL: https://chromiumcodereview.appspot.com/11360248
git-svn-id: http://src.chromium.org/svn/trunk/src/build@169334 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is used for normal builds to strip out lots of unneeded symbols and
minimize binary size. However, for shared library build, this causes
needed symbols to be excluded and subsequent so's to fail linking.
BUG=158821
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11413110
git-svn-id: http://src.chromium.org/svn/trunk/src/build@169060 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The WebView build doesn't have third_party/android_tools/ndk with the
added gyp file, but the cpufeatures code has already been built as part
of the system. Introduce a .gypi that can be included to get the
appropriate dependency for the current build type.
BUG=
Review URL: https://codereview.chromium.org/11417114
git-svn-id: http://src.chromium.org/svn/trunk/src/build@169026 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The genproto_java action was not necessarily run before the java.gypi
included action, so the build would fail.
This makes java.gypi depend on the genproto_java stamp file, so the
order will now be deterministic.
BUG=161587
Review URL: https://codereview.chromium.org/11413091
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168838 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The NoCache test for the PAC fetcher verifies that an attempt to
fetch a PAC script fails once the server is killed, thus assuring
that PAC files are not cached.
Due to the device-server / port forwarding layout of running
gtests on Android, the specific error being returned by the
fetch attempt is "Connection reset by peer" rather than
"Connection refused". This patch takes this into consideration.
BUG=161763
Review URL: https://chromiumcodereview.appspot.com/11412070
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168805 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds Java resources directly to the content and chrome folders and starts
accessing them through the Java classes org.chromium.content.R and
org.chromium.chrome.R instead of using AppResource.
A following CL will remove these resources from ContentShell and other build
targets that currently provide duplicates of these resources. The following CL
will also remove remaining references to AppResource.
This is the second of three CLs to replace AppResource with R:
1. http://codereview.chromium.org/11363150 - Support Java resources within content
2. http://codereview.chromium.org/11360207 - Add Java resources to content and chrome
3. http://codereview.chromium.org/11377117 - Remove AppResource and unneeded resources
BUG=136704
Review URL: https://chromiumcodereview.appspot.com/11360207
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168759 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
In Android 4.2, pinch gestures send both pinch events (for the
zoom-in/out part of the pinch) and scroll events (for double-finger
panning). The previous logic in LayerTreeHostImpl created a pan from
the pinch event, resulting in 2x overpanning on Android 4.2.
In order to have compatible gesture generation in older Android versions as
well, I copy-pasted the latest Android GestureDetector.java file into the
Chromium tree and use that instead of the system file.
BUG=161909
Review URL: https://chromiumcodereview.appspot.com/11299083
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168721 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a new target to all.gyp: chromium_builder_nacl_sdk
Adds a native_client_sdk gyp file: it depends on nacl_core_sdk from the
native_client repo, but also builds and copies ppapi libraries to the toolchain
directories.
Retry of http://codereview.chromium.org/11363045/
This originally failed here: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/41342
With the following error:
init.c:(.text+0x3c): undefined reference to `__libc_setup_tls'
init.c:(.text+0x2e2): undefined reference to `_dl_init_static_tls'
init.c:(.text+0x2ec): undefined reference to `_dl_wait_lookup_done'
While building simple_glibc_x86_32.nexe.
My change seems to have tickled a bug in nacl_browser_test.gypi which was using
the link flag -lpthread instead of -pthread. Changing this seems to have fixed
the link failure.
BUG=none
TBR=noelallen@chromium.orgTBR=ncbray@chromium.org
Review URL: https://codereview.chromium.org/11280063
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168603 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The WebView will eventually need to be built for multiple target
architectures. Prepare for this by passing --suffix .arm to gyp when
generating the makefiles, and including an architecture-specific
makefile at the top level. Also, remove the hardcoding of arm as the
target architecture in envsetup.sh.
The previous change I made to .gitignore to only ignore *.host.mk and
*.target.mk instead of *.mk has been reverted in favour of just
specifically un-ignoring files called Android.mk (which are
handwritten).
BUG=
Review URL: https://codereview.chromium.org/11416036
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168506 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds a new target to all.gyp: chromium_builder_nacl_sdk
Adds a native_client_sdk gyp file: it depends on nacl_core_sdk from the native_client repo, but also builds and copies ppapi libraries to the toolchain directories.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11363045
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168359 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and
foo.exe.pdb). This is beneficial for a couple reasons:
* no more chrome_dll.pdb and chrome_exe.pdb silliness
* also avoids this issue if we end up with similarly named targets in the
future (target.dll and target.exe)
* ninja already does this, and, by extension, either ninja needs to be broken
to use the old scheme, or the we fix the broken in the existing system.
One less difference between msvs and ninja.
Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015
BUG=
Review URL: https://codereview.chromium.org/11384003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168341 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This provides support for android-style resource folders in content and other
non-apk Java targets. The AppResource hack can then be removed shortly.
Details: while building a non-apk target (e.g. chromium_content.jar), we
generate an R.java file with non-final constants and in the appropriate Java
package (e.g. org.chromium.content.R) using the resources in the target (e.g.
content/public/android/java/res). This R.java is used to produce the jar, but is
not included in the jar itself.
When we later build an apk, we merge the resources from the apk (e.g.
org/chromium/content_shell/res) with the resources from the non-apk targets it
depends on (e.g. content/public/android/java/res). A new R.java is generated
using the merged resources with the correct mapping from resources to integer
IDs. This R.java file is copied into each needed package (e.g.
org.chromium.content.R and org.chromium.content_shell.R) and included in the
apk.
This is the first of three CLs to replace AppResource with R:
1. http://codereview.chromium.org/11363150 - Support Java resources within content
2. http://codereview.chromium.org/11360207 - Add Java resources to content and chrome
3. http://codereview.chromium.org/11377117 - Remove AppResource and unneeded resources
BUG=136704
Review URL: https://codereview.chromium.org/11363150
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168283 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
thakis@chromium.org
ilevy@chromium.org
yfriedman@chromium.org
dalecurtis@google.com
binji@chromium.org
dfalcantara@chromium.org
fischman@chromium.org
pliard@chromium.org
marja@chromium.org
aberent@chromium.org
chrisha@chromium.org
chenyu@chromium.org
iannucci@chromium.org
peter@chromium.org
torne@chromium.org
michaelbai@chromium.org
nileshagrawal@chromium.org
vasilii@google.com
sky@chromium.org
phajdan.jr@chromium.org
tonyg@chromium.org
nyquist@chromium.org
bulach@chromium.org
mkosiba@chromium.org
ppi@chromium.org
newt@chromium.org
aelias@chromium.org
sadrul@chromium.org
sreeram@chromium.org
jam@chromium.org
beaudoin@chromium.org
dbeam@chromium.org
mirandac@chromium.org