When --verbose is given, print more detailed info to help debugging.
The dependency of offending header files and the obj files they affect
should help determine which files to fix. The number of affected
object files can be a proxy of seriousness.
If the whitelist is not given, the extra detail would be very long.
BUG=661774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
Review-Url: https://codereview.chromium.org/2932153002
Cr-Original-Commit-Position: refs/heads/master@{#478956}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8cc3123c31e0538f0f10be6329683d9c698fbfed
Check whether the build is dirty first, and abort when dirty. This can
be skipped by using option --skip-dirty-check.
Dump JSON output on error, so that the result is still valid.
Filter out generated headers more aggressively.
Report non-existing headers in JSON as well.
BUG=725877
Review-Url: https://codereview.chromium.org/2911543002
Cr-Original-Commit-Position: refs/heads/master@{#476895}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0735fd76fd89d25935fd27d1d985ca0f3457a18a
Before running check_gn_headers.py, it is necessary to build all
in order to get the dependency info from the compiler. Directly
checking whether rebuilding is needed by running a build dry run
takes too long, so some heuristics are used instead.
BUG=661774
Review-Url: https://codereview.chromium.org/2891363004
Cr-Original-Commit-Position: refs/heads/master@{#474588}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ceaba5ef538ce1780578d5e948641bc27f5829b
Reason for revert:
This optimization was buggy and broke the ninja parsing.
Original issue's description:
> Optimize check_gn_headers.py for speed
>
> Process the output of 'ninja' live through the pipe rather than waiting
> for it to finish.
>
> Before:
> 20.74user 16.36system 0:24.57elapsed 151%CPU
>
> After:
> 16.63user 9.24system 0:13.94elapsed 185%CPU
>
> BUG=661774
>
> Review-Url: https://codereview.chromium.org/2842513003
> Cr-Commit-Position: refs/heads/master@{#466900}
> Committed: 6b609383cfTBR=dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661774
Review-Url: https://codereview.chromium.org/2844623002
Cr-Original-Commit-Position: refs/heads/master@{#467231}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c219b8a1823f884703c3546bf2cb7c17fb737d67
Process the output of 'ninja' live through the pipe rather than waiting
for it to finish.
Before:
20.74user 16.36system 0:24.57elapsed 151%CPU
After:
16.63user 9.24system 0:13.94elapsed 185%CPU
BUG=661774
Review-Url: https://codereview.chromium.org/2842513003
Cr-Original-Commit-Position: refs/heads/master@{#466900}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6b609383cf3669b0670b567249ff868ea4b26e43
wychen
mahmadi