Adds build targets for arm versions of md5sum, host_forwarder, and
libc++. Special targets are necessary since the Android/device deps
can't be built with the clang_arm toolchain, so we can't just use it
for everything.
Also updates the arm build config slightly since Raspberry Pis require
mfloat-abi to be set to hard, while Android requires it to be set to
soft.
Bug: 779837
Change-Id: I19c861d2c8a528c82bcb5d9f43c3812499d23ddf
Reviewed-on: https://chromium-review.googlesource.com/761357
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530711}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e29eea14f91a8adb8ed3a443fb23eab673f2932b
This is primarily motivated by PRESUBMIT not recognizing that changes
to 'stack' require an update to the corresponding pydeps file (as happened
in the llvm_symbolizer CLs in crbug.com/774267). It'll also keep us
from generating a 'stackc' bytecode file.
Bug: 774267
Change-Id: I5ae07fa317883a429865e07452fbef0dd3f92234
Reviewed-on: https://chromium-review.googlesource.com/846462
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#526422}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d24221ca3e05c599f2420539ee32367f93c7e667
llvm symbolizer is a more efficient symbolizer than addr2line, objdump,
etc.
In this cl, I 1)created a wrapper instance to interact with
llvm symbolizer, 2)made the stack script to use llvm symbolizer instance,
and then 3)added llvm symbolizer into isolated inputs.
The reland is to fix:
1UnboundLocalError: local variable 'code_addr' referenced before assignment
2AttributeError: 'module' object has no attribute 'ToolPath'
TBR=dpranke@chromium.org,agrieve@chromium.org
Bug: 774267
Change-Id: Iee626065e4cfe9403f9b13dfec2dfd99e749510c
Reviewed-on: https://chromium-review.googlesource.com/834754
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#526304}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ed89eb8fd900951e7f7a604f460d1b1c2ea3c526
This reverts commit b2754af2ed37b2bf30efac6234fcecbdd941c4bb.
Reason for revert: Caused the step stack_tool_with_logcat_dump to start failing on cronet bots.
Original change's description:
> [Reland] Use llvm symbolizer for stack script.
>
> llvm symbolizer is a more efficient symbolizer than addr2line, objdump,
> etc.
>
> In this cl, I 1)created a wrapper instance to interact with
> llvm symbolizer, 2)made the stack script to use llvm symbolizer instance,
> and then 3)added llvm symbolizer into isolated inputs.
>
> Bug: 774267
> Change-Id: I43d305b4c0c94be614ee4cad35b40f04b3d3ae20
> Reviewed-on: https://chromium-review.googlesource.com/810007
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Zhiling Huang <hzl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522520}
TBR=dpranke@chromium.org,agrieve@chromium.org,hzl@chromium.org,jbudorick@chromium.org
Change-Id: If4e9f5618f62a5ed2a4d3152af6b18dbc748b1f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 774267
Reviewed-on: https://chromium-review.googlesource.com/816257
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522711}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6e6e84820c83c331f13add5fc62b8ee439bd10f0
llvm symbolizer is a more efficient symbolizer than addr2line, objdump,
etc.
In this cl, I 1)created a wrapper instance to interact with
llvm symbolizer, 2)made the stack script to use llvm symbolizer instance,
and then 3)added llvm symbolizer into isolated inputs.
Bug: 774267
Change-Id: I43d305b4c0c94be614ee4cad35b40f04b3d3ae20
Reviewed-on: https://chromium-review.googlesource.com/810007
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522520}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2754af2ed37b2bf30efac6234fcecbdd941c4bb
llvm symbolizer is a more efficient symbolizer than addr2line, objdump,
etc.
In this cl, I 1)created a wrapper instance to interact with
llvm symbolizer, 2)made the stack script to use llvm symbolizer instance,
and then 3)added llvm symbolizer into isolated inputs.
Bug: 774267
Change-Id: I971fb808b97f3a569eb9615f99efa41e3a56f3cb
Reviewed-on: https://chromium-review.googlesource.com/789376
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521820}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b6e038a7a7b07f680eba6d6ec1c32319ae89cd78
d5ead4d70f0b Upstream lightly modified Chromium BUILD.gn files
Also removed build/secondary/third_party/crashpad as those are
moved to the Crashpad repo.
Part of starting to port Crashpad to Fuchsia.
Bug: crashpad:79, 753619
Change-Id: Id3732e6d58ff42fe1163337340f901e9880b8c37
Reviewed-on: https://chromium-review.googlesource.com/779624
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#518007}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 68af3af0992a4f1e660fcf70fdc9456f96f47078
22e8c33b21e8 linux: Provide PTRACE_GET_THREAD_AREA for 32-bit x86 with
glibc
d7798a4e2844 Tolerate safe size mismatches in the CrashpadInfo struct
Bug: 784427
Change-Id: I00b05eb950b32b2ce637dc7d7fb2909716332733
Reviewed-on: https://chromium-review.googlesource.com/773026
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#516902}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 81430cecfa1067172939dcaf1e0ba9fe4a97538c
ASan violates too many of crashpad's assumptions for it to be worth
making these tests pass. Even though most crashpad tests pass with ASan
and we could disable the five or so failing tests under ASan, I suspect
that new crashpad tests are likely to not work under ASan. I'd rather
not have to disable crashpad tests upstream and roll it just to pacify
these Windows ASan bots.
We should re-enable these tests when we care about shipping ASan builds
to users and reporting ASan errors back through craspad. Whoever works
on that is going to want to work through these tests failures and add
new integration tests here.
Remove the previous string test exclusion now that we won't run these
tests.
R=hans@chromium.org, mark@chromium.orgTBR=dpranke@chromium.org
Bug: 782907, 782454
Change-Id: I5ba89193a3bcf5017a5c087040f1b1679163c17b
Reviewed-on: https://chromium-review.googlesource.com/762380
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#515676}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e16a775e9e8a6133a074ec01b558ce17d2f93a7
6f6f8a144d89 Add FileModificationTime
13e17bf90f1e Fix FileModificationTime for Android
e2b9ab3ed202 win: Tests shouldn’t freak out when CodeView PDB links
are absent
0e3c38a4ca52 win: Make ProcessSnapshotTest.CrashpadInfoChild use a
loaded module
b8f61fdc8b1e Add TimevalToTimespec and use it to get CurrentTime on
macOS
Bug: 782781
Change-Id: Id8943d8e245cf3cbdb97ad52bcd664fa9dddab2a
Reviewed-on: https://chromium-review.googlesource.com/761878
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#515471}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 24e4db15c4bc9840b6830ffe10d75dababbd2343
Originally landed at efd8584f0232
(https://chromium-review.googlesource.com/751403) and subsequently
reverted at 49f5374a36de because of test failures. There are no changes
to this reland, but the test failures are addressed by updating Crashpad
to include
https://chromium.googlesource.com/crashpad/crashpad/+/d3b7463c7a48.
Until the recent ef647b4938a6 and 00a065492978, Crashpad tests did not
build or run in Chromium. Since then, crashpad_util_test was buildable
in Chromium, but was only run on Windows bots.
Crashpad has many more tests than crashpad_util_test, and its tests run
on both macOS and Windows. This change allows all of Crashpad’s unit
tests to build in Chromium’s GN-based build, and runs them on macOS and
Windows try- and buildbots.
Rather than having individual module-specific test executables like
crashpad_util_test, all unit tests are brought together into one
monolithic “crashpad_tests” executable.
On Windows, Crashpad also has an “end_to_end_test.py” which drives
crashpad_handler and some test crasher programs, and verifies the
produced minidump output by running the cdb debugger. That’s not
currently accounted for in the Chromium build.
As part of this change, additional Crashpad tools are also added to the
Chromium build, including the generate_dump tool.
Bug: 779790, 782011
Change-Id: Id192c40a1e7db178bdb093cd050b7fc5a5a876c9
Reviewed-on: https://chromium-review.googlesource.com/757188
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#514759}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1782adb1a98dc011a10049787696bd70671c1d06
d768538e39f3 Add ProcessSnapshotLinux
b851b2590b23 Update mini_chromium to dd0c3e9680ae
18726100ed9a Move win/time to misc/time and add more conversion
functions
34f5e8d513a8 Only disable -Wconstant-conversion for Clang, not GCC
d3b7463c7a48 win: Recognize nsi.dll presenting as
VFT_DRV/VFT2_DRV_NETWORK
2d077a2c571b win: Use “long” format modifier for DWORD
Change-Id: I9089b7a79d048429d0bc5898d57ea1fb06379fd1
Reviewed-on: https://chromium-review.googlesource.com/757079
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#514757}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 80c7ba1f1bd18e3eb2ebc232d95ea83137d63931
This reverts commit efd8584f0232f3b7be704d8f329032bdcfc11214.
Reason for revert: Causes crashpad_tests failure on Win7 bot. First failure:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64492
Original change's description:
> Build all Crashpad tests in Chromium, and run on Chromium bots
>
> Until ef647b4938a6 and 00a065492978 last week, Crashpad tests did not
> build or run in Chromium. Since then, crashpad_util_test was buildable
> in Chromium, but was only run on Windows bots.
>
> Crashpad has many more tests than crashpad_util_test, and its tests run
> on both macOS and Windows. This change allows all of Crashpad’s unit
> tests to build in Chromium’s GN-based build, and runs them on macOS and
> Windows try- and buildbots.
>
> Rather than having individual module-specific test executables like
> crashpad_util_test, all unit tests are brought together into one
> monolithic “crashpad_tests” executable.
>
> On Windows, Crashpad also has an “end_to_end_test.py” which drives
> crashpad_handler and some test crasher programs, and verifies the
> produced minidump output by running the cdb debugger. That’s not
> currently accounted for in the Chromium build.
>
> As part of this change, additional Crashpad tools are also added to the
> Chromium build, including the generate_dump tool.
>
> Bug: 779790
> Change-Id: I87104558c4e33d59b0c6a77bfe0f6f42009a4690
> Reviewed-on: https://chromium-review.googlesource.com/751403
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Commit-Queue: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514167}
TBR=dpranke@chromium.org,rsesek@chromium.org,mark@chromium.org,siggi@chromium.org
Change-Id: I0f1298327e1a9069685811ac5e6eb27d92e7dceb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 779790, 782011
Reviewed-on: https://chromium-review.googlesource.com/756174
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#514296}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49f5374a36de074d0b3edeb9f07d80468ec20caa
Until ef647b4938a6 and 00a065492978 last week, Crashpad tests did not
build or run in Chromium. Since then, crashpad_util_test was buildable
in Chromium, but was only run on Windows bots.
Crashpad has many more tests than crashpad_util_test, and its tests run
on both macOS and Windows. This change allows all of Crashpad’s unit
tests to build in Chromium’s GN-based build, and runs them on macOS and
Windows try- and buildbots.
Rather than having individual module-specific test executables like
crashpad_util_test, all unit tests are brought together into one
monolithic “crashpad_tests” executable.
On Windows, Crashpad also has an “end_to_end_test.py” which drives
crashpad_handler and some test crasher programs, and verifies the
produced minidump output by running the cdb debugger. That’s not
currently accounted for in the Chromium build.
As part of this change, additional Crashpad tools are also added to the
Chromium build, including the generate_dump tool.
Bug: 779790
Change-Id: I87104558c4e33d59b0c6a77bfe0f6f42009a4690
Reviewed-on: https://chromium-review.googlesource.com/751403
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#514167}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: efd8584f0232f3b7be704d8f329032bdcfc11214
3231a80e8b69 Add the minidump extension and writer for Annotation
objects
f9e587b036b1 Remove NOTREACHED() in ModuleSnapshot::AnnotationObjects()
impls
e38c57a9c658 Expose the annotation_objects on MinidumpModuleCrashpadInfo
620a29dbf356 Add support for reading annotation objects in
ModuleSnapshotMinidump
2db30e035a00 win: Fix Clang -Wsign-compare warnings in new test code
Change-Id: Ib1eb0ae9c20b2ccfe523bdd596dc90ad15322875
Reviewed-on: https://chromium-review.googlesource.com/751381
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#513711}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 90d447d79f8da95ff0e705080fb46de5d894aa0d
b88fde0b5647 Add the AnnotationSnapshot object and attach it to
ModuleSnapshot
38c8f51ae88b Add MinidumpByteArray extension and its Writer
e4723d524f19 Expand the MachOImageAnnotationsReader to read Annotation
objects
9609b7471676 Expand the PEImageAnnotationsReader to read Annotation
objects
7e82179d43a4 Move filesystem test utilities to test/
8db7e7dc3912 test: Don’t hide --gtest_* arguments from Chromium’s
test runner
81eced5192d9 snapshot: Specify test dependencies properly
a0f4f294b1e2 win handler: Provide a wmain() entry point
a51e912004a6 Fix warnings produced by trunk clang in test code
af594c8deb08 Heap-allocate MinidumpContextAMD64Writer objects with
proper alignment
1669ca2bac66 test: Rework TestPaths interface for obtaining 32-bit build
artifacts
c542a5ae0371 net: Remove extra spaces from WinHttp log messages
43b798b492a2 test: Fix paths for crashpad_tests monolith in Chromium
4f5524fc684c Fix Windows build after 81eced5192d9
6950a552bfab doc: Fix Doxygen-generated documentation after 34699d378b82
Change-Id: I6361f8a454e1539399fa260165f4385ed209a2de
Reviewed-on: https://chromium-review.googlesource.com/748815
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#513217}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e7838d29b7a2fa8d1935d67268dec065df227585
fbc365fa9ed5 GCC 7.2 support (-Wnoexcept-type)
2f481590112b Make crashpad_util_test build without warnings with clang-
cl on Windows
b96b9f627ee7 win: Use test::ErrorMessage() in test::ChildLauncher
52d766400da1 linux: ProcessReader can own ProcessMemoryLinux without
unique_ptr
9bc5989125b8 crashpad_util_test warning fixes for clang-cl, 64-bit
edition
34699d378b82 Create client data structures for typed Annotations
5e9ed4cb9f69 win: Dynamically disable WoW64 tests absent explicit 32-bit
build output
cb3aa9c4d8f3 DumpAndCrash in extended handler test in favor of debug
break
c49da9caef30 win: Expect uneven symbolic link support
1dae919b7e5a #include "base/logging.h" in client/annotation.h for
DCHECK()
ef262d1ee3c2 #include "build/build_config.h" where needed
672c87258912 Upstream crashpad_util_test-in-Chromium changes
692488a254c4 Un-disable WinMultiprocess-based tests in Chromium
3fae8ff07c09 win: Fix -Wsign-compare warnings produced by clang
Change-Id: I4b1355afce8be5571af3582f7dd0057b5018d70f
Bug: crashpad:204, crashpad:205
Reviewed-on: https://chromium-review.googlesource.com/742284
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#512421}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a34342c04d44aca77783f9f89acf1550957ddfe6
Ran
python tools\mb\mb.py run out\gn crashpad_util_test
to locally verify data and data_deps entries for swarming.
Swarming apparently requires the use of base::TestLauncher, so
use that in Crashpad-in-Chromium builds. Disable a bunch of tests
that fail in that setup.
Bug: 777924,778672
Change-Id: I4aa828040d488755582e5559d5f117e1ed8d1c86
Reviewed-on: https://chromium-review.googlesource.com/737439
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#512262}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00a0654929787f70b0cd81f30aa14e81c5e11b2f
The support library roll will require update in both the public and
the internal repos. In order to avoid breaking the builders, this
patch declares target we will need downstream so that they can be
referred to early.
Bug: 769683
Change-Id: If45b97ec373d1e876d0069037e7cbc2005bf7eb8
Reviewed-on: https://chromium-review.googlesource.com/738768
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#512169}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 15f16222e0377c88a0a68392d7a11be2068a9957
Fix all warnings emitted in cl.exe and clang-cl Windows builds.
I verified that crashpad_util_test works in those two configurations.
This omits the tests in process/, because that code is
linux-only and .gn files don't hook up linux code yet.
Some new tests are only added on non-Windows since they fail
on Windows (see util/BUILD.gn).
Bug: 777924
Change-Id: I5378085f78908af2aefb93991087e0190938641f
Reviewed-on: https://chromium-review.googlesource.com/735820
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511547}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ef647b4938a6c0b5fccf740ef44e1654d80320a4
be7b8a509cd3 Include stddef.h for offsetof() in cpuid_reader.cc
59c5d848e5c5 linux: Refactor `ptrace` usage
a04edfad5c36 Accept a non-empty vdso name in linux/debug_rendezvous_test
45de8bf76e32 Add generic VMAddress-related types
f3a8dbd6710b net: Identify clients via URL parameters during report
upload
9e07a7148ce6 Move linux/elf files to snapshot/elf
cea0671011e6 win: Add crashpad_handler_console as a dependency of
crashpad_client_test
6c9bd10a24ad Use generic VM types in snapshot/elf
78b6353e458b android: Build FakePtraceConnection on Android
f6aebd8bafd0 android: Fix build after 45de8bf76e32
c6adcc2482f9 win: Make CrashpadClient::DumpAndCrashTargetProcess() less
chatty
90054edf6202 win: De-flake hanging_program.exe
2e9282c9f97e Update buildtools, gtest, and gyp
370e441962cd win: Address late feedback after 90054edf6202
e5896de993bd win: Fix process_structs.h definition of
RTL_USER_PROCESS_PARAMETERS
31df2acb1239 win: Fix messages in
ProcessInfo::LoggingRangeIsFullyReadable()
93c88d87f0ac win: Don’t appear to be a client connecting in
end_to_end_test.py
6de7ad8a2255 Fix Android x86_64 build when using traditional headers
10411266ed3f linux/android: List compat headers in compat.gyp
2633708f8440 android: Support mmap() with large file offsets and API <
21
1abaf22e2813 Use readdir() instead of readdir_r() on all (POSIX)
platforms
fe4b16fe88ae Move linux/process files to util/process
a99c84b8b417 Use generic VM types in util/process
4c4e67952c93 win: 10.0.16299.0 SDK compatibility
7a849482eaca Switch the language standard to C++14 and use
std::make_unique
a327c86a52c3 C++14 is required, don’t pretend to support pre-C++11 or
pre-MSVS 2015
c958c164915b Declare overriding method with override
dabe8477dab0 win: Fix TEB.TlsSlots offset
906fce1d0144 Make ProcessMemory an abstract interface
474c7331a6df Add DirectoryReader to iterate over files in a directory
4d7a07f6849c Add ScopedRemoveFile to call LoggingRemoveFile for a
FilePath
68a0e736c651 Use a FileReaderInterface for file attachments instead of a
FilePath
419f25eac8d8 Remove PointerVector<> and replace with
std::vector<std::unique_ptr<>>
ce084d37c83d Add MoveFileOrDirectory to move files, directories, or
symbolic links
55133d332b6c win: Use inline asm instead of ml.exe for
SafeTerminateProcess()
2f4516f93838 win: Provide broken CHECK()ing dummy CaptureContext() for
cross builds
aff8d906b6d1 linux: Fix interpretation of device numbers in
/proc/pid/maps
8b63f1f00a22 snapshot/linux: Fix #includes
c2cc76dc26c0 util/linux: #include what you use
025455e77af4 Remove one more vestige of pre-C++11 library support
6d5bd1d04d5f win: Go back to using ml.exe for SafeTerminateProcess()
Change-Id: I376e30821e9406f78a57dee213900d8f747f9fcf
Reviewed-on: https://chromium-review.googlesource.com/733614
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511275}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b653292f3f8de3ac19374d12090c46dc20b4220f
The inline asm doesn't work in clang builds for reasons I don't yet understand.
Since we just switched to clang by default, lets get back to a good state first.
TBR=mark@chromium.org
Bug: 777579,777741,762167
Change-Id: I928ebaeaca033da69eaf1d832f477fb3fdca0283
Reviewed-on: https://chromium-review.googlesource.com/735619
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511127}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: af5f31ed615bdbf0ad246cff643a2802a1e0d702
- Add the vision-common client, since the vision client has been split
into vision and vision-common.
- Add a landmine, since GN can't deal with reversing the dependency
between google_play_services_vision_common_java and
google_play_services_vision_java.
- Add the basement client's Proguard config to all the other clients,
since common Proguard flags are now consolidated in basement, rather
than being duplicated for all clients.
- Update the cached .info files, as is required since
cf7f522954566498f01a4809932319b720e57338.
- Make InstanceIdWithSubtype contain rather than extend InstanceID. The
InstanceID constructor which takes a subtype is now private; iid
instead exposes a getInstance which takes the subtype via Bundle.
BUG=706943
Change-Id: I16ba37243eb7a5b49539fefe489986fcd3f8ffb0
Reviewed-on: https://chromium-review.googlesource.com/729047
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510877}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3a7fff53a24d265afd73b181d0771a8c5046480a
This is not fit for production, but it unblocks building 'chrome',
'browser_tests', and almost all other targets on Linux hosts.
Bug: 762167
Change-Id: Ib0b7de5cbc71c87ca3630254d6ddda0ad38f1769
Reviewed-on: https://chromium-review.googlesource.com/733601
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fc1ac734b09f7f8017c01d66947b3d17b1ba1718
It's a bit less code, and it removes one of two uses of ml.exe in the chrome
build. No intended behavior change.
clang-cl's output for the new code:
mov eax, dword ptr [__imp__TerminateProcess@8]
push ebp
mov ebp, esp
push dword ptr [ebp + 12]
push dword ptr [ebp + 8]
call dword ptr [eax]
test eax, eax
setne al
mov esp, ebp
pop ebp
ret
cl.exe's output for the new code:
push ebp
mov ebp, esp
push DWORD PTR [ebp+12]
push DWORD PTR [ebp+8]
call DWORD PTR __imp__TerminateProcess@8
test eax, eax
setne al
mov esp, ebp
pop ebp
ret 0
Bug: 762167
Change-Id: I54266504a09c150ef6ae8fb8defa42af65ac7e6c
Reviewed-on: https://chromium-review.googlesource.com/732030
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510822}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 912c9907d5636ec45d59f95cd0902f4215e027d9
Shows an invitation to take a survey if Chrome Home was enabled
for longer than 1 week.
Creates a generic survey controller for future surveys.
Creates a Chrome Home specific controller.
Bug: 754499
Change-Id: I53064f181fcd8832a5524eb4d7d38841531c84e7
Reviewed-on: https://chromium-review.googlesource.com/683323
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#507156}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dead4a6c01ec0850e2ea507427cf60b2ad39c93b
f16e4eb9ffbf Implement SleepNanoseconds() on Windows
b953388b9553 Add SystemSnapshotLinux
ad1b86535c6a Roll mini_chromium to 068fe690218f
20ed4146d377 Use StringPiece for key and value in SimpleStringDictionary
interface
Bug: 758724
Change-Id: I0ef3d1a95dd2b2475a11256891beca32ab593fc5
Reviewed-on: https://chromium-review.googlesource.com/652669
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500022}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 97fba6506881970e6c7b0578a9cee9ef977321fe
This reverts commit 03ac069ca8de6a9b92572fadd73f79f794f129ab.
Reason for reland: Reworked support .aars to work with downstream
Speeds up "gn gen" by about 600ms on my machine.
NOTRY=true (all passed except net_unittests, which is globally broken atm)
TBR=bshe@chromium.org
Bug: 748851, 759903
Change-Id: I639aeb64ef2f531589e8c04535d48a54e413fe15
Reviewed-on: https://chromium-review.googlesource.com/641371
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498216}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf7f522954566498f01a4809932319b720e57338
Speeds up "gn gen" by about 600ms on my machine.
BUG=748851
Change-Id: I2a4208728eddc49bab040459e9b93552d0a9cc55
Reviewed-on: https://chromium-review.googlesource.com/609147
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497853}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5302e35e0230a5661f081732b621241cfa00c4bf
Missing deps weren't causing any problems, but correctness is required
for a later change. Deps found via maven pom.xml files.
Bug: 695304
Change-Id: Ic0ea9d652db8fa417bd8bc410ff139f061ee56df
Reviewed-on: https://chromium-review.googlesource.com/611725
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494271}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c364075d22c97468f204d35ce066c52d268744f4
b42854dfe134 Fix Doxygen after 8c802aace407
bf52da0f1bc1 posix: Fix Semaphore::TimedWait wait time
d2d10d1dc8f3 posix: Use std::trunc() from <cmath> instead of trunc()
7819ecbed662 posix: Use trunc() from <math.h> instead of std::trunc()
f37b382687c0 linux/android: Reenable util test, and enable snapshot test
a8493c9b3148 android: Fix FloatContext::NativeFpxregs for x86 with
unified headers
376cddee9eea doc: Update for NDK r15b
6823f6783082 Limit alignas to 64
3d6f7bcf90f5 Enable x86 optimizations for zlib
13e8672410d8 Update mini_chromium to ee67585e3115
1c87c92932d0 linux: Add ProcessMemoryRange to restrict memory reads to a
range
4224be41d7d1 linux: Add ElfImageReader to read ELF images via
ProcessMemory
a79791969d03 linux: Add MemoryMap::FindFileMmapStart
041a50d75c4c linux: Add DebugRendezvous to read dynamic linker data
structures
6ab73e0ad8ac linux: #include appropriate headers for ElfImageReader
5536baff1392 linux: Use PTRACE_GET_THREAD_AREA for x86
ThreadInfo.GetThreadArea
6b5f139d88ce linux: Add ProcessReader
7be6b8ea1ded Add functions to convert native x86 contexts to Crashpad
CPUContexts
bde35ca918ba Add MemorySnapshotLinux
37f20f7b1400 Add ThreadSnapshotLinux
9299d409ab0a linux: Refactor reading start time from the stat file
90e4649f0dfa linux: Sort alphabetically in util .gyp files
01b347732e0e linux: Collect CPU times in ProcStatReader and use in
ProcessReader
281be63d0074 Standardize on static constexpr for arrays when possible
7e6a0145b17b mac handler: Record the number of open files in the handler
process
6dac7ecdf58e Use constexpr at function scope
8f0636288a0e Use constexpr at namespace scope
b653f8615321 Fix Windows build after 8f0636288a0e
a06ca92083f5 Switch CQ to use the new swarmbucket (LUCI) builders
3a5837c77379 #include "build/build_config.h" where necessary
c332e7ffdab6 Fix Doxygen usage in util/misc/lexing.h
1d443b822364 Revert "Switch CQ to use the new swarmbucket (LUCI)
builders"
c9319008b609 Disable the win x86 tests in the CQ until they are swarmed
43a1e46a31f5 Tweak the README wording
7f038ebbd2df #include "build/build_config.h" where necessary
Change-Id: Ib6fe73caf333ecda8f1311ca212dae41affa534d
Reviewed-on: https://chromium-review.googlesource.com/592694
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490857}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9b9fe1cfc5ae9e3cc39361e6e3ed0e928391d8e
To be used in testing system APK removal and replacement.
Bug: 728404
Change-Id: I7e1dc884098f6639eef93a4534e3254fc5f7516a
Reviewed-on: https://chromium-review.googlesource.com/530102
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#482331}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3fa4315be4d2fb7769629ac3af9ced0e5a39537e
d3e4f09742d6 linux: Collect fxsave instead of fsave in ThreadInfo
8c802aace407 Add ReinterpretBytes which does a checked, variable size
bit cast
c4f6ca3c6ac5 mac: Provide a larger thread state buffer for AVX-512 on
10.13
Bug: 733387, crashpad:30, crashpad:185, crashpad:190
Change-Id: Ib4c1ab4c64c7e8697daca7695b81caa426e25b48
Reviewed-on: https://chromium-review.googlesource.com/541517
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480842}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2d809772b79618f5504d642bd6100bd226402ce
Reason for revert:
downstream breakage fixed by adding another mock target downstream
Original issue's description:
> Revert of Add a mock vision-common GMS client target (patchset #1 id:1 of https://codereview.chromium.org/2888283002/ )
>
> Reason for revert:
> broke downstream
>
> Original issue's description:
> > Add a mock vision-common GMS client target
> >
> > Upcoming GMS versions will split the vision client into vision and
> > vision-common. In order to roll downstream, we must add an upstream
> > dependency on vision-common. But upstream is not yet ready to roll, so
> > we add a mock vision-common target to temporarily satisfy the new
> > dependency in upstream builds.
> >
> > BUG=706943
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> >
> > Review-Url: https://codereview.chromium.org/2888283002
> > Cr-Commit-Position: refs/heads/master@{#473268}
> > Committed: 420cf37ad0
>
> TBR=agrieve@chromium.org,reillyg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=706943
>
> Review-Url: https://codereview.chromium.org/2893093002
> Cr-Commit-Position: refs/heads/master@{#473302}
> Committed: 9010e14d8fTBR=agrieve@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706943
Review-Url: https://codereview.chromium.org/2892953003
Cr-Original-Commit-Position: refs/heads/master@{#473377}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eaf7cc9d2e262724f33be38d880fcb7eaa97100d
Reason for revert:
broke downstream
Original issue's description:
> Add a mock vision-common GMS client target
>
> Upcoming GMS versions will split the vision client into vision and
> vision-common. In order to roll downstream, we must add an upstream
> dependency on vision-common. But upstream is not yet ready to roll, so
> we add a mock vision-common target to temporarily satisfy the new
> dependency in upstream builds.
>
> BUG=706943
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2888283002
> Cr-Commit-Position: refs/heads/master@{#473268}
> Committed: 420cf37ad0TBR=agrieve@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706943
Review-Url: https://codereview.chromium.org/2893093002
Cr-Original-Commit-Position: refs/heads/master@{#473302}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9010e14d8fc816219fe22ca57b63a9d1eefef45b
Upcoming GMS versions will split the vision client into vision and
vision-common. In order to roll downstream, we must add an upstream
dependency on vision-common. But upstream is not yet ready to roll, so
we add a mock vision-common target to temporarily satisfy the new
dependency in upstream builds.
BUG=706943
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2888283002
Cr-Original-Commit-Position: refs/heads/master@{#473268}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 420cf37ad0ddf1c54203a4fdffb68af920503b0e
Enable tombstones for swarming bots. Previously if a test case is
crashed on swarming bots, no tombstones will be resolved, and even if
they are attempted to be resolved, they will fail because of the lack of
tool chains.
In this cl, we are enabling tombstones for swarming bots and we are also
adding tool chains to the dependency.
BUG=631213
Review-Url: https://codereview.chromium.org/2883633003
Cr-Original-Commit-Position: refs/heads/master@{#472615}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fc66094f89df0ecca2a3378296304a9c7e66bbff
The stability file naming code is needed both to know which file to
record to and to know which file to collect on crash (note that for the
postmortem case we simply glob files).
Note: changing the file naming is fine wrt live code as the only
current consumption of stability files is via glob on the postmortem
path.
BUG=718437
Review-Url: https://codereview.chromium.org/2860863003
Cr-Original-Commit-Position: refs/heads/master@{#469733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 531ed20b52b93b78c30a73e37ccf968238c25d84
bsheedy
John Budorick
Zhiling Huang
Peter Collingbourne
Derek Cheng
Scott Graham
Mark Mentovai
Reid Kleckner
Robert Sesek
meade_UTC10
Nicolas Dossou-gbete
Nico Weber
Paul Miller
Daniel Park
Sigurdur Asgeirsson
Andrew Grieve
Eric Stevenson
Ingemar Ådahl
Mike Bjorge
Sergey Ulanov
paulmiller
hzl
manzagop