6626a30e61
Change test_isolation_mode default from noop to check
...
TBR=maruel@chromium.org
NOTRY=True
BUG=
Review URL: https://chromiumcodereview.appspot.com/12623013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187625 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-12 18:59:16 +00:00
d3a79fb81c
Hotfix the build on the ChromeOS ASan bots: only add a dependency on ASan dynamic runtime for OS X and iOS.
...
BUG=170629
TBR=mark
Review URL: https://codereview.chromium.org/12716011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187582 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-12 14:06:16 +00:00
a22f2863b3
Revert 187575 "Change test_isolation_mode default from noop to c..."
...
> Change test_isolation_mode default from noop to check
>
> NOTRY=True
> TBR=maruel@chromium.org
> BUG=
>
>
> Review URL: https://chromiumcodereview.appspot.com/12454003
TBR=csharp@chromium.org
Review URL: https://codereview.chromium.org/12408025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187579 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-12 13:50:53 +00:00
ddd652afbd
Change test_isolation_mode default from noop to check
...
NOTRY=True
TBR=maruel@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/12454003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187575 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-12 13:27:48 +00:00
3920cdb878
Re-land https://codereview.chromium.org/11642018/ : Add a postbuild action for executables built with ASan on Mac OS.
...
The action will copy the ASan dynamic runtime to the output dir and into every
bundled executable being built.
Unlike the previous change, this one does not touch build/all.gyp, since our target
doesn't need to be built when building 'All'.
BUG=170629
TBR=thakis,mark
Review URL: https://codereview.chromium.org/12685006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187566 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-12 11:56:31 +00:00
2d827c22b2
Android: rename android_build_type gyp variable.
...
Rename the "android_build_type" gyp variable to "android_webview_build"
to better describe what it does. There are still references in WebKit
and V8 that need to be changed before the original variable can be
removed.
BUG=184431
Review URL: https://codereview.chromium.org/12730006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187556 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-12 10:22:36 +00:00
32a5997dba
PPAPI: Remove threading options; it's always on
...
This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
BUG=159240,92909
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186925
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=186939 due to build errors
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187340
Review URL: https://chromiumcodereview.appspot.com/12378050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187427 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-12 00:41:08 +00:00
2f171fbf43
Revert 187340 "PPAPI: Remove threading options; it's always on"
...
> PPAPI: Remove threading options; it's always on
>
> This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
>
> BUG=159240,92909
>
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186925
> Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=186939 due to build errors
>
> Review URL: https://chromiumcodereview.appspot.com/12378050
TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/12476028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187346 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-11 19:58:09 +00:00
8d4784f7c3
PPAPI: Remove threading options; it's always on
...
This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
BUG=159240,92909
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186925
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=186939 due to build errors
Review URL: https://chromiumcodereview.appspot.com/12378050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187340 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-11 19:33:53 +00:00
6b07d49787
Revert 187297
...
> Add a postbuild action for executables built with ASan on Mac OS.
> The action will copy the ASan dynamic runtime to the same dir where
> the executable is.
>
> BUG=170629
> Review URL: https://codereview.chromium.org/11642018
TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/12440020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187309 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-11 17:30:53 +00:00
d65fd9f99f
Add a postbuild action for executables built with ASan on Mac OS.
...
The action will copy the ASan dynamic runtime to the same dir where
the executable is.
BUG=170629
Review URL: https://codereview.chromium.org/11642018
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187297 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-11 15:30:18 +00:00
3c350ef79c
Only specify C++ warnings when building C++ code.
...
Review URL: https://codereview.chromium.org/12734005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187292 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-11 13:59:16 +00:00
c8f63936a9
Linux: use -Wl,--no-as-needed on 32-bit builders.
...
This is needed to fix a linking error on Ubuntu Precise:
/usr/bin/ld: out/Debug/obj.target/sync/libsync.so: undefined reference to symbol 'SSL_ExportKeyingMaterial'
/usr/bin/ld: note: 'SSL_ExportKeyingMaterial' is defined in DSO out/Debug/obj.target/net/third_party/nss/libcrssl.so so try adding it to the linker command line
out/Debug/obj.target/net/third_party/nss/libcrssl.so: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make: *** [out/Debug/unit_tests] Error 1
TBR=thestig
BUG=170262
Review URL: https://codereview.chromium.org/12633012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187181 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-10 03:07:45 +00:00
afa91a139d
[MIPS] Set CXX variable used for v8 build
...
This change sets CXX gyp variable for target_arch=="mipsel".
It is a follow up of the change in v8, and it resolves issue of
incorrectly passed m32 flag to MIPS cross toolchain.
Full discussion with Jakob Kummerow and related v8 change can be seen at:
https://codereview.chromium.org/12218113/
BUG= https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome
Review URL: https://chromiumcodereview.appspot.com/12699003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@187124 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-09 02:51:28 +00:00
2be1efb1a7
Revert 186925 since it breaks many of the builds on the bots (e.g.
...
http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/45240/steps/compile/logs/stdio ).
> PPAPI: Remove threading options; it's always on
>
> This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
>
> BUG=159240,92909
>
>
> Review URL: https://chromiumcodereview.appspot.com/12378050
TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/12504007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186939 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-08 11:10:10 +00:00
95c7836b00
PPAPI: Remove threading options; it's always on
...
This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere.
BUG=159240,92909
Review URL: https://chromiumcodereview.appspot.com/12378050
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186925 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-08 09:29:14 +00:00
d0d70ccbf4
Add PNaCl PPAPI browser tests via pre-translation.
...
Helps test that the shim and the compiler work together
correctly. At this moment, this does not use the in-browser
translator, since the ppapi browser test nexe is large and
the translation cache does not get shared between
invocations. See comments in bug 2484 about this.
BUG= https://code.google.com/p/nativeclient/issues/detail?id=2484
TEST= browser_tests --gtest_filter=*PNaCl*
Review URL: https://chromiumcodereview.appspot.com/12288013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186787 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-07 22:07:33 +00:00
5210a618cb
remove another reference to "library"
...
BUG=111541
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12529002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186430 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-06 14:06:17 +00:00
3d3e9730df
Update ndk sysroot to API level 14.
...
Update ndk toolchain to api level 14 to make application to be
able to setup SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION
mode which was introduced in api level 14 in opensl.
BUG=179926
Review URL: https://chromiumcodereview.appspot.com/12379078
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186254 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-05 20:54:33 +00:00
9b4c1570b0
Make it possible to override the default mipsel sysroot.
...
Also, update the default mipsel sysroot to match the work in issue 12315003.
Review URL: https://chromiumcodereview.appspot.com/12387011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186251 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-05 20:50:07 +00:00
dcc162d788
Revert 186179 - Change test_isolation_mode default from noop to check
...
This broke the Mac ASan bots: They fail during runhooks.
NOTRY=True
BUG=
Review URL: https://chromiumcodereview.appspot.com/12330117
TBR=csharp@chromium.org
Review URL: https://codereview.chromium.org/12453002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186182 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-05 15:52:20 +00:00
137cee0dcb
Change test_isolation_mode default from noop to check
...
NOTRY=True
BUG=
Review URL: https://chromiumcodereview.appspot.com/12330117
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186179 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-05 15:28:04 +00:00
b04ee0e4ee
Remove "use_skia" variable from gyp.
...
We've now switched to Skia from CoreGraphics entirely. See
http://crbug.com/110881 for details.
This change removes the vestigal "use_skia" variable. I'll send follow-up
patches to remove uses of USE_SKIA from Chromium source.
BUG=110881
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/12379030
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186155 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-05 11:52:26 +00:00
0a7b1d0150
Cleanup: Remove another reference to web intents.
...
BUG=173194
Review URL: https://chromiumcodereview.appspot.com/12393057
git-svn-id: http://src.chromium.org/svn/trunk/src/build@186098 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-05 04:25:22 +00:00
9afccecc62
fix linking against olepro32.lib on win x64
...
R=jschuh@chromium.org
BUG=179717
Review URL: https://codereview.chromium.org/12377089
git-svn-id: http://src.chromium.org/svn/trunk/src/build@185968 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-04 20:58:36 +00:00
e29281cef1
Linux: Use the system ld instead of gold for 32-bit builds. Pass --no-keep-memory to prevent linker OOM errors.
...
BUG=170262
Review URL: https://chromiumcodereview.appspot.com/12330042
git-svn-id: http://src.chromium.org/svn/trunk/src/build@185374 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-03-01 00:11:23 +00:00
526012d7dc
Remove some more web intents code I missed previously
...
Thanks to Jochen for finding it.
BUG=173194
TBR=tony
Review URL: https://codereview.chromium.org/12340107
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184957 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-27 15:29:45 +00:00
bf07df1195
MemorySanitizer: common.gypi changes.
...
R=glider@chromium.org ,timurrrr@chromium.org
BUG=178409
Review URL: https://chromiumcodereview.appspot.com/12342013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184713 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-26 20:06:59 +00:00
078d8890f3
Add delayimp.lib to default libs in preparation for GYP change & roll.
...
R=cpu@chromium.org
BUG=176040
Review URL: https://chromiumcodereview.appspot.com/12330116
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184496 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-25 22:10:39 +00:00
1b69e52585
This change enables tcmalloc on Win64
...
BUG=177300
Review URL: https://chromiumcodereview.appspot.com/12324020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184292 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-23 06:06:55 +00:00
4e125330a9
Disable pyauto for Win64 build
...
Pyauto doesn't build on Win64 due to several issues. Since
it's deprecated it may not be worth the effort of fixing,
but in the immediate term I need it disabled for just the
Win64 build.
BUG=177664
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12334038
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184171 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-22 21:02:07 +00:00
52b2461d0d
Introduce Image loader extension.
...
Files.app's ui used to be unresponsive, when displaying large images. This was caused because of contex.drawImage() synchronous
call on the UI thread, which takes sometimes even 300 ms per one picture. In case of loading more images it causes ui freezes.
This patch solves this issue by introducing an image loader extension, which loads and resizes images asynchronously.
With this fix, we will be able to enable mosaic view on each volume, not only on Drive.
TEST=Check thumbnails in Files.app, including photo importer and gallery.
BUG=175697, 176237, 168035
Review URL: https://chromiumcodereview.appspot.com/12304013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184088 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-22 11:17:25 +00:00
9ea5bbd2cd
Linux: Do not include CFI data in the .eh_frame section for 32-bit release builds. This reduces output binary size and does not seem to have an affect on crash reports.
...
Review URL: https://chromiumcodereview.appspot.com/12330039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@184018 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-22 04:10:35 +00:00
a613933795
enable -Wstring-conversion when compiling with clang
...
Summary of try run with flag enabled as warning:
On linux_clang, there's false positives from a bunch of assert usage that does !"string" or "string" for a true or false value. It's only in third_party (Mesa, skia, libjingle, etc.) so it probably wouldn't be too hard to disable the warnings in those subtrees.
It diagnoses 4 useful locations:
1.
../../base/debug/trace_event_unittest.cc:70:41: warning: implicit conversion turns string literal into bool: 'const char [2]' to 'bool' [-Wstring-conversion]
TraceLog::GetInstance()->SetEnabled("*");
~~~~~~~~ ^~~
2.
../../sync/syncable/entry_kernel.cc:77:38: warning: implicit conversion turns string literal into bool: 'const char [5]' to 'bool' [-Wstring-conversion]
value->SetBoolean("encrypted", "true");
~~~~~ ^~~~~~
3.
../../chrome/browser/webdata/web_data_service.cc:334:17: warning: implicit conversion turns string literal into bool: 'const char [44]' to 'bool' [-Wstring-conversion]
DLOG_ASSERT("WebDataService dtor called without Shutdown");
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:595:43: note: expanded from macro 'DLOG_ASSERT'
4.
../../chrome/browser/renderer_host/web_cache_manager_unittest.cc:259:20: warning: implicit conversion turns string literal into bool: 'const char [29]' to 'bool' [-Wstring-conversion]
EXPECT_FALSE("Unexpected entry in strategy");
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Finding #1 is what made me look into this, #3 and #4 are not doing what they're supposed to, and #2 is kind of funny so not all is lost.
So, 3 bugs and 1 very-close-to-a-bug: seems worth enabling.
R=thakis@chromium.org
TBR=darin@chromium.org , dhollowa@chromium.org , brettw@chromium.org , zea@chromium.org
BUG=177306
Review URL: https://chromiumcodereview.appspot.com/12258039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183998 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-22 03:37:51 +00:00
639e7bec59
Enable autofill dialog codepath on Android.
...
Note that it will crash on Android if the user initiates an autocomplete
action on a rAc-enabled web-page.
There is a subseqent CL that sets up an empty shell to avoid crashes.
BUG=177508
Review URL: https://chromiumcodereview.appspot.com/12330059
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183997 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-22 03:37:22 +00:00
7a45e488db
Add gyp flag to specify whether we should optimize JNI generation.
...
Do not regenerate JNI files (and subsequently the .so file) if they have
not changed. This will happen if you edit a java file that has a native
counterpart, but the native signatures were not touched.
We do not enable this all the time as some build systems require that
when you modify an input, the output should also be modified. This
also will result in more command line output, so we'll keep it behind
a developer flag for now.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12314025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183936 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-22 00:37:33 +00:00
512bf4bd5c
Support spdy proxy origin settings via gyp.
...
BUG=176057,175895
Review URL: https://chromiumcodereview.appspot.com/12294048
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183832 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-21 17:52:29 +00:00
d63f62a841
Fix Android x86 release official build.
...
Android toolchain linker does not support --no-keep-files-mapped flag.
Add a gyp condition to disable this flag for Android.
BUG=177400
Review URL: https://chromiumcodereview.appspot.com/12317040
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183828 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-21 17:20:15 +00:00
359d57ffb2
Enable CLD for Android and register the translate manager on the renderer
...
BUG=149349
Review URL: https://chromiumcodereview.appspot.com/12295008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183513 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-20 13:54:12 +00:00
a013757a87
Linux: add a tool and code to make use_system_ffmpeg option more compatible
...
This introduces a compile-time detection of ffmpeg configuration
(which codecs are available).
See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/fm5Oe_AC3Sc/qkbmC7txaSkJ
for more context.
No functional change for Google Chrome.
BUG=none
Review URL: https://codereview.chromium.org/12302029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183463 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-20 10:35:01 +00:00
b5ab497204
build: Remove deprecated 'library' variable from common.gypi.
...
Looks like all the third_party usages were fixed.
BUG=111541
R=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12261058
git-svn-id: http://src.chromium.org/svn/trunk/src/build@183142 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-18 22:21:17 +00:00
5c4cf6978c
Add default import libraries to common GYP config in preparation for GYP changes that remove default library configuration.
...
R=scottmg@chromium.org
BUG=176040
Review URL: https://chromiumcodereview.appspot.com/12256014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@182699 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-15 13:48:40 +00:00
fdde1443ee
Revert 182241
...
This seems to have broken the Mac ASAN LKGR builders. For example:
http://build.chromium.org/p/chromium.lkgr/builders/Mac%20ASAN%20Release/builds/1188/steps/compile/logs/stdio
> Roll Clang r170392:r174491.
>
> BUG=174873, 170629
>
> Review URL: https://codereview.chromium.org/12220089
TBR=hans@chromium.org
Review URL: https://codereview.chromium.org/12256052
git-svn-id: http://src.chromium.org/svn/trunk/src/build@182603 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-15 02:31:54 +00:00
5e12eebaa3
Roll Clang r170392:r174491.
...
BUG=174873, 170629
Review URL: https://codereview.chromium.org/12220089
git-svn-id: http://src.chromium.org/svn/trunk/src/build@182241 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-13 16:35:23 +00:00
44d73a7b8f
Revert "Roll Clang r170392:r174491."
...
It turns out that r181918, which pinned the Clang revision on Mac ASan
bots worked a little too well, pinning the version on *all* Mac bots.
This reverts the Clang roll. We will then fix update.sh to get the Mac
ASan pinning correct, and then re-land the roll.
BUG=174873, 170629
Review URL: https://codereview.chromium.org/12256002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@182173 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-13 09:30:02 +00:00
3874b4bdfc
Roll Clang r170392:r174491.
...
BUG=174873, 170629
Review URL: https://chromiumcodereview.appspot.com/12220089
git-svn-id: http://src.chromium.org/svn/trunk/src/build@182023 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-12 21:40:04 +00:00
a99fddb449
Disable RTC in coverage builds.
...
Syzygy is unable to instrument some of the Chrome tests (browser_tests and unit_tests) due to interactions with RTC. Disable them so that we can collect full coverage stats.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12207129
git-svn-id: http://src.chromium.org/svn/trunk/src/build@182004 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-12 21:02:29 +00:00
ecf166db7e
Do not strip ASan builds.
...
As of Clang r174490 instrumented binaries do not include the __asan_* symbols,
so the postbuild strip action fails.
This is a temporary measure, we may need to do something else (e.g. use different .saves files) when the dynamic runtime is adopted on OSX.
BUG=170629,174873
Review URL: https://codereview.chromium.org/12210114
git-svn-id: http://src.chromium.org/svn/trunk/src/build@181733 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-11 19:25:09 +00:00
0d15f80322
Adding field trial branching code to use either the modal dialog or the bubble for sing in confirmation.
...
BUG=174120
Review URL: https://chromiumcodereview.appspot.com/12177022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@181012 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-06 18:47:29 +00:00
6cb9ddfa01
Revert 180901
...
> Turn on aura again to get performance numbers. Will revert once perf release
> bots cycle.
>
> R=ben@chromium.org
> TBR=ben@chromium.org
> BUG=none
> TEST=none
>
> Review URL: https://codereview.chromium.org/12225037
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/12226031
git-svn-id: http://src.chromium.org/svn/trunk/src/build@180902 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2013-02-06 06:46:48 +00:00
csharp@chromium.org
glider@chromium.org
torne@chromium.org
dmichael@chromium.org
benm@google.com
phajdan.jr@chromium.org
petarj@mips.com
aberent@google.com
jvoung@chromium.org
thakis@chromium.org
leozwang@chromium.org
mostynb@opera.com
bartfab@chromium.org
teravest@chromium.org
thestig@chromium.org
scottmg@chromium.org
eugenis@chromium.org
siggi@chromium.org
wfh@chromium.org
jschuh@chromium.org
mtomasz@chromium.org
aruslan@chromium.org
tedchoc@chromium.org
bengr@chromium.org
shashishekhar@chromium.org
miguelg@chromium.org
tfarina@chromium.org
isherman@chromium.org
hans@chromium.org
chrisha@chromium.org
jwd@chromium.org
sky@chromium.org