This CL removes a number of functions from the sync debugging framework
in order to prepare for some upcoming changes to sync debugging (due to
328606).
This CL removes the following functions:
- GetRootNodeDetails
- GetNodeSummaries
- GetNodeDetails
- GetChildNodeIds
It also adds the function 'getListOfKnownTypes' to help replace some old
functionality required by the 'data' tab and to fix issue 329013.
Rather than having that tab fetch a list of children of the root node,
it now asks for a list of all known data types. This is a better
solution, since it does not require sync to be fully initialized in
order to properly populate the set of checkboxes.
The most significant user of the removed functionality is the node
browser. Its javascript code has been modified in order to transition
it to relying on the getAllNodes function. Rather than fetching node
data on demand by a series of asynchronous callbacks, the tab now
fetches a list of all known sync nodes at once. This has the advantage
of providing a more consistent (though more stale) snapshot. This CL
adds a refresh button to the node browser tab in order to give users
some control over its staleness.
This change had some minor side-effects. The node browser now relies on
items' string-based IDs rather than their metahandles when determining
the nodes' hierarchy. We've also had to add a 'positionIndex' field to
the output of getAllNodes to make it easier for the node browser to sort
its entries. In part to make it easier to fetch this field, most of the
code associated with getAllNodes has been moved into the
syncable::Directory.
In addition to all these changes, this CL adds some webui tests to help
prevent regressions in about:sync functionality. For now, they only
cover the node browser. More tests will be added in future CLs.
BUG=110517,329013,328606
Review URL: https://codereview.chromium.org/134443004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@245313 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Relanding. This patch had previously been reverted because opting into the new path could run us into bugs. All known bugs have been resolved, so this should be safe to land.
We now have two accelerated scrolling paths. One accelerates scrolling whenever
it's safe to promote the overflow scrolling div to a stacking container /
containing block and not break stacking or clipping.
The new path, the 'universal' path, enables accelerated scrolling in those cases
where the old path would not opt-in.
Eventually, we'd like to eliminate the old path, but this will require layer
squashing (the new path can result in many composited layers that ought to be
combined -- i.e., a 'layer explosion'). Until these paths are mature, we need to
be able to enable and disable them both, so we have two separate sets of flags.
Once we've eliminated the old path, we can replace both with
--[enable/disable]-accelerated-overflow-scroll (and eventually get rid of both
sets of flags).
BUG=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228187R=darin@chromium.org, hartmanng@chromium.org, shawnsingh@chromium.org
Review URL: https://codereview.chromium.org/26809004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@229421 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This reverts commit 429530bcff087403123cecafedbd93022fb74746.
> Add a flag for enabling/disabling the new accelerated scrolling path
>
> We now have two accelerated scrolling paths. One accelerates scrolling whenever
> it's safe to promote the overflow scrolling div to a stacking container /
> containing block and not break stacking or clipping.
>
> The new path, the 'universal' path, enables accelerated scrolling in those cases
> where the old path would not opt-in.
>
> Eventually, we'd like to eliminate the old path, but this will require layer
> squashing (the new path can result in many composited layers that ought to be
> combined -- i.e., a 'layer explosion'). Until these paths are mature, we need to
> be able to enable and disable them both, so we have two separate sets of flags.
>
> Once we've eliminated the old path, we can replace both with
> --[enable/disable]-accelerated-overflow-scroll (and eventually get rid of both
> sets of flags).
>
> BUG=None
>
> Review URL: https://codereview.chromium.org/26809004TBR=jamser@chromium.org
BUG=307486
Review URL: https://codereview.chromium.org/27393002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@228743 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Sticky position and CSS 3 shaders have been changed to
be runtime enabled feature and thus piggy-back on top
of the experimental web platform features.
This change remove the 2 previous preference along
with the associated code.
BUG=None
Review URL: https://codereview.chromium.org/27072003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@228540 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
We now have two accelerated scrolling paths. One accelerates scrolling whenever
it's safe to promote the overflow scrolling div to a stacking container /
containing block and not break stacking or clipping.
The new path, the 'universal' path, enables accelerated scrolling in those cases
where the old path would not opt-in.
Eventually, we'd like to eliminate the old path, but this will require layer
squashing (the new path can result in many composited layers that ought to be
combined -- i.e., a 'layer explosion'). Until these paths are mature, we need to
be able to enable and disable them both, so we have two separate sets of flags.
Once we've eliminated the old path, we can replace both with
--[enable/disable]-accelerated-overflow-scroll (and eventually get rid of both
sets of flags).
BUG=None
Review URL: https://codereview.chromium.org/26809004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@228187 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This deletes the SessionStateControllerImpl class (formerly
used when the --ash-disable-new-lock-animations flag, which
I'm also removing, was set) and moves
LockStateControllerImpl2 into LockStateController (which was
formerly an interface).
BUG=294310
Review URL: https://codereview.chromium.org/24980006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@226298 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Eliminates NetworkListDetailedView and dependencies.
This mostly removes dead code, but also fixes the following
issues related to the old code:
* TrayNetwork::OnWillToggleWifi() ->
TrayNetwork::RequestToggleWifi() to toggle wifi directly
from Ash.
* Implement TrayNetwork::NetworkManagerChanged() so that
detailed views are notified when technology state changes.
* Eliminates unnecessary ash::SystemTrayDelegate
dependencies on network_menu_ when using new connection
handler code.
BUG=240859
For about_network.cc:
TBR=jamescook@chromium.org, jennyz@chromium.org
Review URL: https://codereview.chromium.org/15350002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@201322 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The close button in download pane should be the tab close button asset : tab_close_*.png (this was originally reported as part of BUG=173251).
By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).
The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed (this is handled by two separate committs to work around restriction on binary committs by newbies).
See https://codereview.chromium.org/12703022/ for added resources.
BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
Review URL: https://chromiumcodereview.appspot.com/12703039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190844 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Inconsistent use of [x] close panel icon
> The close button in download pane should be the tab close button asset : tab_close_*.png
> (this was originally reported as part of BUG=173251).
>
> By the same logic the same smaller bitmap with red hover background should be used for all infobars
> such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
> platforms (Mac was missed with the previous implementation).
>
> The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
>
> Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
> IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
> IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
> png files were also renamed.
>
> BUG=217094
> TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
>
> TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
>
> TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
>
> TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
>
> Review URL: https://codereview.chromium.org/12634025TBR=flackr@chromium.org
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190432 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The close button in download pane should be the tab close button asset : tab_close_*.png
(this was originally reported as part of BUG=173251).
By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).
The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed.
BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
Review URL: https://codereview.chromium.org/12634025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@190431 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Mobile (Android and iOS).
Added a new page chrome://net-export to start/stop/send the net_log
for mobile platforms. net_log entries are saved in
"chrome-net-export-log.json" file created in temporary directory.
Button "Start Saving (after deleting old data)" will start saving to a
temporary file in "NetLog" directory in Temp directory. It deletes all
the old temporary files that were in that directory before creating a
new temporty file. It is a no-op if we are already saving data into a
file.
Button "Stop Saving Data" closes the temporary file so that it could
be mailed. It is a no-op if we haven't started saving data into a
file.
Button "Send Data" emails the data file if a temporary file exists in
"NetLog" directory. It is a no-op if there is no file.
There is only a single temporary file into which we log the
data. NetLog data is saved in the browser process. Logging of net_log
data behaves similar to the command line option --log-net-log.
If chrome://net-export is accessed in multiple tabs, action in first
tab wins. If Stop is clicked in any tab, logging stops. If start is
clicked in any tab, net logging starts.
about:about lists chrome://net-export as one of the links.
unit tests create a temporary file for each test run and they delete the
file at the end of the test run.
mmenke@ and/or eroman@ for chrome\browser\resources and webui changes.
jar@ for net_log_temp_file changes.
jhawkins@chromium.org for chrome\browser\ui\webui and chrome\browser\resources
OWNERS stamp.
R=jar@chromium.org, mmenke@chromium.org
BUG=151212
TEST=chrome://net-export
Review URL: https://chromiumcodereview.appspot.com/11828036
git-svn-id: http://src.chromium.org/svn/trunk/src/build@180026 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
of net_internal's HTML and JS to ios's grit_whitelist.
Disabled Firefox settings for iOS ala Android.
Set FTP transaction factory if DISABLE_FTP_SUPPORT is not set.
Used ProxyService::CreateUsingSystemProxyResolver instead of
net::CreateProxyServiceUsingV8ProxyResolver because V8 is
used on IPHone.
Temporarily ifdef'ed out webkit_glue::ResourceLoadTimingInfo
for IOS in load_timing_observer. load_timing_observer is going
away per mmenke. Thus change to load_timing_observer.h and
load_timing_observer.cc will be deleted.
R=droger@chromium.org, mmenke@chromium.org
BUG=151212
Review URL: https://chromiumcodereview.appspot.com/11450023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@172789 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
joaodasilva@chromium.org
rlarocque@chromium.org
thestig@chromium.org
blundell@chromium.org
nyquist@chromium.org
noyau@chromium.org
leng@chromium.org
pkl@chromium.org
felt@chromium.org
vollick@chromium.org
derat@chromium.org
jchaffraix@chromium.org
droger@chromium.org
dbeam@chromium.org
bdibello@google.com
sehr@chromium.org
sehr@google.com
chenyu@chromium.org
pvalenzuela@chromium.org
isherman@chromium.org
xians@chromium.org
stevenjb@chromium.org
palmer@chromium.org
justincohen@google.com
stuartmorgan@chromium.org
varkha@chromium.org
flackr@chromium.org
fischman@chromium.org
rohitrao@chromium.org
rtenneti@chromium.org
jam@chromium.org
lliabraa@chromium.org
qsr@chromium.org
msarda@chromium.org