Reason for revert:
crbug.com/342539 is likely happening because of the patch that this patch depends on. I need to ensure that logcats work on the bots before relanding (and that the corresponding steps fail if they don't.)
Original issue's description:
> I broke something by removing an apparently unused import that actually was used elsewhere. I addressed the issue by having the client code just call android_commands.GetAttachedDevices explicitly.
>
> BUG=168518
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250206TBR=craigdh@chromium.org,frankf@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=168518
Review URL: https://codereview.chromium.org/159453002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250264 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
build/common.gypi already sets <(android_toolchain) independently of this
env var, and nothing seems to really depend on the env var.
(tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py uses it
to print a better error message if it's available, but that doesn't seem
important.)
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/146723004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250141 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This allows the test runner to not depend on the STRIP env var, which is going away.
Other approaches considered:
1. Converting the remaining exe-based tests to apk tests. The apk versions
were slower, and didn't pass without other changes though.
2. Just don't strip. But that slows down these two tests by over 100%
(due to copying data to the device is slow, and stripped size is 0.5MB while
unstripped size is on the order of 10MB).
3. Try to get a trip binary from third_party/android_tools/ndk. That's fiddly
since it requires getting the right arch.
Since there are only two exe-based tests left, just strip them from gyp.
Medium-term, maybe gyp/mac's postbuild stuff can be brought to android,
it looks like there are various things that could be made simpler with that.
BUG=142642
TEST=
build/android/test_runner.py gtest -s sandbox_linux_unittests &&
build/android/test_runner.py gtest -s breakpad_unittests
R=bulach@chromium.org, frankf@chromium.org
TBR=jln, thestig
Review URL: https://codereview.chromium.org/157743004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@250035 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This reverts commit dc6d7c9d8d8bd5d29dd7a4fc681bb8c2a0bc3297.
Sorry, we can not commit this without the accompanying downstream change, because without that there are two --disable-stack-tool option strings (one in the downstream script and the newly added one here).
This causes the following error on the clank tot bot:
optparse.OptionConflictError: option --disable-stack-tool: conflicting option string(s): --disable-stack-tool
Link: https://chromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/22826/steps/compile/logs/stdio
Reverting because this is keeping clank from picking up changes, and I'm not sure how to do a quick fix right now. Removing the option from clank requires the public script to have it, which requires clank to roll. Slightly tricky and I don't have the time to do it today.
TBR=craigdh@chromium.org,frankf@chromium.org,navabi@chromium.org,eugenis@chromium.org
NOTRY=true
BUG=325685
Review URL: https://codereview.chromium.org/154553003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248830 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It's been unused for two weeks, and should be a noop for everyone who sourced
envsetup since.
If you see an error message like
gyp: buid/all_android.gyp not found (cwd: /path/to/chrome/src)
after this change, open a fresh shell (and source envsetup),
or run `unset CHROMIUM_GYP_FILE`.
Also remove the code for unsetting CHROMIUM_GYP_FIE from envsetup
and fold the one line left in common_gyp_vars into its only caller.
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/150903005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248748 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Nothing sets this env var. (I checked with the folks who added this line, who
confirmed that this is unused.)
If something like this gets added again in the future, it shouldn't use a global
env var to turn it on but a single gyp define (that's hopefully identical for
desktop and mobile).
BUG=330631
R=torne@chromium.org
Review URL: https://codereview.chromium.org/135493004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248722 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If this patch breaks your build, try running `unset ANDROID_SDK_ROOT`.
Before this patch, envsetup checked if
${ANDROID_SDK_ROOT}/platforms/android-${ANDROID_SDK_VERSION} existed and fell
back to the sdk in chromium's third_party if that wasn't the case.
Since most people don't set ANDROID_SDK_ROOT and the ones who do will be
able to realize that they're using an SDK that doesn't have the right toolchain
version, this seems save to do. (The motivation is that I want to move
ANDROID_SDK_VERSION out of envsetup and into common.gypi.)
This reverts part of https://chromiumcodereview.appspot.com/10920094
BUG=330631
Review URL: https://codereview.chromium.org/152173002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248483 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Instead of the slightly rube-goldbergian approach of giving mips_arch_variant
the default value mips32r2 in common.gypi and then always overriding this with
mips32r1 in envsetup, just set mips_arch_variant to mips32r1 by default and
don't set it in envsetup.
I checked that the generated ninja file for base is identical before and after
this change, and that the mips flags change as expected when manually setting
mips_arch_variant to mips32r2. No behavior change.
BUG=330631
TBR=torne@chromium.org
Review URL: https://codereview.chromium.org/152233002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248409 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The explicit setting seems to match the default value for host_arch in
build/common.gypi close to line 110, and it's not set explicitly for other
target_archs, so this looks like an oversight. It's been this way since this
file was added in r148790 18 months ago.
No intended behavior change.
BUG=330631
Review URL: https://codereview.chromium.org/142023006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248188 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1. Removes obsolete methods.
- DeriveFontList(font_style)
# The method name and argument are not clear compared to other versions. Use DeriveWithStyle(style) below instead.
- DeriveFontListWithSize(absolute_size)
# Don't specify the absolute size.
2. Renames very long named methods.
- DeriveFontListWithSizeDeltaAndStyle => Derive
- DeriveFontListWithSizeDelta => DeriveWithSizeDelta
- new method => DeriveWithStyle
Since DeriveFontListWithSizeDeltaAndStyle is used more often than DeriveFontListWithSizeDelta, so give the former a shorter name.
Review URL: https://codereview.chromium.org/142523003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ContentViewGestureHandler conditionally forwards MotionEvent's to the Android
gesture detection pipeline, depending on the current touch stream handling
disposition. However, this approach is fragile, as the detection pipeline
expects a consistent touch stream for each sequence. Instead, forward all
MotionEvent's immediately for gesture detection, conditionally dispatching the
generated gestures depending on the touch stream ack dispositions.
BUG=295075,334040,327444,240550,234516
NOTRY=true
Review URL: https://codereview.chromium.org/120513005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@248066 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
ui/gfx/ depended on net/ for two things, SortedDisplayURL and gfx::ElideUrl().
SortedDisplayURL was not used by anything other than its own unit test and is
deleted in this patch. ElideUrl() is only used from
chrome/browser/ui/(gtk|cocoa|views), so this patch moves the functionality up
to chrome/browser/ui/elide_url.(h|cc) and the unit test to
chrome/browser/ui/tests/elide_url_unittest.cc.
R=sky
Review URL: https://codereview.chromium.org/143463006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247820 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a quick and dirty fix for a problem that occurs to me when
trying to run instrumentation tests in a simulator.
For some reason 'pm path org.chromium.content_shell_apk.tests' outputs
a warning message in my environment that confuses the python scripts
and they end up calling md5sum for the root directory which is a bit
slow... The real fix would be to be able drop the stderr of the command
but it needs a lot of plumbing and probably there is not that much chance
that something like that will happen again for someone.
BUG=334439
Review URL: https://codereview.chromium.org/138143019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247742 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If targets shouldn't be part of the android build, they should be conditional
in gyp instead.
Removing this line leads to 17 more files being compiled and one more binary
(printing_unittests) being linked on the open source bots, and there are no
build errors.
(An internal build of the 'all' target is also successful, and it builds only
183 additional edges too, which add about 1 minute / 5% to build time.)
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/149103002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247571 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
aberent@chromium.org
thakis@chromium.org
dfalcantara@chromium.org
jbudorick@chromium.org
thestig@chromium.org
phajdan.jr@chromium.org
bulach@chromium.org
wibling@chromium.org
zty@chromium.org
eugenis@chromium.org
navabi@google.com
pasko@chromium.org
dpranke@chromium.org
qsr@chromium.org
yukishiino@chromium.org
plundblad@chromium.org
jdduke@chromium.org
jamesr@chromium.org
b.kelemen@samsung.com
kjellander@chromium.org