f0306b0431
whitespace trigger, TBR=thakis
...
BUG=
Review URL: https://codereview.chromium.org/150053002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247842 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-30 05:30:15 +00:00
d2035efb45
Remove net dependency from ui/gfx
...
ui/gfx/ depended on net/ for two things, SortedDisplayURL and gfx::ElideUrl().
SortedDisplayURL was not used by anything other than its own unit test and is
deleted in this patch. ElideUrl() is only used from
chrome/browser/ui/(gtk|cocoa|views), so this patch moves the functionality up
to chrome/browser/ui/elide_url.(h|cc) and the unit test to
chrome/browser/ui/tests/elide_url_unittest.cc.
R=sky
Review URL: https://codereview.chromium.org/143463006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247820 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-30 03:37:33 +00:00
e727e8d042
Drop warnings from adb shell output
...
This is a quick and dirty fix for a problem that occurs to me when
trying to run instrumentation tests in a simulator.
For some reason 'pm path org.chromium.content_shell_apk.tests' outputs
a warning message in my environment that confuses the python scripts
and they end up calling md5sum for the root directory which is a bit
slow... The real fix would be to be able drop the stderr of the command
but it needs a lot of plumbing and probably there is not that much chance
that something like that will happen again for someone.
BUG=334439
Review URL: https://codereview.chromium.org/138143019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247742 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 21:27:35 +00:00
d1c00d0377
Update WebRTC test filter for Chromium tests.
...
In https://codereview.chromium.org/137793008/ phoglund@
changed the test filter for desktop tests after the renames in
https://codereview.chromium.org/131203005/ and
https://codereview.chromium.org/137753004/
This CL makes similar change for Android.
BUG=none
TBR=frankf@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/144483003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247716 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 17:40:57 +00:00
388172cfd4
Update asan_symbolize script to work with new logcat format.
...
Also works with unprefixed reports.
BUG=325685
R=glider@chromium.org , bulach@chromium.org
Review URL: https://codereview.chromium.org/148763008
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247673 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 11:21:51 +00:00
675f5784d3
Change ContentLinker to share relro sections with browser process only on low-end devices.
...
While this change increases memory usage on non low-end devices, the
impact is small enough that we can limit the exposure surface to only
where it makes a signficant impact.
Also adds content_linker_test_apk to the android builders to ensure it
doesn't regress.
Review URL: https://codereview.chromium.org/139743011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247622 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 05:12:26 +00:00
e86c3fb347
Suppress 4 findbugs issues in tooling-only code.
...
BUG=338966
TBR=andrehayden@chromium.org
Review URL: https://codereview.chromium.org/146833022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247610 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 03:42:49 +00:00
a431ee5eee
android buildbot: Default to ninja's default target instead of All.
...
Before https://codereview.chromium.org/149103002/ , chrome/android's default
target was 'All', so no behavior change. After that lands, the default target
is 'all', so the bots will build a few more targets (17 translation units more,
at the moment).
Together with the change linked above, this might enable the removal of
|android_app_target|.
BUG=none
R=yfriedman@chromium.org
Review URL: https://codereview.chromium.org/149213002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247607 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 02:59:07 +00:00
07907a3211
common.gypi: When clang=1 on Windows, set CC to clang-cl
...
(See https://code.google.com/p/gyp/source/detail?r=1846 for
how GYP deals with this.)
BUG=82385
Review URL: https://codereview.chromium.org/147083011
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247586 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 01:59:21 +00:00
a7d5b8dfc7
android envsetup: Remove default_target=All
...
If targets shouldn't be part of the android build, they should be conditional
in gyp instead.
Removing this line leads to 17 more files being compiled and one more binary
(printing_unittests) being linked on the open source bots, and there are no
build errors.
(An internal build of the 'all' target is also successful, and it builds only
183 additional edges too, which add about 1 minute / 5% to build time.)
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/149103002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247571 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 01:36:35 +00:00
4aa03245dd
Revert of [Android] Re-enable content_browsertests on main waterfall. ( https://codereview.chromium.org/132403005/ )
...
Reason for revert:
content_browsertests have been crashy and flaky since being re-enabled.
Looks like they crashing on shutdown, but I'm not sure.
Failed:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11552
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11554
On this one, content_browsertests crashed but still passed. This caused INJECT_EVENTS exceptions in later tests.
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/18163
We see the same thing downstream.
Original issue's description:
> [Android] Re-enable content_browsertests on main waterfall.
>
> There's enough infra capacity now.
>
> BUG=
> R=navabi@chromium.org , navabi@google.com
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247341
TBR=navabi@chromium.org ,navabi@google.com,frankf@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/135363005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247547 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-29 00:50:36 +00:00
d2ac2c5a52
android envsetup: Stop setting TARGET_PRODUCT, don't unset ANDROID_BUILD_TOP.
...
TARGET_PRODUCT seems to not be used in an SDK build.
ANDROID_BUILD_TOP isn't used in the SDK build either.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/130963007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247471 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-28 18:35:51 +00:00
9fd24ddc2e
Pull new GN binary @ r247206
...
Additionally, the Windows binary is a debug build to help find a rare assertion failure.
Updates build files to use a list which this new build requires.
Update win-tool link commands to match GYP
TBR=scottmg
Review URL: https://codereview.chromium.org/139283005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247408 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-28 06:03:11 +00:00
e0d288fdc7
Use icudat*.dat file on Mac
...
1. Set icu_use_data_file_flag to 1 in common.gypi
2. Add icudatl.dat to the resournce bundle list in
chrome_dll_bundle.gypi and content_shell.gypi
3. Move ICU_UTIL_DATA_IMPL to base.gyp
This CL has to be landed after
https://codereview.chromium.org/111723007/ is landed and rolled in.
(done in https://codereview.chromium.org/118313004/ )
Note to perf-sheriff: This CL adds ~10MB to the resource bundle while cutting down the same amount from the Chrome executable/binary.
BUG=72633
TEST=All the Mac builds (static, shared) go through and tests (e.g.
layout tests, base_unittests --gtest_filter=*String*, net_unittests
--gtest_filter=*IDN*) loading the ICU data pass.
Review URL: https://codereview.chromium.org/109013004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247404 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-28 06:00:04 +00:00
350141d9fd
[Android] Re-enable content_browsertests on main waterfall.
...
There's enough infra capacity now.
BUG=
R=navabi@chromium.org , navabi@google.com
Review URL: https://codereview.chromium.org/132403005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247341 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 23:44:24 +00:00
5832577233
[Android] Disable remaining failing content_browsertests.
...
This is in preparation for re-enabling content_browsertests on main
waterfall.
BUG=338408,338023,338411,338421
TBR=craigdh@chromium.org
Review URL: https://codereview.chromium.org/135723006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247298 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 21:30:38 +00:00
d5c03bdb4a
Exclude print_preview resources for platforms that don't use it
...
Only enable_printing==1 uses print_preview and all of its resources.
enable_printing==2 and enable_printing==0 do not need them.
BUG=326023
Review URL: https://codereview.chromium.org/146963004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247291 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 21:07:50 +00:00
8037f9a329
android envsetup: Stop setting ORDER_DEFINES.
...
order_text_section is only used by the chrome_initial target, which isn't
used on android.
(Some internal gyp file explicitly adds -Wl,-section-ordering-file without
going through the order_text_section gyp define, so this setting here is likely
a remnant from when that wasn't the case.)
No intended behavior change.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/148513002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247283 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 19:53:58 +00:00
d849d492c3
android envsetup: Delete bitrotted comments.
...
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/133183003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247260 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 17:23:28 +00:00
f65142622c
android envsetup: Stop setting use_libffmpeg=0 for x86 targets.
...
It's already set to 0 for all targets for OS==android in common.gypi.
No intended functionality change.
BUG=330631
NOTRY=true
Review URL: https://codereview.chromium.org/147863002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247259 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 17:22:10 +00:00
bc22401d2d
ASan/Android: crash on calloc overflow.
...
This is the generally preferred behaviour that is also expected by the
unit tests.
BUG=325685
R=glider@chromium.org , navabi@chromium.org
Review URL: https://codereview.chromium.org/146833010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247219 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 11:24:18 +00:00
a561545dc2
GN build fixes, mostly for Mac.
...
This hooks up detection for the "-arch" flag on Mac to set the GYP "ARCH" xcode variable. GN then removes the -arch argument from the compiler args, since GYP will then re-add it based on the ARCH value. Previously, not doing this resulting in mutliple "-arch" arguments to the compiler since GYP would always insert its own.
Disables some warnings on Windows for the re2 target to match the GYP build. The third warning (4018) that the GYP build sets is disabled globally so there's no need to do it for this target.
Hooks up some iOS SDK stuff.
BUG=336667
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/141433015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247206 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-27 07:41:23 +00:00
d510ca04eb
[Android] Disabling TouchInputBrowserTests timing out on android.
...
BUG=338011
NOTRY=True
TBR=jdduke@chromium.org
Review URL: https://codereview.chromium.org/147503002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247111 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-25 09:26:40 +00:00
24cc033e7d
Use the icu data file on Linux (but not on CrOS)
...
Set icu_use_data_file_flag to 1 for POSIX (other than Mac/iOS/Android).
Mac and Android will be handled in a separate CL.
This has to wait until https://codereview.chromium.org/111723007/ is rolled in.
(done by https://codereview.chromium.org/118313004/ )
BUG=72633
TEST=All linux builds go through and all tests pass and there's no perf (start-up etc) regression.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246678
R=mark@chromium.org , mmoss@chromium.org
Review URL: https://codereview.chromium.org/102413007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247045 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-25 00:58:56 +00:00
f9239b2372
Delete some msvs_cygwin_shell:0
...
This is the default, so these are no-ops.
TBR=thakis@chromium.org
BUG=123026
Review URL: https://codereview.chromium.org/141693007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247039 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-25 00:45:40 +00:00
7913da50df
Start building IPC fuzzer again, except when component=="shared_library".
...
Component builds require more work, linking is currently broken.
BUG=260848
Review URL: https://codereview.chromium.org/135973007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247038 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-25 00:44:50 +00:00
1b088707e4
[Android] Disable webrtc browser tests timing out/failing on Android.
...
TBR=wjia@chromium.org
BUG=181069
Review URL: https://codereview.chromium.org/147093002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@247011 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 23:34:18 +00:00
0178a36b24
android envsetup: Stop setting OBJCOPY.
...
I couldn't find anything that still calls this. I looked for OBJCOPY in
internal repos, and for \$OBJCOPY, ['\"]OBJCOPY, and [[{]OBJCOPY in
cs.chromium.org.
BUG=142642
R=torne@chromium.org
Review URL: https://codereview.chromium.org/145083013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246964 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 21:15:52 +00:00
9c91fda9d1
Revert 246678 "Use the icu data file on Linux (but not on CrOS)"
...
"Failed sizes" - http://build.chromium.org/p/chromium/builders/Linux
> Use the icu data file on Linux (but not on CrOS)
>
> Set icu_use_data_file_flag to 1 for POSIX (other than Mac/iOS/Android).
>
> Mac and Android will be handled in a separate CL.
>
> This has to wait until https://codereview.chromium.org/111723007/ is rolled in.
> (done by https://codereview.chromium.org/118313004/ )
>
> BUG=72633
> TEST=All linux builds go through and all tests pass and there's no perf (start-up etc) regression.
>
> Review URL: https://codereview.chromium.org/102413007
TBR=jshin@chromium.org
Review URL: https://codereview.chromium.org/144023015
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246952 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 20:25:13 +00:00
1375326281
[Android] Disable 4 failing accessibility-related content browsertests.
...
BUG=297230
TBR=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/130273005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246940 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 19:06:33 +00:00
ab1d559d69
Revert of Fixed the bracket and the missing type, introduced by https://codereview.chromium.org/139743016 ( https://codereview.chromium.org/144063007/ )
...
Reason for revert:
bauerb fixed it before me but I was using the pinned revision so missed the fix.
Original issue's description:
> Fixed the bracket and the missing type, introduced by https://codereview.chromium.org/139743016
>
> BUG=None
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246903
TBR=thakis@chromium.org ,mvanouwerkerk@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/143523013
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246904 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 16:38:50 +00:00
304803bffe
Fixed the bracket and the missing type, introduced by https://codereview.chromium.org/139743016
...
BUG=None
NOTRY=true
Review URL: https://codereview.chromium.org/144063007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246903 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 16:31:07 +00:00
99df6e99fb
Fix temporary_android_dummy_target in build/all_android.gyp.
...
TBR=thakis@chromium.org
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/145313005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246883 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 13:43:31 +00:00
51060a6f51
Revert 240449 "Add IPC fuzzer dependency to chromium_builder_asan."
...
LKGR ASAN Debug builder fails to compile IPC fuzzer. Disable it until the issue is resolved.
> Add IPC fuzzer dependency to chromium_builder_asan.
>
> This is the first CL towards enabling IPC fuzzer for ClusterFuzz. The second CL
> will add enable_ipc_fuzzer=1 GYP define to symbolized ASAN Release builder.
>
> BUG=260848
>
> Review URL: https://codereview.chromium.org/112933004
TBR=aedla@chromium.org
Review URL: https://codereview.chromium.org/146783002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246878 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 13:33:47 +00:00
cf1d2c1c59
Start massaging the GYP files for building with clang on Windows
...
BUG=82385
TBR=cpu
Review URL: https://codereview.chromium.org/146043003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246874 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 13:26:35 +00:00
c5846a908e
Fix syntax error in build/all_android.gyp
...
TBR=thakis@chromium.org
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/145013016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246850 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 12:43:11 +00:00
c9139ec536
Switch to the "new" way of ASan deployment on Android devices.
...
This will elimitate startup slowdown in ASan/Android tests, and
improve overall run time very significantly.
For the idea behind this change, refer to
https://code.google.com/p/address-sanitizer/wiki/Android#Running_NDK_applications_with_ASan
R=bulach@chromium.org , frankf@chromium.org , glider@chromium.org , navabi@chromium.org
BUG=
Review URL: https://codereview.chromium.org/138153003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246847 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 12:35:03 +00:00
39a2338132
win: Remove msbuild_toolset, and msvs-specific ProgramDatabaseFile.
...
Since we're now on ninja, they don't have an effect.
BUG=none
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/145493007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246783 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 04:36:23 +00:00
96b4c2d4c3
android: Fold all_android.gyp into all.gyp.
...
All other platforms have their targets in all.gyp. Android didn't during
bring-up, but enough stuff works by now that there's no need for the
separate all_android.gyp file any more.
BUG=330631
R=yfriedman@chromium.org
TBR=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/139743016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246782 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 04:32:18 +00:00
2a82402f9e
Enable icu_use_data_file on Windows
...
Set icu_use_data_file_flag to 1 on Windows in common.gypi and make the dependency on icudata conditional on 'icu_use_data_file_flag != 0' in common.gypi, base.gyp and net.gyp
Add icudtl.dat to the Windows build/archive/install file lists.
Load icudtl.dat from DIR_MODULE instead of DIR_EXE on Windows. (to fix bug 337116)
This also requires a change in third_party/icu/icu.gyp
( https://codereview.chromium.org/111723007/ ), which was rolled in by https://codereview.chromium.org/118313004/
BUG=72633,337116
TEST=All windows builds work fine and there's no perf regression (start-up etc). Chrome installed via mini_installer runs fine (no issue with icu data file).
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246387
Review URL: https://codereview.chromium.org/99473012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246751 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-24 01:00:41 +00:00
67845a0884
android: Stop adding toolchain dir to PATH.
...
This seems mostly no longer necessary (at least I can build all targets
in an open-source chrome/android build without problems). I'm guessing
that https://codereview.chromium.org/9693042 made this obsolete.
It was only needed for `as` with clang; pass -B to clang instead
for now (until we switch to clang's integrated assembler).
BUG=330631,124610
R=torne@chromium.org
Review URL: https://codereview.chromium.org/133963003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246714 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 23:16:35 +00:00
e5a9786ccf
Use the icu data file on Linux (but not on CrOS)
...
Set icu_use_data_file_flag to 1 for POSIX (other than Mac/iOS/Android).
Mac and Android will be handled in a separate CL.
This has to wait until https://codereview.chromium.org/111723007/ is rolled in.
(done by https://codereview.chromium.org/118313004/ )
BUG=72633
TEST=All linux builds go through and all tests pass and there's no perf (start-up etc) regression.
Review URL: https://codereview.chromium.org/102413007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246678 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 20:38:52 +00:00
7e185d448a
Revert of Enable icu_use_data_file on Windows ( https://codereview.chromium.org/99473012/ )
...
Reason for revert:
mini_installer somehow does not install icudtl.dat in the top product directory (alongside chrome.exe) leading to a failure in InitializeICU().
icudtl.dat is listed in both mini_installer.gypi and FILES.cfg for windows.
Original issue's description:
> Enable icu_use_data_file on Windows
>
>
> Set icu_use_data_file_flag to 1 on Windows in common.gypi and make the dependency on icudata conditional on 'icu_use_data_file_flag != 0' in common.gypi, base.gyp and net.gyp
>
> This also requires a change in third_party/icu/icu.gyp
> ( https://codereview.chromium.org/111723007/ ), which was rolled in by https://codereview.chromium.org/118313004/
>
> BUG=72633
> TEST=All windows builds work fine and there's no perf regression (start-up etc).
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246387
TBR=mark@chromium.org ,scottmg@chromium.org,laforge@chromium.org,maruel@chromium.org,grt@chromium.org,wtc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633
Review URL: https://codereview.chromium.org/139403006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246632 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 17:43:48 +00:00
8d224e2195
Build IPC fuzzer with the LKGR ASAN builders.
...
Now that the re2 dependency issue is resolved, give it a try at actually building the IPC fuzzer.
Revert 246078 "Revert 240449 "Add IPC fuzzer dependency to chrom..."
> Revert 240449 "Add IPC fuzzer dependency to chromium_builder_asan."
>
> > Add IPC fuzzer dependency to chromium_builder_asan.
> >
> > This is the first CL towards enabling IPC fuzzer for ClusterFuzz. The second CL
> > will add enable_ipc_fuzzer=1 GYP define to symbolized ASAN Release builder.
> >
> > BUG=260848
> >
> > Review URL: https://codereview.chromium.org/112933004
>
> TBR=aedla@chromium.org
>
> Review URL: https://codereview.chromium.org/138123005
TBR=aedla@chromium.org
Review URL: https://codereview.chromium.org/136423003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246605 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 16:20:33 +00:00
5b68711365
Pass -marm when building with ASan for Android/ARM.
...
Frame pointers are broken in Thumb mode.
The same reason as in 'profiling' condition several lines above.
FTR, http://llvm.org/bugs/show_bug.cgi?id=18505
BUG=325685
Review URL: https://codereview.chromium.org/143323010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246568 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 11:07:53 +00:00
588ee2e9f5
Support joined -D flags for gn.
...
BUG=326230
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/145073004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246558 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 09:55:45 +00:00
b4b9cfcc04
Revert 246313 "Use an alternate mechanism for CreateFile calls i..."
...
This caused reading profile error on Windows8 platform.
> Use an alternate mechanism for CreateFile calls in Chrome
>
> BUG=334379
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464
>
> Review URL: https://codereview.chromium.org/138593004
TBR=caitkp@chromium.org
Review URL: https://codereview.chromium.org/144333003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246541 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 08:57:54 +00:00
b70112e06d
Add telemetry.gyp to chromium_builder{,_dbg,_rel} targets
...
BUG=323813
Review URL: https://codereview.chromium.org/144023014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246504 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 03:20:48 +00:00
3d8715d022
Remove unused android_experimental.
...
Follow-up to r246093.
BUG=none
R=ilevy@chromium.org
Review URL: https://codereview.chromium.org/138163019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246467 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 01:10:51 +00:00
a547df586f
[GCM] Add gcm_unit_tests to aura_builder target
...
BUG=284553
Review URL: https://codereview.chromium.org/136383004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@246455 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2014-01-23 00:15:25 +00:00
scottmg@chromium.org
jamesr@chromium.org
b.kelemen@samsung.com
kjellander@chromium.org
eugenis@chromium.org
yfriedman@chromium.org
thakis@chromium.org
hans@chromium.org
cjhopman@chromium.org
brettw@chromium.org
jshin@chromium.org
frankf@chromium.org
aurimas@chromium.org
aedla@chromium.org
ronghuawu@chromium.org
avayvod@chromium.org
bauerb@chromium.org
kochi@google.com
szym@chromium.org
zea@chromium.org