Граф коммитов

4359 Коммитов

Автор SHA1 Сообщение Дата
evanm@google.com 6af62f4ce5 Remove -Wno-unknown-pragmas from global compiler flags on Linux.
BUG=2053

Review URL: http://codereview.chromium.org/13175
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.


git-svn-id: http://src.chromium.org/svn/trunk/src/build@6597 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-09 18:29:45 +00:00
ager@google.com 00b547ed52 Fix mac build by adding new V8 files to the xcode project.
Review URL: http://codereview.chromium.org/13120

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6350 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-04 08:25:37 +00:00
mpcomplete@chromium.org 7de46bda18 Stop filtering out the 'gears' SConscript on linux and mac.
Review URL: http://codereview.chromium.org/12929

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6341 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-04 01:01:22 +00:00
agl@chromium.org 8a3897d626 Linux: use other fonts when the primary is missing glyphs
We had a bug where we weren't setting the fontdata for missing glyphs to
NULL. This caused WebKit not to try to load other fonts when glyphs
were missing.

With that fixed, we can implement the code to find a font for a given
set of code points. This uses fontconfig as it has this information
already indexed.

This fixes css2.1/t0805-c5519-brdr-r-00-a.html

Review URL: http://codereview.chromium.org/13108


git-svn-id: http://src.chromium.org/svn/trunk/src/build@6328 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-03 23:19:26 +00:00
avi@google.com e238046e5b Get the test plugin compiling and working for the Mac.
Review URL: http://codereview.chromium.org/12913

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6308 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-03 20:54:03 +00:00
bradnelson@chromium.org 273a2f8afc Allows scons build to use local copy of platformsdk if one is not bundled side-by-side.
Review URL: http://codereview.chromium.org/12915

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6305 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-03 20:45:47 +00:00
sgk@google.com 70201182b9 Parameterize the "Hammer" subdirectory name in which we build as
$BUILD_TARGET_DIR, so it can be set to "Debug" or "Release' to
mimic Visual Studio, or whatever other subdirectory the user prefers.
Fix PROGRESS= on Linux so the messages go to /dev/tty.
Remove the now-unnecessary in-SCons support for --clobber.
Review URL: http://codereview.chromium.org/13087

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6301 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-03 20:08:12 +00:00
sgk@google.com 958772d1b3 Fix syntax errors in _official and _dom_stats.scons.
Review URL: http://codereview.chromium.org/13089

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6285 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-03 12:05:47 +00:00
sgk@google.com cbf8f0b1cb Fixes and enhancements
* Configurable CHROME_BUILD_TYPE command line or external environment
  variable for selecting appropriate release_impl*.scons settings
  (_checksenabled, _coverage, _dom_stats, _official, _purify).
* Configurable CHROMIUM_BUILD command line or external environment
  variable for selecting appropriate chromium_build*.scons settings
  (_google_chrome).
* Configurable /INCREMENTAL linking via command line or external
  environment variable ($INCREMENTAL), through appropriate setting
  of an internal $CHROMIUM_INCREMENTAL_FLAGS construction variable.
* Full link of release builds by default.
* Alphabetize *.scons files in the mac_env.FilterOut() list.
* Explicitly set _checksenabled.scons link flags.
Review URL: http://codereview.chromium.org/13039

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6210 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-02 07:36:03 +00:00
evanm@google.com 65e6b88408 Remove the cpu-count forwarding passing code from the v8 SConscript.
Running with n CPUs would cause our parent scons to run with n cpus
and then have it spawn a sub-scons that would itself attempt to run
with an additional n cpus.

Review URL: http://codereview.chromium.org/13010


git-svn-id: http://src.chromium.org/svn/trunk/src/build@6152 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-12-01 19:36:56 +00:00
dank@chromium.org 1c8df3df91 Rediff the tlslite patch (it was against wrong baseline)
Apply it when installing on Linux
Link to bug report describing the problem it fixes

This solves a hang on Linux running url_request_unittest

Review URL: http://codereview.chromium.org/12477

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6037 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-26 18:48:09 +00:00
dank@chromium.org 5feef55745 Support Intrepid.
Add msttcorefonts.

Review URL: http://codereview.chromium.org/12440

git-svn-id: http://src.chromium.org/svn/trunk/src/build@6035 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-26 18:21:52 +00:00
agl@chromium.org d94b0514e1 Remove dependancies on gcc/perl etc. This saves a bunch of stats and
full rebuilds whenever changing compilers etc.

Review URL: http://codereview.chromium.org/12436


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5983 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-25 19:12:51 +00:00
maruel@chromium.org 7725116886 It was brought to my attention that defining _HAS_TR1=0 helps with Visual Studio 2008 compilation and causes no adverse effect on Visual Studio 2005.
Thanks to Daniel A. White for the tip.
Review URL: http://codereview.chromium.org/12607

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5959 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-25 02:15:23 +00:00
sgk@google.com 9615c1176a Purify support:
* Add third_party/purify/pure_api.c to the base\base_lib.scons sources.
* Support specification of CHROME_BUILD_TYPE (and CHROMIUM_BUILD
  while we're here) either on the command line or as an
  external environment variable.
* Fix syntax error in release_impl_purify.scons (previously unused).
* Add a central $CHROMIUM_CC_OPT_FLAGS variable (included in $CCFLAGS)
  that can be used to set explicitly the optimization level without
  having to worry about optimization flags being pulled in from other
  settings files.
Review URL: http://codereview.chromium.org/11368

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5887 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-22 01:10:01 +00:00
sgk@google.com 369e1d731a Fix use of LOAD= with WantSystemLib() (we could blow up if a variable
hadn't been added to the config) and extend use of LOAD= into submodules:
* Add a ChromeLoadSConscriptModules() method that encapsulates the
  conditional logic, and makes things more readable by specifying
  component names as keyword arguments, not hard-coding the logic
  as a series of if-tests.
* Put the ChromeLoadSConscriptModules() logic in a Tool module in
  site_scons/site_tools, so it doesn't clutter up
  build/SConscript.main directly.
* Move env.WantSystemLib() calls into the individual *.scons files,
  so we call them each time (or not, based one LOAD=) and the config
  itself just returns if the system library is requested and we
  don't need to build anything locally.
* Move the settings where a library name changes based on whether or
  not the system lib is being used into the using_*.scons files,
  so they're available to clients independently of whether or not the
  component's *.scons configuration is loaded.
* While here:  rename the affected third_party SConscript files:
  third_party/libjpeg/SConscript => third_party/libjpeg/libjpeg.scons
  third_party/libxml/SConscript => third_party/libxml/libxml.scons
  third_party/libxslt/SConscript => third_party/libxslt/libxslt.scons
* While here:  move the Chrome{Program,SharedLibrary}() etc. builder
  definitions from build/SConscript.main to a new too
  Ad the ChromeLoadSConscriptModules() logic in a Tool module,
  to remove more clutter from build/SConscript.main.
Review URL: http://codereview.chromium.org/11430

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5820 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-21 06:04:04 +00:00
sgk@google.com 208bd6d9b4 Finish release (opt) builds on Windows, including the parallel
build\*.scons structure (mirroring build\*.vsprops files):
* Use env.ApplySConscript() instead of env.SConscript with a
  hand-crafted dictionary defining 'env'.
* Move various CPPPATH, CCFLAGS, CPPDEFINES, LIBS and LIBPATH
  definitions from build/SConscript.main and target-specific 
  *.scons files into the build\*.scons files that mirror the
  existing build\*.vsprops hierarchy.
* Use the new build\{debug,release}.scons files to update the
  windows_dbg and windows_opt construction environments.
* Mirror current support for CHROME_BUILD_TYPE and CHROMIUM_BUILD
  external environment variables.
* Remove hard-coded /TP options.
* Massage $CXXFLAGS to remove $CCFLAGS, avoiding duplication of options
  on command lines.  Handle the ripple effect in $PCHCOM by adding
  $CCFLAGS back to that command line.
* Delete hammer's default settings of {CC,LINK}FLAGS_{DEBUG,OPTIMIZED}
  so they don't pollute our construction environments.
* Update chrome config to link against v8 for opt, v8_g for dbg.
* Get rid of fragile by-hand order of using_net.scons before other
  using_*.scons files.  We're now using --start-group and --end-group
  on Linux to deal with dependency cycles in libraries.
Review URL: http://codereview.chromium.org/11478

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5741 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-20 01:12:38 +00:00
deanm@chromium.org e434344159 Don't build with exception support, we don't use exceptions.
This makes the output executable substantially smaller because it won't emit .eh_frame and .eh_frame_hdr header sections.  These were previously ~1.2mb for an opt test_shell.

Review URL: http://codereview.chromium.org/11265

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-19 08:16:31 +00:00
mmoss@google.com 40dbba5eda Add Linux lighttpd for running LayoutTests on Linux.
Updated to use system lighttpd and php-cgi. This is based on the Hardy packages and file layout. YMMV with other distros.

BUG=4281

Review URL: http://codereview.chromium.org/10653


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5633 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-18 20:56:29 +00:00
mmoss@google.com 745177d267 Add platform_utils and stub test lists for Linux.
This allows the LayoutTest harness to run on Linux. Note that the tests still
don't run properly because Linux test_shell is missing the ability to read URLs
from stdin (causing the test_shell to just sit there waiting for input). I'll
add that in another CL.

BUG=4281

Review URL: http://codereview.chromium.org/10413


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5566 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-17 20:05:05 +00:00
tony@chromium.org 963426065d Fix the mac build to add dmg_fp to the libbase.a.
Remove third_party/dmg_fp complete since nothing else depends on it.

Review URL: http://codereview.chromium.org/10963


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5525 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-15 01:40:31 +00:00
tc@google.com b53e4e50cd Move dmg_fp in scons build to compile from
base/third_party/dmg_fp and compile it into base_lib.

Review URL: http://codereview.chromium.org/10769

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5521 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-15 00:53:54 +00:00
sgk@google.com 6a98bfc462 Add a webkit.scons file in between build\SConscript.main and
webkit\SConscript, as a place for calling renamed *.scons files.
Add 'webkit' and 'chrome'  COMPONENT_PROGRAM_GROUPS and
COMPONENT_TEST_PROGRAM_GROUPS so the generated .exe files get
copied correctly into the Hammer\ build subdirectory.
Review URL: http://codereview.chromium.org/10768

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5518 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 23:29:55 +00:00
sgk@google.com 1e723fddbe More *.scons renaming:
* Rename SConscript to *.scons in the following directories:
  third_party\{bspatch,bsdiff,lzma_dsk}
  chrome\installer\{setup,mini_installer,util}
* Split mini_installer and installer_unittests into separate *.scons files.
* Add using_bspatch.scons and using_lzma_sdk.scons "properties" files,
  modifying other *.scons files to use them as appropriate.
Review URL: http://codereview.chromium.org/10952

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5515 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 23:00:46 +00:00
scherkus@chromium.org 472df4f13a Recommit of media project files due to a mistake in media_unittest.vcproj
that worked in Visual Studio but broke on IncrediBuild.  Also updated to
include dmg_fp dependency.

Trying ONE MORE TIME because I think gcl breaks with "A +" files (I used "svn merge -c REV ." to un-rollback my change).

Original: http://codereview.chromium.org/10683
Rollback: http://codereview.chromium.org/10908
Review URL: http://codereview.chromium.org/10733

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5490 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 19:10:21 +00:00
sgk@google.com b02e098041 Fixes for Visual Studio solution + project file generation:
* Fix the grit tool so it works with Repository() directories (and
  tap gspencer to upstream the changes).
* Fix the evaluation of $PRE_EVALUATE_DIRS, which was interfering
  with sucking up the source files for listing in the .vcproj files.
* Set AlwaysBuild() on the project files so they're always
  evaluated for up-to-dateness when 'all_solutions' is the target.
Review URL: http://codereview.chromium.org/10725

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5440 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-14 02:26:30 +00:00
evanm@google.com ccf7d6e9b0 Allow optimized builds on Linux.
Review URL: http://codereview.chromium.org/10857


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5406 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 23:44:51 +00:00
agl@chromium.org ed6355cf7d * Revert "Checking in the media project files (layout based on net/base libraries)."
This reverts commit fdeb8575309055ad23803b376659c236099348ac.

Review URL: http://codereview.chromium.org/10908


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5392 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 22:23:46 +00:00
scherkus@chromium.org 1b34e0fc01 Checking in the media project files (layout based on net/base libraries).
Added a dummy media.cc file in order to produce media.lib so there are no
linker errors when building media_unittests.exe.  Currently chrome_dll
does NOT depend on media so it will not be linked in, which is OK for now :)
Review URL: http://codereview.chromium.org/10683

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5389 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 22:10:12 +00:00
agl@chromium.org 6755331f09 Add extra pass throughs for enforge.
Add march flag to builds. Our system compilers are assuming > i386 already, but
not all gcc installations will do this. Without an march flag, gcc assumes only
a 386 and then some atomic operations are compiled to undefined references
which break linking.

Review URL: http://codereview.chromium.org/10689


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5363 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 20:11:17 +00:00
tony@chromium.org 610050b47d fix mac build
need to include dmg_fp config settings in debug and release

tbr=playmobil

Review URL: http://codereview.chromium.org/10665


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5325 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-13 00:00:46 +00:00
evanm@google.com f5d343a0ce Allow chromium to be built with some system libs by introducing
a variable called SYSTEM_LIBS, consisting of a comma-separated
list of system libraries. So far, bzip2, libpng, libjpeg,
libxml, libxslt, lzma_sdk, zlib, hunspell, sqlite, libevent are recognized.

BUG=4321

Review URL: http://codereview.chromium.org/10626
Patch from Fabien Tassin <fta@sofaraway.org>.


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5320 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 23:23:52 +00:00
tc@google.com d24eb6296a Make unit_tests pass with pt_BR.UTF-8 locale.
BUG=3675

Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>
original issue: http://codereview.chromium.org/9509

Review URL: http://codereview.chromium.org/11002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5319 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 23:19:30 +00:00
tc@google.com a0708c6f6d add distcc_dir to the list of pass through vars
Review URL: http://codereview.chromium.org/10658


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5316 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 23:01:48 +00:00
evanm@google.com ca912ea7d7 chmod +x install-build-deps.sh
R=deanm


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5292 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 20:54:10 +00:00
deanm@chromium.org 4259cc4667 Build v8 in debug mode, we build everything else in debug.
Review URL: http://codereview.chromium.org/10636

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5274 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-12 19:31:08 +00:00
evanm@google.com c4a6002a10 Some changes necessary to build an optimized binary on Linux.
Two other speedup changes that I'm not including:
 root_env = Environment(
     tools = ['component_setup'],
+    RPATH=[],

And
 linux_env.Tool('target_platform_linux')
-linux_env.Tool('target_debug')
+linux_env.Tool('target_optimized')

Review URL: http://codereview.chromium.org/10292


git-svn-id: http://src.chromium.org/svn/trunk/src/build@5193 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-11 19:12:07 +00:00
paulg@google.com 89a99172b2 Replace 7z with ar.
Review URL: http://codereview.chromium.org/10299

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5191 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-11 19:02:12 +00:00
dkegel@google.com ee579a8fe9 Serialize links on Linux. Should fix http://code.google.com/p/chromium/issues/detail?id=3805
Review URL: http://codereview.chromium.org/9463

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-10 22:32:01 +00:00
mark@chromium.org 29ca6d3298 Reduce build verbosity after r5042
git-svn-id: http://src.chromium.org/svn/trunk/src/build@5068 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-08 14:38:11 +00:00
bradnelson@chromium.org 3a1113cb9a Adding in new solution builder pattern.
Review URL: http://codereview.chromium.org/10231

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5047 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-08 00:12:34 +00:00
mark@chromium.org 9e48815ff4 Dramatically improve the link time in release mode. Today's MC Hammer Xcode
Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake"
.dSYM that contains the original unstripped Mach-O file.
Review URL: http://codereview.chromium.org/9659

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-07 23:55:47 +00:00
sgk@google.com 03bb2a400b Set cpus=1 on systems where we don't (yet) know how to deduce
the number of CPUs.  This at least allows the build to function
on unknown systems.

Remove a now-unnecessary addition of $V8_DIR to LIBPATH.  The
v8 libraries now get installed in $LIBS_DIR like everyone else.
Review URL: http://codereview.chromium.org/10208

git-svn-id: http://src.chromium.org/svn/trunk/src/build@5007 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-07 19:32:43 +00:00
tc@google.com a8fd3d2cfe A more friendly build error on linux
when packages are not found by pkg-config.

Review URL: http://codereview.chromium.org/9618


git-svn-id: http://src.chromium.org/svn/trunk/src/build@4856 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-06 01:36:34 +00:00
sgk@google.com fcdca53949 Make better (and more efficient) use of Hammer functionality
in base, net and sandbox:
* Remove by-hand Install() and Alias() calls.
* Set $COMPONENT_PROGRAM_GROUPS and $COMPONENT_TEST_PROGRAM_GROUPS
  (with in each foo\foo.scons file) so executables get added
  automatically to the appropriate Alias.
* Set $TESTS_DIR and $STAGING_DIR so executables get linked
  directly in their final resting place ($TARGET_ROOT).
Review URL: http://codereview.chromium.org/9188

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4805 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 19:48:25 +00:00
brettw@google.com 6da170243d Unrollback the Scons changes, they weren't the cause of the problem.
Review URL: http://codereview.chromium.org/9184

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4783 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 17:27:18 +00:00
brettw@google.com 8fad7b7ebb Rollback r4734 to see if it fixes the crashing I experience when starting chrome, as well as the 1MB regression in chrome.dll size.
Review URL: http://codereview.chromium.org/8226

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4781 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 16:43:50 +00:00
bradnelson@chromium.org 9f09494542 Adding better project generation (source and build targets).
Adding fix to targets_msvs to work with chrome hammer.bat in depot_tools.


Review URL: http://codereview.chromium.org/9149

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4734 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-05 02:37:37 +00:00
bradnelson@chromium.org a8cac93cc2 Take Hammer out of the default target list.
Review URL: http://codereview.chromium.org/9142

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4673 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-04 21:59:37 +00:00
bradnelson@chromium.org eb99a0eae3 Adding visual studio solution files.
Sandbox is currently having a problem with this so it is disabled.
Fixed a few stray items.

Review URL: http://codereview.chromium.org/9259

git-svn-id: http://src.chromium.org/svn/trunk/src/build@4525 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2008-11-04 00:32:42 +00:00