Граф коммитов

3357 Коммитов

Автор SHA1 Сообщение Дата
ilevy@chromium.org 446837e802 Add android findbugs to main builder / main trybot
- this will stick these tests on CQ. But I will try to rewrite
  them as a presubmit test next week.

NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11364155

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166752 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 20:59:03 +00:00
pliard@chromium.org 191521e795 Upstream recent downstream changes in envsetup.sh.
A superset of this change was needed to fix a bug downstream. Note that the bug
doesn't exist upstream since it was caused by a piece of code not upstreamed.

Therefore the only purpose of this change is to decrease the upstream vs
downstream diff.


Review URL: https://chromiumcodereview.appspot.com/11365147

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166699 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 18:11:02 +00:00
pliard@chromium.org 8cbdbb400f Fix findbugs_diff in ContentVideoView.java.
Findbugs was emitting:
M P SIC: Should org.chromium.content.browser.ContentVideoView$FullScreenMediaController be a _static_ inner class?  At ContentVideoView.java

NOTRY=true
TEST=findbugs_diff.py


Review URL: https://chromiumcodereview.appspot.com/11293170

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 14:30:52 +00:00
jknotten@chromium.org ef38b69c93 Fix Findbugs Warnings
TestWebServer moved from Android WebView to net.test in
https://chromiumcodereview.appspot.com/11366108 , but the
findbugs file was not correctly updated.

Review URL: https://codereview.chromium.org/11365148

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166668 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 12:45:06 +00:00
cramya@chromium.org a36930902a Disabling failing/crash webkit_unit_tests
BUG=159935


Review URL: https://chromiumcodereview.appspot.com/11365140

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166665 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 12:21:18 +00:00
mkosiba@chromium.org 8a9a13e51a Add android_webview_unittests to the FYI android bot.
This makes the android FYI test runners run android_webview
native unittests.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11366133

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166663 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 12:17:18 +00:00
msarda@chromium.org 69f2cf2f7e Add Sad Tab resources to the iOS build.
Review URL: https://chromiumcodereview.appspot.com/11364130

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166651 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 10:27:08 +00:00
nileshagrawal@chromium.org 3bb3dae148 Android: Fix invocations of TestResult.LogFull
Also remove the tests_to_run output from summay if we do not have the list of tests.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11365134

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166602 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 04:39:09 +00:00
scottmg@google.com 8c900d2e48 Revert 166547 - Use tcmalloc's debugallocation for Debug builds
to catch memory problems early, easily, and cleanly.

Because of gyp limitations, this can't be now controlled
by a flag.

BUG=30715
TEST=none

Review URL: https://codereview.chromium.org/11266019

TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/11366141

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166566 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 01:00:08 +00:00
brettw@chromium.org d8b77bb8ec Enable pepper threading by default.
BUG=159240

Review URL: https://codereview.chromium.org/11361075

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166560 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 00:33:21 +00:00
phajdan.jr@chromium.org 7e5f077000 Linux: fix build with system ffmpeg (Chromium side).
BUG=118986, 91970

Review URL: https://codereview.chromium.org/11364077

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166557 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-08 00:09:31 +00:00
phajdan.jr@chromium.org 86eb779b72 Use tcmalloc's debugallocation for Debug builds
to catch memory problems early, easily, and cleanly.

Because of gyp limitations, this can't be now controlled
by a flag.

BUG=30715
TEST=none

Review URL: https://codereview.chromium.org/11266019

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166547 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 23:33:43 +00:00
mmoss@chromium.org 973efb33fc Fix if/then typo.
TBR=scroggo@chromium.org

Review URL: https://codereview.chromium.org/11360134

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166537 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 22:56:35 +00:00
peter@chromium.org c7cb0e1d3f Export the build type as part of Android's build bot baseline setup
The WebKit tester builds in release mode, which we need to tell the run_tests.py
script about. Otherwise it'll assume a debug build, causing it to be unable to
find the webkit_unit_tests and TestWebKitAPI APKs.

BUG=136774

Review URL: https://chromiumcodereview.appspot.com/11368122

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166519 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 21:12:05 +00:00
jknotten@chromium.org aecc5cdb78 Move Android WebView Test WebServer to net.
Move Android WebView Test WebServer to net so that other test code can
make use of it.

BUG=159601


Review URL: https://chromiumcodereview.appspot.com/11366108

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166493 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 19:40:41 +00:00
mmoss@chromium.org b8025de8b3 Improve warnings about 32bit libs on 64bit systems.
Review URL: https://codereview.chromium.org/11360130

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166488 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 19:31:52 +00:00
bulach@chromium.org 7d38bac524 Android: uses "import" section and inner classes for obtaining qualified JNI parameters.
Rather than explicitly listing all the parameters
(see crbug.com/158722), infer almost all of them from the import section and inner classes.
Assumes other classes are in the same package as a fallback.

BUG=159397
TEST=base/android/jni_generator/jni_generator_tests.py


Review URL: https://chromiumcodereview.appspot.com/11363079

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166482 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 19:06:51 +00:00
hans@chromium.org 70b992f6a9 Roll Clang for the Android port 163674:167488.
This brings us up to the same version as the rest of Chromium.

Disable -Wasm-operand-widths until crbug.com/159452 is fixed.

BUG=159712, 156947, 159452


Review URL: https://chromiumcodereview.appspot.com/11371004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166479 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 18:57:53 +00:00
peter@chromium.org aaf54ef3a5 Fix running WebKit layout tests by not indenting a continuation.
BUG=

Review URL: https://codereview.chromium.org/11364128

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166440 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 15:44:55 +00:00
cjhopman@chromium.org aff218abd9 Remove unneeded symbolic link to libraries.
The stack annotation tool has been changed to work with Chrome output
directory structure and so we no longer need to create the artificial
structure in out/android.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11368102

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166423 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 15:08:01 +00:00
peter@chromium.org 8869e2b098 Teach the WebKit bots how to run layout tests, TestWebKitAPI and webkit_unit_tests for Android
This will enable them to run the suites themselves. Having more detailed error
messages and uploading the created results will be implemented after this.

BUG=136774

Review URL: https://chromiumcodereview.appspot.com/11312101

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166417 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 13:53:14 +00:00
pastarmovj@google.com c1f966fa34 Revert 166369 - Revert 166365 - roll clang 165787:167488
Seems like a clobber might be enough to fix the issues caused by this CL.

Reverted because it is assumed to be the cause for multiple compile failures on  mac and linux.

Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)

BUG=159712,159452,159475,159502,159598,59580
TBR=hans

Review URL: https://codereview.chromium.org/11361133

TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020

TBR=pastarmovj@google.com
Review URL: https://codereview.chromium.org/11377023

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166405 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 12:52:38 +00:00
eugenis@chromium.org 7eaafcbdc6 Support running Android apk-based tests under ASan.
BUG=137569
Review URL: https://codereview.chromium.org/11361125

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166394 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 12:14:16 +00:00
eugenis@chromium.org ff8eb4dd41 Disable ASan instrumentation of globals on Android.
BUG=137569,159801
Review URL: https://codereview.chromium.org/11275185

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166391 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 12:11:25 +00:00
jcivelli@chromium.org 52ce28c51d Make sure we build the tools used for testing minidumps on Android.
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/11368111

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166377 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 10:18:55 +00:00
pastarmovj@google.com b0b2a042ca Revert 166365 - roll clang 165787:167488
Reverted because it is assumed to be the cause for multiple compile failures on  mac and linux.

Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)

BUG=159712,159452,159475,159502,159598,59580
TBR=hans

Review URL: https://codereview.chromium.org/11361133

TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166369 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 08:49:12 +00:00
thakis@chromium.org 605d4a523d roll clang 165787:167488
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)

BUG=159712,159452,159475,159502,159598,59580
TBR=hans

Review URL: https://codereview.chromium.org/11361133

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166365 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 06:57:44 +00:00
tedchoc@chromium.org feb3978829 Fix adb_run_content_shell to correctly pass URL.
Also fixes testshell to support launching with a URL and triggering
new intents (and fixes it's adb_run_chromium_testshell.

BUG=159602


Review URL: https://chromiumcodereview.appspot.com/11377011

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166357 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-07 04:53:26 +00:00
frankf@chromium.org 7e62b5f5df Add TakeScreenshot command to android_commands.
Also, take screenshots using /system/bin/screencap instead of monkeyrunner.

BUG=158851

Review URL: https://codereview.chromium.org/11366068

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166273 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 21:44:58 +00:00
eugenis@chromium.org 2834bd5d07 ASan on Android requires -pie.
Review URL: https://codereview.chromium.org/11363104

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166212 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 16:01:21 +00:00
bulach@chromium.org 581d3136c6 Android: fixes instrumentation tests call to LogFull.
Following:
https://chromiumcodereview.appspot.com/11363088
add an extra empty parameter.

BUG=
TEST=instrumentation tests on android


Review URL: https://chromiumcodereview.appspot.com/11293115

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166208 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 14:34:48 +00:00
torne@chromium.org bb85c64ec5 Android: fix webview build.
TARGET_ARCH doesn't get set in the webview path through envsetup;
hardcode it to ARM for now. This will be revisited once envsetup has
been tidied up to make this less complicated.

BUG=

Review URL: https://codereview.chromium.org/11359069

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166198 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 12:46:17 +00:00
bulach@chromium.org 983e2624ca Android: uses an object rather than the Boolean for synchronizing LibraryLoad.
BUG=159173


Review URL: https://chromiumcodereview.appspot.com/11312066

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166193 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 12:33:51 +00:00
pkotwicz@chromium.org bff60ca8cf Cleanup resource_bundle_unittest
BUG=None
Test=ResourceBundleTest.*

Review URL: https://chromiumcodereview.appspot.com/11358014

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 03:53:18 +00:00
nileshagrawal@chromium.org b360e14245 Android: Report step failure when tests time out.
Currently when tests time out, we retry them but still mark the step as
a warning, which does not cause a step failure.

We should report a failure when tests time out. Also adding more stats
on how many tests we were supposed to run and how many we failed to run.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11363088

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166132 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 03:45:53 +00:00
sergeyu@chromium.org ff63a0a779 Move Chromoting strings to string_resources.grd and simplify remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD 
file will allow to share them with native components. Also simplified 
how resources are generated:
 1. Now <if> is used to handle branded strings instead of generating 
    grd file in build time
 2. Removed resource_ids - ids are now specified in grd files.

BUG=158995


Review URL: https://chromiumcodereview.appspot.com/11275101

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166127 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 03:39:19 +00:00
vandebo@chromium.org db864e9b52 Revert 166085 - Selective build clobbering feature (landmines.py and android build scripts).
It looks like this made win extract_build fail.

Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that
the build will selectively clobber when a builder moves over a revision with such
a change.

This cl has an basis landmines.py, and hooks the clobber mechanism to the android
build scripts. 

The relevant cl which implements this for
compile.py is here: https://chromiumcodereview.appspot.com/11234013/

I'm planning to also implement an informational invocation for gclient to let devs know
about any potential landmines so they can decide if they need to clobber.

R=cmp,maruel@chromium.org
BUG=121897

Review URL: https://chromiumcodereview.appspot.com/11175016

TBR=iannucci@chromium.org
Review URL: https://codereview.chromium.org/11293111

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166105 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 01:53:24 +00:00
iannucci@chromium.org 378a534dbb Selective build clobbering feature (landmines.py and android build scripts).
Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that
the build will selectively clobber when a builder moves over a revision with such
a change.

This cl has an basis landmines.py, and hooks the clobber mechanism to the android
build scripts. 

The relevant cl which implements this for
compile.py is here: https://chromiumcodereview.appspot.com/11234013/

I'm planning to also implement an informational invocation for gclient to let devs know
about any potential landmines so they can decide if they need to clobber.

R=cmp,maruel@chromium.org
BUG=121897

Review URL: https://chromiumcodereview.appspot.com/11175016

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166085 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 00:13:27 +00:00
nileshagrawal@chromium.org 150fbdb816 Android: Fix finbugs step on experimental bots.
BUG=

Review URL: https://codereview.chromium.org/11365101

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-06 00:05:56 +00:00
ilevy@chromium.org 166b551ea4 Pass -g1 on android release builds with fastbuild
Also reorganizing fastbuild section.

NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/11364088

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166076 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 23:54:43 +00:00
phajdan.jr@chromium.org 69a1067671 Revert "Move Chromoting strings to string_resources.grd and simplify remoting_resources target."
This reverts commit f5dfed801f9358411900c4f9ca58ef0a11cce9ae.

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166069 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 23:32:12 +00:00
sergeyu@chromium.org d5f0ede00e Move Chromoting strings to string_resources.grd and simplify remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD
file will allow to share them with native components. Also simplified
how resources are generated:
 1. Now <if> is used to handle branded strings instead of generating
    grd file in build time
 2. Removed resource_ids - ids are now specified in grd files.

BUG=158995

Review URL: https://codereview.chromium.org/11275101

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166068 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 23:26:21 +00:00
jochen@chromium.org f869fa5d67 Add an option to specify the versio to tweak_info_plist, and use it to set the version of content_shell
This breaks the dependency on chrome/VERSION to build content shell on mac

BUG=156242


Review URL: https://chromiumcodereview.appspot.com/11367095

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166044 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 21:57:28 +00:00
blundell@chromium.org 6f6f580f69 Add several strings to the grit whitelist for iOS.
Review URL: https://chromiumcodereview.appspot.com/11359056

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166033 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 21:19:56 +00:00
nileshagrawal@chromium.org 8a1fd85c19 Android: Remove dependency on language detection library.
Savings: 1.2MB in stripped so (in the .rodata section)
         750K in APK size


BUG=155069

Review URL: https://chromiumcodereview.appspot.com/11361051

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166024 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 20:40:31 +00:00
sergeyu@chromium.org 0e2ccdaa18 Revert 166003 - Move Chromoting strings to string_resources.grd and simplify remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD
file will allow to share them with native components. Also simplified
how resources are generated:
 1. Now <if> is used to handle branded strings instead of generating
    grd file in build time
 2. Removed resource_ids - ids are now specified in grd files.

BUG=158995

Review URL: https://codereview.chromium.org/11275101

TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/11365095

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166013 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 20:17:54 +00:00
sergeyu@chromium.org 34f1df4e5e Move Chromoting strings to string_resources.grd and simplify remoting_resources target.
Previously all strings were in messages.json files. Moving them to GRD
file will allow to share them with native components. Also simplified
how resources are generated:
 1. Now <if> is used to handle branded strings instead of generating
    grd file in build time
 2. Removed resource_ids - ids are now specified in grd files.

BUG=158995

Review URL: https://codereview.chromium.org/11275101

git-svn-id: http://src.chromium.org/svn/trunk/src/build@166003 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 19:55:59 +00:00
maruel@chromium.org e13b1f9e62 Disable isolate_dependency_tracked in build driver for .isolate files.
This is to help speed up the switch over. This will be reenabled once the
switch over is in progress.

R=csharp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11365087

git-svn-id: http://src.chromium.org/svn/trunk/src/build@165965 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 18:29:12 +00:00
blundell@chromium.org de44484f68 Changes to build/common.gypi for iOS.
- Disable some features that are not used on iOS.
- Remove dSYM in debug mode to reduce build time.
- Build for armv7 as armv7s is not yet fully tested.


Review URL: https://chromiumcodereview.appspot.com/11364072

git-svn-id: http://src.chromium.org/svn/trunk/src/build@165948 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 17:11:44 +00:00
blundell@chromium.org 2545b7573a Change copy_test_data_ios.py to enable copying hidden files.
Loosen the dotfile test in this script as some tests can use hidden files.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11312084

git-svn-id: http://src.chromium.org/svn/trunk/src/build@165936 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
2012-11-05 14:22:30 +00:00