I would have preferred if precompiled headers could be enabled by
default. The motivation for this change is primarily that Visual
Studio does the wrong thing on preprocessor flag changes - instead of
rebuilding precompiled headers, it errors out on any file that uses
them, saying that the precompiled header was built with different
flags! This causes a world of hurt on our infrastructure stuff,
particularly on trybots as they may be jumping back and forth between
revisions before and after a flag change.
Prior to this change, only Debug builds used precompiled headers and
Release builds did not. The reason Release builds did not was that
official builds were running out of memory with precompiled headers
enabled. The distinction of Debug vs. Release is no longer necessary
after the flag is added, so removing that extra bit of complexity from
the .gyp files.
BUG=none
TEST=it builds
Review URL: http://codereview.chromium.org/8041022
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102839 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Use XI2 multitouch events instead of mouse events as touch event input for touchui build.
Note: XI MT will be supported in X server 1.12 and XI2.2. Please use build switch "use_xi2_mt=<minor version number>" to specify the minimum XI2 minor version. It is useful to test on experimental XI2.1 with MT support (e.g. build with use_xi2_mt=1).
BUG=95150
TEST=(1) build with touchui=1 use_xi2_mt=1 (2) test on ubuntu 11.04 (X server 1.10 and XI2.1 with experimental MT support). (3) manually test if touch works on browser UI and JS touch events.
Review URL: http://codereview.chromium.org/7792094
Patch from Ningxin Hu <ningxin.hu@intel.com>.
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102668 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
tools/clang/scripts/update.sh tries to use curl to download over https (wget has
issues with this). To make sure curl is installed on new bots, add it to
install-build-deps.sh, so that we can use the https download on bots.
BUG=97288
TEST=none
Review URL: http://codereview.chromium.org/7966029
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102566 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This allows develoeprs to build from any sln file and not have to rebuild the
world. This is more like how XCode projects are generated.
We choose src/build/{Debug,Release} because this is where all.sln generates
files and this is what the bots use. This shouldn't require any changes to
the bots.
BUG=95278
Review URL: http://codereview.chromium.org/7835006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102514 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Removes the dependency on chromeos-specific code in the extension-based file picker. Compiles and links, but does not yet run - the extension subsystem is not finding the resources for the file_manager component extension. The Aura build currently won't process keyboard or mouse events, so I don't have a good way to debug this. For now, added logging, and we'll get back to it when Aura is in better shape.
BUG=chromium-os:20583
TEST=On plain ChromeOS, can still open a file with control-O file picker.
Review URL: http://codereview.chromium.org/7941014TBR=jamescook@chromium.org
Review URL: http://codereview.chromium.org/7976025
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102116 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Removes the dependency on chromeos-specific code in the extension-based file picker. Compiles and links, but does not yet run - the extension subsystem is not finding the resources for the file_manager component extension. The Aura build currently won't process keyboard or mouse events, so I don't have a good way to debug this. For now, added logging, and we'll get back to it when Aura is in better shape.
BUG=chromium-os:20583
TEST=On plain ChromeOS, can still open a file with control-O file picker.
Review URL: http://codereview.chromium.org/7941014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102113 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=96935
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Review URL: http://codereview.chromium.org/7957002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102071 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7904034
git-svn-id: http://src.chromium.org/svn/trunk/src/build@102005 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Original change description: Switch on use of precompiled headers for VS 2008.
The precompiled header brings in more definitions of abs() for the base/time_win.cc file, and a hint to the compiler was needed to let VS 2008 build the file correctly.
On VS 2008 only, the mini_installer target did not link correctly with precompiled headers enabled so this change disables them for that project.
BUG=none
TEST=it builds (esp. on Windows), existing tests pass
Review URL: http://codereview.chromium.org/7910002TBR=laforge@chromium.org
Review URL: http://codereview.chromium.org/7945017
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101836 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=96935
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101581
Review URL: http://codereview.chromium.org/7670041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101785 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reason for revert: Broke compile on linux touch.
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=None
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Review URL: http://codereview.chromium.org/7670041TBR=flackr@chromium.org
Review URL: http://codereview.chromium.org/7919028
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101585 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This adds the flag --use-more-webui to allow turning on WebUI replacements for native dialogs. This flag is automatically set when --use-pure-views is specified. Modifies replaced native dialogs to be toggled based on flag value. BookmarkEditor has also been refactored to use static constructors to EditDetails to describe what is being edited to make the code more readable.
BUG=None
TEST=Tested that webui dialogs can be turned on or left off with --use-more-webui.
Review URL: http://codereview.chromium.org/7670041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101581 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The precompiled header brings in more definitions of abs() for the base/time_win.cc file, and a hint to the compiler was needed to let VS 2008 build the file correctly.
On VS 2008 only, the mini_installer target did not link correctly with precompiled headers enabled so this change disables them for that project.
BUG=none
TEST=it builds (esp. on Windows), existing tests pass
Review URL: http://codereview.chromium.org/7910002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101474 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Clean up SSL false start blacklist code. Numerous changes, including:
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.
Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7903016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@101378 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
epoger@google.com
thestig@chromium.org
joi@chromium.org
michaelbai@google.com
jschuh@chromium.org
cmp@chromium.org
rsleevi@chromium.org
sadrul@chromium.org
saintlou@chromium.org
sievers@chromium.org
thakis@chromium.org
evan@chromium.org
tony@chromium.org
davemoore@chromium.org
bradnelson@google.com
jamescook@chromium.org
flackr@chromium.org
nsylvain@chromium.org
sky@chromium.org
piman@chromium.org
scherkus@chromium.org
rsimha@chromium.org
ben@chromium.org
pkasting@chromium.org