Reproduced on a new Win7 x64 VM, and this fixed the build (at
least for the chrome target).
This doesn't address the need to copy the runtime DLLs into the
output directory so that chrome runs though, that's a separate
problem where something in chrome's gyp should be copying them
there, at least for a debug build.
TBR=mikelawther@chromium.org
BUG=326345
Review URL: https://codereview.chromium.org/111183002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@239671 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Without GYP_DEFINES set, build/gyp_chromium would crash with
Generating gyp files from GN...
Traceback (most recent call last):
File "./build/gyp_chromium", line 207, in <module>
if not RunGN(supplemental_includes):
File "./build/gyp_chromium", line 147, in RunGN
gyp_vars = GetVarsStringForGN(supplemental_includes)
File "./build/gyp_chromium", line 79, in GetVarsStringForGN
items = shlex.split(env_string)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 279, in split
return list(lex)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 269, in next
token = self.get_token()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 96, in get_token
raw = self.read_token()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 124, in read_token
nextchar = self.instream.read(1)
AttributeError: 'list' object has no attribute 'read'
This was broken by r238475
BUG=321352
Review URL: https://codereview.chromium.org/103253002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238486 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of 236542 and 238454 (runs GN in GYP mode before actually running GYP), plus some additions
Move GYP_DEFINES parsing to Python for GN.
I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
Currently, GN does not produce any files used by the build, these will be added in a second step.
BUG=321352
TBR=bradnelson@google.com
Review URL: https://codereview.chromium.org/101573004
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238475 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
> Hook up GN to the GYP build system.
>
> This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions
>
> Move GYP_DEFINES parsing to Python for GN.
>
> I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
>
> Currently, GN does not produce any files used by the build, these will be added in a second step.
>
> BUG=321352
> R=bradnelson@google.com
>
> Review URL: https://codereview.chromium.org/73623005TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/102923002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238459 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions
Move GYP_DEFINES parsing to Python for GN.
I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
Currently, GN does not produce any files used by the build, these will be added in a second step.
BUG=321352
R=bradnelson@google.com
Review URL: https://codereview.chromium.org/73623005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@238454 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This cl ports the nacl wrapper to the chromium build system and adds local modifications from Chromevox to liblouis. The native library and braille tables are copied to the location in the resources output directory where chromevox can pick them up.
BUG=316353
Review URL: https://codereview.chromium.org/67283007
git-svn-id: http://src.chromium.org/svn/trunk/src/build@237638 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
With this change, `gclient runhooks` creates ninja files by default on Mac.
To build, run `ninja -C out/Release chrome`. The output appears in out/
instead of in xcodebuild/. (This doesn't happen if OS=ios, so it shouldn't
affect chrome/ios development.)
If you need to use xcode for some reason, you can
`export GYP_GENERATORS=xcode` to force xcode project generation.
If you do this, please inform me why.
Bots should automatically pick up the binaries in the new location (out).
If something does break, it should be safe to revert this change, and bots
should then automatically go back to picking up binaries from the old
location (xcodebuild).
BUG=294387
R=mark@chromium.org
Review URL: https://codereview.chromium.org/31143002
git-svn-id: http://src.chromium.org/svn/trunk/src/build@231675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL modifies remoting/tools/localize.py script such that it can:
- be invoked via 'pymod_do_main' filter.
- generate a separate output file for each locale/language.
- produce the list of output files for given set of parameters.
remoting.gyp now generates the lists of .pak and message.json files invoking the script via 'pymod_do_main' filter. 'pymod_do_main' is necessary to pass paths unaltered between GYP and python.
The script was also renamed to remoting/tools/build/remoting_localize.py to avoid potential name clashes since the script is globally visible now.
TBR is for the DEPS changes only.
TBR=cpu@chromium.org
BUG=155204
Review URL: https://chromiumcodereview.appspot.com/18868009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@211227 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If a generator is set explicitly (via GYP_GENERATORS or via -f or via
chromium.gyp_env), it will have precedence over the new default.
If you've used make until now, run `ninja -C out/Debug` instead of `make` to
build.
If you're using goma, go/ma has documentation on how to use goma with ninja.
(It's the same as make, except that CC / CXX are now picked up at `gclient sync`
/ `gclient runhooks` / `build/gyp_chromium` time instead of at build time.)
If you can't use ninja for some reason, `export GYP_GENERATORS=make` and sync
again. Please also send me (thakis@chromium.org) an email explaining why ninja
does not work for you.
This will also switch all bots that don't explicitly set a build tool (including
the public bots). compile.py will use ninja instead or make based on if
build.ninja or Makefile are newer, so they should build the right thing
automatically. And since built products end up in the same place, packaging
should do the right thing too.
BUG=239257
R=mark@chromium.org
Review URL: https://codereview.chromium.org/15100009
git-svn-id: http://src.chromium.org/svn/trunk/src/build@199603 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It looks like this made win extract_build fail.
Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that
the build will selectively clobber when a builder moves over a revision with such
a change.
This cl has an basis landmines.py, and hooks the clobber mechanism to the android
build scripts.
The relevant cl which implements this for
compile.py is here: https://chromiumcodereview.appspot.com/11234013/
I'm planning to also implement an informational invocation for gclient to let devs know
about any potential landmines so they can decide if they need to clobber.
R=cmp,maruel@chromium.org
BUG=121897
Review URL: https://chromiumcodereview.appspot.com/11175016TBR=iannucci@chromium.org
Review URL: https://codereview.chromium.org/11293111
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166105 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that
the build will selectively clobber when a builder moves over a revision with such
a change.
This cl has an basis landmines.py, and hooks the clobber mechanism to the android
build scripts.
The relevant cl which implements this for
compile.py is here: https://chromiumcodereview.appspot.com/11234013/
I'm planning to also implement an informational invocation for gclient to let devs know
about any potential landmines so they can decide if they need to clobber.
R=cmp,maruel@chromium.org
BUG=121897
Review URL: https://chromiumcodereview.appspot.com/11175016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166085 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This target generates the locale .pak files on Windows. Since nothing
depends on this target, it doesn't build by default (they're not used
yet).
Specific changes:
- Have locale_settings_win.grd generate .pak files.
- Use pymod_do_main to avoid some shell escaping problems (and it's a bit
faster).
- Rewrite repack_locales.py to work with pymod_do_main.
BUG=92724
Review URL: http://codereview.chromium.org/7648001
git-svn-id: http://src.chromium.org/svn/trunk/src/build@97012 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
brettw@chromium.org
scottmg@chromium.org
thakis@chromium.org
plundblad@chromium.org
jam@chromium.org
ckocagil@chromium.org
iannucci@chromium.org
schenney@chromium.org
alexeypa@chromium.org
adamk@chromium.org
abarth@chromium.org
tony@chromium.org
phajdan.jr@chromium.org
vandebo@chromium.org
grt@chromium.org
yongsheng.zhu@intel.com
bradnelson@google.com
joi@chromium.org
maruel@chromium.org
pam@chromium.org