Currently when logdog binary doesn not exist, we are still trying to
upload logcats. Without logdog binary setting up, trying to upload
logcats will result in NotBootstrappedError. This error will then output
a stack which is confusing to engineers.
BUG=675666
Review-Url: https://codereview.chromium.org/2835203004
Cr-Original-Commit-Position: refs/heads/master@{#467505}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9efa729c382c00ae0746a4abf98e4358d9f12ff4
Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.
In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.
BUG=707387
Review-Url: https://codereview.chromium.org/2797773003
Cr-Original-Commit-Position: refs/heads/master@{#461898}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9ae14459caaa7f3b049b3d44be2c209890773213
Previously we ran tests, without setting butler environment variables.
This will run into NotBootstrappedError when we try to upload test
results through logdog.
In this cl, we use logdog butler subcommand to run tests, which will set
butler environment variables before hand.
BUG=692287
Review-Url: https://codereview.chromium.org/2695963003
Cr-Commit-Position: refs/heads/master@{#456976}
Committed: de2df28c86
patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001)
Review-Url: https://codereview.chromium.org/2767833002
Cr-Original-Commit-Position: refs/heads/master@{#459281}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6
Previously we ran tests, without setting butler environment variables.
This will run into NotBootstrappedError when we try to upload test
results through logdog.
In this cl, we use logdog butler subcommand to run tests, which will set
butler environment variables before hand.
BUG=692287
Review-Url: https://codereview.chromium.org/2695963003
Cr-Commit-Position: refs/heads/master@{#456976}
Committed: de2df28c86
patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001)
Review-Url: https://codereview.chromium.org/2753993002
Cr-Original-Commit-Position: refs/heads/master@{#458264}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5
Reason for revert:
Increases time by a great deal.
Original issue's description:
> Use logdog butler subcommand to run tests.
>
> Previously we ran tests, without setting butler environment variables.
> This will run into NotBootstrappedError when we try to upload test
> results through logdog.
>
> In this cl, we use logdog butler subcommand to run tests, which will set
> butler environment variables before hand.
>
> BUG=692287
>
> Review-Url: https://codereview.chromium.org/2695963003
> Cr-Commit-Position: refs/heads/master@{#456976}
> Committed: de2df28c86TBR=mikecase@chromium.org,dnj@chromium.org,jbudorick@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692287
Review-Url: https://codereview.chromium.org/2749643008
Cr-Original-Commit-Position: refs/heads/master@{#457257}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d58d09ff7ef678920db1110ae5a0230f7d7cdb52
Previously we ran tests, without setting butler environment variables.
This will run into NotBootstrappedError when we try to upload test
results through logdog.
In this cl, we use logdog butler subcommand to run tests, which will set
butler environment variables before hand.
BUG=692287
Review-Url: https://codereview.chromium.org/2695963003
Cr-Original-Commit-Position: refs/heads/master@{#456976}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de2df28c86b13227040aba5f9f5a1d1f869b81eb
hzl
jbudorick
bpastene
nicholaslin