- This is a fixed version of
https://chromium-review.googlesource.com/c/chromium/src/+/1995743
which was reverted because it caused a build failure for ToTLinux.
-Build failure in ToTLinux is fixed by only adding "--generate-dwp" for
the Android toolchain when building for Android OS.
- Modify some compiler build definitions to allow symbol_level=2 with
Chrome Android 32bit, and to make the build respect use_debug_fission in
those cases.
- Modify "link" and "solink" tools in Android toolchain so that DWP
files can be generated for builds with use_debug_fission.
- Modify partitioned_shared_library template/script so that DWP files
can be generated for partitioned libs when use_debug_fission is set.
Change-Id: I7f023de42e46aca1e8c56c9edf3858617e2ab5ad
Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Cq-Include-Trybots: chrome/try:mac-chrome
Change-Id: I7f023de42e46aca1e8c56c9edf3858617e2ab5ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330810
Commit-Queue: Nelson Billing <nbilling@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801271}
GitOrigin-RevId: 3ed7301e9e05897bc8d087e73fd3b0b44f7b555e
Add compiler wrapper script at build/apple/swiftc.py, define
the necessary tool in the toolchain and pass the -target and
-sdk through the configuration.
Bug: none
Change-Id: I177b8a6acf169b5c1d2399b625bdc0a82083b6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341135
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800939}
GitOrigin-RevId: d8dec3b0c6760844fe707d2531a3a4f6cfe57c8b
Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS. We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.
This is changes for /build
This CL was uploaded by git cl split.
R=tikuta@chromium.org
Bug: 1110266
Change-Id: Id461b5872c27e7a3f7b4df922e44cc2e073f9dd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371212
Auto-Submit: Sean McAllister <smcallis@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800889}
GitOrigin-RevId: 863b1c2cf409b9929772de52e37d7e5ed3b460e2
Add an example to show how to use the test runner with xvfb
Change-Id: I8ccf0750024e8ae4a8e68e8178faf38d9aa37974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368415
Auto-Submit: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800673}
GitOrigin-RevId: 1974d187732d279cce7172ae6f460966d37a8d49
Adds the --code-review-system flag to the Android test runner and adds
the necessary code to handle it for use with Gold. This is necessary
because we will be specifying 'gerrit-internal' when running tryjobs
for internal CLs so that Gold knows where to comment if new images are
generated.
Bug: 1077274
Change-Id: I5ce089a511275afed0c06378d9d49e977e330f85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366072
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800652}
GitOrigin-RevId: d905484ce6700a15442a7625ef27a93f220acdc8
This CL was initially generated by //tools/gn/roll_gn.py and
picks up the following changes:
https://gn.googlesource.com/gn/+log/e327ffdc..6f13aaac
6f13aaac [visibility] Consider configs in visibility check
5da62d5e Fix native MinGW build
0649bd9a Add MSYS as a platform.
501b49a3 clang: Add support for C++ modules in deps
03df22eb [rust-project] Add "proc_macro" as dep for proc macro targets
b489f906 Add support for Solaris and illumos systems
6f13aac is a breaking change, in that it addresses gn bug #22,
where `visibility` was not actually enforced on configs (it was
enforced only on targets); as a result, we have some visibility
violations that are now picked up with the new GN binary.
This CL fixes those violations.
Change-Id: I52b6e01f31ce64c1926e97b699b7f8a399dbf9f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360685
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800616}
GitOrigin-RevId: c362a595dc6461deb7ac53632639e729602c5cc9
In Debian testing, lib32gcc1 is replaced by lib32gcc-s1 and no longer
installable.
BUG=chromium:1119692
TEST=./install-build-deps on rodete.
Change-Id: I47a8e9d07ac0478a33cf31c6d8566a0e0f98aad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366381
Auto-Submit: Junichi Uekawa <uekawa@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800353}
GitOrigin-RevId: 01b7c1412d486d16538f6ec34a2432b9100ce51d
In Chrome OS, we need to enable call-graph-profile-sort for most
of the use cases, except when we are generating orderfiles. Thus
we have to use a flag to enable call-graph-profile-sort, when
it's needed. Hopefully this flag can also be useful when other
platforms find it useful to enable call-graph-profile-sort.
BUG=chromium:1117564
TEST=Tested locally for chromeos
Change-Id: I045cbeae058889f2b4f20fbfcd1994d45179bb9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364753
Commit-Queue: Tiancong Wang <tcwang@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800344}
GitOrigin-RevId: 98c5c39ab231ef2d986690e8f30dec5d9df3a949
#1 - Ignore XML namespaces when sorting
See https://chromium-review.googlesource.com/c/chromium/src/+/2321522
for an example of where this was causing them to change order.
#2 - Prefer to sort by android:name when present
Prevents order change when attributes are added/removed.
#3 - Don't sort top-level nodes reversed (other than <application>)
Bug: 1064151
Change-Id: If552c2c2baa1f538a00d9ddfa3ead6feb19ce6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366038
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800203}
GitOrigin-RevId: 482eda1279d561e80e2a702ee03407d8408ea11d
Not all EG2 tests run with xcode-parallelization. This is an arg
that's primiarily used with simulators. Downstream, eg2 tests
are also run on devices.
Because simulators are defined in testing/buildbot, and because
the xcode-parallelization arg is bound to platform and version
(both defined by simulators), we move this arg down to testing.
* Introduced support for mixins one level above variants such that
a mixin defined here applies to all variants below.
* Removed the --xcode-parallelization arg in the GN EG2 iOS
template.
* Added xcode-parallelization for all test targets that ran
through the eg2 target upstream.
Bug: 912681
Change-Id: Ie5cb45a14be0ecbb6fb64b7c8af6eea6f49df94c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364031
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800180}
GitOrigin-RevId: 85fb8df06132058d3dce41614e076d6ac5ee6116
As one of the first steps in making the build work with Python 3,
we will need a way to indicate which actions still require Python 2
to run (most work fine under Python 3 already, but some do not).
This CL introduces a python2_action() template, which works just
like a regular action() rule, but ensures that the script runs
under Python 2 instead of whichever Python version you happen to be
running.
This CL also switches //tools/metrics:histograms_xml to use it
(because it seems to need it) as a proof that it works correctly
and does not regress in a normal (python 2) build.
Bug: 941669, 1118214
Change-Id: I98fbc073cf9443acece3caaae2ed35f9d60c38e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363655
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799909}
GitOrigin-RevId: bfd2cd563d440d8fb3136fe08b84581d968318cf
This reverts commit cd69e8f5d2c8477b2a22c73458eca4e718b834ed.
Reason for revert: re-landing with a fix.
Original change's description:
> Revert "Rework generated_script handling in MB."
>
> This reverts commit b05d8793d66d76750d8151598e88fceccebdece6.
>
> Reason for revert: Broke ios full_configs bot. See:
> https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25885
>
> Doesn't look like this change triggered the full_config bots on try.
>
> Original change's description:
> > Rework generated_script handling in MB.
> >
> > It turns out the work I did on the "wrapped_*" targets in
> > gn_isolate_map was somewhat overlapping with the already-existing
> > iOS work to declare things as "generated_scripts". However, the
> > generated_scripts did not include test_env.py.
> >
> > So, this CL rearranges things so that the generated script will call
> > test_env.py, and then we can share logic between the generated_script
> > targets (and every target on iOS and LaCrOS) and use that as the
> > basis for the rest of the work going forward.
> >
> > Bug: 816629
> > Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917
> > Reviewed-by: Erik Staab <estaab@chromium.org>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#799171}
>
> TBR=dpranke@google.com,estaab@chromium.org,jeffyoon@chromium.org
>
> Change-Id: I94597d58417f7aa76320579ca282293e6b643811
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 816629
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364014
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#799629}
TBR=dpranke@google.com,justincohen@chromium.org,estaab@chromium.org,jeffyoon@chromium.org
# Not skipping CQ checks because this is a reland.
Bug: 816629
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: I1f481f23ff1f1de991b13f3e5aadf967818c2763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364696
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#799880}
GitOrigin-RevId: f37639af120bdae188fba18821a089fe798f8be9
We should ensure that no new usages of the real targets can be added.
Change-Id: I4999c2257f9aedef38809c4f182f419c8bed058c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357452
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799813}
GitOrigin-RevId: b7098f557444b7780f9e0fa84b9b84c2475153c3
We should not care about trailing whitespace in expectation files,
since R8 doesn't either.
Change-Id: Ief57c4c260083f662ca5b791edf7504de2e40428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363259
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799804}
GitOrigin-RevId: 099807e92294b0d2aafc478319e83b0e666d5056
See:
https://bugs.chromium.org/p/chromium/issues/detail?id=946475#c48
I believe the root cause of the flake is trying to test if the server
has been killed by trying to rebind to the port, although my test shows
that the port can get claimed for something else by the system.
Add a process.wait() to ensure server process has terminated and remove
the error from checking the port status. Could do a check on PID status
but system could reassign the PID, so that could lead to the same
flake as before except based on PID instead of port number.
Bug: 946475
Change-Id: I48911fffcab6b592ddf627e5999fc0609e0f0b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339553
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799803}
GitOrigin-RevId: 21db61205360d121b6791a6f51ccf9666e899225
Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS. We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.
Bug: 1110266
Change-Id: Iebbe654853bebeb4af49c9cb793dae5938416f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351374
Commit-Queue: Sean McAllister <smcallis@google.com>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799710}
GitOrigin-RevId: 0d73ca3d802abb2f3af6eeaa0e830fa7a4c6b0ad
This reverts commit b05d8793d66d76750d8151598e88fceccebdece6.
Reason for revert: Broke ios full_configs bot. See:
https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25885
Doesn't look like this change triggered the full_config bots on try.
Original change's description:
> Rework generated_script handling in MB.
>
> It turns out the work I did on the "wrapped_*" targets in
> gn_isolate_map was somewhat overlapping with the already-existing
> iOS work to declare things as "generated_scripts". However, the
> generated_scripts did not include test_env.py.
>
> So, this CL rearranges things so that the generated script will call
> test_env.py, and then we can share logic between the generated_script
> targets (and every target on iOS and LaCrOS) and use that as the
> basis for the rest of the work going forward.
>
> Bug: 816629
> Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917
> Reviewed-by: Erik Staab <estaab@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#799171}
TBR=dpranke@google.com,estaab@chromium.org,jeffyoon@chromium.org
Change-Id: I94597d58417f7aa76320579ca282293e6b643811
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364014
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799629}
GitOrigin-RevId: cd69e8f5d2c8477b2a22c73458eca4e718b834ed
The baseline CPU for macOS on arm64 is the Apple A12 (Vortex/Tempest),
and clang should default to this when building for this OS/CPU
combination. Apple clang embedded in Xcode 12 does, but trunk clang does
not, instead targeting the Apple A7 (Cyclone), the proper baseline CPU
for iOS on arm64. https://reviews.llvm.org/D82699 would fix it, but it
hasn't gained any traction. Specify the baseline CPU explicitly here.
Bug: 1107587, 1119249
Change-Id: I2a132b00ef9b5c8262aa24f27a7519d83a3df41a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363772
Auto-Submit: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799582}
GitOrigin-RevId: 2b08317cd0133bb4a2bb2da0a47895f2fe5c75a9
This checks for the existence of the file and skips adding it
as a parameter if it doesn't exist.
Also removes classes from the prebuilt output jar since they
cannot be actually included in the build - they are required
only for the desugaring step.
Bug: 105675
Change-Id: Ib1e86fb25cb4607a18278446c4b35606f179e076
R: agrieve@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363555
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799503}
GitOrigin-RevId: 889a439fd73488b1da8096634b62fbb8683c1fe7
When chrome_public_smoke_test has a crash, our test runner does not
notice and so does not collect tombstones.
This changes the "are there tombstones" logic to look for a tombstone
message in logcat rather than looking to see if any tests crashed.
Bug: 1117540
Change-Id: Ic0594f0d8dcb2cb8c7280ade9d8d5133c890614f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363075
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799490}
GitOrigin-RevId: e384305105fd123223d4df97f0b44afb8a337ae7
Nelson Billing
Andrey Kosyakov
chromium-autoroll
Sylvain Defresne
Sean McAllister
Evan Stade
Tom Anderson
Yuke Liao
Andrew Grieve
Brian Sheedy
Dirk Pranke
Wei-Yin Chen (陳威尹)
Junichi Uekawa
Tiancong Wang
Jeff Yoon
Arthur Eubanks
Mohamed Heikal
Ben Joyce
Sebastien Marchand
Justin Cohen
Mark Mentovai
Justin DeWitt
Hajime Hoshi