As https://crrev.com/c/2299189 adds `OS_MAC` & `OS_APPLE`, add a gn
variable `is_apple` that is true when `OS_APPLE` is defined. This
allow an easy mapping between gn variables and cpp macros.
Convert all usages of `is_ios || is_mac` or `is_mac || is_ios` to
use the new variable instead.
Bug: 1105907
Change-Id: I4cef55496a0ccf0a6162e60409ff3b7996f633dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315695
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791803}
GitOrigin-RevId: fafffe8843d5dac1ef479ae2e9058e0f93faf82d
`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.
Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.
This CL was uploaded by git cl split.
R=tikuta@chromium.org
Bug: 1041419
Change-Id: I15bd43c6df0ba87f879e5226e4dbb1af7ba73f03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998745
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#731078}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4782d7368c37ae35cf0c44456ba8307079a4d24e
Extra changes in this update:
- Update the released clang version to 10.0.0.
- Move -momit-leaf-frame-pointer next to -fno-omit-frame-pointer
since that's where it logically belongs. clang started warning
on momit without fno-omit after r365860, but it stopped doing this
again in r368728 so this change is no longer needed for the roll.
But it's still a nice cleanup.
- A file in the profile runtime with static init was renamed, do that in the
check
- Disable new -Wno-implicit-float-conversion warning
- Remove ifdefs for plugins using new ErrorOr API in clang
- Remove -Wno-error=return-stack-address flag for ToT builds.
- Replace llvm::make_unique with std::make_unique in clang plugins for
LLVM r369130, remove LLVM_FORCE_HEAD_REVISION ifdefs
TBR=dprake
Binary-Size: crbug.com/992372, compiler update adds 32KB, seems reasonabe
Bug: 983371
Change-Id: Icdcbd70adec2548a2bf8222df15560e70ce32d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763261
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#689588}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 18026ae8f2ca650128026720a9244e8cde5b9625
This reverts commit 8b43f27599d3b490fc6bc936c4e0e1d3c0f38aeb.
Reason for revert: Causing crashes in ANGLE's dEQP tests. Likely
related to exception handling on Windows.
See issue for more details.
Bug: 994333
Original change's description:
> Roll clang 365097:368742.
>
> Extra changes in this update:
> - Update the released clang version to 10.0.0.
>
> - Move -momit-leaf-frame-pointer next to -fno-omit-frame-pointer
> since that's where it logically belongs. clang started warning
> on momit without fno-omit after r365860, but it stopped doing this
> again in r368728 so this change is no longer needed for the roll.
> But it's still a nice cleanup.
>
> - A file in the profile runtime with static init was renamed, do that in the
> check
>
> - Disable new -Wno-implicit-float-conversion warning
>
> - Remove ifdefs for plugins using new ErrorOr API in clang
>
> - Remove -Wno-error=return-stack-address flag for ToT builds.
>
> TBR=dpranke
>
> Binary-Size: crbug.com/992372, compiler update adds 32KB, seems reasonable
> Bug: 983371
> Change-Id: Id6e64948fe4966b486aa77615e19f4f7566f13ed
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751203
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686837}
TBR=thakis@chromium.org,hans@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 983371
Change-Id: I3e577f9bb0e8c42e29b06b7580fadc80a0529f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756767
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#687472}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 90cdc2584cd4f7e6c905d1f228084736ce9ee6e7
Extra changes in this update:
- Update the released clang version to 10.0.0.
- Move -momit-leaf-frame-pointer next to -fno-omit-frame-pointer
since that's where it logically belongs. clang started warning
on momit without fno-omit after r365860, but it stopped doing this
again in r368728 so this change is no longer needed for the roll.
But it's still a nice cleanup.
- A file in the profile runtime with static init was renamed, do that in the
check
- Disable new -Wno-implicit-float-conversion warning
- Remove ifdefs for plugins using new ErrorOr API in clang
- Remove -Wno-error=return-stack-address flag for ToT builds.
TBR=dpranke
Binary-Size: crbug.com/992372, compiler update adds 32KB, seems reasonable
Bug: 983371
Change-Id: Id6e64948fe4966b486aa77615e19f4f7566f13ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751203
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#686837}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8b43f27599d3b490fc6bc936c4e0e1d3c0f38aeb
This reverts commit b897e9bf67b6c0dc04269e9527e9e9064cd76af1.
Reason for revert: Bisecting pinpoints this CL as responsible for breaking WebKit Linux MSAN. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/1194 for the first failure caused by it. Please run the linux-webkit-msan-rel tryjob and ensure it passes before resubmitting.
Original change's description:
> Reland "Roll clang 365097:368354."
>
> This is a reland of 5c7654a48b01a46a7b26a5c37dcad2c17b12ee64
>
> I moved the -momit-leaf-pointer flag so that it is not redundant
> with -fomit-frame-pointer and the x86-only warning doesn't occur.
>
> Original change's description:
> > Roll clang 365097:368354.
> >
> > Update the released clang version to 10.0.0.
> >
> > Binary-Size: crbug.com/992372, compiler update adds 32KB, seems reasonable
> > Bug: 983371
> > Change-Id: I378b4e30ec045e9206ba11b77a95d81dc3008f1d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713302
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Reid Kleckner <rnk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#685744}
>
> Bug: 983371
> Change-Id: Ia2d628b4710033de4b80700de7bd96bbe5d9d73f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747138
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Reid Kleckner <rnk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685783}
TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 983371
Change-Id: I36911cf6042bd8fddbde923f83d68e221b5fc993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747491
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#685909}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e0e3d85599361c275320594e7fc8b27a2e7056bb
This is a reland of 5c7654a48b01a46a7b26a5c37dcad2c17b12ee64
I moved the -momit-leaf-pointer flag so that it is not redundant
with -fomit-frame-pointer and the x86-only warning doesn't occur.
Original change's description:
> Roll clang 365097:368354.
>
> Update the released clang version to 10.0.0.
>
> Binary-Size: crbug.com/992372, compiler update adds 32KB, seems reasonable
> Bug: 983371
> Change-Id: I378b4e30ec045e9206ba11b77a95d81dc3008f1d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713302
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Reid Kleckner <rnk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685744}
Bug: 983371
Change-Id: Ia2d628b4710033de4b80700de7bd96bbe5d9d73f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747138
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#685783}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b897e9bf67b6c0dc04269e9527e9e9064cd76af1
This will help reproducing nocompile test failures with locally built
Clang, and also fixes a TODO from 2011 :-)
Bug: 913420
Change-Id: I613f0836d92c8f3f6513e0e03af83206447e4c76
Reviewed-on: https://chromium-review.googlesource.com/c/1409188
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#622440}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8261b16886d3c7732fd2a87a74b32f7263d290ed
Add the dependencies of the invoker target to the generated nocompile
targets. This should address the flakiness issues of building
content_nocompile_tests.
Bug: 882234
Change-Id: Ic7f7a07d3a6567202b3a0da8800228c7329f119d
Reviewed-on: https://chromium-review.googlesource.com/1215964
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589918}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb2a899dd5bcf5d7801a69f2e99d04ea7393955d
Also adds the generated output file directory as include directory to
nocompile build targets.
Bug: 878356, 867421
Change-Id: I51a8433a1e5295949f67aaea188444f81c394100
Reviewed-on: https://chromium-review.googlesource.com/1194224
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587265}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 03d0d427b4f1713bcaf975d1586f4ad4be53bec5
As the main sources has switched to C++14, nocompile tests should also
switch to it.
Bug: 554717
Change-Id: Ib06b3e931b78d545e709d6f7b886ca895840fbd9
Reviewed-on: https://chromium-review.googlesource.com/593372
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490826}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cffd16beb3874844101953c888e7d497c94a05cb
Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.
This didn't seem to cause a problem for the nocompile test because the output
file is not used.
This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.
Review-Url: https://codereview.chromium.org/2627703002
Cr-Original-Commit-Position: refs/heads/master@{#444507}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb57bea1642b294af0578ab0e50d1c63bb5491b2
nocompile_tests wasn't aware header file dependencies that included by
a .nc file. That makes a test failure sticky.
This CL makes nocompile_driver.py to emit a depfile to let ninja know
the implicit dependencies.
Review URL: https://codereview.chromium.org/1698763002
Cr-Original-Commit-Position: refs/heads/master@{#375504}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b5f8f4bca759e2535439edb022cc1f3e0b5a897d
No-compile tests have been disabled for a while on GYP build, and GN
didn't support it.
This CL converts //build/nocompile.gypi to //build/nocompile.gni to
support no-compile test, and splits out test cases from base_unittests
to base_nocompile_tests on GN build.
This doesn't enable the test by default. To opt-in to it, set
enable_nocompile_tests to true in GN args.
BUG=568478
Review URL: https://codereview.chromium.org/1526933002
Cr-Original-Commit-Position: refs/heads/master@{#365757}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0137dc5d4031d8bc13d28adf579a9af6a2169c75
Sylvain Defresne
Nico Weber
Hans Wennborg
Jamie Madill
Fergus Dall
Reid Kleckner
Scott Little
Eric Seckler
Lei Zhang
Lukasz Anforowicz
Victor Costan
Tom Anderson
tzik
Trent Apted
wychen
brettw